[fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is null by swjtu-zhanglei · Pull Request #53075 · apache/doris

swjtu-zhanglei · 2025-07-10T16:42:20Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-07-10T16:42:26Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

swjtu-zhanglei · 2025-07-10T16:42:37Z

run buildall

doris-robot · 2025-07-10T17:03:30Z

TPC-H: Total hot run time: 33373 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f982ce58cfc7b41b2378621895dba7b4230e15c, data reload: false
------ Round 1 ----------------------------------
q1	17590	5208	5102	5102
q2	1908	272	193	193
q3	10311	1281	722	722
q4	10237	1011	513	513
q5	7944	2646	2349	2349
q6	187	163	129	129
q7	910	744	596	596
q8	9311	1340	1097	1097
q9	6878	5087	5106	5087
q10	6888	2392	1960	1960
q11	487	302	278	278
q12	335	352	208	208
q13	17799	3704	3097	3097
q14	248	235	217	217
q15	532	476	486	476
q16	425	428	378	378
q17	577	871	360	360
q18	7659	7211	7122	7122
q19	1210	961	559	559
q20	339	333	215	215
q21	3933	3163	2404	2404
q22	371	328	311	311
Total cold run time: 106079 ms
Total hot run time: 33373 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5085	5055	5227	5055
q2	239	326	222	222
q3	2230	2739	2347	2347
q4	1382	1793	1332	1332
q5	4260	4385	4576	4385
q6	216	167	133	133
q7	2156	1951	1897	1897
q8	2695	2593	2568	2568
q9	7262	7282	7278	7278
q10	3188	3323	2953	2953
q11	589	517	496	496
q12	737	820	628	628
q13	3689	4020	3392	3392
q14	297	312	278	278
q15	511	464	479	464
q16	459	503	444	444
q17	1202	1626	1357	1357
q18	8048	7771	7173	7173
q19	795	769	880	769
q20	1923	1948	1834	1834
q21	4796	4479	4353	4353
q22	636	593	544	544
Total cold run time: 52395 ms
Total hot run time: 49902 ms

doris-robot · 2025-07-10T17:15:06Z

TPC-DS: Total hot run time: 186900 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f982ce58cfc7b41b2378621895dba7b4230e15c, data reload: false
query1	1001	378	379	378
query2	6516	1667	1705	1667
query3	6737	207	213	207
query4	25831	24097	23609	23609
query5	4339	585	404	404
query6	281	198	189	189
query7	4622	490	294	294
query8	284	227	220	220
query9	8606	2650	2649	2649
query10	463	347	274	274
query11	15416	15079	14886	14886
query12	169	106	104	104
query13	1672	526	413	413
query14	8613	5865	5841	5841
query15	194	194	179	179
query16	7286	603	495	495
query17	1198	699	609	609
query18	1978	400	290	290
query19	192	183	151	151
query20	121	127	115	115
query21	206	116	99	99
query22	4013	4190	4010	4010
query23	33994	33102	33207	33102
query24	8546	2361	2404	2361
query25	512	453	390	390
query26	1223	270	151	151
query27	2757	504	341	341
query28	4319	2137	2115	2115
query29	754	576	425	425
query30	278	221	188	188
query31	907	832	732	732
query32	75	69	58	58
query33	553	364	311	311
query34	784	832	524	524
query35	778	809	742	742
query36	970	977	909	909
query37	110	98	72	72
query38	4159	4158	4033	4033
query39	1495	1440	1431	1431
query40	211	114	105	105
query41	57	63	53	53
query42	125	105	106	105
query43	510	514	475	475
query44	1282	821	829	821
query45	179	167	160	160
query46	836	1008	628	628
query47	1775	1811	1737	1737
query48	376	433	307	307
query49	756	463	405	405
query50	628	685	424	424
query51	5476	5432	5562	5432
query52	107	103	96	96
query53	214	248	188	188
query54	572	566	501	501
query55	82	77	79	77
query56	312	302	297	297
query57	1182	1180	1126	1126
query58	278	265	260	260
query59	2587	2780	2674	2674
query60	352	329	319	319
query61	150	143	145	143
query62	783	748	653	653
query63	226	188	180	180
query64	4313	963	637	637
query65	4266	4176	4174	4174
query66	1138	404	308	308
query67	15945	15641	15260	15260
query68	7760	868	519	519
query69	474	290	271	271
query70	1209	1109	1089	1089
query71	429	338	289	289
query72	5669	4758	4811	4758
query73	659	618	350	350
query74	8839	8992	8910	8910
query75	3420	3159	2718	2718
query76	3307	1233	715	715
query77	692	397	303	303
query78	9986	10108	9319	9319
query79	2250	816	594	594
query80	565	501	485	485
query81	492	262	217	217
query82	467	129	97	97
query83	248	252	232	232
query84	244	106	89	89
query85	815	356	326	326
query86	381	319	280	280
query87	4344	4457	4341	4341
query88	3763	2240	2273	2240
query89	380	313	286	286
query90	1899	200	206	200
query91	138	143	115	115
query92	74	61	56	56
query93	1826	911	573	573
query94	674	403	299	299
query95	365	290	290	290
query96	481	569	276	276
query97	2729	2761	2674	2674
query98	232	214	204	204
query99	1341	1387	1272	1272
Total cold run time: 272822 ms
Total hot run time: 186900 ms

doris-robot · 2025-07-10T17:20:22Z

ClickBench: Total hot run time: 29.12 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f982ce58cfc7b41b2378621895dba7b4230e15c, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.62	0.11	0.12
query5	0.44	0.42	0.41
query6	1.16	0.66	0.67
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.51	0.53
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.62
query14	0.80	0.82	0.82
query15	0.90	0.87	0.87
query16	0.38	0.37	0.40
query17	1.07	1.09	1.05
query18	0.23	0.22	0.21
query19	2.02	1.82	1.83
query20	0.02	0.02	0.01
query21	15.41	0.94	0.54
query22	0.75	1.21	0.70
query23	14.92	1.34	0.64
query24	6.92	1.85	0.30
query25	0.28	0.11	0.06
query26	0.52	0.17	0.13
query27	0.06	0.05	0.06
query28	9.78	0.88	0.44
query29	12.56	3.99	3.36
query30	0.25	0.09	0.07
query31	2.84	0.60	0.39
query32	3.23	0.56	0.47
query33	3.03	3.09	3.23
query34	16.15	5.37	4.81
query35	4.81	4.85	4.80
query36	0.69	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.05	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.03	0.03	0.03
Total cold run time: 103.85 s
Total hot run time: 29.12 s

swjtu-zhanglei · 2025-07-11T02:43:15Z

run buildall

dataroaring

LGTM

doris-robot · 2025-07-11T03:51:41Z

TPC-H: Total hot run time: 33249 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5e80e82d7102bbb7510931dc629df7d626a37359, data reload: false
------ Round 1 ----------------------------------
q1	17553	5251	5066	5066
q2	1932	313	189	189
q3	10335	1317	730	730
q4	10217	1022	527	527
q5	7722	2435	2353	2353
q6	176	159	131	131
q7	914	738	617	617
q8	9322	1330	1078	1078
q9	6867	5060	5133	5060
q10	6889	2381	1974	1974
q11	477	288	289	288
q12	352	354	213	213
q13	17765	3675	3054	3054
q14	226	225	218	218
q15	537	475	495	475
q16	425	419	390	390
q17	586	886	370	370
q18	7607	7308	7089	7089
q19	1525	962	552	552
q20	344	346	230	230
q21	3949	3149	2350	2350
q22	350	320	295	295
Total cold run time: 106070 ms
Total hot run time: 33249 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5132	5076	5082	5076
q2	231	323	215	215
q3	2152	2726	2315	2315
q4	1354	1795	1363	1363
q5	4228	4427	4635	4427
q6	213	167	126	126
q7	2044	2038	1868	1868
q8	2668	2641	2532	2532
q9	7537	7027	7397	7027
q10	3124	3321	2901	2901
q11	576	664	513	513
q12	706	780	619	619
q13	3524	3996	3523	3523
q14	292	300	262	262
q15	524	477	499	477
q16	467	505	429	429
q17	1120	1568	1397	1397
q18	8041	7631	7632	7631
q19	824	823	855	823
q20	2097	2039	1921	1921
q21	4944	4623	4620	4620
q22	687	600	543	543
Total cold run time: 52485 ms
Total hot run time: 50608 ms

github-actions · 2025-07-11T03:52:26Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-11T03:52:28Z

PR approved by anyone and no changes requested.

doris-robot · 2025-07-11T04:03:24Z

TPC-DS: Total hot run time: 187565 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e80e82d7102bbb7510931dc629df7d626a37359, data reload: false
query1	1022	388	401	388
query2	6512	1720	1665	1665
query3	6736	216	216	216
query4	26260	23568	23350	23350
query5	4360	582	432	432
query6	310	212	214	212
query7	4621	488	299	299
query8	260	228	226	226
query9	8631	2666	2645	2645
query10	477	346	276	276
query11	15826	15116	14881	14881
query12	155	108	105	105
query13	1649	511	392	392
query14	9094	5992	6088	5992
query15	209	199	174	174
query16	7704	437	266	266
query17	1315	716	589	589
query18	2022	407	305	305
query19	199	187	169	169
query20	123	119	113	113
query21	210	124	114	114
query22	4246	4597	4714	4597
query23	34631	33926	33131	33131
query24	8410	2354	2373	2354
query25	513	450	392	392
query26	1242	261	142	142
query27	2721	502	334	334
query28	4308	2116	2104	2104
query29	700	526	442	442
query30	286	219	192	192
query31	926	904	750	750
query32	69	63	85	63
query33	546	351	269	269
query34	801	834	509	509
query35	582	644	564	564
query36	958	983	891	891
query37	108	102	77	77
query38	4186	4145	4014	4014
query39	1470	1409	1410	1409
query40	203	112	104	104
query41	55	52	51	51
query42	120	121	107	107
query43	483	491	465	465
query44	1310	818	826	818
query45	172	169	170	169
query46	814	1019	628	628
query47	1798	1829	1754	1754
query48	376	409	298	298
query49	738	476	377	377
query50	630	676	411	411
query51	5640	5545	5278	5278
query52	109	102	96	96
query53	221	244	181	181
query54	568	552	516	516
query55	80	81	82	81
query56	322	297	300	297
query57	1178	1187	1114	1114
query58	261	245	256	245
query59	2617	2570	2499	2499
query60	315	315	298	298
query61	127	120	119	119
query62	776	730	672	672
query63	214	184	181	181
query64	4358	1192	846	846
query65	4278	4164	4175	4164
query66	1063	403	319	319
query67	15969	15659	15369	15369
query68	9114	891	521	521
query69	501	306	272	272
query70	1214	1142	1067	1067
query71	481	313	292	292
query72	5477	4809	4840	4809
query73	734	611	348	348
query74	9232	9379	8840	8840
query75	4120	3227	2707	2707
query76	3534	1150	716	716
query77	758	369	319	319
query78	11007	11142	10194	10194
query79	1934	851	577	577
query80	637	494	424	424
query81	457	259	224	224
query82	421	125	93	93
query83	274	245	236	236
query84	288	104	99	99
query85	780	375	310	310
query86	333	300	302	300
query87	4388	4399	4342	4342
query88	2915	2241	2263	2241
query89	380	313	286	286
query90	1917	250	209	209
query91	136	139	110	110
query92	69	55	54	54
query93	1075	932	585	585
query94	677	316	199	199
query95	376	297	288	288
query96	485	561	277	277
query97	2748	2740	2654	2654
query98	224	207	200	200
query99	1417	1407	1272	1272
Total cold run time: 277296 ms
Total hot run time: 187565 ms

doris-robot · 2025-07-11T04:08:39Z

ClickBench: Total hot run time: 29.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e80e82d7102bbb7510931dc629df7d626a37359, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.44	0.41	0.43
query6	1.15	0.67	0.65
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.60	0.53	0.54
query10	0.58	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.63	0.61	0.61
query14	0.79	0.81	0.82
query15	0.90	0.86	0.87
query16	0.40	0.38	0.40
query17	1.06	1.07	1.07
query18	0.22	0.21	0.21
query19	1.99	1.83	1.78
query20	0.02	0.01	0.01
query21	15.39	0.90	0.55
query22	0.76	1.10	0.64
query23	15.05	1.37	0.62
query24	7.08	1.41	0.58
query25	0.51	0.23	0.06
query26	0.57	0.18	0.14
query27	0.06	0.06	0.05
query28	9.62	0.87	0.44
query29	12.55	3.98	3.29
query30	0.26	0.10	0.06
query31	2.83	0.59	0.39
query32	3.24	0.56	0.48
query33	3.09	3.04	3.17
query34	16.10	5.39	4.72
query35	4.79	4.86	4.87
query36	0.68	0.50	0.49
query37	0.09	0.07	0.07
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.2 s
Total hot run time: 29.15 s

swjtu-zhanglei · 2025-07-11T05:26:56Z

run buildall

doris-robot · 2025-07-11T06:00:59Z

TPC-H: Total hot run time: 33220 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fad404917fd9add362b7ebbf2132e839f57c8e5f, data reload: false
------ Round 1 ----------------------------------
q1	17555	5141	5004	5004
q2	1927	274	182	182
q3	10316	1253	723	723
q4	10218	989	518	518
q5	7510	2383	2337	2337
q6	175	161	126	126
q7	909	726	615	615
q8	9331	1287	1106	1106
q9	6801	5114	5063	5063
q10	6880	2384	1968	1968
q11	479	301	280	280
q12	342	347	211	211
q13	17771	3676	3119	3119
q14	231	227	211	211
q15	534	479	478	478
q16	426	424	378	378
q17	580	861	370	370
q18	7447	7205	7096	7096
q19	1211	931	570	570
q20	333	343	223	223
q21	3943	3261	2345	2345
q22	351	334	297	297
Total cold run time: 105270 ms
Total hot run time: 33220 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5095	5078	5051	5051
q2	249	337	229	229
q3	2167	2651	2327	2327
q4	1372	1790	1318	1318
q5	4257	4170	4530	4170
q6	217	167	127	127
q7	2053	1894	1896	1894
q8	2645	2533	2495	2495
q9	7287	7322	7359	7322
q10	3162	3269	2911	2911
q11	571	506	497	497
q12	758	1084	629	629
q13	3548	3982	3397	3397
q14	287	316	269	269
q15	523	471	472	471
q16	455	496	435	435
q17	1193	1573	1380	1380
q18	7959	7862	7515	7515
q19	858	887	1021	887
q20	2009	2053	1965	1965
q21	4910	4355	4242	4242
q22	661	583	525	525
Total cold run time: 52236 ms
Total hot run time: 50056 ms

doris-robot · 2025-07-11T06:12:36Z

TPC-DS: Total hot run time: 187497 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fad404917fd9add362b7ebbf2132e839f57c8e5f, data reload: false
query1	1014	399	434	399
query2	6518	1722	1729	1722
query3	6738	210	218	210
query4	26466	23190	23097	23097
query5	4372	596	437	437
query6	304	214	216	214
query7	4627	499	296	296
query8	259	217	216	216
query9	8625	2591	2603	2591
query10	461	336	275	275
query11	15246	15317	15445	15317
query12	166	105	107	105
query13	1646	526	397	397
query14	9474	5945	6062	5945
query15	219	195	175	175
query16	7648	446	285	285
query17	1299	680	567	567
query18	2020	392	296	296
query19	190	186	167	167
query20	121	117	120	117
query21	206	118	105	105
query22	3968	4201	4176	4176
query23	33926	32989	32929	32929
query24	8399	2337	2343	2337
query25	527	484	388	388
query26	1232	269	144	144
query27	2775	500	350	350
query28	4263	2106	2077	2077
query29	735	555	443	443
query30	282	219	191	191
query31	922	835	755	755
query32	68	68	63	63
query33	550	324	292	292
query34	787	836	510	510
query35	624	636	561	561
query36	941	969	899	899
query37	110	97	73	73
query38	4138	4075	4068	4068
query39	1517	1436	1421	1421
query40	213	114	102	102
query41	55	54	51	51
query42	131	107	111	107
query43	519	519	475	475
query44	1288	807	800	800
query45	192	169	162	162
query46	827	1020	616	616
query47	1739	1788	1738	1738
query48	375	402	297	297
query49	728	441	396	396
query50	633	681	432	432
query51	5414	5446	5427	5427
query52	107	99	99	99
query53	222	248	177	177
query54	563	549	484	484
query55	81	81	83	81
query56	307	300	272	272
query57	1145	1207	1117	1117
query58	266	248	247	247
query59	2640	2792	2565	2565
query60	333	317	304	304
query61	122	116	140	116
query62	815	701	646	646
query63	215	180	187	180
query64	4290	1188	857	857
query65	4250	4167	4227	4167
query66	1047	407	318	318
query67	15945	15685	15359	15359
query68	7841	873	513	513
query69	489	301	260	260
query70	1213	1140	1123	1123
query71	430	325	299	299
query72	5533	4738	4801	4738
query73	695	658	347	347
query74	9205	9274	8921	8921
query75	3410	3174	2658	2658
query76	3198	1129	712	712
query77	716	371	292	292
query78	10867	11213	10413	10413
query79	1646	821	564	564
query80	580	515	421	421
query81	464	253	228	228
query82	178	127	94	94
query83	251	239	228	228
query84	251	107	90	90
query85	747	346	318	318
query86	350	323	278	278
query87	4414	4409	4356	4356
query88	3246	2267	2262	2262
query89	390	312	276	276
query90	1986	212	201	201
query91	151	165	113	113
query92	71	59	54	54
query93	1369	923	584	584
query94	666	339	202	202
query95	372	288	279	279
query96	499	569	271	271
query97	2652	2742	2666	2666
query98	244	217	198	198
query99	1329	1374	1336	1336
Total cold run time: 273298 ms
Total hot run time: 187497 ms

doris-robot · 2025-07-11T06:17:52Z

ClickBench: Total hot run time: 29.8 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fad404917fd9add362b7ebbf2132e839f57c8e5f, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.05	0.04
query3	0.24	0.08	0.08
query4	1.60	0.11	0.11
query5	0.44	0.43	0.44
query6	1.19	0.67	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.52	0.50
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.61	0.61
query14	0.81	0.80	0.84
query15	0.91	0.88	0.86
query16	0.40	0.39	0.39
query17	1.04	1.10	1.06
query18	0.22	0.21	0.21
query19	1.95	1.80	1.87
query20	0.01	0.02	0.02
query21	15.39	0.89	0.53
query22	0.75	1.21	0.74
query23	14.82	1.37	0.60
query24	6.87	1.18	1.28
query25	0.50	0.17	0.10
query26	0.65	0.16	0.14
query27	0.06	0.05	0.05
query28	9.74	0.90	0.44
query29	12.54	3.92	3.28
query30	0.24	0.09	0.06
query31	2.84	0.61	0.39
query32	3.26	0.55	0.46
query33	3.16	3.06	3.10
query34	16.12	5.37	4.70
query35	4.81	4.81	4.80
query36	0.70	0.51	0.48
query37	0.09	0.07	0.08
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.13	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.05 s
Total hot run time: 29.8 s

doris-robot · 2025-07-11T07:10:26Z

BE UT Coverage Report

Increment line coverage 25.00% (2/8) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.13% (15525/27175)
Line Coverage	45.96% (138665/301714)
Region Coverage	35.35% (103687/293314)
Branch Coverage	37.86% (45705/120726)

dataroaring

LGTM

github-actions · 2025-07-12T04:03:50Z

PR approved by at least one committer and no changes requested.

…rce.fs is null

swjtu-zhanglei · 2025-07-14T04:28:54Z

run buildall

doris-robot · 2025-07-14T05:25:20Z

TPC-H: Total hot run time: 33174 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b629af83f1657cb1df3c46c9f0821c1e157896ac, data reload: false
------ Round 1 ----------------------------------
q1	17601	5264	5149	5149
q2	1933	310	181	181
q3	10568	1317	720	720
q4	10371	1032	512	512
q5	8328	2331	2416	2331
q6	181	159	127	127
q7	912	744	587	587
q8	9331	1324	1118	1118
q9	7567	5066	5085	5066
q10	6902	2408	1955	1955
q11	480	283	265	265
q12	345	355	212	212
q13	17772	3748	3044	3044
q14	227	220	211	211
q15	550	476	476	476
q16	414	434	374	374
q17	600	896	361	361
q18	7781	7246	7053	7053
q19	1207	937	551	551
q20	338	355	222	222
q21	3815	3146	2363	2363
q22	365	326	296	296
Total cold run time: 107588 ms
Total hot run time: 33174 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5093	5124	5137	5124
q2	241	326	220	220
q3	2162	2684	2309	2309
q4	1419	1787	1365	1365
q5	4220	4416	4547	4416
q6	209	166	124	124
q7	1985	1991	1820	1820
q8	2695	2583	2616	2583
q9	7231	7300	7347	7300
q10	3078	3372	2854	2854
q11	578	543	538	538
q12	712	777	661	661
q13	3680	3957	3321	3321
q14	311	312	268	268
q15	522	490	489	489
q16	459	516	445	445
q17	1191	1620	1360	1360
q18	7906	7699	7576	7576
q19	805	820	927	820
q20	1987	2128	1940	1940
q21	4979	4636	4668	4636
q22	684	557	555	555
Total cold run time: 52147 ms
Total hot run time: 50724 ms

doris-robot · 2025-07-14T05:37:04Z

TPC-DS: Total hot run time: 187948 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b629af83f1657cb1df3c46c9f0821c1e157896ac, data reload: false
query1	999	381	389	381
query2	6496	1658	1691	1658
query3	6746	211	214	211
query4	26395	23694	22984	22984
query5	4388	561	404	404
query6	304	212	205	205
query7	4633	519	290	290
query8	267	225	229	225
query9	8615	2608	2640	2608
query10	461	343	271	271
query11	15206	15067	15094	15067
query12	155	110	102	102
query13	1658	525	395	395
query14	8716	6077	5936	5936
query15	210	205	168	168
query16	7650	438	263	263
query17	1324	732	587	587
query18	2025	402	315	315
query19	196	190	166	166
query20	124	120	112	112
query21	215	124	110	110
query22	4160	4513	4752	4513
query23	34839	33898	33332	33332
query24	8532	2347	2346	2346
query25	522	449	379	379
query26	1233	259	137	137
query27	2784	511	340	340
query28	4279	2100	2075	2075
query29	737	529	415	415
query30	283	217	190	190
query31	888	862	764	764
query32	66	63	58	58
query33	536	340	269	269
query34	818	830	525	525
query35	596	629	556	556
query36	939	1011	895	895
query37	103	97	80	80
query38	4200	4215	4138	4138
query39	1461	1447	1431	1431
query40	205	112	103	103
query41	54	51	51	51
query42	127	109	104	104
query43	499	508	486	486
query44	1282	800	806	800
query45	170	172	168	168
query46	826	1043	625	625
query47	1771	1823	1756	1756
query48	383	412	301	301
query49	742	495	389	389
query50	624	686	393	393
query51	5575	5519	5398	5398
query52	110	100	98	98
query53	214	249	186	186
query54	570	564	495	495
query55	84	79	79	79
query56	296	302	295	295
query57	1179	1187	1147	1147
query58	258	257	246	246
query59	2590	2641	2583	2583
query60	319	315	343	315
query61	126	121	118	118
query62	770	715	672	672
query63	232	178	182	178
query64	4359	1228	812	812
query65	4254	4183	4215	4183
query66	1094	401	345	345
query67	16004	15967	15615	15615
query68	8299	892	523	523
query69	515	336	268	268
query70	1275	1109	1159	1109
query71	504	321	286	286
query72	5563	4684	4954	4684
query73	707	641	345	345
query74	8856	8932	9109	8932
query75	3918	3201	2697	2697
query76	3734	1137	726	726
query77	773	378	286	286
query78	10982	11329	10286	10286
query79	2156	835	595	595
query80	590	513	428	428
query81	491	263	220	220
query82	455	129	99	99
query83	250	243	229	229
query84	247	121	97	97
query85	790	351	313	313
query86	385	299	287	287
query87	4549	4428	4321	4321
query88	3625	2251	2263	2251
query89	394	320	289	289
query90	1826	208	206	206
query91	129	144	108	108
query92	79	59	58	58
query93	1600	926	577	577
query94	675	308	201	201
query95	366	292	286	286
query96	500	561	281	281
query97	2730	2794	2627	2627
query98	229	248	198	198
query99	1351	1377	1293	1293
Total cold run time: 277019 ms
Total hot run time: 187948 ms

doris-robot · 2025-07-14T05:42:20Z

ClickBench: Total hot run time: 29.3 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b629af83f1657cb1df3c46c9f0821c1e157896ac, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.07	0.07
query4	1.62	0.11	0.11
query5	0.45	0.44	0.43
query6	1.15	0.66	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.50	0.52
query10	0.56	0.56	0.56
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.63	0.62	0.61
query14	0.80	0.81	0.83
query15	0.91	0.87	0.88
query16	0.39	0.38	0.38
query17	1.05	1.10	1.01
query18	0.22	0.21	0.22
query19	1.94	1.86	1.87
query20	0.01	0.01	0.01
query21	15.42	0.91	0.57
query22	0.76	1.30	0.73
query23	14.76	1.39	0.65
query24	6.81	1.70	0.50
query25	0.52	0.27	0.06
query26	0.51	0.16	0.14
query27	0.06	0.07	0.06
query28	9.76	0.88	0.45
query29	12.54	4.02	3.33
query30	0.26	0.09	0.06
query31	2.82	0.58	0.39
query32	3.22	0.56	0.47
query33	3.10	3.15	3.06
query34	16.06	5.32	4.75
query35	4.83	4.86	4.82
query36	0.71	0.50	0.50
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.04	0.04	0.04
Total cold run time: 103.73 s
Total hot run time: 29.3 s

doris-robot · 2025-07-14T07:07:40Z

BE UT Coverage Report

Increment line coverage 25.00% (2/8) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.60% (15670/27205)
Line Coverage	46.31% (139645/301546)
Region Coverage	35.60% (104398/293232)
Branch Coverage	38.15% (46006/120601)

dataroaring

LGTM

github-actions · 2025-07-14T13:09:07Z

PR approved by at least one committer and no changes requested.

…rage_resource.fs is null (#53075)

… rowset._storage_resource.fs is null #53075 (#53227) Cherry-picked from #53075 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

… rowset._storage_resource.fs is null #53075 (#53228) Cherry-picked from #53075 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

dataroaring previously approved these changes Jul 11, 2025
View reviewed changes

dataroaring added dev/3.0.x dev/3.1.x labels Jul 11, 2025

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

github-actionsBot added the reviewed label Jul 11, 2025

swjtu-zhanglei dismissed dataroaring’s stale review via fad4049July 11, 2025 05:26

swjtu-zhanglei force-pushed the master-fix13 branch from 5e80e82 to fad4049Compare July 11, 2025 05:26

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

dataroaring previously approved these changes Jul 12, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2025

gavinchou reviewed Jul 14, 2025
View reviewed changes

Comment threadbe/src/olap/rowset/rowset_meta.cpp

swjtu-zhanglei added 2 commits July 14, 2025 12:27

[fix](cloud) Sync storage resource once, when rowset's _storage_resou…
4b07ffb
…rce.fs is null

Add some comments
b629af8

swjtu-zhanglei dismissed dataroaring’s stale review via b629af8July 14, 2025 04:28

swjtu-zhanglei force-pushed the master-fix13 branch from fad4049 to b629af8Compare July 14, 2025 04:28

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 14, 2025

dataroaring approved these changes Jul 14, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2025

Yukang-Lian approved these changes Jul 14, 2025
View reviewed changes

gavinchou changed the title ~~[fix](cloud) Sync storage resource once, when rowset's _storage_resource.fs is null~~[fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is nullJul 14, 2025

gavinchou merged commit 0846d1b into apache:masterJul 14, 2025

github-actionsBot pushed a commit that referenced this pull request Jul 14, 2025
[fix](cloud) Sync storage resource once in read path when rowset._sto…
82c488f
…rage_resource.fs is null (#53075)

github-actionsBot mentioned this pull request Jul 14, 2025
branch-3.0: [fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is null #53075 #53227
Merged

github-actionsBot pushed a commit that referenced this pull request Jul 14, 2025
[fix](cloud) Sync storage resource once in read path when rowset._sto…
bd16a6d
…rage_resource.fs is null (#53075)

github-actionsBot mentioned this pull request Jul 14, 2025
branch-3.1: [fix](cloud) Sync storage resource once in read path when rowset._storage_resource.fs is null #53075 #53228
Merged

dataroaring pushed a commit that referenced this pull request Jul 15, 2025
branch-3.0: [fix](cloud) Sync storage resource once in read path when…
6b432f2
… rowset._storage_resource.fs is null #53075 (#53227) Cherry-picked from #53075 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Jul 15, 2025

morrySnow pushed a commit that referenced this pull request Jul 15, 2025
branch-3.1: [fix](cloud) Sync storage resource once in read path when…
1791cf2
… rowset._storage_resource.fs is null #53075 (#53228) Cherry-picked from #53075 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jul 15, 2025

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

swjtu-zhanglei commented Jul 10, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jul 10, 2025

Uh oh!

swjtu-zhanglei commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

swjtu-zhanglei commented Jul 11, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

swjtu-zhanglei commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

BE UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 12, 2025

Uh oh!

Uh oh!

swjtu-zhanglei commented Jul 14, 2025

Uh oh!

doris-robot commented Jul 14, 2025

Uh oh!

doris-robot commented Jul 14, 2025

Uh oh!

doris-robot commented Jul 14, 2025

Uh oh!

doris-robot commented Jul 14, 2025

BE UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants