Skip to content

[bugfix](restore) fix npe of restore command#53151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 1 commit into from
Jul 14, 2025
Merged

[bugfix](restore) fix npe of restore command #53151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3146,7 +3146,9 @@ private TRestoreSnapshotResult restoreSnapshotImpl(TRestoreSnapshotRequest reque
//instantiate RestoreCommand
LabelNameInfo labelNameInfo = new LabelNameInfo(label.getDbName(), label.getLabelName());
List<TableRefInfo> tableRefInfos = new ArrayList<>();
for (TableRef tableRef : restoreTableRefClause.getTableRefList()) {
List<TableRef> tableRefList = restoreTableRefClause == null
? new ArrayList<>() : restoreTableRefClause.getTableRefList();
for (TableRef tableRef : tableRefList) {
TableName tableName = tableRef.getName();
String[] aliases = tableRef.getAliases();
PartitionNames partitionNames = tableRef.getPartitionNames();
Expand DownExpand Up@@ -3208,7 +3210,7 @@ private TRestoreSnapshotResult restoreSnapshotImpl(TRestoreSnapshotRequest reque
ctx.setCurrentUserIdentity(UserIdentity.createAnalyzedUserIdentWithIp(fullUserName, "%"));
ctx.setThreadLocalInfo();
restoreCommand.validate(ctx);
ctx.getEnv().getBackupHandler().process(restoreCommand);
Env.getCurrentEnv().getBackupHandler().process(restoreCommand);
} catch (UserException e) {
LOG.warn("failed to restore: {}, command: {}", e.getMessage(), restoreCommand, e);
status.setStatusCode(TStatusCode.ANALYSIS_ERROR);
Expand Down