Skip to content

[Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffing - #5325

Merged
wuyunfeng merged 13 commits into
apache:masterfrom
stalary:es_ssl
Apr 12, 2021
Merged

[Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffing#5325
wuyunfeng merged 13 commits into
apache:masterfrom
stalary:es_ssl

Conversation

@stalary

@stalarystalary commented Jan 30, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Support doris connect https es server and support config esNodesDiscovery

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Issue: #5324

wuyunfeng
wuyunfeng requested changes Feb 23, 2021
View reviewed changes

@wuyunfengwuyunfeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good job, I left some comment

Comment threadbe/src/exec/es/es_scan_reader.cpp Outdated
Comment threadbe/src/exec/es/es_scan_reader.h Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsNodeInfo.java Outdated
Comment threadgensrc/thrift/Descriptors.thrift Outdated
wuyunfeng
wuyunfeng reviewed Feb 23, 2021
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/EsTable.java Outdated
@wuyunfengwuyunfeng changed the title WIP：Support doris connect https es server and support config esNodesDiscovery[Doris On ES][WIP]：Support ES with SSL secured and support disabling ES nodes detectingFeb 23, 2021
@wuyunfengwuyunfeng self-assigned this Feb 23, 2021
@wuyunfengwuyunfeng added the area/doris-on-es Issues or PRs related to Doris on ElasticSearch label Feb 23, 2021
@wuyunfengwuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and support disabling ES nodes detecting[Doris On ES][WIP]：Support ES with SSL secured and disabling ES nodes detectingFeb 23, 2021
@wuyunfengwuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and disabling ES nodes detecting[Doris On ES][WIP]：Support ES with SSL secured and configurable node sniffingFeb 23, 2021
@wuyunfengwuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and configurable node sniffing[Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffingFeb 23, 2021
@wuyunfengwuyunfeng linked an issue Feb 23, 2021 that may be closed by this pull request
[Doris On ES][Feature] Does Doris support external ES table with SSL secured and configurable node sniffing? #5324
Closed
wuyunfeng
wuyunfeng requested changes Feb 24, 2021
View reviewed changes
Comment threadbe/src/exec/es/es_scan_reader.h Outdated
Comment threadbe/src/http/http_client.h Outdated
wuyunfeng
wuyunfeng reviewed Feb 24, 2021
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/PartitionPhase.java Outdated
wuyunfeng
wuyunfeng requested changes Feb 24, 2021
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/EsTable.java Outdated
wuyunfeng
wuyunfeng requested changes Mar 3, 2021
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/PartitionPhase.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java Outdated
@apacheapache deleted a comment from stalaryMar 4, 2021
wuyunfeng
wuyunfeng requested changes Mar 11, 2021
View reviewed changes
Comment threaddocs/en/extending-doris/doris-on-es.md Outdated
Comment threaddocs/en/extending-doris/doris-on-es.md Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsNodeInfo.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsRestClient.java Outdated
wuyunfeng
wuyunfeng requested changes Mar 22, 2021
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsRestClient.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsShardPartitions.java Outdated
wuyunfeng
wuyunfeng requested changes Apr 7, 2021
View reviewed changes
Comment threaddocs/en/extending-doris/doris-on-es.md Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsRestClient.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsRestClient.java Outdated
wuyunfeng
wuyunfeng requested changes Apr 7, 2021
View reviewed changes
Comment threaddocs/en/extending-doris/doris-on-es.md Outdated
Comment threaddocs/en/extending-doris/doris-on-es.md Outdated
wuyunfeng
wuyunfeng previously approved these changes Apr 9, 2021
View reviewed changes

@wuyunfengwuyunfeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuyunfengwuyunfeng added the approved Indicates a PR has been approved by one committer. label Apr 9, 2021
wuyunfeng
wuyunfeng approved these changes Apr 12, 2021
View reviewed changes

@wuyunfengwuyunfeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuyunfeng
wuyunfeng merged commit 75db273 into apache:masterApr 12, 2021
@wuyunfengwuyunfeng mentioned this pull request Apr 12, 2021
Closed
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
@stalary@morningman-cmy
[Doris On ES][WIP] Support external ES table with SSL secured and c…
8b91d67
…onfigurable node sniffing (apache#5325)
Support external ES table with `SSL` secured and configurable node sniffing
@morningmanmorningman mentioned this pull request Oct 10, 2021
Closed
@stalary
stalary deleted the es_ssl branch May 8, 2022 10:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuyunfengwuyunfengwuyunfeng approved these changes

Assignees

@wuyunfengwuyunfeng

Labels

approvedIndicates a PR has been approved by one committer.area/doris-on-esIssues or PRs related to Doris on ElasticSearch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Doris On ES][Feature] Does Doris support external ES table with SSL secured and configurable node sniffing?

2 participants

@stalary@wuyunfeng