[fix](warmup) avoid calling recycle_cache after rebalance by kaijchen · Pull Request #53339 · apache/doris

kaijchen · 2025-07-15T15:10:02Z

What problem does this PR solve?

Problem Summary:

recycle_cached_data() should not call recycle_cache(). Because rebalance will also call recycle_cached_data(). For compaction, we should call recycle_cache() in delete_expired_stale_rowsets() and clear_cache().

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-07-15T15:10:08Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

…53523) backport #53339

…53339 (#53338) backport #53339

kaijchen · 2025-08-06T08:38:37Z

run buildall

doris-robot · 2025-08-06T09:33:20Z

TPC-H: Total hot run time: 34079 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91492f6cf08908a701905fe0add2804fafa73b4c, data reload: false
------ Round 1 ----------------------------------
q1	17555	5368	5365	5365
q2	1938	273	182	182
q3	10346	1354	692	692
q4	10224	971	525	525
q5	7557	2409	2317	2317
q6	191	168	132	132
q7	910	774	612	612
q8	9334	1302	1140	1140
q9	6816	5118	5098	5098
q10	6890	2371	1974	1974
q11	464	275	270	270
q12	356	368	224	224
q13	17761	3490	2960	2960
q14	231	242	215	215
q15	557	483	454	454
q16	420	432	392	392
q17	586	827	370	370
q18	7574	6986	7008	6986
q19	1843	988	553	553
q20	319	302	204	204
q21	2811	3055	2403	2403
q22	1038	1018	1011	1011
Total cold run time: 105721 ms
Total hot run time: 34079 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5395	5403	5386	5386
q2	230	313	217	217
q3	2086	2556	2230	2230
q4	1330	1748	1303	1303
q5	4146	4409	4602	4409
q6	228	185	134	134
q7	1908	1911	1864	1864
q8	2642	2598	2436	2436
q9	7293	7319	7289	7289
q10	3248	3352	2904	2904
q11	550	516	493	493
q12	689	799	653	653
q13	3391	3658	3196	3196
q14	292	311	494	311
q15	542	454	449	449
q16	451	493	456	456
q17	1185	1389	1328	1328
q18	7953	7881	7439	7439
q19	12794	905	914	905
q20	2094	2169	1859	1859
q21	15536	4294	4304	4294
q22	1042	1018	971	971
Total cold run time: 75025 ms
Total hot run time: 50526 ms

doris-robot · 2025-08-06T09:45:01Z

TPC-DS: Total hot run time: 169844 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91492f6cf08908a701905fe0add2804fafa73b4c, data reload: false
============================================
query1	1011	384	391	384
query2	6557	1831	1701	1701
query3	6748	227	218	218
query4	26933	23162	22911	22911
query5	4372	622	503	503
query6	325	235	236	235
query7	4638	513	298	298
query8	301	244	234	234
query9	8616	2955	2912	2912
query10	456	340	305	305
query11	15384	14968	14786	14786
query12	187	133	139	133
query13	1659	568	435	435
query14	8615	5809	5826	5809
query15	210	185	167	167
query16	7128	642	460	460
query17	1212	735	612	612
query18	1979	435	300	300
query19	223	207	212	207
query20	146	134	139	134
query21	215	123	109	109
query22	4018	3973	3801	3801
query23	34558	34172	34444	34172
query24	5135	2345	2428	2345
query25	503	498	439	439
query26	715	290	167	167
query27	2274	507	352	352
query28	3094	2333	2307	2307
query29	609	595	484	484
query30	294	230	199	199
query31	834	788	762	762
query32	89	80	77	77
query33	523	414	404	404
query34	800	846	518	518
query35	803	838	741	741
query36	1024	1062	943	943
query37	135	109	86	86
query38	3951	3914	3944	3914
query39	1449	1395	1381	1381
query40	243	137	163	137
query41	62	59	54	54
query42	137	121	127	121
query43	533	502	475	475
query44	1408	866	845	845
query45	193	201	178	178
query46	941	1057	673	673
query47	1803	1784	1717	1717
query48	408	426	310	310
query49	673	527	400	400
query50	658	705	412	412
query51	4166	4226	4309	4226
query52	125	132	116	116
query53	263	292	212	212
query54	643	642	557	557
query55	88	92	90	90
query56	357	364	347	347
query57	1203	1210	1116	1116
query58	333	330	340	330
query59	2720	2705	2647	2647
query60	428	404	414	404
query61	153	149	150	149
query62	764	739	645	645
query63	268	214	218	214
query64	2435	1173	870	870
query65	4296	4142	4105	4105
query66	1077	452	322	322
query67	query68	17341	637	588	588
query69	998	312	278	278
query70	1464	1138	1114	1114
query71	730	335	319	319
query72	9167	2351	2361	2351
query73	3638	634	356	356
query74	8988	9049	8893	8893
query75	7651	3110	2611	2611
query76	8896	1225	815	815
query77	1158	407	352	352
query78	9539	10918	9453	9453
query79	14506	644	584	584
query80	1791	548	479	479
query81	567	258	229	229
query82	516	152	120	120
query83	407	290	270	270
query84	293	100	82	82
query85	1125	410	331	331
query86	370	310	301	301
query87	4213	4209	4060	4060
query88	5639	2266	2227	2227
query89	485	360	321	321
query90	2608	231	236	231
query91	153	146	112	112
query92	93	72	68	68
query93	6400	985	668	668
query94	1121	401	275	275
query95	407	330	327	327
query96	507	584	283	283
query97	2729	2716	2609	2609
query98	288	233	224	224
query99	1461	1429	1296	1296
Total cold run time: 299350 ms
Total hot run time: 169844 ms

doris-robot · 2025-08-06T09:50:30Z

ClickBench: Total hot run time: 33.13 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91492f6cf08908a701905fe0add2804fafa73b4c, data reload: false
query1	0.04	0.03	0.04
query2	0.09	0.04	0.04
query3	0.24	0.08	0.08
query4	1.61	0.11	0.11
query5	0.42	0.41	0.42
query6	1.15	0.64	0.65
query7	0.03	0.02	0.02
query8	0.05	0.03	0.04
query9	0.57	0.48	0.46
query10	0.53	0.52	0.54
query11	0.16	0.11	0.10
query12	0.15	0.11	0.11
query13	0.65	0.64	0.63
query14	0.89	1.13	1.11
query15	0.92	0.88	0.90
query16	0.38	0.39	0.38
query17	1.06	1.09	1.08
query18	0.22	0.20	0.20
query19	1.96	1.95	1.93
query20	0.02	0.02	0.02
query21	15.38	0.86	0.56
query22	0.85	1.31	0.79
query23	14.76	1.21	0.62
query24	7.00	1.09	0.60
query25	0.47	0.13	0.31
query26	0.60	0.17	0.13
query27	0.06	0.06	0.05
query28	9.41	0.85	0.44
query29	12.86	3.82	3.27
query30	3.04	3.01	2.93
query31	2.81	0.57	0.41
query32	3.24	0.58	0.49
query33	3.04	3.17	3.28
query34	15.76	5.39	4.91
query35	4.92	5.00	4.99
query36	0.72	0.52	0.50
query37	0.10	0.07	0.07
query38	0.06	0.05	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.05	0.04	0.04
Total cold run time: 106.6 s
Total hot run time: 33.13 s

hello-stephen · 2025-08-06T10:27:39Z

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	58.30% (16382/28100)
Line Coverage	47.20% (148057/313709)
Region Coverage	36.13% (110743/306499)
Branch Coverage	39.03% (49188/126025)

hello-stephen · 2025-08-06T12:12:46Z

BE Regression && UT Coverage Report

Increment line coverage 70.37% (19/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.19% (22391/27577)
Line Coverage	73.93% (231866/313647)
Region Coverage	61.44% (193341/314702)
Branch Coverage	65.32% (83317/127553)

dataroaring · 2025-08-07T06:12:09Z

run buildall

dataroaring · 2025-08-07T06:12:28Z

run buildall

doris-robot · 2025-08-07T07:06:35Z

TPC-H: Total hot run time: 33871 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cc6c16c3cd0fedb9a182a4759283cf1344bcb266, data reload: false
------ Round 1 ----------------------------------
q1	17615	5308	5223	5223
q2	1913	300	197	197
q3	10348	1407	741	741
q4	10279	1019	513	513
q5	9355	2284	2328	2284
q6	228	173	134	134
q7	886	779	646	646
q8	9332	1308	1128	1128
q9	7594	5130	5158	5130
q10	6975	2376	1985	1985
q11	472	286	267	267
q12	382	374	224	224
q13	17804	3490	3006	3006
q14	236	255	216	216
q15	551	458	461	458
q16	437	427	394	394
q17	588	826	366	366
q18	7407	7072	6899	6899
q19	1349	991	569	569
q20	325	304	207	207
q21	3435	3044	2309	2309
q22	1057	1039	975	975
Total cold run time: 108568 ms
Total hot run time: 33871 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5608	5340	5314	5314
q2	377	313	219	219
q3	2146	2595	2251	2251
q4	1352	1725	1336	1336
q5	4418	4461	4298	4298
q6	224	184	137	137
q7	1997	1938	1804	1804
q8	2621	2481	2396	2396
q9	7516	7365	7215	7215
q10	3225	3420	2951	2951
q11	547	513	468	468
q12	714	847	648	648
q13	3507	3744	3323	3323
q14	286	357	288	288
q15	497	458	462	458
q16	471	689	430	430
q17	1181	1488	1392	1392
q18	7817	7685	7666	7666
q19	4981	1005	982	982
q20	1983	2043	1814	1814
q21	10805	4141	4375	4141
q22	1072	1036	986	986
Total cold run time: 63345 ms
Total hot run time: 50517 ms

doris-robot · 2025-08-07T07:18:29Z

TPC-DS: Total hot run time: 170314 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cc6c16c3cd0fedb9a182a4759283cf1344bcb266, data reload: false
============================================
query1	990	370	445	370
query2	6562	1808	1672	1672
query3	6748	232	217	217
query4	26811	23560	23348	23348
query5	4357	636	521	521
query6	336	263	236	236
query7	4639	531	307	307
query8	291	267	232	232
query9	8606	2995	2979	2979
query10	489	362	303	303
query11	15751	14918	14897	14897
query12	191	141	140	140
query13	1723	585	429	429
query14	8667	5928	5985	5928
query15	268	194	173	173
query16	8009	694	503	503
query17	1645	821	652	652
query18	2106	453	333	333
query19	278	217	186	186
query20	156	146	147	146
query21	224	127	112	112
query22	4073	3929	3895	3895
query23	34662	34631	34149	34149
query24	8365	2391	2405	2391
query25	538	509	435	435
query26	784	340	165	165
query27	2604	529	356	356
query28	4242	2343	2324	2324
query29	685	608	498	498
query30	301	233	199	199
query31	921	818	709	709
query32	95	76	83	76
query33	560	439	364	364
query34	840	847	526	526
query35	800	837	760	760
query36	1033	1042	930	930
query37	137	118	96	96
query38	4011	3978	3936	3936
query39	1443	1390	1361	1361
query40	239	143	140	140
query41	65	61	55	55
query42	143	124	128	124
query43	498	499	468	468
query44	1476	884	879	879
query45	199	198	184	184
query46	964	1088	680	680
query47	1738	1822	1724	1724
query48	424	445	333	333
query49	709	520	413	413
query50	685	714	418	418
query51	4176	4226	4141	4141
query52	123	138	123	123
query53	275	305	231	231
query54	669	675	562	562
query55	91	92	93	92
query56	358	375	361	361
query57	1201	1218	1155	1155
query58	343	344	346	344
query59	2663	2664	2545	2545
query60	412	404	405	404
query61	128	121	137	121
query62	821	739	665	665
query63	258	218	222	218
query64	3433	1094	788	788
query65	4246	4109	4170	4109
query66	892	437	352	352
query67	query68	19152	1480	837	837
query69	1027	315	292	292
query70	1459	1165	1094	1094
query71	718	338	336	336
query72	9212	2296	2443	2296
query73	3843	677	356	356
query74	9000	8909	8482	8482
query75	7667	3127	2648	2648
query76	8818	1241	788	788
query77	1157	445	353	353
query78	9445	10815	9275	9275
query79	15093	630	581	581
query80	1889	583	505	505
query81	563	270	225	225
query82	498	158	122	122
query83	369	285	273	273
query84	297	97	84	84
query85	943	388	332	332
query86	364	328	287	287
query87	4220	4133	4085	4085
query88	5619	2205	2273	2205
query89	499	368	326	326
query90	2611	230	231	230
query91	146	139	111	111
query92	90	73	68	68
query93	6416	1011	651	651
query94	985	386	275	275
query95	409	332	327	327
query96	505	588	280	280
query97	2690	2745	2611	2611
query98	269	235	224	224
query99	1464	1423	1272	1272
Total cold run time: 309607 ms
Total hot run time: 170314 ms

doris-robot · 2025-08-07T07:23:57Z

ClickBench: Total hot run time: 33.22 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cc6c16c3cd0fedb9a182a4759283cf1344bcb266, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.26	0.07	0.08
query4	1.60	0.11	0.11
query5	0.42	0.44	0.44
query6	1.16	0.68	0.66
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.57	0.49	0.48
query10	0.52	0.53	0.53
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.64	0.67	0.65
query14	0.93	1.24	1.00
query15	0.95	0.87	0.91
query16	0.37	0.37	0.40
query17	1.07	1.06	1.05
query18	0.23	0.20	0.21
query19	1.91	1.81	1.82
query20	0.01	0.01	0.02
query21	15.37	0.87	0.56
query22	0.76	1.26	0.96
query23	14.70	1.15	0.65
query24	6.58	1.76	0.66
query25	0.53	0.20	0.07
query26	0.62	0.16	0.13
query27	0.06	0.06	0.05
query28	9.52	0.83	0.45
query29	12.58	3.82	3.27
query30	3.05	3.04	2.97
query31	2.81	0.56	0.40
query32	3.24	0.57	0.50
query33	3.03	3.19	3.24
query34	16.12	5.38	4.95
query35	4.92	5.00	4.95
query36	0.70	0.52	0.50
query37	0.11	0.07	0.08
query38	0.06	0.05	0.05
query39	0.03	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 106.29 s
Total hot run time: 33.22 s

hello-stephen · 2025-08-07T07:34:15Z

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	58.31% (16385/28098)
Line Coverage	47.21% (148124/313781)
Region Coverage	36.19% (110911/306459)
Branch Coverage	39.08% (49258/126040)

hello-stephen · 2025-08-07T09:28:24Z

BE Regression && UT Coverage Report

Increment line coverage 70.37% (19/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.32% (22424/27575)
Line Coverage	74.03% (232249/313719)
Region Coverage	61.35% (193044/314662)
Branch Coverage	65.47% (83514/127568)

dataroaring

LGTM

dataroaring · 2025-08-11T14:36:46Z

duplicated recycle in expire and unused path.
check rowset state in destination, if it is held in destination, it should be recycled by the destination.

github-actions · 2025-08-11T14:40:59Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-11T14:41:02Z

PR approved by anyone and no changes requested.

gavinchou · 2025-08-11T14:41:05Z

 void remove_unused_rowsets();

- static void recycle_cached_data(const std::vector<RowsetSharedPtr>& rowsets);
+ static std::vector<RecycledRowsets> recycle_cached_data(


add comment to describe the behavior, what is the returned value and the input param

liaoxin01

LGTM

kaijchen · 2025-08-11T14:54:56Z

run buildall

doris-robot · 2025-08-11T15:57:55Z

TPC-H: Total hot run time: 33960 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b9fca8489a409712c59b2d2b54f42f3f45d918cf, data reload: false
------ Round 1 ----------------------------------
q1	17590	5282	5112	5112
q2	1914	282	181	181
q3	10331	1278	705	705
q4	10210	1004	533	533
q5	7486	2407	2307	2307
q6	186	162	128	128
q7	904	751	603	603
q8	9296	1317	1089	1089
q9	6859	5086	5147	5086
q10	6884	2356	1970	1970
q11	490	279	287	279
q12	337	345	212	212
q13	17768	3664	3016	3016
q14	227	246	210	210
q15	535	493	488	488
q16	418	437	369	369
q17	580	862	355	355
q18	7672	7101	7104	7101
q19	1230	960	581	581
q20	336	344	223	223
q21	4022	3246	2414	2414
q22	1086	1036	998	998
Total cold run time: 106361 ms
Total hot run time: 33960 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5198	5502	5126	5126
q2	247	324	224	224
q3	2193	2705	2320	2320
q4	1373	1777	1304	1304
q5	4230	4634	4597	4597
q6	207	164	128	128
q7	1991	1968	1823	1823
q8	2637	2615	2668	2615
q9	7398	7271	7262	7262
q10	3157	3323	2833	2833
q11	590	497	517	497
q12	683	779	637	637
q13	3500	3847	3301	3301
q14	284	317	291	291
q15	534	467	495	467
q16	458	505	452	452
q17	1250	1638	1354	1354
q18	8235	7802	7720	7720
q19	822	963	1099	963
q20	1972	2061	1897	1897
q21	4924	4354	4258	4258
q22	1116	1037	1013	1013
Total cold run time: 52999 ms
Total hot run time: 51082 ms

doris-robot · 2025-08-11T16:09:28Z

TPC-DS: Total hot run time: 184973 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b9fca8489a409712c59b2d2b54f42f3f45d918cf, data reload: false
query1	996	388	401	388
query2	6515	1742	1773	1742
query3	6744	225	221	221
query4	26509	23068	23428	23068
query5	4342	625	483	483
query6	317	212	205	205
query7	4634	497	288	288
query8	273	242	222	222
query9	8597	2876	2854	2854
query10	470	338	292	292
query11	16014	15006	14843	14843
query12	172	109	113	109
query13	1658	546	434	434
query14	9722	5868	5668	5668
query15	200	190	166	166
query16	7658	621	481	481
query17	1448	733	629	629
query18	2014	394	309	309
query19	186	181	157	157
query20	127	120	117	117
query21	252	124	107	107
query22	4066	4328	4005	4005
query23	34274	33363	33325	33325
query24	8026	2331	2352	2331
query25	552	487	403	403
query26	1237	273	158	158
query27	2711	506	348	348
query28	4313	2246	2209	2209
query29	722	563	431	431
query30	284	224	191	191
query31	883	790	680	680
query32	82	72	74	72
query33	554	369	323	323
query34	797	850	501	501
query35	782	816	752	752
query36	980	1015	919	919
query37	115	107	87	87
query38	4067	3996	4031	3996
query39	1457	1423	1422	1422
query40	231	124	115	115
query41	57	54	55	54
query42	120	105	111	105
query43	502	500	483	483
query44	1315	848	836	836
query45	175	168	162	162
query46	862	1015	633	633
query47	1783	1814	1698	1698
query48	390	415	316	316
query49	737	478	401	401
query50	656	690	396	396
query51	4081	4133	4069	4069
query52	115	118	105	105
query53	235	252	192	192
query54	572	573	514	514
query55	86	82	91	82
query56	313	312	329	312
query57	1180	1210	1133	1133
query58	276	269	272	269
query59	2588	2683	2620	2620
query60	340	331	337	331
query61	151	118	128	118
query62	802	736	644	644
query63	224	187	189	187
query64	4271	1019	700	700
query65	4277	4199	4212	4199
query66	1088	419	331	331
query67	15636	15306	15042	15042
query68	8198	906	560	560
query69	481	330	286	286
query70	1215	1084	1152	1084
query71	485	323	315	315
query72	5607	4768	4825	4768
query73	709	588	355	355
query74	8934	9058	9021	9021
query75	3829	3062	2605	2605
query76	3720	1130	727	727
query77	801	435	343	343
query78	9575	9756	8897	8897
query79	2363	821	590	590
query80	645	586	480	480
query81	477	258	228	228
query82	425	146	106	106
query83	285	248	231	231
query84	297	98	88	88
query85	786	374	333	333
query86	361	307	308	307
query87	4278	4272	4194	4194
query88	2849	2192	2192	2192
query89	394	316	287	287
query90	1967	228	226	226
query91	138	141	106	106
query92	91	71	63	63
query93	1115	979	626	626
query94	669	400	302	302
query95	397	310	306	306
query96	480	579	275	275
query97	2684	2681	2606	2606
query98	241	220	213	213
query99	1429	1400	1270	1270
Total cold run time: 273738 ms
Total hot run time: 184973 ms

doris-robot · 2025-08-11T16:14:55Z

ClickBench: Total hot run time: 32.11 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b9fca8489a409712c59b2d2b54f42f3f45d918cf, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.05	0.04
query3	0.25	0.07	0.07
query4	1.62	0.11	0.11
query5	0.42	0.42	0.40
query6	1.16	0.67	0.65
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.60	0.52	0.50
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.61
query14	0.81	0.84	0.83
query15	0.87	0.85	0.85
query16	0.39	0.39	0.39
query17	1.04	1.05	1.08
query18	0.22	0.20	0.20
query19	1.94	1.81	1.76
query20	0.01	0.01	0.02
query21	15.39	0.93	0.55
query22	0.75	1.17	0.70
query23	14.95	1.36	0.63
query24	6.86	1.10	0.38
query25	0.54	0.16	0.07
query26	0.53	0.16	0.14
query27	0.06	0.05	0.06
query28	9.51	0.96	0.43
query29	12.59	3.98	3.26
query30	3.08	3.01	3.01
query31	2.82	0.58	0.39
query32	3.23	0.57	0.47
query33	3.05	3.08	3.06
query34	16.09	5.43	4.89
query35	4.89	4.88	4.89
query36	0.69	0.51	0.50
query37	0.10	0.07	0.07
query38	0.06	0.05	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.57 s
Total hot run time: 32.11 s

hello-stephen · 2025-08-11T16:44:35Z

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.01% (16606/28141)
Line Coverage	47.88% (150511/314344)
Region Coverage	36.72% (112767/307084)
Branch Coverage	39.64% (50029/126196)

hello-stephen · 2025-08-11T18:10:05Z

BE Regression && UT Coverage Report

Increment line coverage 70.37% (19/27) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.49% (22505/27616)
Line Coverage	74.17% (233152/314346)
Region Coverage	61.39% (193606/315346)
Branch Coverage	65.46% (83616/127744)

liaoxin01

LGTM

github-actions · 2025-08-13T01:59:07Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

kaijchen mentioned this pull request Jul 15, 2025
branch-3.1: [fix](warmup) avoid calling recycle_cache after rebalance #53339 #53338
Merged

kaijchen changed the title ~~[fix](warmup) avoid calling recycle_cache after rebalance (#4169)~~[fix](warmup) avoid calling recycle_cache after rebalanceJul 18, 2025

kaijchen mentioned this pull request Jul 18, 2025
[fix](warmup) avoid calling recycle_cache after rebalance (#53339) #53523
Merged

dataroaring pushed a commit that referenced this pull request Jul 21, 2025
[fix](warmup) avoid calling recycle_cache after rebalance (#53339) (#…
237adc2
…53523) backport #53339

dataroaring added dev/3.0.7-merged dev/3.1.x labels Jul 21, 2025

morrySnow pushed a commit that referenced this pull request Jul 24, 2025
branch-3.1: [fix](warmup) avoid calling recycle_cache after rebalance#…
bda6d12
…53339 (#53338) backport #53339

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jul 24, 2025

kaijchen force-pushed the master-warmup-rebalance branch from c23124c to 91492f6Compare August 6, 2025 08:38

kaijchen marked this pull request as ready for review August 6, 2025 08:38

kaijchen requested review from dataroaring and gavinchou as code owners August 6, 2025 08:38

[fix](warmup) avoid calling recycle_cache after rebalance
cc6c16c

dataroaring force-pushed the master-warmup-rebalance branch from 91492f6 to cc6c16cCompare August 7, 2025 06:12

dataroaring previously approved these changes Aug 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2025

github-actionsBot added the reviewed label Aug 11, 2025

gavinchou reviewed Aug 11, 2025
View reviewed changes

liaoxin01 previously approved these changes Aug 11, 2025
View reviewed changes

kaijchen commented Aug 11, 2025
View reviewed changes

Comment threadbe/src/cloud/cloud_tablet.h

add comments
b9fca84

kaijchen dismissed stale reviews from liaoxin01 and dataroaring via b9fca84August 11, 2025 14:54

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 11, 2025

liaoxin01 approved these changes Aug 13, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2025

dataroaring approved these changes Aug 13, 2025
View reviewed changes

dataroaring merged commit 6021a2a into apache:masterAug 13, 2025
27 of 30 checks passed

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

kaijchen commented Jul 15, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jul 15, 2025

Uh oh!

kaijchen commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

hello-stephen commented Aug 6, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 6, 2025

BE Regression && UT Coverage Report

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

hello-stephen commented Aug 7, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 7, 2025

BE Regression && UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

dataroaring commented Aug 11, 2025

Uh oh!

github-actionsBot commented Aug 11, 2025

Uh oh!

github-actionsBot commented Aug 11, 2025

Uh oh!

gavinchouAug 11, 2025

Choose a reason for hiding this comment

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaijchen commented Aug 11, 2025

Uh oh!

doris-robot commented Aug 11, 2025

Uh oh!

doris-robot commented Aug 11, 2025

Uh oh!

doris-robot commented Aug 11, 2025

Uh oh!

hello-stephen commented Aug 11, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 11, 2025

BE Regression && UT Coverage Report

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 13, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers