Skip to content

[fix](nereids)alter sql block rule lost sql pattern info - #53559

Merged
morrySnow merged 1 commit into
apache:masterfrom
starocean999:master_0331
Jul 30, 2025
Merged

[fix](nereids)alter sql block rule lost sql pattern info#53559
morrySnow merged 1 commit into
apache:masterfrom
starocean999:master_0331

Conversation

@starocean999

@starocean999starocean999 commented Jul 18, 2025

Copy link
Copy Markdown
Contributor
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");

when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep other properties unchanged, but we need call setSqlPattern to fill the new sql pattern or it will be 'NULL' which is a wrong pattern

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999

starocean999 commented Jul 18, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 18, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34239 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
------ Round 1 ----------------------------------
q1	17579	5217	5083	5083
q2	1961	304	196	196
q3	10270	1318	717	717
q4	10269	1003	526	526
q5	8084	2384	2333	2333
q6	203	170	140	140
q7	935	773	630	630
q8	9347	1315	1102	1102
q9	7085	5087	5088	5087
q10	6976	2374	1976	1976
q11	510	306	293	293
q12	364	375	238	238
q13	17789	3723	3091	3091
q14	241	245	233	233
q15	606	538	519	519
q16	441	441	391	391
q17	600	868	378	378
q18	7385	7052	7069	7052
q19	1295	984	627	627
q20	347	362	241	241
q21	4155	3209	2386	2386
q22	1038	1018	1000	1000
Total cold run time: 107480 ms
Total hot run time: 34239 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5209	5121	5136	5121
q2	278	351	252	252
q3	2213	2713	2324	2324
q4	1342	1820	1344	1344
q5	4387	4525	4508	4508
q6	215	171	145	145
q7	2017	1934	1816	1816
q8	2605	2658	2533	2533
q9	7274	7165	7115	7115
q10	3075	3275	2831	2831
q11	573	544	533	533
q12	697	812	634	634
q13	3645	4015	3362	3362
q14	307	308	288	288
q15	560	504	507	504
q16	505	503	481	481
q17	1218	1578	1374	1374
q18	7988	7681	7431	7431
q19	795	857	1035	857
q20	2094	2089	1930	1930
q21	4906	4584	4391	4391
q22	1114	1057	1025	1025
Total cold run time: 53017 ms
Total hot run time: 50799 ms

@doris-robot

doris-robot commented Jul 18, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191472 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
query1	1031	391	425	391
query2	6578	1759	1816	1759
query3	6758	228	226	226
query4	26155	23696	23035	23035
query5	4409	649	560	560
query6	336	239	242	239
query7	4646	532	310	310
query8	399	354	336	336
query9	8705	2687	2698	2687
query10	512	356	309	309
query11	15608	15115	14857	14857
query12	179	126	127	126
query13	1699	588	450	450
query14	9030	6178	6222	6178
query15	228	199	184	184
query16	7660	658	497	497
query17	1219	718	598	598
query18	2021	433	382	382
query19	198	207	171	171
query20	141	133	128	128
query21	238	142	127	127
query22	4146	4650	4516	4516
query23	35096	33747	33769	33747
query24	8485	2425	2460	2425
query25	556	480	415	415
query26	1244	276	158	158
query27	2724	523	362	362
query28	4368	2194	2187	2187
query29	758	570	456	456
query30	297	230	204	204
query31	983	877	822	822
query32	87	78	72	72
query33	580	386	345	345
query34	841	861	532	532
query35	807	849	781	781
query36	986	1028	903	903
query37	120	110	84	84
query38	4244	4104	4118	4104
query39	1530	1478	1475	1475
query40	245	137	162	137
query41	116	106	108	106
query42	130	123	120	120
query43	529	523	506	506
query44	1342	848	855	848
query45	188	189	173	173
query46	858	1037	668	668
query47	1805	1823	1764	1764
query48	400	449	341	341
query49	820	586	489	489
query50	674	735	450	450
query51	5586	5650	5476	5476
query52	119	115	109	109
query53	250	282	211	211
query54	596	593	525	525
query55	91	85	90	85
query56	343	326	366	326
query57	1268	1223	1150	1150
query58	311	291	298	291
query59	2589	2701	2560	2560
query60	354	349	350	349
query61	153	153	151	151
query62	846	771	679	679
query63	244	214	232	214
query64	4350	1062	745	745
query65	4279	4195	4179	4179
query66	1296	599	579	579
query67	16133	15734	15836	15734
query68	8227	917	551	551
query69	482	335	317	317
query70	1248	1196	1188	1188
query71	494	359	327	327
query72	5761	4894	4785	4785
query73	589	626	366	366
query74	9325	9269	8869	8869
query75	4061	3237	2736	2736
query76	3180	1174	730	730
query77	826	460	376	376
query78	10037	10168	9395	9395
query79	4944	840	591	591
query80	747	587	526	526
query81	502	279	236	236
query82	588	144	107	107
query83	328	291	272	272
query84	301	118	101	101
query85	866	409	379	379
query86	346	332	299	299
query87	4418	4508	4420	4420
query88	3077	2397	2416	2397
query89	456	407	310	310
query90	2034	236	232	232
query91	159	153	124	124
query92	92	74	67	67
query93	2977	940	600	600
query94	708	430	322	322
query95	388	317	313	313
query96	494	606	292	292
query97	2698	2784	2652	2652
query98	241	227	217	217
query99	1456	1437	1272	1272
Total cold run time: 283567 ms
Total hot run time: 191472 ms

@doris-robot

doris-robot commented Jul 18, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
query1	0.05	0.04	0.03
query2	0.08	0.05	0.05
query3	0.24	0.08	0.08
query4	1.61	0.12	0.11
query5	0.47	0.42	0.41
query6	1.20	0.67	0.69
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.54	0.52
query10	0.58	0.58	0.57
query11	0.17	0.12	0.12
query12	0.15	0.13	0.12
query13	0.63	0.62	0.61
query14	0.82	0.81	0.84
query15	0.91	0.89	0.87
query16	0.40	0.39	0.40
query17	1.05	1.05	1.04
query18	0.24	0.23	0.22
query19	1.98	1.86	1.90
query20	0.01	0.01	0.02
query21	15.38	0.93	0.56
query22	0.78	1.16	0.63
query23	14.97	1.41	0.61
query24	7.24	0.98	0.57
query25	0.53	0.23	0.07
query26	0.58	0.17	0.16
query27	0.07	0.06	0.06
query28	9.35	0.98	0.47
query29	12.58	4.06	3.41
query30	3.15	3.11	3.05
query31	2.83	0.61	0.40
query32	3.25	0.56	0.50
query33	3.12	3.11	3.13
query34	16.00	5.46	4.76
query35	4.84	4.82	4.90
query36	0.71	0.51	0.50
query37	0.11	0.09	0.08
query38	0.06	0.05	0.05
query39	0.05	0.04	0.04
query40	0.19	0.16	0.16
query41	0.10	0.05	0.03
query42	0.04	0.03	0.04
query43	0.05	0.04	0.04
Total cold run time: 107.25 s
Total hot run time: 32.66 s

@hello-stephen

hello-stephen commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@starocean999

starocean999 commented Jul 22, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 22, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34184 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
------ Round 1 ----------------------------------
q1	17621	5258	5010	5010
q2	1956	305	196	196
q3	10295	1354	710	710
q4	10281	1041	541	541
q5	8471	2433	2307	2307
q6	222	169	142	142
q7	937	773	625	625
q8	9346	1322	1078	1078
q9	7088	5116	5122	5116
q10	6908	2409	1992	1992
q11	503	323	291	291
q12	366	400	249	249
q13	17777	3718	3079	3079
q14	246	239	232	232
q15	601	523	523	523
q16	427	451	392	392
q17	601	878	364	364
q18	7406	7190	7243	7190
q19	1171	985	588	588
q20	358	349	240	240
q21	4033	2535	2354	2354
q22	1066	1052	965	965
Total cold run time: 107680 ms
Total hot run time: 34184 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5210	5128	5127	5127
q2	265	346	243	243
q3	2172	2680	2278	2278
q4	1362	1796	1369	1369
q5	4276	4441	4467	4441
q6	220	177	136	136
q7	2072	1965	1786	1786
q8	2662	2498	2586	2498
q9	7482	7257	7278	7257
q10	3114	3308	2908	2908
q11	595	521	566	521
q12	689	813	606	606
q13	3578	4023	3366	3366
q14	308	331	304	304
q15	557	545	518	518
q16	480	511	492	492
q17	1181	1598	1357	1357
q18	7822	7872	7568	7568
q19	828	753	805	753
q20	2001	2065	1922	1922
q21	5085	4678	4335	4335
q22	1059	1047	985	985
Total cold run time: 53018 ms
Total hot run time: 50770 ms

@doris-robot

doris-robot commented Jul 22, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191420 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
query1	1026	395	407	395
query2	6538	1776	1804	1776
query3	6751	231	223	223
query4	26781	23533	23386	23386
query5	4504	717	589	589
query6	339	254	235	235
query7	4638	523	315	315
query8	401	346	333	333
query9	8605	2945	2930	2930
query10	530	385	338	338
query11	15919	15384	14826	14826
query12	183	140	144	140
query13	1705	584	454	454
query14	9705	6032	6007	6007
query15	223	213	189	189
query16	7673	628	480	480
query17	1471	709	607	607
query18	2061	430	338	338
query19	203	238	170	170
query20	144	134	127	127
query21	234	139	126	126
query22	4037	4202	4197	4197
query23	34130	33140	33529	33140
query24	8158	2419	2414	2414
query25	539	491	454	454
query26	1242	275	172	172
query27	2725	523	375	375
query28	4356	2214	2184	2184
query29	739	601	482	482
query30	301	239	202	202
query31	957	888	816	816
query32	94	88	87	87
query33	592	420	384	384
query34	830	856	536	536
query35	819	846	785	785
query36	979	1041	932	932
query37	125	117	99	99
query38	4108	4217	4142	4142
query39	1527	1481	1459	1459
query40	243	142	138	138
query41	105	101	99	99
query42	136	121	119	119
query43	526	522	494	494
query44	1361	884	880	880
query45	202	183	181	181
query46	850	1027	659	659
query47	1811	1847	1832	1832
query48	402	485	346	346
query49	818	583	473	473
query50	666	712	434	434
query51	5559	5441	5370	5370
query52	135	122	113	113
query53	255	285	210	210
query54	615	628	560	560
query55	102	98	94	94
query56	361	352	335	335
query57	1218	1230	1185	1185
query58	323	330	354	330
query59	2574	2722	2503	2503
query60	380	375	368	368
query61	152	144	153	144
query62	824	750	660	660
query63	251	218	214	214
query64	4286	1064	727	727
query65	4264	4210	4224	4210
query66	1261	606	581	581
query67	15995	15794	15524	15524
query68	7958	906	552	552
query69	501	336	318	318
query70	1276	1230	1176	1176
query71	486	358	338	338
query72	5721	4761	4802	4761
query73	735	632	376	376
query74	9181	9144	9137	9137
query75	3986	3180	2729	2729
query76	3732	1140	733	733
query77	856	447	387	387
query78	9968	10086	9484	9484
query79	3711	852	583	583
query80	756	599	544	544
query81	497	280	241	241
query82	479	149	117	117
query83	311	296	271	271
query84	306	114	99	99
query85	823	395	372	372
query86	360	316	305	305
query87	4473	4415	4441	4415
query88	3377	2397	2396	2396
query89	469	340	309	309
query90	1988	238	241	238
query91	156	162	131	131
query92	96	81	82	81
query93	2866	937	596	596
query94	706	403	318	318
query95	410	351	331	331
query96	539	599	294	294
query97	2727	2773	2655	2655
query98	256	227	224	224
query99	1486	1443	1282	1282
Total cold run time: 282759 ms
Total hot run time: 191420 ms

@doris-robot

doris-robot commented Jul 22, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a13df4ca202192445c69cbbf38769d3ec3a6a3e1, data reload: false
query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.11	0.11
query5	0.43	0.43	0.40
query6	1.16	0.66	0.69
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.60	0.55	0.51
query10	0.59	0.59	0.58
query11	0.17	0.12	0.12
query12	0.16	0.12	0.12
query13	0.62	0.62	0.61
query14	0.81	0.81	0.83
query15	0.90	0.88	0.89
query16	0.38	0.38	0.39
query17	1.05	1.09	1.06
query18	0.24	0.23	0.22
query19	1.98	1.82	1.82
query20	0.02	0.02	0.01
query21	15.36	0.89	0.56
query22	0.77	1.21	0.67
query23	14.94	1.35	0.67
query24	6.52	1.70	1.37
query25	0.50	0.18	0.15
query26	0.69	0.17	0.15
query27	0.07	0.06	0.06
query28	10.43	0.90	0.45
query29	12.53	3.98	3.26
query30	3.15	3.09	3.08
query31	2.83	0.61	0.39
query32	3.24	0.56	0.48
query33	3.04	3.08	3.08
query34	16.16	5.43	4.82
query35	4.92	4.89	4.93
query36	0.68	0.51	0.50
query37	0.12	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.04	0.03
query40	0.18	0.17	0.16
query41	0.08	0.03	0.03
query42	0.04	0.04	0.04
query43	0.05	0.05	0.04
Total cold run time: 107.59 s
Total hot run time: 33.49 s

@hello-stephen

hello-stephen commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@starocean999

starocean999 commented Jul 24, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 24, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33865 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09b0ce432650889add2dd7204f71868eff5d5c66, data reload: false
------ Round 1 ----------------------------------
q1	17573	5243	5071	5071
q2	1917	298	183	183
q3	10312	1270	727	727
q4	10243	1024	510	510
q5	7863	2433	2300	2300
q6	184	158	131	131
q7	922	742	603	603
q8	9320	1306	1140	1140
q9	6901	5151	5153	5151
q10	6892	2385	1960	1960
q11	485	297	278	278
q12	342	362	217	217
q13	17772	3663	3021	3021
q14	228	234	217	217
q15	539	480	490	480
q16	424	431	366	366
q17	589	853	361	361
q18	7516	7190	7066	7066
q19	1216	946	575	575
q20	370	332	223	223
q21	3907	3112	2321	2321
q22	1056	1027	964	964
Total cold run time: 106571 ms
Total hot run time: 33865 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5222	5267	5154	5154
q2	240	318	225	225
q3	2164	2656	2302	2302
q4	1396	1821	1333	1333
q5	4234	4622	4436	4436
q6	228	182	135	135
q7	2006	1916	1836	1836
q8	2670	2467	2482	2467
q9	7343	7247	7347	7247
q10	3130	3288	2851	2851
q11	590	534	510	510
q12	790	787	630	630
q13	3675	4032	3408	3408
q14	293	316	278	278
q15	511	500	490	490
q16	438	522	451	451
q17	1184	1574	1399	1399
q18	7863	7916	7503	7503
q19	834	823	821	821
q20	1930	2006	1817	1817
q21	4753	4356	4314	4314
q22	1070	1041	976	976
Total cold run time: 52564 ms
Total hot run time: 50583 ms

@doris-robot

doris-robot commented Jul 24, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 186723 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09b0ce432650889add2dd7204f71868eff5d5c66, data reload: false
query1	1000	385	390	385
query2	6505	1745	1696	1696
query3	6750	220	226	220
query4	26679	23642	22802	22802
query5	4326	633	509	509
query6	319	228	199	199
query7	4618	495	289	289
query8	257	223	217	217
query9	8589	2819	2868	2819
query10	477	306	283	283
query11	15800	14925	14758	14758
query12	157	114	113	113
query13	1665	537	415	415
query14	8817	5896	5838	5838
query15	209	191	169	169
query16	7203	612	450	450
query17	1230	727	600	600
query18	1995	412	325	325
query19	202	193	156	156
query20	124	117	115	115
query21	222	128	110	110
query22	4187	4196	4054	4054
query23	33956	32954	33101	32954
query24	8171	2376	2417	2376
query25	530	469	417	417
query26	966	272	157	157
query27	2728	504	340	340
query28	4343	2188	2159	2159
query29	694	559	462	462
query30	291	218	190	190
query31	906	802	733	733
query32	86	71	74	71
query33	551	375	354	354
query34	793	840	508	508
query35	857	804	730	730
query36	981	1012	899	899
query37	117	106	89	89
query38	4304	4116	4069	4069
query39	1475	1415	1399	1399
query40	215	126	119	119
query41	59	56	53	53
query42	120	110	117	110
query43	521	511	480	480
query44	1356	857	856	856
query45	174	173	167	167
query46	843	999	635	635
query47	1808	1813	1765	1765
query48	382	447	310	310
query49	680	477	404	404
query50	664	706	413	413
query51	5426	5567	5457	5457
query52	116	112	105	105
query53	232	253	191	191
query54	604	580	531	531
query55	89	88	87	87
query56	348	321	301	301
query57	1204	1187	1127	1127
query58	286	273	275	273
query59	2654	2793	2626	2626
query60	347	341	323	323
query61	129	123	125	123
query62	805	720	647	647
query63	230	204	185	185
query64	3570	1057	741	741
query65	4278	4146	4135	4135
query66	1089	421	338	338
query67	15745	15738	15314	15314
query68	9190	898	558	558
query69	495	328	286	286
query70	1263	1170	1160	1160
query71	490	412	313	313
query72	5619	4872	4986	4872
query73	770	669	357	357
query74	8828	9011	8669	8669
query75	4370	3049	2636	2636
query76	3664	1153	744	744
query77	816	394	311	311
query78	9811	10271	9301	9301
query79	2179	827	608	608
query80	644	532	477	477
query81	465	262	235	235
query82	230	136	104	104
query83	281	270	242	242
query84	302	112	90	90
query85	750	403	326	326
query86	338	311	321	311
query87	4383	4362	4290	4290
query88	2825	2254	2236	2236
query89	405	316	283	283
query90	2075	218	214	214
query91	133	136	114	114
query92	84	71	67	67
query93	1716	969	646	646
query94	683	398	304	304
query95	391	308	308	308
query96	482	585	281	281
query97	2653	2782	2628	2628
query98	240	221	205	205
query99	1426	1437	1302	1302
Total cold run time: 275055 ms
Total hot run time: 186723 ms

@doris-robot

doris-robot commented Jul 24, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09b0ce432650889add2dd7204f71868eff5d5c66, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.25	0.07	0.07
query4	1.63	0.10	0.10
query5	0.44	0.44	0.40
query6	1.16	0.67	0.68
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.59	0.53	0.51
query10	0.58	0.56	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.63	0.61	0.62
query14	0.78	0.83	0.87
query15	0.89	0.85	0.89
query16	0.39	0.39	0.38
query17	1.07	1.02	1.06
query18	0.21	0.20	0.20
query19	1.93	1.82	1.83
query20	0.02	0.02	0.01
query21	15.39	0.91	0.53
query22	0.76	1.04	0.86
query23	14.84	1.41	0.64
query24	6.97	1.06	0.63
query25	0.54	0.26	0.06
query26	0.58	0.16	0.15
query27	0.05	0.05	0.05
query28	9.61	0.94	0.43
query29	12.58	3.96	3.29
query30	3.07	3.07	3.02
query31	2.82	0.58	0.38
query32	3.23	0.55	0.47
query33	3.06	3.02	3.10
query34	16.07	5.45	4.81
query35	4.83	4.90	4.87
query36	0.72	0.52	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.07	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.02
Total cold run time: 106.68 s
Total hot run time: 32.4 s

@hello-stephen

hello-stephen commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@starocean999
starocean999 marked this pull request as ready for review July 24, 2025 10:36
morrySnow
morrySnow reviewed Jul 30, 2025
View reviewed changes
Comment threadregression-test/suites/sql_block_rule_p0/test_sql_block_rule.groovy

CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",

@morrySnowmorrySnowJul 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not get the purpose of this case

@starocean999starocean999Jul 30, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the change, sqlPattern will be 'NULL', so 'select NULL' would hit this sql block rule

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2025
@github-actions

github-actionsBot commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow

morrySnow commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

run check_coverage

@morrySnow
morrySnow merged commit 31ad545 into apache:masterJul 30, 2025
11 of 14 checks passed
github-actionsBot pushed a commit that referenced this pull request Jul 30, 2025
@starocean999Your Name
[fix](nereids)alter sql block rule lost sql pattern info (#53559)
64aa8c2
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
@github-actionsgithub-actionsBot mentioned this pull request Jul 30, 2025
Merged
github-actionsBot pushed a commit that referenced this pull request Jul 30, 2025
@starocean999Your Name
[fix](nereids)alter sql block rule lost sql pattern info (#53559)
fbd7a11
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
@github-actionsgithub-actionsBot mentioned this pull request Jul 30, 2025
Closed
github-actionsBot pushed a commit that referenced this pull request Jul 30, 2025
@starocean999Your Name
[fix](nereids)alter sql block rule lost sql pattern info (#53559)
85eb737
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
@github-actionsgithub-actionsBot mentioned this pull request Jul 30, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 31, 2025
@github-actions@starocean999
branch-3.1: [fix](nereids)alter sql block rule lost sql pattern info#…
afab6ef
…53559 (#54095)
Cherry-picked from #53559
Co-authored-by: starocean999 <lichi@selectdb.com>
dataroaring pushed a commit that referenced this pull request Aug 12, 2025
@github-actions@starocean999
branch-3.0: [fix](nereids)alter sql block rule lost sql pattern info#…
6b40ab0
…53559 (#54091)
Cherry-picked from #53559
Co-authored-by: starocean999 <lichi@selectdb.com>
@gavinchougavinchou mentioned this pull request Sep 1, 2025
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 19, 2025
@starocean999
[fix](nereids)alter sql block rule lost sql pattern info (apache#5131)
b558a01
## Proposed changes
pick from apache#53559
<!--Describe your changes.-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zddrzddrzddr approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.xdev/3.0.8-mergeddev/3.1.0-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@starocean999@Thearas@doris-robot@hello-stephen@morrySnow@zddr@dataroaring