Uh oh!
There was an error while loading. Please reload this page.
[fix](result-sink)Fix the correctness of the results when multiple be and dry_run_query=true. - #53653
Merged
Merged
Conversation
… and dry_run_query=true.
hello-stephen
commented
Jul 21, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hubgeter
commented
Jul 21, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 21, 2025
TPC-H: Total hot run time: 34231 ms |
doris-robot
commented
Jul 21, 2025
TPC-DS: Total hot run time: 190819 ms |
doris-robot
commented
Jul 21, 2025
ClickBench: Total hot run time: 32.62 s |
morningman
approved these changes
Jul 22, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
BiteTheDDDDt
commented
Jul 22, 2025
Contributor
Can you add some test case for this problem? |
ContributorAuthor
There is already p2 case. |
BiteTheDDDDt
approved these changes
Jul 23, 2025
| // statistics->set_returned_rows(returned_rows); | ||
| // In a multi-mysql_result_writer scenario, since each mysql_result_writer will set this rows, in order | ||
| // to avoid missing rows when dry_run_query = true, they should all be added up. | ||
| numReceivedRows += resultBatch.getQueryStatistics().getReturnedRows(); |
Contributor
There was a problem hiding this comment.
If one backend returns multiple batches, does it will the repeated calculation lead to result row number more than real?
ContributorAuthor
There was a problem hiding this comment.
I don't think it will happen. returned_rows set by BE will only be increased during the close phase of ResultBlockBuffer. Reference:src/runtime/result_block_buffer.cpp:ResultBlockBuffer<ResultCtxType>::close(....)
BiteTheDDDDt
approved these changes
Jul 23, 2025
w41ter pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 30, 2025
… and dry_run_query=true. (apache#53653) Related PR: apache#36053 && apache#53209 Problem Summary: Fixed the issue that the result of `dry_run_query=true` is wrong in multi-be scenarios (the number of rows is less) I think this may be related to the multi result sink introduced in pr apache#36053 && apache#53209. Reason: ```cpp vmysql_result_writer.cpp GetResultBatchCtx::on_close() { ... statistics->set_returned_rows(returned_rows); // Set only once per result_writer. ... } ``` ``` java if (connectContext != null && connectContext.getSessionVariable().dryRunQuery) { if (resultBatch.isEos()) { // This will only be counted once. numReceivedRows += resultBatch.getQueryStatistics().getReturnedRows(); } } else if (resultBatch.getBatch() != null) { numReceivedRows += resultBatch.getBatch().getRowsSize(); } ``` If there are multiple be, there will be multiple result sinks, and each result sink will update its own row count at the end. Since `resultBatch.isEos()` is only triggered once, the row count information is less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #36053 && #53209
Problem Summary:
Fixed the issue that the result of
dry_run_query=trueis wrong in multi-be scenarios (the number of rows is less)I think this may be related to the multi result sink introduced in pr #36053 && #53209.
Reason:
If there are multiple be, there will be multiple result sinks, and each result sink will update its own row count at the end. Since
resultBatch.isEos()is only triggered once, the row count information is less.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)