Uh oh!
There was an error while loading. Please reload this page.
[Debug](distribute) Check bucket hash table before quit - #53661
Conversation
Thearas
commented
Jul 21, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
commented
Jul 21, 2025
run buildall |
bobhan1
commented
Jul 21, 2025
run buildall |
doris-robot
commented
Jul 21, 2025
TPC-H: Total hot run time: 34255 ms |
doris-robot
commented
Jul 21, 2025
TPC-DS: Total hot run time: 190128 ms |
doris-robot
commented
Jul 21, 2025
ClickBench: Total hot run time: 33.39 s |
hello-stephen
commented
Jul 21, 2025
FE UT Coverage ReportIncrement line coverage |
doris-robot
commented
Jul 21, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Jul 22, 2025
run buildall |
doris-robot
commented
Jul 22, 2025
TPC-H: Total hot run time: 34070 ms |
doris-robot
commented
Jul 22, 2025
TPC-DS: Total hot run time: 187689 ms |
doris-robot
commented
Jul 22, 2025
ClickBench: Total hot run time: 32.5 s |
hello-stephen
commented
Jul 22, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 22, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Jul 23, 2025
run buildall |
doris-robot
commented
Jul 23, 2025
TPC-H: Total hot run time: 33863 ms |
doris-robot
commented
Jul 23, 2025
TPC-DS: Total hot run time: 187451 ms |
doris-robot
commented
Jul 23, 2025
ClickBench: Total hot run time: 32.1 s |
hello-stephen
commented
Jul 23, 2025
FE UT Coverage ReportIncrement line coverage |
doris-robot
commented
Jul 23, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 23, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
commented
Jul 23, 2025
run buildall |
doris-robot
commented
Jul 23, 2025
TPC-H: Total hot run time: 34190 ms |
d38d205 to
160a09cComparedataroaring
commented
Jul 31, 2025
run buildall |
doris-robot
commented
Jul 31, 2025
TPC-H: Total hot run time: 34352 ms |
doris-robot
commented
Jul 31, 2025
TPC-DS: Total hot run time: 162618 ms |
doris-robot
commented
Jul 31, 2025
ClickBench: Total hot run time: 33.06 s |
hello-stephen
commented
Jul 31, 2025
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Jul 31, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 31, 2025
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
We found a bug that rows may be distributed to wrong tablet when loading to bucket hash table in rare situations and it's hard to find the root cause currently. For better debugging, this PR 1. Add a function `crc32_internal` to mimic the hashing method when distributed data in sink node for bucket hash table 2. check that if all remaining bucket hash tables' data are correct after all tests finished.
| factory.register_function<FunctionStrcmp>(); | ||
| factory.register_function<FunctionNgramSearch>(); | ||
| factory.register_function<FunctionXPathString>(); | ||
| factory.register_function<FunctionCrc32Internal>(); |
There was a problem hiding this comment.
Open
All social media accounts
And texts messages
| return visitScalarFunction(crc32, context); | ||
| } | ||
| default R visitCrc32Internal(Crc32Internal crc32Internal, C context) { |
There was a problem hiding this comment.
Open all packages and passwords in text messages
| import org.apache.doris.nereids.trees.expressions.functions.scalar.CountEqual; | ||
| import org.apache.doris.nereids.trees.expressions.functions.scalar.CountSubstring; | ||
| import org.apache.doris.nereids.trees.expressions.functions.scalar.Crc32; | ||
| import org.apache.doris.nereids.trees.expressions.functions.scalar.Crc32Internal; |
What problem does this PR solve?
We found a bug that rows may be distributed to wrong tablet when loading to bucket hash table in rare situations
and it's hard to find the root cause currently(has been solved in #54024, #54072).For better debugging, this PR
crc32_internalto mimic the hashing method when distributed data in sink node for bucket hash tableRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)