Skip to content

[fix](job) fix NullPointerException when replay job - #53768

Merged
hello-stephen merged 1 commit into
apache:masterfrom
sollhui:fix_replay_job_fail
Jul 24, 2025
Merged

[fix](job) fix NullPointerException when replay job#53768
hello-stephen merged 1 commit into
apache:masterfrom
sollhui:fix_replay_job_fail

Conversation

@sollhui

@sollhuisollhui commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

introduce by #52911

fix NullPointerException when replay job

java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "this.cloudCluster" is null

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui

sollhui commented Jul 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 23, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33807 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e12387580374bd1c89371c421894ed7010c413fa, data reload: false
------ Round 1 ----------------------------------
q1	17560	5184	5039	5039
q2	1908	275	182	182
q3	10330	1231	693	693
q4	10217	1029	527	527
q5	7504	2449	2312	2312
q6	175	160	131	131
q7	901	739	589	589
q8	9297	1366	1133	1133
q9	6710	5082	5097	5082
q10	6873	2369	1985	1985
q11	465	287	274	274
q12	344	353	216	216
q13	17777	3700	3110	3110
q14	229	241	215	215
q15	551	486	487	486
q16	416	419	372	372
q17	622	866	382	382
q18	7596	7037	6942	6942
q19	1213	944	565	565
q20	358	347	228	228
q21	3874	3164	2372	2372
q22	1076	988	972	972
Total cold run time: 105996 ms
Total hot run time: 33807 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5195	5170	5131	5131
q2	249	320	221	221
q3	2182	2664	2334	2334
q4	1324	1747	1354	1354
q5	4264	4311	4438	4311
q6	211	165	127	127
q7	2091	1969	1781	1781
q8	2670	2612	2631	2612
q9	7344	7239	7357	7239
q10	3135	3271	2880	2880
q11	584	516	487	487
q12	678	761	629	629
q13	3863	3906	3498	3498
q14	292	310	280	280
q15	536	479	479	479
q16	448	499	451	451
q17	1173	1526	1410	1410
q18	7823	7905	7715	7715
q19	808	783	799	783
q20	1903	2002	1801	1801
q21	4745	4438	4206	4206
q22	1083	1035	962	962
Total cold run time: 52601 ms
Total hot run time: 50691 ms

@doris-robot

doris-robot commented Jul 23, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 187821 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e12387580374bd1c89371c421894ed7010c413fa, data reload: false
query1	993	387	405	387
query2	6575	1724	1680	1680
query3	6772	217	217	217
query4	26654	23937	23473	23473
query5	4385	643	480	480
query6	332	224	205	205
query7	4631	498	303	303
query8	282	237	218	218
query9	8584	2850	2867	2850
query10	482	348	270	270
query11	15938	15018	14924	14924
query12	162	120	113	113
query13	1655	550	409	409
query14	9164	5899	5994	5899
query15	213	194	171	171
query16	7302	633	457	457
query17	1221	725	604	604
query18	2000	421	330	330
query19	194	185	166	166
query20	124	117	124	117
query21	213	124	109	109
query22	4372	4299	4186	4186
query23	34022	33041	33086	33041
query24	8121	2401	2409	2401
query25	550	499	427	427
query26	1237	265	160	160
query27	2735	490	341	341
query28	4389	2201	2166	2166
query29	742	589	457	457
query30	283	217	192	192
query31	921	789	746	746
query32	83	77	73	73
query33	549	378	327	327
query34	790	839	513	513
query35	790	832	733	733
query36	957	1008	943	943
query37	121	103	87	87
query38	4132	4233	4098	4098
query39	1447	1424	1382	1382
query40	223	128	115	115
query41	62	57	53	53
query42	124	113	110	110
query43	499	490	471	471
query44	1374	849	846	846
query45	177	166	164	164
query46	855	1005	645	645
query47	1765	1836	1720	1720
query48	398	423	320	320
query49	693	469	387	387
query50	672	692	415	415
query51	5503	5446	5520	5446
query52	122	111	108	108
query53	239	260	195	195
query54	592	593	528	528
query55	86	89	89	89
query56	324	315	309	309
query57	1166	1215	1123	1123
query58	282	276	283	276
query59	2543	2673	2534	2534
query60	352	345	341	341
query61	124	131	159	131
query62	791	746	646	646
query63	229	198	190	190
query64	4271	1005	708	708
query65	4274	4177	4258	4177
query66	1163	424	340	340
query67	15592	15416	15306	15306
query68	8034	915	562	562
query69	475	324	297	297
query70	1281	1149	1177	1149
query71	479	353	317	317
query72	5258	4792	4751	4751
query73	744	616	355	355
query74	8963	9088	8966	8966
query75	3779	3094	2692	2692
query76	3682	1139	739	739
query77	794	387	322	322
query78	9822	10249	9157	9157
query79	2263	855	597	597
query80	607	598	482	482
query81	464	269	222	222
query82	428	136	103	103
query83	281	259	234	234
query84	304	109	127	109
query85	783	380	330	330
query86	337	308	309	308
query87	4427	4433	4223	4223
query88	2862	2240	2221	2221
query89	372	326	285	285
query90	1921	231	228	228
query91	151	147	113	113
query92	84	69	68	68
query93	1136	995	624	624
query94	673	389	307	307
query95	394	325	316	316
query96	488	598	282	282
query97	2741	2722	2621	2621
query98	232	226	210	210
query99	1418	1398	1283	1283
Total cold run time: 274289 ms
Total hot run time: 187821 ms

@doris-robot

doris-robot commented Jul 23, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e12387580374bd1c89371c421894ed7010c413fa, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.05
query3	0.26	0.08	0.07
query4	1.62	0.11	0.11
query5	0.41	0.42	0.41
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.53	0.51
query10	0.58	0.56	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.63	0.61
query14	0.81	0.82	0.83
query15	0.89	0.88	0.85
query16	0.41	0.40	0.42
query17	1.05	1.04	1.05
query18	0.22	0.21	0.20
query19	1.93	1.89	1.82
query20	0.01	0.02	0.02
query21	15.38	0.94	0.54
query22	0.77	1.30	0.94
query23	14.69	1.36	0.65
query24	6.57	1.70	1.03
query25	0.45	0.15	0.18
query26	0.73	0.18	0.14
query27	0.06	0.05	0.06
query28	9.58	0.92	0.43
query29	12.58	3.91	3.24
query30	3.09	3.04	2.97
query31	2.81	0.56	0.38
query32	3.24	0.55	0.47
query33	3.05	3.07	3.20
query34	16.12	5.44	4.84
query35	4.87	4.90	4.89
query36	0.70	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.13	0.14
query41	0.08	0.02	0.02
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.27 s
Total hot run time: 33.05 s

@hello-stephen

hello-stephen commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

liaoxin01
liaoxin01 approved these changes Jul 23, 2025
View reviewed changes

@liaoxin01liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2025
@github-actions

github-actionsBot commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
hello-stephen merged commit b4f13fb into apache:masterJul 24, 2025
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Jul 30, 2025
@sollhui@w41ter
[fix](job) fix NullPointerException when replay job (apache#53768)
5a75bbd
### What problem does this PR solve?
introduce by apache#52911
fix NullPointerException when replay job
```
java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "this.cloudCluster" is null
```
sollhui added a commit to sollhui/doris that referenced this pull request Jul 30, 2025
@sollhui
[fix](job) fix NullPointerException when replay job (apache#53768)
8a0dda4
### What problem does this PR solve?
introduce by apache#52911
fix NullPointerException when replay job
```
java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "this.cloudCluster" is null
```
@sollhuisollhui mentioned this pull request Jul 30, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 31, 2025
@sollhui
branch-3.1: [fix](job) use cluster name rather than cluster id to fin…
ab54486
…d available be #52911 and #53768 (#54123)
pick #52911 and #53768
RoanHeNaN pushed a commit to RoanHeNaN/doris that referenced this pull request Aug 4, 2025
@sollhui@RoanHeNaN
[fix](job) fix NullPointerException when replay job (apache#53768)
beba1ce
### What problem does this PR solve?
introduce by apache#52911
fix NullPointerException when replay job
```
java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "this.cloudCluster" is null
```
@sollhuisollhui mentioned this pull request Sep 11, 2025
Merged
16 tasks
@enocknkhomaenocknkhoma mentioned this pull request Jul 13, 2026
Open
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01liaoxin01liaoxin01 approved these changes
@hello-stephenhello-stephenhello-stephen approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.9-mergeddev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sollhui@Thearas@doris-robot@hello-stephen@liaoxin01@dataroaring@morrySnow