Uh oh!
There was an error while loading. Please reload this page.
[branch-3.0](core) Fix format round would core under boundary conditions - #53855
Merged
Conversation
hello-stephen
commented
Jul 24, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Mryange
commented
Jul 24, 2025
ContributorAuthor
run buildall |
1 similar comment
Mryange
commented
Jul 24, 2025
ContributorAuthor
run buildall |
Mryangeforce-pushed
the
branch-3.0-pick-53660
branch
from
July 24, 2025 12:44
bbe83e0 to
a9682a8CompareMryange
commented
Jul 24, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 24, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
commented
Jul 24, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 24, 2025
TPC-H: Total hot run time: 39832 ms |
doris-robot
commented
Jul 24, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
doris-robot
commented
Jul 24, 2025
TPC-DS: Total hot run time: 196673 ms |
doris-robot
commented
Jul 24, 2025
ClickBench: Total hot run time: 30.74 s |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…53660)
#53660
my_double_round did not handle NaN values correctly. For example, when dec is very large and value is 0, there will be a case of 0 * inf, resulting in a NaN value.
do_format_round assumes the input is always a valid double value, which causes a core dump when a NaN is passed in.
Additionally,
(value.size() - (is_positive ? (decimal_places + 2) : (decimal_places + 3))) / 3;
This code does not account for the situation where value.size() is 0.
Currently, a custom add_thousands_separator function is implemented. If the fmt library is upgraded in the future, we should use fmt to add thousands separators.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)