Skip to content

[fix](warmup) fix warm up jobs missing last batch (#53860) - #53861

Merged
dataroaring merged 2 commits into
apache:branch-3.0from
kaijchen:DORIS-21591-3.0
Jul 25, 2025
Merged

[fix](warmup) fix warm up jobs missing last batch (#53860)#53861
dataroaring merged 2 commits into
apache:branch-3.0from
kaijchen:DORIS-21591-3.0

Conversation

@kaijchen

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: DORIS-21591
Related PR: #53860

Problem Summary:

  1. _pending_job_metas may be cleared by a CLEAR_JOB request, so we need to check it again.
  2. We can not call pop_front before the job is finished, because GET_CURRENT_JOB_STATE_AND_LEASE is relying on the pending job size.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen

Copy link
Copy Markdown
MemberAuthor

run buildall

@kaijchenkaijchen changed the title [fix](warmup) fix warm up jobs missing last batch[fix](warmup) fix warm up jobs missing last batch (#53860)Jul 24, 2025
@kaijchen

Copy link
Copy Markdown
MemberAuthor

run buildall

@freemandealerfreemandealer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage41.90% (11136/26580)
Line Coverage32.44% (95406/294129)
Region Coverage31.57% (49264/156069)
Branch Coverage28.00% (25249/90186)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage50.78% (13322/26234)
Line Coverage41.24% (121136/293735)
Region Coverage38.90% (70307/180737)
Branch Coverage33.27% (33922/101952)

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 66d1c33 into apache:branch-3.0Jul 25, 2025
27 of 30 checks passed
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@kaijchen@Thearas@hello-stephen@freemandealer@gavinchou@dataroaring