Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids) project distinct to agg checker exclude window function - #54133
Merged
924060929 merged 1 commit intoAug 11, 2025
Merged
Conversation
Thearas
commented
Jul 31, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
yujun777
commented
Jul 31, 2025
ContributorAuthor
run buildall |
yujun777force-pushed
the
fix-project-distinct-window-function
branch
from
July 31, 2025 03:26
6ac7f5e to
6046e2dCompareyujun777
commented
Jul 31, 2025
ContributorAuthor
run buildall |
yujun777force-pushed
the
fix-project-distinct-window-function
branch
from
July 31, 2025 03:51
6046e2d to
ea287b1Compareyujun777
commented
Jul 31, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jul 31, 2025
TPC-H: Total hot run time: 35475 ms |
doris-robot
commented
Jul 31, 2025
TPC-DS: Total hot run time: 163915 ms |
doris-robot
commented
Jul 31, 2025
ClickBench: Total hot run time: 32.74 s |
yujun777
commented
Jul 31, 2025
ContributorAuthor
run nonconcurrent |
yujun777force-pushed
the
fix-project-distinct-window-function
branch
from
July 31, 2025 09:11
ea287b1 to
fe137c9Compareyujun777
commented
Jul 31, 2025
ContributorAuthor
run buildall |
hello-stephen
commented
Jul 31, 2025
Contributor
FE UT Coverage ReportIncrement line coverage |
doris-robot
commented
Jul 31, 2025
TPC-H: Total hot run time: 33968 ms |
doris-robot
commented
Jul 31, 2025
TPC-DS: Total hot run time: 172331 ms |
doris-robot
commented
Jul 31, 2025
ClickBench: Total hot run time: 33.18 s |
morrySnow
approved these changes
Aug 4, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
yujun777force-pushed
the
fix-project-distinct-window-function
branch
from
August 8, 2025 09:56
fe137c9 to
c32624cCompareyujun777
commented
Aug 8, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Aug 8, 2025
TPC-H: Total hot run time: 33541 ms |
doris-robot
commented
Aug 8, 2025
TPC-DS: Total hot run time: 170385 ms |
doris-robot
commented
Aug 8, 2025
ClickBench: Total hot run time: 33.39 s |
yujun777
commented
Aug 8, 2025
ContributorAuthor
run nonconcurrent |
hello-stephen
commented
Aug 8, 2025
Contributor
FE UT Coverage ReportIncrement line coverage |
yujun777
commented
Aug 8, 2025
ContributorAuthor
run nonConcurrent |
yujun777
commented
Aug 8, 2025
ContributorAuthor
run nonconcurrent |
924060929
approved these changes
Aug 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 11, 2025
Merged
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
for a project, if it is distinct and no contains agg function, ProjectWithDistinctToAggregate will convert project to agg.
but the agg function should exclude window function.
for example:
for table t:
then for a distinct query
it output two rows, it's error, should output one row.
so we exclude the window function, then with this pr, the result will be:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)