[workloadgroup](improvement) using min/max cpu and memory percent to unify soft and hard limit by yiguolei · Pull Request #54243 · apache/doris

yiguolei · 2025-08-03T08:46:49Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-08-03T08:46:54Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yiguolei · 2025-08-05T06:44:07Z

run buildall

doris-robot · 2025-08-05T07:06:51Z

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.16% (1361/1677)
Line Coverage	65.80% (23508/35725)
Region Coverage	67.01% (11677/17427)
Branch Coverage	56.63% (6117/10802)

wangbo · 2025-08-05T10:41:37Z

+ {"MIN_CPU_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MAX_CPU_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MIN_MEMORY_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MAX_MEMORY_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},


In an 1024G memoy's node, 1% means 10G memory, 0.5% means 5G memory, it's not a small waste , maybe double is better.

I think it is ok. If the memory is very large, use do not need care about 5GB memory.
But this is a bug, the type should be varchar, not int64.

wangbo · 2025-08-05T10:54:38Z

- int64_t _memory_limit; // bytes
+ std::atomic<int> _min_cpu_percent = 0;
+ std::atomic<int> _max_cpu_percent = 100;
+ bool _enable_memory_overcommit = true;


_enable_memory_overcommit is useless?

Currently it is useful， we only use it to skip memory check....

yiguolei · 2025-08-06T06:04:58Z

run buildall

hello-stephen · 2025-08-06T06:28:03Z

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.60% (1401/1717)
Line Coverage	65.98% (23856/36158)
Region Coverage	67.24% (11844/17615)
Branch Coverage	56.81% (6193/10902)

wangbo · 2025-08-06T06:45:40Z

- .add(MAX_REMOTE_SCAN_THREAD_NUM).add(MIN_REMOTE_SCAN_THREAD_NUM)
- .add(MEMORY_LOW_WATERMARK).add(MEMORY_HIGH_WATERMARK)
+ .add(MAX_CPU_PERCENT).add(MIN_CPU_PERCENT)
+ .add(MAX_MEMORY_PERCENT).add(MIN_MEMORY_PERCENT).add(ENABLE_MEMORY_OVERCOMMIT)


ENABLE_MEMORY_OVERCOMMIT这个是不是可以删了

还不太行，现在老版本升级过来的normal的内存只有40%，之前是软限，所以没问题。我们现在都改成硬限了，会导致query 被cancel。所以还得让默认的enable memory overcommit 发挥作用，让他是true

doris-robot · 2025-08-06T08:02:10Z

TPC-H: Total hot run time: 34160 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3532709f1ea972e709637404f0250fc442bbb1a7, data reload: false
------ Round 1 ----------------------------------
q1	17660	5393	5330	5330
q2	1913	288	178	178
q3	10682	1379	762	762
q4	10324	1073	550	550
q5	10173	2299	2326	2299
q6	237	168	134	134
q7	894	759	639	639
q8	9296	1298	1112	1112
q9	6831	5094	5096	5094
q10	6957	2382	1983	1983
q11	476	285	265	265
q12	352	362	223	223
q13	17812	3407	2996	2996
q14	239	251	224	224
q15	546	469	473	469
q16	445	419	375	375
q17	584	826	357	357
q18	7393	7028	7053	7028
q19	2096	976	542	542
q20	318	307	211	211
q21	3417	3080	2391	2391
q22	1105	1133	998	998
Total cold run time: 109750 ms
Total hot run time: 34160 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5542	5235	5265	5235
q2	236	311	225	225
q3	2086	2557	2153	2153
q4	1297	1728	1373	1373
q5	4473	4405	4526	4405
q6	222	185	133	133
q7	1874	1945	1947	1945
q8	2532	2438	2598	2438
q9	7268	7316	7188	7188
q10	3148	3442	2880	2880
q11	648	509	490	490
q12	669	811	623	623
q13	3356	3699	3204	3204
q14	296	290	302	290
q15	492	466	472	466
q16	460	500	467	467
q17	1181	1513	1342	1342
q18	7980	7655	7804	7655
q19	15114	895	981	895
q20	2815	1908	1810	1810
q21	13878	4282	4312	4282
q22	1087	1038	1036	1036
Total cold run time: 76654 ms
Total hot run time: 50535 ms

doris-robot · 2025-08-06T08:13:59Z

TPC-DS: Total hot run time: 170687 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3532709f1ea972e709637404f0250fc442bbb1a7, data reload: false
============================================
query1	1004	428	416	416
query2	6536	1861	1711	1711
query3	6738	226	221	221
query4	27079	23906	22882	22882
query5	4356	633	529	529
query6	343	242	237	237
query7	4637	519	303	303
query8	278	232	226	226
query9	8563	2995	2942	2942
query10	478	337	289	289
query11	15636	14934	14802	14802
query12	184	140	130	130
query13	1675	547	417	417
query14	9489	5908	5954	5908
query15	211	184	167	167
query16	7815	668	452	452
query17	1632	783	654	654
query18	2122	431	311	311
query19	311	205	180	180
query20	147	145	131	131
query21	218	164	107	107
query22	3987	4049	3915	3915
query23	34761	34311	34354	34311
query24	7405	2396	2403	2396
query25	536	523	435	435
query26	912	286	171	171
query27	2531	485	356	356
query28	4317	2356	2355	2355
query29	736	601	491	491
query30	295	233	200	200
query31	898	788	708	708
query32	94	74	74	74
query33	600	421	361	361
query34	829	830	532	532
query35	793	852	744	744
query36	1042	1047	908	908
query37	132	109	95	95
query38	3967	3902	3958	3902
query39	1463	1374	1366	1366
query40	247	140	132	132
query41	62	58	54	54
query42	145	127	136	127
query43	496	517	495	495
query44	1393	880	881	880
query45	198	184	177	177
query46	967	1067	697	697
query47	1800	1853	1750	1750
query48	415	430	313	313
query49	676	512	412	412
query50	674	695	423	423
query51	4211	4221	4223	4221
query52	130	146	118	118
query53	257	288	226	226
query54	650	646	552	552
query55	91	86	92	86
query56	353	351	359	351
query57	1209	1221	1134	1134
query58	338	334	331	331
query59	2659	2715	2591	2591
query60	400	391	386	386
query61	127	121	146	121
query62	808	735	692	692
query63	252	216	219	216
query64	3557	1113	779	779
query65	4266	4187	4186	4186
query66	920	461	334	334
query67	query68	17053	878	857	857
query69	1101	268	284	268
query70	1314	1146	1121	1121
query71	711	310	327	310
query72	9208	2294	2177	2177
query73	3176	688	360	360
query74	9079	9114	8913	8913
query75	7463	3107	2710	2710
query76	8425	1216	804	804
query77	1167	406	354	354
query78	9773	10961	9551	9551
query79	14330	615	574	574
query80	1740	607	470	470
query81	575	262	224	224
query82	624	152	118	118
query83	378	291	264	264
query84	299	98	84	84
query85	870	403	337	337
query86	365	345	296	296
query87	4205	4158	4110	4110
query88	5449	2349	2249	2249
query89	488	370	310	310
query90	2599	234	238	234
query91	145	139	113	113
query92	90	72	67	67
query93	6171	1008	658	658
query94	1001	401	279	279
query95	399	337	320	320
query96	510	580	282	282
query97	2705	2725	2637	2637
query98	252	247	222	222
query99	1470	1465	1295	1295
Total cold run time: 305186 ms
Total hot run time: 170687 ms

doris-robot · 2025-08-06T08:19:39Z

ClickBench: Total hot run time: 35.23 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3532709f1ea972e709637404f0250fc442bbb1a7, data reload: false
query1	0.03	0.03	0.04
query2	0.11	0.05	0.06
query3	0.30	0.06	0.06
query4	1.60	0.08	0.09
query5	0.41	0.41	0.41
query6	1.17	0.67	0.65
query7	0.03	0.02	0.02
query8	0.08	0.05	0.05
query9	0.59	0.47	0.48
query10	0.53	0.53	0.53
query11	0.26	0.13	0.13
query12	0.25	0.14	0.13
query13	0.67	0.70	0.69
query14	0.93	1.11	1.30
query15	1.01	0.93	0.93
query16	0.39	0.40	0.39
query17	1.07	1.10	1.09
query18	0.26	0.23	0.24
query19	1.94	1.90	1.96
query20	0.01	0.01	0.01
query21	15.35	1.00	0.71
query22	0.99	1.13	0.97
query23	14.67	1.53	0.89
query24	4.95	0.62	0.38
query25	0.19	0.11	0.11
query26	0.56	0.23	0.20
query27	0.12	0.12	0.12
query28	11.08	1.15	0.66
query29	12.60	4.07	3.59
query30	3.08	3.01	3.02
query31	2.83	0.62	0.47
query32	3.26	0.65	0.56
query33	3.08	3.22	3.31
query34	16.77	5.51	4.88
query35	4.87	5.07	5.08
query36	0.67	0.55	0.52
query37	0.25	0.24	0.23
query38	0.23	0.24	0.24
query39	0.07	0.07	0.06
query40	0.21	0.18	0.17
query41	0.12	0.08	0.07
query42	0.08	0.07	0.07
query43	0.07	0.07	0.07
Total cold run time: 107.74 s
Total hot run time: 35.23 s

doris-robot · 2025-08-06T08:52:14Z

BE UT Coverage Report

Increment line coverage 48.33% (58/120) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	58.30% (16380/28097)
Line Coverage	47.20% (148092/313737)
Region Coverage	36.16% (110860/306572)
Branch Coverage	39.04% (49211/126039)

yiguolei · 2025-08-07T08:17:36Z

run feut

… and hard limit

yiguolei · 2025-08-07T09:57:30Z

run feut

yiguolei · 2025-08-09T13:34:12Z

run buildall

hello-stephen · 2025-08-09T13:56:26Z

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.91% (1413/1725)
Line Coverage	66.19% (24239/36622)
Region Coverage	67.42% (12069/17901)
Branch Coverage	57.18% (6328/11066)

hello-stephen · 2025-08-09T14:42:58Z

FE UT Coverage Report

Increment line coverage 60.18% (133/221) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2025-08-09T15:24:59Z

TPC-H: Total hot run time: 33850 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 302da54a34adece062ba1b161f74b148b95a3b2c, data reload: false
------ Round 1 ----------------------------------
q1	17575	5344	5275	5275
q2	1920	291	197	197
q3	10302	1294	694	694
q4	10215	1009	553	553
q5	7700	2247	2372	2247
q6	238	166	131	131
q7	913	758	628	628
q8	9307	1278	1095	1095
q9	6892	5103	5122	5103
q10	6975	2379	2009	2009
q11	455	279	268	268
q12	356	356	234	234
q13	17781	3464	3009	3009
q14	227	251	223	223
q15	543	456	469	456
q16	419	426	376	376
q17	582	833	366	366
q18	7234	6956	7010	6956
q19	1243	993	554	554
q20	329	318	215	215
q21	3429	2462	2272	2272
q22	1067	1041	989	989
Total cold run time: 105702 ms
Total hot run time: 33850 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5386	5376	5271	5271
q2	238	308	225	225
q3	2076	2556	2217	2217
q4	1304	1703	1294	1294
q5	4133	4224	4528	4224
q6	222	175	137	137
q7	1930	1983	1877	1877
q8	2572	2547	2534	2534
q9	7353	7149	7301	7149
q10	3276	3297	2910	2910
q11	563	534	586	534
q12	775	763	626	626
q13	3454	3705	3367	3367
q14	298	306	303	303
q15	568	454	451	451
q16	584	485	465	465
q17	1178	1493	1381	1381
q18	8114	7653	7672	7653
q19	11765	983	1093	983
q20	1927	1996	1763	1763
q21	14739	4335	4228	4228
q22	1052	1023	1003	1003
Total cold run time: 73507 ms
Total hot run time: 50595 ms

doris-robot · 2025-08-09T15:36:38Z

TPC-DS: Total hot run time: 170582 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 302da54a34adece062ba1b161f74b148b95a3b2c, data reload: false
============================================
query1	996	407	425	407
query2	6511	1918	1737	1737
query3	6740	223	223	223
query4	26949	23860	22793	22793
query5	4340	636	519	519
query6	342	251	228	228
query7	4641	516	302	302
query8	278	236	222	222
query9	8570	2934	2977	2934
query10	510	377	321	321
query11	15623	15120	14764	14764
query12	183	138	142	138
query13	1684	549	420	420
query14	8684	5958	5846	5846
query15	208	187	184	184
query16	7712	684	494	494
query17	1267	747	646	646
query18	2009	451	313	313
query19	223	207	187	187
query20	150	179	142	142
query21	220	122	102	102
query22	4087	4095	4083	4083
query23	34498	34398	34403	34398
query24	5983	2429	2463	2429
query25	486	494	431	431
query26	709	306	158	158
query27	2336	509	345	345
query28	2997	2338	2342	2338
query29	637	613	478	478
query30	288	231	204	204
query31	871	784	712	712
query32	90	80	82	80
query33	542	408	362	362
query34	838	865	517	517
query35	795	835	785	785
query36	1011	1041	917	917
query37	128	115	92	92
query38	4012	3923	3961	3923
query39	1459	1371	1393	1371
query40	242	143	129	129
query41	63	56	57	56
query42	153	127	127	127
query43	504	530	489	489
query44	1410	874	860	860
query45	198	192	185	185
query46	956	1086	673	673
query47	1805	1808	1739	1739
query48	410	446	308	308
query49	674	500	410	410
query50	660	690	425	425
query51	4173	4208	4341	4208
query52	134	132	121	121
query53	259	289	206	206
query54	644	646	568	568
query55	96	91	87	87
query56	360	357	334	334
query57	1186	1211	1166	1166
query58	341	355	342	342
query59	2618	2686	2583	2583
query60	413	394	387	387
query61	129	121	127	121
query62	756	749	668	668
query63	246	213	217	213
query64	2378	1167	776	776
query65	4238	4140	4161	4140
query66	916	450	332	332
query67	query68	18173	994	909	909
query69	1059	277	285	277
query70	1420	1122	1158	1122
query71	717	338	326	326
query72	9142	2272	2355	2272
query73	3706	635	360	360
query74	9341	8928	8741	8741
query75	7600	3091	2684	2684
query76	8943	1225	863	863
query77	1147	418	331	331
query78	9510	9712	9234	9234
query79	13841	609	584	584
query80	942	554	541	541
query81	545	259	227	227
query82	360	151	119	119
query83	302	292	280	280
query84	298	100	82	82
query85	817	371	342	342
query86	354	321	300	300
query87	4201	4132	4100	4100
query88	3780	2243	2252	2243
query89	475	363	316	316
query90	2636	228	232	228
query91	158	146	118	118
query92	93	73	77	73
query93	4403	974	669	669
query94	921	416	276	276
query95	408	327	329	327
query96	513	640	286	286
query97	2686	2732	2617	2617
query98	262	239	220	220
query99	1424	1455	1317	1317
Total cold run time: 295746 ms
Total hot run time: 170582 ms

doris-robot · 2025-08-09T15:42:17Z

ClickBench: Total hot run time: 35.05 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 302da54a34adece062ba1b161f74b148b95a3b2c, data reload: false
query1	0.04	0.03	0.04
query2	0.11	0.06	0.06
query3	0.29	0.06	0.07
query4	1.61	0.08	0.08
query5	0.42	0.42	0.44
query6	1.17	0.70	0.68
query7	0.04	0.02	0.02
query8	0.07	0.05	0.06
query9	0.61	0.48	0.50
query10	0.55	0.55	0.56
query11	0.25	0.12	0.12
query12	0.25	0.13	0.13
query13	0.68	0.69	0.68
query14	0.92	1.10	1.12
query15	1.05	0.94	0.93
query16	0.38	0.39	0.39
query17	1.11	1.12	1.10
query18	0.25	0.23	0.24
query19	2.17	1.89	1.98
query20	0.02	0.01	0.01
query21	15.34	0.97	0.71
query22	0.97	1.16	0.92
query23	14.72	1.50	0.87
query24	4.91	0.63	0.40
query25	0.18	0.12	0.11
query26	0.57	0.23	0.20
query27	0.11	0.11	0.11
query28	11.14	1.15	0.65
query29	12.63	3.99	3.48
query30	3.11	3.00	3.06
query31	2.82	0.62	0.46
query32	3.24	0.66	0.57
query33	3.12	3.26	3.28
query34	16.42	5.51	4.95
query35	4.89	4.96	5.08
query36	0.67	0.54	0.51
query37	0.25	0.23	0.22
query38	0.24	0.24	0.23
query39	0.07	0.06	0.06
query40	0.20	0.18	0.17
query41	0.12	0.07	0.08
query42	0.08	0.07	0.08
query43	0.07	0.06	0.06
Total cold run time: 107.86 s
Total hot run time: 35.05 s

doris-robot · 2025-08-09T15:58:15Z

BE UT Coverage Report

Increment line coverage 49.15% (58/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	58.89% (16585/28165)
Line Coverage	47.78% (150306/314561)
Region Coverage	36.63% (112590/307333)
Branch Coverage	39.62% (50027/126257)

hello-stephen · 2025-08-09T18:04:14Z

BE Regression && UT Coverage Report

Increment line coverage 77.97% (92/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.35% (22486/27642)
Line Coverage	74.05% (232945/314576)
Region Coverage	61.52% (194145/315604)
Branch Coverage	65.50% (83713/127807)

yiguolei · 2025-08-10T00:21:31Z

run p0

yiguolei · 2025-08-10T02:22:24Z

run p0

yiguolei · 2025-08-10T02:56:34Z

run p0

yiguolei · 2025-08-10T08:00:04Z

run buildall

doris-robot · 2025-08-10T08:29:35Z

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.91% (1413/1725)
Line Coverage	66.17% (24233/36622)
Region Coverage	67.36% (12058/17901)
Branch Coverage	57.12% (6321/11066)

doris-robot · 2025-08-10T08:48:19Z

TPC-H: Total hot run time: 33618 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e1d519b7520a0dddb83e7c0d9e59b8d0304eb92a, data reload: false
------ Round 1 ----------------------------------
q1	16408	5449	5309	5309
q2	1912	258	189	189
q3	9841	1227	696	696
q4	9684	988	505	505
q5	7490	2322	2199	2199
q6	182	166	131	131
q7	914	746	630	630
q8	9112	1259	1015	1015
q9	6880	5045	5076	5045
q10	6901	2331	1973	1973
q11	475	283	276	276
q12	348	371	216	216
q13	17371	3442	2985	2985
q14	235	227	220	220
q15	510	473	457	457
q16	432	414	365	365
q17	565	800	367	367
q18	7169	6966	7055	6966
q19	905	962	523	523
q20	315	293	204	204
q21	2699	2964	2318	2318
q22	998	1029	1036	1029
Total cold run time: 101346 ms
Total hot run time: 33618 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5319	5355	5250	5250
q2	229	298	220	220
q3	2100	2599	2158	2158
q4	1312	1691	1298	1298
q5	4120	4045	4195	4045
q6	217	183	137	137
q7	2027	1867	1968	1867
q8	2547	2433	2469	2433
q9	7136	7254	7178	7178
q10	3137	3421	2940	2940
q11	548	524	489	489
q12	736	816	641	641
q13	3515	3760	3390	3390
q14	273	286	288	286
q15	486	458	436	436
q16	450	484	452	452
q17	1119	1297	1283	1283
q18	7831	7599	7631	7599
q19	1632	911	925	911
q20	1998	2062	1935	1935
q21	4823	4263	4209	4209
q22	1023	1031	1033	1031
Total cold run time: 52578 ms
Total hot run time: 50188 ms

doris-robot · 2025-08-10T09:00:07Z

TPC-DS: Total hot run time: 169837 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e1d519b7520a0dddb83e7c0d9e59b8d0304eb92a, data reload: false
============================================
query1	998	406	419	406
query2	6532	1831	1692	1692
query3	6743	217	219	217
query4	26859	23798	22930	22930
query5	4361	634	522	522
query6	333	248	238	238
query7	4633	521	289	289
query8	299	231	231	231
query9	8612	2934	2927	2927
query10	477	313	282	282
query11	15838	14946	14709	14709
query12	180	134	130	130
query13	1649	543	414	414
query14	8540	5894	5795	5795
query15	256	190	177	177
query16	8046	634	480	480
query17	1640	778	656	656
query18	2097	451	325	325
query19	283	214	193	193
query20	156	138	135	135
query21	228	131	114	114
query22	4149	3937	3988	3937
query23	34627	34157	34103	34103
query24	8135	2390	2421	2390
query25	588	547	498	498
query26	885	286	160	160
query27	2648	493	371	371
query28	4250	2320	2316	2316
query29	693	589	490	490
query30	292	247	203	203
query31	897	772	708	708
query32	87	76	80	76
query33	556	416	371	371
query34	861	870	509	509
query35	829	837	773	773
query36	1021	1031	947	947
query37	140	107	90	90
query38	3888	4013	3936	3936
query39	1434	1394	1379	1379
query40	233	141	133	133
query41	59	58	54	54
query42	141	130	126	126
query43	502	527	472	472
query44	1421	856	856	856
query45	192	193	183	183
query46	941	1052	671	671
query47	1779	1837	1732	1732
query48	410	420	308	308
query49	676	508	409	409
query50	652	692	408	408
query51	4198	4138	4255	4138
query52	126	131	117	117
query53	259	291	207	207
query54	665	632	554	554
query55	88	89	87	87
query56	346	366	352	352
query57	1221	1186	1119	1119
query58	351	324	330	324
query59	2642	2719	2528	2528
query60	406	384	374	374
query61	125	130	147	130
query62	826	727	631	631
query63	250	206	208	206
query64	3529	1107	842	842
query65	4220	4143	4145	4143
query66	899	474	335	335
query67	query68	17001	867	1049	867
query69	1039	269	293	269
query70	1358	1152	1116	1116
query71	724	315	317	315
query72	9159	2324	2219	2219
query73	3299	686	354	354
query74	9115	8921	8753	8753
query75	7686	3141	2662	2662
query76	8860	1216	787	787
query77	1161	415	337	337
query78	9542	10726	9479	9479
query79	15051	619	593	593
query80	1883	561	508	508
query81	529	261	226	226
query82	511	152	114	114
query83	367	286	276	276
query84	310	101	86	86
query85	862	381	342	342
query86	363	310	319	310
query87	4260	4127	4055	4055
query88	5531	2254	2265	2254
query89	486	363	322	322
query90	2459	234	240	234
query91	151	143	111	111
query92	93	73	68	68
query93	6404	984	651	651
query94	1059	395	282	282
query95	434	335	387	335
query96	515	601	282	282
query97	2702	2696	2567	2567
query98	284	240	222	222
query99	1491	1423	1283	1283
Total cold run time: 306586 ms
Total hot run time: 169837 ms

doris-robot · 2025-08-10T09:05:46Z

ClickBench: Total hot run time: 34.99 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e1d519b7520a0dddb83e7c0d9e59b8d0304eb92a, data reload: false
query1	0.04	0.03	0.03
query2	0.10	0.05	0.06
query3	0.30	0.07	0.07
query4	1.59	0.09	0.08
query5	0.42	0.41	0.42
query6	1.17	0.67	0.67
query7	0.05	0.01	0.02
query8	0.07	0.06	0.06
query9	0.60	0.48	0.48
query10	0.54	0.53	0.55
query11	0.26	0.13	0.13
query12	0.25	0.14	0.13
query13	0.68	0.67	0.69
query14	0.92	1.12	1.09
query15	1.07	0.92	0.93
query16	0.38	0.40	0.38
query17	1.09	1.11	1.12
query18	0.25	0.23	0.24
query19	2.02	1.81	1.95
query20	0.02	0.02	0.02
query21	15.38	0.98	0.72
query22	0.97	1.07	0.93
query23	14.68	1.51	0.88
query24	4.86	0.63	0.39
query25	0.18	0.12	0.11
query26	0.56	0.23	0.20
query27	0.10	0.10	0.11
query28	11.09	1.16	0.64
query29	12.66	4.01	3.49
query30	3.15	3.00	3.00
query31	2.85	0.63	0.46
query32	3.24	0.65	0.57
query33	3.08	3.27	3.26
query34	16.63	5.44	4.93
query35	4.86	5.04	5.03
query36	0.69	0.55	0.53
query37	0.26	0.23	0.23
query38	0.24	0.23	0.23
query39	0.06	0.05	0.05
query40	0.20	0.18	0.16
query41	0.12	0.07	0.07
query42	0.08	0.07	0.07
query43	0.07	0.07	0.06
Total cold run time: 107.83 s
Total hot run time: 34.99 s

hello-stephen · 2025-08-10T09:11:35Z

BE UT Coverage Report

Increment line coverage 49.15% (58/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	58.88% (16583/28165)
Line Coverage	47.77% (150279/314561)
Region Coverage	36.64% (112613/307333)
Branch Coverage	39.62% (50024/126257)

hello-stephen · 2025-08-10T09:17:33Z

BE Regression && UT Coverage Report

Increment line coverage 77.97% (92/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.37% (22493/27642)
Line Coverage	74.05% (232950/314576)
Region Coverage	61.21% (193193/315604)
Branch Coverage	65.46% (83658/127807)

hello-stephen · 2025-08-10T10:42:02Z

BE Regression && UT Coverage Report

Increment line coverage 77.97% (92/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.37% (22493/27642)
Line Coverage	74.05% (232953/314576)
Region Coverage	61.17% (193070/315604)
Branch Coverage	65.45% (83654/127807)

hello-stephen · 2025-08-10T11:02:40Z

BE Regression && UT Coverage Report

Increment line coverage 77.97% (92/118) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.38% (22494/27642)
Line Coverage	74.06% (232970/314576)
Region Coverage	61.20% (193165/315604)
Branch Coverage	65.46% (83657/127807)

hello-stephen · 2025-08-11T02:58:48Z

FE UT Coverage Report

Increment line coverage 60.18% (133/221) 🎉
Increment coverage report
Complete coverage report

wangbo

LGTM

github-actions · 2025-08-11T06:26:11Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-11T06:26:14Z

PR approved by anyone and no changes requested.

HappenLee

LGTM

wangbo reviewed Aug 5, 2025
View reviewed changes

Comment threadbe/src/agent/cgroup_cpu_ctl.cpp

wangbo reviewed Aug 5, 2025
View reviewed changes

Comment threadbe/src/agent/cgroup_cpu_ctl.cpp

wangbo reviewed Aug 5, 2025
View reviewed changes

Comment threadbe/src/runtime/workload_group/workload_group.cpp

wangbo reviewed Aug 5, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java

yiguolei force-pushed the rename_percent branch from f670f37 to 3532709Compare August 6, 2025 04:31

wangbo reviewed Aug 6, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java

wangbo reviewed Aug 6, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java Outdated

wangbo reviewed Aug 6, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java Outdated

wangbo reviewed Aug 6, 2025
View reviewed changes

Comment threadbe/src/runtime/workload_group/workload_group.h

yiguolei force-pushed the rename_percent branch 2 times, most recently from 7e91ce9 to ad316d3Compare August 7, 2025 02:48

yiguolei added 4 commits August 7, 2025 17:01

[workloadgroup](soft&hard) unify workload group cpu and memory's soft…
6638ba2
… and hard limit

f
a08a9e6

f
f735651

f
87a14c1

yiguolei force-pushed the rename_percent branch from 44b3f5d to 87a14c1Compare August 7, 2025 09:57

f
5326b03

f
e1d519b

wangbo approved these changes Aug 11, 2025
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 11, 2025

HappenLee approved these changes Aug 11, 2025
View reviewed changes

yiguolei merged commit 60a7a32 into apache:masterAug 11, 2025
25 of 28 checks passed

Uh oh!

Conversation

yiguolei commented Aug 3, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Aug 3, 2025

Uh oh!

yiguolei commented Aug 5, 2025

Uh oh!

doris-robot commented Aug 5, 2025

Cloud UT Coverage Report

Uh oh!

Uh oh!

Uh oh!

wangboAug 5, 2025

Choose a reason for hiding this comment

Uh oh!

yiguoleiAug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wangboAug 5, 2025

Choose a reason for hiding this comment

Uh oh!

yiguoleiAug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yiguolei commented Aug 6, 2025

Uh oh!

hello-stephen commented Aug 6, 2025

Cloud UT Coverage Report

Uh oh!

Uh oh!

wangboAug 6, 2025

Choose a reason for hiding this comment

Uh oh!

yiguoleiAug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

Uh oh!

doris-robot commented Aug 6, 2025

BE UT Coverage Report

Uh oh!

yiguolei commented Aug 7, 2025

Uh oh!

yiguolei commented Aug 7, 2025

Uh oh!

yiguolei commented Aug 9, 2025

Uh oh!

hello-stephen commented Aug 9, 2025

Cloud UT Coverage Report

Uh oh!

hello-stephen commented Aug 9, 2025

FE UT Coverage Report

Uh oh!

doris-robot commented Aug 9, 2025

Uh oh!

doris-robot commented Aug 9, 2025

Uh oh!

doris-robot commented Aug 9, 2025

Uh oh!

doris-robot commented Aug 9, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 9, 2025

BE Regression && UT Coverage Report

Uh oh!

yiguolei commented Aug 10, 2025