Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or - #54353
Conversation
hello-stephen
commented
Aug 5, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
englefly
commented
Aug 6, 2025
run buildall |
doris-robot
commented
Aug 6, 2025
TPC-H: Total hot run time: 33499 ms |
doris-robot
commented
Aug 6, 2025
TPC-DS: Total hot run time: 170899 ms |
doris-robot
commented
Aug 6, 2025
ClickBench: Total hot run time: 32.81 s |
hello-stephen
commented
Aug 6, 2025
FE UT Coverage ReportIncrement line coverage |
| boolean nullable = left.getNullableFromNereids().isPresent() && left.getNullableFromNereids().get() | ||
| || left.isNullable() | ||
| || right.getNullableFromNereids().isPresent() && right.getNullableFromNereids().get() | ||
| || right.isNullable(); | ||
| cp.setNullableFromNereids(nullable); |
There was a problem hiding this comment.
i think we should only rely on NullableFromNereids. in which case NullableFromNereids is not present?
englefly
commented
Aug 6, 2025
run buildall |
doris-robot
commented
Aug 6, 2025
TPC-H: Total hot run time: 33602 ms |
doris-robot
commented
Aug 6, 2025
TPC-DS: Total hot run time: 169465 ms |
doris-robot
commented
Aug 6, 2025
ClickBench: Total hot run time: 33.65 s |
hello-stephen
commented
Aug 6, 2025
FE UT Coverage ReportIncrement line coverage |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
englefly
commented
Aug 8, 2025
run buildall |
feiniaofeiafei
commented
Aug 8, 2025
can add related pr #44574 in description |
doris-robot
commented
Aug 8, 2025
TPC-H: Total hot run time: 33958 ms |
doris-robot
commented
Aug 8, 2025
TPC-DS: Total hot run time: 160349 ms |
doris-robot
commented
Aug 8, 2025
ClickBench: Total hot run time: 33.2 s |
PR approved by at least one committer and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)