[fix](csv reader) trim enclose do not require trim_double_quotes property by sollhui · Pull Request #54937 · apache/doris

sollhui · 2025-08-18T08:14:38Z

What problem does this PR solve?

If user would like to load data "aaa" to Doris and want to trim """ to be aaa, need config two properties enclose = "\"" and trim_double_quotes = true.

This pr aim to trim enclose do not require trim_double_quotes property, if user config enclose, Doris would trim enclose automatically.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-08-18T08:14:43Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

sollhui · 2025-08-18T08:14:57Z

run buildall

sollhui · 2025-08-18T08:24:20Z

run buildall

doris-robot · 2025-08-18T08:50:00Z

TPC-H: Total hot run time: 33678 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c5f9de42f5be64f095fe86f1e82b95ee4f5417bc, data reload: false
------ Round 1 ----------------------------------
q1	17584	5418	5090	5090
q2	1915	283	181	181
q3	10327	1239	699	699
q4	10210	979	533	533
q5	7512	2416	2258	2258
q6	190	155	130	130
q7	881	739	605	605
q8	9305	1290	1072	1072
q9	6887	5157	5138	5138
q10	6881	2372	1961	1961
q11	490	298	276	276
q12	348	347	216	216
q13	17755	3668	3030	3030
q14	239	236	224	224
q15	585	478	481	478
q16	426	423	362	362
q17	583	841	352	352
q18	7269	7061	6964	6964
q19	1084	945	568	568
q20	342	324	216	216
q21	3986	2557	2345	2345
q22	1079	996	980	980
Total cold run time: 105878 ms
Total hot run time: 33678 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5217	5166	5192	5166
q2	242	317	223	223
q3	2178	2646	2260	2260
q4	1375	1765	1353	1353
q5	4198	4395	4458	4395
q6	220	169	129	129
q7	2084	1925	1879	1879
q8	2658	2528	2546	2528
q9	7288	7329	7324	7324
q10	3072	3269	2796	2796
q11	588	521	488	488
q12	763	820	670	670
q13	3502	3946	3263	3263
q14	304	312	271	271
q15	517	477	484	477
q16	456	506	452	452
q17	1138	1518	1456	1456
q18	7864	7720	7654	7654
q19	843	804	848	804
q20	1951	2081	1822	1822
q21	4784	4435	4390	4390
q22	1065	1005	995	995
Total cold run time: 52307 ms
Total hot run time: 50795 ms

doris-robot · 2025-08-18T09:01:27Z

TPC-DS: Total hot run time: 184136 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c5f9de42f5be64f095fe86f1e82b95ee4f5417bc, data reload: false
query1	997	373	410	373
query2	6561	1723	1711	1711
query3	6743	217	214	214
query4	26307	23692	22854	22854
query5	4316	600	486	486
query6	293	217	196	196
query7	4625	512	281	281
query8	270	219	206	206
query9	8572	2863	2839	2839
query10	478	340	291	291
query11	15482	15144	14806	14806
query12	157	113	107	107
query13	1669	541	432	432
query14	8474	5798	5690	5690
query15	207	178	169	169
query16	7129	613	447	447
query17	1041	690	565	565
query18	2029	405	314	314
query19	185	182	164	164
query20	122	115	119	115
query21	208	119	106	106
query22	3957	4114	4123	4114
query23	33843	33180	33204	33180
query24	8121	2315	2306	2306
query25	533	475	400	400
query26	1238	268	155	155
query27	2748	499	338	338
query28	4415	2224	2195	2195
query29	777	551	445	445
query30	312	223	187	187
query31	888	782	720	720
query32	77	75	72	72
query33	545	356	330	330
query34	778	834	504	504
query35	790	802	733	733
query36	944	999	906	906
query37	114	101	85	85
query38	4050	3985	3936	3936
query39	1474	1442	1435	1435
query40	217	120	118	118
query41	58	56	52	52
query42	119	105	110	105
query43	487	500	478	478
query44	1314	838	841	838
query45	176	165	162	162
query46	853	1000	637	637
query47	1772	1807	1712	1712
query48	380	405	310	310
query49	734	473	382	382
query50	628	685	390	390
query51	4122	4083	4089	4083
query52	107	112	100	100
query53	236	259	195	195
query54	578	582	503	503
query55	87	84	82	82
query56	307	311	300	300
query57	1225	1175	1132	1132
query58	283	269	276	269
query59	2672	2738	2583	2583
query60	376	337	321	321
query61	133	125	122	122
query62	810	697	662	662
query63	218	195	180	180
query64	4347	1008	673	673
query65	4227	4239	4238	4238
query66	1153	419	311	311
query67	15529	15285	15083	15083
query68	5657	916	570	570
query69	500	313	336	313
query70	1190	1173	1149	1149
query71	436	324	310	310
query72	5206	4729	4893	4729
query73	671	619	352	352
query74	9189	9154	8868	8868
query75	3120	3070	2621	2621
query76	3166	1124	738	738
query77	519	400	328	328
query78	9470	9428	8772	8772
query79	2879	809	597	597
query80	629	513	475	475
query81	487	254	216	216
query82	665	134	107	107
query83	253	245	234	234
query84	274	117	94	94
query85	825	365	360	360
query86	388	321	306	306
query87	4177	4272	4212	4212
query88	3706	2164	2156	2156
query89	371	315	274	274
query90	1880	211	211	211
query91	135	141	113	113
query92	90	67	69	67
query93	2614	982	634	634
query94	706	412	301	301
query95	387	314	301	301
query96	479	563	269	269
query97	2622	2679	2545	2545
query98	244	208	214	208
query99	1347	1451	1278	1278
Total cold run time: 268899 ms
Total hot run time: 184136 ms

doris-robot · 2025-08-18T09:06:55Z

ClickBench: Total hot run time: 32.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c5f9de42f5be64f095fe86f1e82b95ee4f5417bc, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.24	0.07	0.07
query4	1.63	0.11	0.11
query5	0.44	0.44	0.40
query6	1.18	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.53	0.51
query10	0.59	0.58	0.57
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.60
query14	0.82	0.81	0.82
query15	0.88	0.86	0.85
query16	0.39	0.40	0.38
query17	1.05	1.07	1.02
query18	0.21	0.19	0.20
query19	1.91	1.81	1.84
query20	0.01	0.02	0.01
query21	15.39	0.95	0.60
query22	0.75	1.27	0.78
query23	14.76	1.37	0.59
query24	6.55	0.67	1.46
query25	0.46	0.22	0.12
query26	0.59	0.16	0.12
query27	0.06	0.06	0.05
query28	10.84	0.91	0.42
query29	12.70	3.88	3.22
query30	3.04	3.06	2.98
query31	2.82	0.59	0.38
query32	3.23	0.55	0.48
query33	3.03	3.11	3.09
query34	15.85	5.43	4.90
query35	4.94	4.95	4.95
query36	0.69	0.51	0.50
query37	0.09	0.08	0.08
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.07	0.02	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.3 s
Total hot run time: 32.56 s

dataroaring

LGTM

github-actions · 2025-08-18T09:47:36Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-18T09:47:38Z

PR approved by anyone and no changes requested.

sollhui · 2025-08-18T13:16:10Z

run buildall

doris-robot · 2025-08-18T13:42:45Z

TPC-H: Total hot run time: 33686 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 861da969966531fe6bc005a5ce4a418c58ff08aa, data reload: false
------ Round 1 ----------------------------------
q1	17583	5160	5080	5080
q2	1911	281	183	183
q3	10312	1249	724	724
q4	10214	1014	518	518
q5	7521	2405	2259	2259
q6	174	157	128	128
q7	883	755	611	611
q8	9302	1251	1097	1097
q9	6819	5143	5076	5076
q10	6928	2372	1981	1981
q11	480	289	274	274
q12	354	354	224	224
q13	17794	3633	3050	3050
q14	233	254	210	210
q15	567	477	485	477
q16	420	416	377	377
q17	593	838	345	345
q18	7304	7050	6904	6904
q19	1089	936	560	560
q20	339	327	218	218
q21	4157	3215	2423	2423
q22	1084	1019	967	967
Total cold run time: 106061 ms
Total hot run time: 33686 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5117	5109	5097	5097
q2	244	319	212	212
q3	2179	2651	2260	2260
q4	1372	1794	1359	1359
q5	4217	4410	4424	4410
q6	211	171	132	132
q7	2057	1971	1819	1819
q8	2663	2640	2594	2594
q9	7319	7185	7267	7185
q10	3113	3257	2862	2862
q11	573	557	486	486
q12	719	800	639	639
q13	3492	3955	3447	3447
q14	289	294	284	284
q15	529	482	469	469
q16	461	502	440	440
q17	1129	1535	1450	1450
q18	7852	7710	7487	7487
q19	830	809	941	809
q20	2214	2049	1894	1894
q21	4900	4337	4294	4294
q22	1089	1062	998	998
Total cold run time: 52569 ms
Total hot run time: 50627 ms

doris-robot · 2025-08-18T13:54:15Z

TPC-DS: Total hot run time: 185051 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 861da969966531fe6bc005a5ce4a418c58ff08aa, data reload: false
query1	995	400	422	400
query2	6517	1725	1696	1696
query3	6749	226	219	219
query4	26375	23541	23603	23541
query5	4386	638	465	465
query6	295	206	219	206
query7	4617	499	283	283
query8	252	243	218	218
query9	8600	2813	2784	2784
query10	480	313	289	289
query11	15422	14902	14763	14763
query12	164	110	109	109
query13	1657	550	428	428
query14	8561	5722	5744	5722
query15	195	186	182	182
query16	7146	629	441	441
query17	1072	704	577	577
query18	1980	397	344	344
query19	191	180	155	155
query20	124	116	114	114
query21	221	116	104	104
query22	4024	4145	3985	3985
query23	34146	33427	33792	33427
query24	8171	2369	2404	2369
query25	548	485	412	412
query26	1246	279	162	162
query27	2712	512	346	346
query28	4315	2216	2193	2193
query29	777	558	437	437
query30	289	224	186	186
query31	860	810	705	705
query32	83	78	70	70
query33	548	371	335	335
query34	784	826	500	500
query35	813	823	756	756
query36	993	1023	907	907
query37	119	105	84	84
query38	4083	3982	3967	3967
query39	1460	1433	1420	1420
query40	218	127	116	116
query41	60	55	54	54
query42	115	106	106	106
query43	521	505	470	470
query44	1309	827	830	827
query45	168	167	166	166
query46	850	994	637	637
query47	1753	1818	1705	1705
query48	381	420	307	307
query49	717	492	379	379
query50	613	685	380	380
query51	4085	4083	4342	4083
query52	107	108	97	97
query53	222	264	187	187
query54	593	582	514	514
query55	88	78	91	78
query56	306	328	297	297
query57	1205	1204	1115	1115
query58	283	274	277	274
query59	2600	2677	2598	2598
query60	358	351	333	333
query61	155	160	150	150
query62	805	774	665	665
query63	236	186	187	186
query64	4370	981	676	676
query65	4233	4196	4193	4193
query66	1173	423	326	326
query67	15124	15122	15012	15012
query68	7958	891	574	574
query69	477	316	290	290
query70	1199	1106	1143	1106
query71	449	323	306	306
query72	5721	4800	4884	4800
query73	710	659	347	347
query74	9229	8925	9071	8925
query75	3709	3080	2624	2624
query76	3538	1200	728	728
query77	783	380	331	331
query78	9442	9624	8844	8844
query79	2177	829	611	611
query80	585	539	468	468
query81	481	256	223	223
query82	424	132	109	109
query83	255	244	223	223
query84	266	97	91	91
query85	840	383	340	340
query86	344	309	308	308
query87	4271	4331	4164	4164
query88	3101	2208	2157	2157
query89	391	319	302	302
query90	1930	223	218	218
query91	142	143	114	114
query92	88	71	68	68
query93	1133	990	636	636
query94	684	391	301	301
query95	397	309	302	302
query96	482	573	270	270
query97	2672	2644	2565	2565
query98	242	221	211	211
query99	1319	1400	1263	1263
Total cold run time: 270057 ms
Total hot run time: 185051 ms

doris-robot · 2025-08-18T13:59:43Z

ClickBench: Total hot run time: 32.46 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 861da969966531fe6bc005a5ce4a418c58ff08aa, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.08	0.07
query4	1.61	0.11	0.11
query5	0.43	0.45	0.40
query6	1.19	0.64	0.65
query7	0.02	0.02	0.01
query8	0.05	0.04	0.03
query9	0.60	0.53	0.52
query10	0.58	0.57	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.60	0.60
query14	0.81	0.87	0.81
query15	0.87	0.85	0.84
query16	0.40	0.38	0.39
query17	1.04	1.02	1.02
query18	0.22	0.20	0.19
query19	2.00	1.93	1.83
query20	0.01	0.01	0.02
query21	15.42	0.90	0.60
query22	0.75	1.31	0.87
query23	14.71	1.39	0.63
query24	6.52	2.69	0.60
query25	0.49	0.12	0.17
query26	0.64	0.16	0.13
query27	0.05	0.06	0.05
query28	9.31	0.94	0.43
query29	12.56	3.83	3.20
query30	3.08	3.04	3.00
query31	2.82	0.56	0.37
query32	3.24	0.54	0.46
query33	3.07	3.09	3.05
query34	15.99	5.42	4.86
query35	4.94	4.94	4.95
query36	0.69	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.05
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.07	0.03	0.03
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 105.88 s
Total hot run time: 32.46 s

doris-robot · 2025-08-18T14:24:11Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.64% (16773/28125)
Line Coverage	48.53% (152593/314429)
Region Coverage	37.48% (116043/309594)
Branch Coverage	40.39% (51230/126829)

sollhui · 2025-08-18T15:33:43Z

run buildall

hello-stephen · 2025-08-18T15:37:01Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.22% (22932/27556)
Line Coverage	76.76% (241221/314260)
Region Coverage	64.77% (204069/315057)
Branch Coverage	68.30% (87280/127786)

doris-robot · 2025-08-18T15:56:24Z

TPC-H: Total hot run time: 33732 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c1445bb49414a96638e5350c1f1efc6d11051d76, data reload: false
------ Round 1 ----------------------------------
q1	17558	5324	5120	5120
q2	1932	289	179	179
q3	10311	1368	711	711
q4	10225	1004	527	527
q5	7554	2419	2283	2283
q6	189	161	131	131
q7	880	755	623	623
q8	9303	1304	1064	1064
q9	6874	5101	5100	5100
q10	6891	2384	1949	1949
q11	468	305	270	270
q12	341	353	226	226
q13	17742	3660	2994	2994
q14	227	238	204	204
q15	539	499	483	483
q16	433	414	370	370
q17	585	869	374	374
q18	7347	7323	6912	6912
q19	1246	961	596	596
q20	353	340	223	223
q21	3853	3188	2421	2421
q22	1046	1023	972	972
Total cold run time: 105897 ms
Total hot run time: 33732 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5220	5131	5144	5131
q2	245	320	218	218
q3	2171	2648	2290	2290
q4	1369	1774	1353	1353
q5	4228	4601	4560	4560
q6	212	166	136	136
q7	1993	1984	1811	1811
q8	2676	2651	2616	2616
q9	7259	7340	7283	7283
q10	3109	3302	2872	2872
q11	579	506	512	506
q12	774	809	660	660
q13	3508	3872	3272	3272
q14	282	291	301	291
q15	532	471	472	471
q16	478	502	444	444
q17	1226	1552	1424	1424
q18	7861	7666	7577	7577
q19	857	863	919	863
q20	2048	2108	1880	1880
q21	4794	4388	4356	4356
q22	1070	1014	1004	1004
Total cold run time: 52491 ms
Total hot run time: 51018 ms

doris-robot · 2025-08-18T16:07:57Z

TPC-DS: Total hot run time: 184775 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c1445bb49414a96638e5350c1f1efc6d11051d76, data reload: false
query1	984	406	401	401
query2	6506	1771	1760	1760
query3	6739	220	217	217
query4	26012	23161	22996	22996
query5	4330	627	468	468
query6	299	223	197	197
query7	4621	494	288	288
query8	256	227	207	207
query9	8606	2819	2838	2819
query10	458	328	290	290
query11	15838	14957	14677	14677
query12	163	117	110	110
query13	1666	552	430	430
query14	8795	5735	5663	5663
query15	215	193	161	161
query16	7349	666	490	490
query17	1212	730	590	590
query18	1988	406	311	311
query19	193	191	166	166
query20	133	114	117	114
query21	210	121	106	106
query22	4174	4187	4015	4015
query23	34243	33262	33348	33262
query24	8245	2435	2347	2347
query25	531	471	397	397
query26	1230	265	159	159
query27	2737	503	344	344
query28	4342	2226	2203	2203
query29	754	613	444	444
query30	284	216	199	199
query31	865	806	703	703
query32	87	69	73	69
query33	549	378	324	324
query34	798	837	530	530
query35	787	818	729	729
query36	993	1019	903	903
query37	118	106	83	83
query38	4068	4039	3943	3943
query39	1497	1408	1401	1401
query40	217	124	114	114
query41	58	55	52	52
query42	118	106	115	106
query43	516	510	490	490
query44	1309	859	848	848
query45	174	167	158	158
query46	858	1082	652	652
query47	1780	1820	1760	1760
query48	386	418	332	332
query49	718	502	375	375
query50	654	688	395	395
query51	4059	4127	4031	4031
query52	110	107	98	98
query53	232	275	194	194
query54	590	610	517	517
query55	92	93	86	86
query56	301	312	299	299
query57	1175	1191	1146	1146
query58	280	269	263	263
query59	2657	2673	2603	2603
query60	340	332	323	323
query61	129	121	129	121
query62	786	727	660	660
query63	228	192	192	192
query64	4377	1001	697	697
query65	4297	4213	4209	4209
query66	1165	409	334	334
query67	15382	15255	15291	15255
query68	8033	912	569	569
query69	492	303	288	288
query70	1243	1161	1110	1110
query71	467	321	307	307
query72	5568	4901	5006	4901
query73	771	707	360	360
query74	9041	9102	8912	8912
query75	3900	3083	2616	2616
query76	3746	1134	718	718
query77	794	397	315	315
query78	9675	9694	8883	8883
query79	2404	823	576	576
query80	650	538	481	481
query81	499	258	216	216
query82	470	136	106	106
query83	259	252	223	223
query84	246	101	93	93
query85	821	443	334	334
query86	387	317	302	302
query87	4305	4238	4172	4172
query88	3531	2199	2189	2189
query89	386	311	287	287
query90	1844	218	215	215
query91	144	147	113	113
query92	88	80	66	66
query93	1735	1003	647	647
query94	663	392	308	308
query95	399	311	294	294
query96	491	571	273	273
query97	2631	2696	2578	2578
query98	249	225	220	220
query99	1649	1443	1277	1277
Total cold run time: 273444 ms
Total hot run time: 184775 ms

doris-robot · 2025-08-18T16:13:26Z

ClickBench: Total hot run time: 33.19 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c1445bb49414a96638e5350c1f1efc6d11051d76, data reload: false
query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.61	0.10	0.11
query5	0.42	0.41	0.40
query6	1.15	0.63	0.64
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.60	0.54	0.52
query10	0.57	0.56	0.57
query11	0.16	0.12	0.11
query12	0.14	0.12	0.11
query13	0.62	0.60	0.61
query14	0.80	0.84	0.84
query15	0.86	0.86	0.86
query16	0.39	0.40	0.39
query17	1.04	1.02	1.02
query18	0.20	0.19	0.20
query19	1.89	1.83	1.80
query20	0.01	0.01	0.01
query21	15.39	1.04	0.59
query22	0.76	1.14	0.70
query23	14.94	1.37	0.65
query24	6.77	1.41	1.71
query25	0.51	0.19	0.20
query26	0.61	0.16	0.12
query27	0.05	0.06	0.05
query28	10.57	0.87	0.41
query29	12.58	3.82	3.23
query30	3.07	3.01	2.98
query31	2.81	0.58	0.38
query32	3.26	0.57	0.48
query33	3.12	3.04	3.14
query34	16.17	5.46	4.89
query35	4.96	4.90	4.97
query36	0.68	0.51	0.49
query37	0.09	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.04	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.67 s
Total hot run time: 33.19 s

hello-stephen · 2025-08-18T16:32:36Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.64% (16774/28125)
Line Coverage	48.54% (152624/314429)
Region Coverage	37.49% (116067/309594)
Branch Coverage	40.40% (51236/126829)

hello-stephen · 2025-08-19T04:49:57Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.16% (22634/27549)
Line Coverage	74.85% (235128/314137)
Region Coverage	62.05% (195413/314942)
Branch Coverage	66.25% (84627/127746)

liaoxin01

LGTM

github-actions · 2025-08-19T07:06:51Z

PR approved by at least one committer and no changes requested.

hello-stephen · 2025-08-19T08:14:37Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.16% (22634/27549)
Line Coverage	74.85% (235141/314137)
Region Coverage	62.08% (195506/314942)
Branch Coverage	66.24% (84623/127746)

hello-stephen · 2025-08-19T09:11:20Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.16% (22634/27549)
Line Coverage	74.85% (235147/314137)
Region Coverage	62.07% (195490/314942)
Branch Coverage	66.24% (84616/127746)

hello-stephen · 2025-08-20T04:27:42Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.16% (22634/27549)
Line Coverage	74.85% (235141/314137)
Region Coverage	62.07% (195472/314942)
Branch Coverage	66.24% (84618/127746)

sollhui · 2025-08-20T06:43:17Z

run buildall

doris-robot · 2025-08-20T07:19:39Z

TPC-H: Total hot run time: 33426 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f3596bb5b46e0ce94dc0b0ef120b525dabfe13a9, data reload: false
------ Round 1 ----------------------------------
q1	6669	5057	4985	4985
q2	463	276	182	182
q3	871	1292	675	675
q4	711	1002	514	514
q5	2026	2051	2220	2051
q6	202	164	130	130
q7	878	748	607	607
q8	1098	1270	1125	1125
q9	5234	5108	5062	5062
q10	2273	2407	1953	1953
q11	419	279	271	271
q12	292	349	210	210
q13	3323	3661	3033	3033
q14	223	231	219	219
q15	526	483	491	483
q16	417	416	375	375
q17	571	832	378	378
q18	7199	7131	7175	7131
q19	567	928	539	539
q20	347	327	217	217
q21	3856	3150	2309	2309
q22	1040	1036	977	977
Total cold run time: 39205 ms
Total hot run time: 33426 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5103	5116	5077	5077
q2	284	318	228	228
q3	2168	2669	2294	2294
q4	1350	1757	1313	1313
q5	4204	4113	4122	4113
q6	204	166	123	123
q7	1849	1817	1691	1691
q8	2493	2431	2395	2395
q9	6823	6788	6781	6781
q10	2935	3117	2693	2693
q11	550	495	482	482
q12	652	760	584	584
q13	3208	3632	2997	2997
q14	286	290	258	258
q15	513	473	464	464
q16	426	468	446	446
q17	1089	1435	1354	1354
q18	7237	7021	7087	7021
q19	777	760	786	760
q20	1925	1973	1806	1806
q21	4737	4391	4304	4304
q22	1091	1032	991	991
Total cold run time: 49904 ms
Total hot run time: 48175 ms

doris-robot · 2025-08-20T07:31:08Z

TPC-DS: Total hot run time: 184152 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f3596bb5b46e0ce94dc0b0ef120b525dabfe13a9, data reload: false
query1	977	385	398	385
query2	6511	1776	1781	1776
query3	6742	223	221	221
query4	26193	23750	22756	22756
query5	4856	613	529	529
query6	308	212	202	202
query7	4625	490	288	288
query8	267	227	225	225
query9	8643	2839	2828	2828
query10	486	332	285	285
query11	15892	15339	14684	14684
query12	176	115	115	115
query13	1651	555	434	434
query14	9674	5679	5729	5679
query15	205	183	165	165
query16	7640	625	427	427
query17	1269	738	570	570
query18	2021	394	313	313
query19	182	181	156	156
query20	120	118	116	116
query21	216	126	103	103
query22	4020	4033	4019	4019
query23	34152	33287	33412	33287
query24	8102	2311	2315	2311
query25	544	476	397	397
query26	1228	274	154	154
query27	2725	497	341	341
query28	4370	2262	2212	2212
query29	714	551	458	458
query30	285	225	189	189
query31	895	803	713	713
query32	87	80	79	79
query33	544	375	339	339
query34	792	834	505	505
query35	790	866	748	748
query36	945	1028	932	932
query37	122	108	95	95
query38	4135	4076	3964	3964
query39	1493	1427	1441	1427
query40	232	141	134	134
query41	83	67	58	58
query42	121	116	111	111
query43	507	505	492	492
query44	1323	857	844	844
query45	178	170	169	169
query46	882	997	640	640
query47	1771	1800	1729	1729
query48	375	410	314	314
query49	754	495	398	398
query50	640	680	382	382
query51	4100	4187	4029	4029
query52	111	115	101	101
query53	235	263	196	196
query54	579	615	526	526
query55	89	83	87	83
query56	320	308	299	299
query57	1180	1208	1103	1103
query58	275	267	267	267
query59	2648	2704	2651	2651
query60	348	356	326	326
query61	122	119	122	119
query62	795	758	649	649
query63	219	187	189	187
query64	4307	983	689	689
query65	4253	4200	4205	4200
query66	1062	415	383	383
query67	15478	15246	15084	15084
query68	7815	905	570	570
query69	477	316	288	288
query70	1184	1089	1159	1089
query71	421	312	300	300
query72	5650	4728	4815	4728
query73	671	613	350	350
query74	9182	9039	8825	8825
query75	3341	3055	2585	2585
query76	3336	1131	747	747
query77	566	390	322	322
query78	9503	9669	8850	8850
query79	1694	839	584	584
query80	612	540	475	475
query81	509	255	221	221
query82	188	137	102	102
query83	255	250	229	229
query84	252	106	84	84
query85	845	362	332	332
query86	378	311	307	307
query87	4297	4315	4161	4161
query88	2787	2196	2188	2188
query89	391	309	285	285
query90	1878	220	214	214
query91	136	145	188	145
query92	78	67	64	64
query93	1220	979	637	637
query94	644	398	306	306
query95	396	328	303	303
query96	481	586	273	273
query97	2582	2693	2529	2529
query98	231	217	210	210
query99	1316	1404	1259	1259
Total cold run time: 270900 ms
Total hot run time: 184152 ms

doris-robot · 2025-08-20T07:36:36Z

ClickBench: Total hot run time: 32.46 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f3596bb5b46e0ce94dc0b0ef120b525dabfe13a9, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.43	0.42	0.42
query6	1.20	0.63	0.66
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.61	0.53	0.53
query10	0.57	0.57	0.57
query11	0.16	0.10	0.10
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	0.80	0.83	0.83
query15	0.86	0.87	0.84
query16	0.38	0.39	0.39
query17	1.04	1.03	1.06
query18	0.21	0.20	0.20
query19	1.91	1.84	1.92
query20	0.01	0.01	0.01
query21	15.41	0.92	0.58
query22	0.78	1.27	0.92
query23	14.70	1.39	0.64
query24	6.39	1.53	0.65
query25	0.51	0.25	0.11
query26	0.69	0.16	0.13
query27	0.05	0.05	0.06
query28	9.65	0.93	0.43
query29	12.57	3.96	3.25
query30	3.04	3.00	2.91
query31	2.82	0.59	0.37
query32	3.24	0.55	0.48
query33	3.08	3.12	3.04
query34	15.99	5.41	4.80
query35	4.96	4.88	4.91
query36	0.69	0.50	0.50
query37	0.10	0.07	0.07
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.18	0.15	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.06 s
Total hot run time: 32.46 s

doris-robot · 2025-08-20T07:50:07Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.58% (16780/28165)
Line Coverage	48.51% (152635/314638)
Region Coverage	37.49% (116094/309638)
Branch Coverage	40.40% (51244/126852)

hello-stephen · 2025-08-20T08:56:16Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.97% (22620/27597)
Line Coverage	74.63% (234686/314475)
Region Coverage	61.87% (194944/315106)
Branch Coverage	66.03% (84391/127815)

dataroaring

LGTM

github-actions · 2025-08-20T13:44:41Z

PR approved by at least one committer and no changes requested.

…erty (#54937) If user would like to load data `"aaa"` to Doris and want to trim "\"" to be `aaa`, need config two properties `enclose = "\"" `and `trim_double_quotes = true`. This pr aim to trim enclose do not require `trim_double_quotes` property, if user config enclose, Doris would trim enclose automatically.

…_quotes property #54937 (#55090) Cherry-picked from #54937 Co-authored-by: hui lai <laihui@selectdb.com>

sollhui force-pushed the opt_csv_reader_behavior branch from c61fc7d to c5f9de4Compare August 18, 2025 08:24

dataroaring added dev/3.0.x dev/3.1.x p0_easy labels Aug 18, 2025

dataroaring previously approved these changes Aug 18, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2025

github-actionsBot added the reviewed label Aug 18, 2025

sollhui dismissed dataroaring’s stale review via 861da96August 18, 2025 13:15

sollhui force-pushed the opt_csv_reader_behavior branch from c5f9de4 to 861da96Compare August 18, 2025 13:15

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 18, 2025

sollhui force-pushed the opt_csv_reader_behavior branch from 861da96 to c1445bbCompare August 18, 2025 15:33

liaoxin01 previously approved these changes Aug 19, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 19, 2025

trim enclose do not require trim_double_quotes property
f3596bb

sollhui dismissed liaoxin01’s stale review via f3596bbAugust 20, 2025 06:42

sollhui force-pushed the opt_csv_reader_behavior branch from 0c349af to f3596bbCompare August 20, 2025 06:42

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 20, 2025

dataroaring approved these changes Aug 20, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 20, 2025

dataroaring added kind/behavior-changed and removed dev/3.0.x labels Aug 20, 2025

liaoxin01 approved these changes Aug 20, 2025
View reviewed changes

liaoxin01 merged commit 6d3ae36 into apache:masterAug 21, 2025
28 of 30 checks passed

github-actionsBot mentioned this pull request Aug 21, 2025
branch-3.1: [fix](csv reader) trim enclose do not require trim_double_quotes property #54937 #55090
Merged

sollhui deleted the opt_csv_reader_behavior branch August 21, 2025 02:42

morrySnow pushed a commit that referenced this pull request Aug 21, 2025
branch-3.1: [fix](csv reader) trim enclose do not require trim_double…
5272b06
…_quotes property #54937 (#55090) Cherry-picked from #54937 Co-authored-by: hui lai <laihui@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Aug 21, 2025

Uh oh!

Conversation

sollhui commented Aug 18, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Aug 18, 2025

Uh oh!

sollhui commented Aug 18, 2025

Uh oh!

sollhui commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 18, 2025

Uh oh!

github-actionsBot commented Aug 18, 2025

Uh oh!

sollhui commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

BE UT Coverage Report

Uh oh!

sollhui commented Aug 18, 2025

Uh oh!

hello-stephen commented Aug 18, 2025

BE Regression && UT Coverage Report

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

hello-stephen commented Aug 18, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 19, 2025

BE Regression && UT Coverage Report

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 19, 2025

Uh oh!

hello-stephen commented Aug 19, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 19, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 20, 2025

BE Regression && UT Coverage Report

Uh oh!

sollhui commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

BE UT Coverage Report

Uh oh!