Uh oh!
There was an error while loading. Please reload this page.
[refine](function) refine split_by_string function - #54938
Merged
zclllyybb merged 3 commits intoAug 21, 2025
Conversation
hello-stephen
commented
Aug 18, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Mryange
commented
Aug 18, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Aug 18, 2025
TPC-H: Total hot run time: 33952 ms |
doris-robot
commented
Aug 18, 2025
TPC-DS: Total hot run time: 184917 ms |
doris-robot
commented
Aug 18, 2025
ClickBench: Total hot run time: 32.56 s |
Mryange
commented
Aug 18, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Aug 18, 2025
TPC-H: Total hot run time: 34262 ms |
doris-robot
commented
Aug 18, 2025
TPC-DS: Total hot run time: 184608 ms |
doris-robot
commented
Aug 18, 2025
ClickBench: Total hot run time: 33.1 s |
hello-stephen
commented
Aug 18, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryangeforce-pushed
the
refine-split_by_string-dev-8.18
branch
from
August 18, 2025 11:48
3ca4549 to
4fae710CompareMryange
commented
Aug 18, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Aug 18, 2025
TPC-H: Total hot run time: 34037 ms |
doris-robot
commented
Aug 18, 2025
TPC-DS: Total hot run time: 185211 ms |
doris-robot
commented
Aug 18, 2025
ClickBench: Total hot run time: 32.52 s |
hello-stephen
commented
Aug 18, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 18, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For the split_by_string function:
Use StringSearch to optimize the search.
For const, use a unified function for handling.
Removed the handling of null maps (since the return values are all not null).
Previously, split_by_string had some behavioral inconformity, which was also fixed here.
before
now
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)