[fix](constant fold)Remove double boundary check. by Jibing-Li · Pull Request #54939 · apache/doris

Jibing-Li · 2025-08-18T08:40:06Z

What problem does this PR solve?

Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-08-18T08:40:11Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Jibing-Li · 2025-08-18T08:44:22Z

run buildall

doris-robot · 2025-08-18T09:10:31Z

TPC-H: Total hot run time: 33627 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e1a5256504dc4bfaa6c0a3ce18803f6900a8ef1, data reload: false
------ Round 1 ----------------------------------
q1	17628	5209	5047	5047
q2	1934	293	181	181
q3	10311	1289	741	741
q4	10206	1014	511	511
q5	7520	2348	2322	2322
q6	172	159	128	128
q7	921	737	584	584
q8	9297	1279	1104	1104
q9	6873	5117	5063	5063
q10	6938	2366	1949	1949
q11	487	284	269	269
q12	338	344	212	212
q13	17770	3701	3007	3007
q14	229	238	210	210
q15	563	473	480	473
q16	420	426	361	361
q17	593	853	349	349
q18	7325	7185	7020	7020
q19	1088	945	547	547
q20	348	328	219	219
q21	4071	2570	2364	2364
q22	1077	1002	966	966
Total cold run time: 106109 ms
Total hot run time: 33627 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5112	5478	5079	5079
q2	246	319	222	222
q3	2156	2635	2275	2275
q4	1377	1768	1342	1342
q5	4188	4338	4570	4338
q6	213	169	126	126
q7	2042	1959	1842	1842
q8	2609	2654	2582	2582
q9	7341	7278	7314	7278
q10	3073	3349	2863	2863
q11	585	505	508	505
q12	719	778	612	612
q13	3477	3968	3250	3250
q14	291	301	275	275
q15	546	465	492	465
q16	444	504	448	448
q17	1180	1592	1405	1405
q18	7912	7633	7437	7437
q19	808	761	858	761
q20	1886	1939	1834	1834
q21	4679	4330	4315	4315
q22	1076	1016	1000	1000
Total cold run time: 51960 ms
Total hot run time: 50254 ms

doris-robot · 2025-08-18T09:22:03Z

TPC-DS: Total hot run time: 184109 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e1a5256504dc4bfaa6c0a3ce18803f6900a8ef1, data reload: false
query1	974	395	420	395
query2	6530	1741	1732	1732
query3	6756	215	213	213
query4	26566	23204	23480	23204
query5	4367	609	471	471
query6	318	206	207	206
query7	4620	508	288	288
query8	291	250	226	226
query9	8579	2846	2837	2837
query10	502	318	273	273
query11	15789	14952	14714	14714
query12	166	112	114	112
query13	1684	559	434	434
query14	9117	5674	5879	5674
query15	202	187	167	167
query16	7350	654	477	477
query17	1211	731	599	599
query18	1995	420	318	318
query19	191	188	162	162
query20	125	118	121	118
query21	215	125	108	108
query22	4093	4151	4015	4015
query23	34235	33163	33427	33163
query24	8153	2341	2330	2330
query25	546	483	385	385
query26	1232	267	160	160
query27	2777	494	342	342
query28	4326	2208	2188	2188
query29	756	571	460	460
query30	287	218	190	190
query31	884	803	706	706
query32	79	68	82	68
query33	568	379	344	344
query34	772	839	514	514
query35	788	841	728	728
query36	953	1002	904	904
query37	116	104	87	87
query38	4120	4025	3950	3950
query39	1463	1473	1409	1409
query40	221	119	110	110
query41	73	66	56	56
query42	122	105	110	105
query43	481	491	461	461
query44	1306	831	837	831
query45	173	171	162	162
query46	843	994	633	633
query47	1823	1811	1728	1728
query48	380	419	316	316
query49	721	486	371	371
query50	637	681	398	398
query51	4117	4089	4072	4072
query52	122	113	109	109
query53	235	255	187	187
query54	583	576	521	521
query55	87	85	87	85
query56	313	292	284	284
query57	1196	1181	1155	1155
query58	271	267	257	257
query59	2640	2659	2610	2610
query60	340	331	317	317
query61	123	119	122	119
query62	814	713	658	658
query63	227	184	184	184
query64	4367	999	675	675
query65	4274	4231	4218	4218
query66	1153	406	318	318
query67	15901	15519	14985	14985
query68	8125	908	570	570
query69	471	336	281	281
query70	1246	1143	1108	1108
query71	463	320	302	302
query72	5689	4782	4894	4782
query73	762	663	455	455
query74	9290	8793	8601	8601
query75	3814	3057	2610	2610
query76	3664	1125	732	732
query77	869	400	314	314
query78	9608	9819	8830	8830
query79	2514	793	590	590
query80	636	546	467	467
query81	470	263	226	226
query82	428	135	106	106
query83	287	258	232	232
query84	290	106	83	83
query85	790	358	329	329
query86	350	311	297	297
query87	4323	4222	4133	4133
query88	3091	2199	2185	2185
query89	399	312	292	292
query90	1928	231	223	223
query91	138	138	109	109
query92	87	72	66	66
query93	1218	982	650	650
query94	669	416	290	290
query95	403	314	306	306
query96	482	584	276	276
query97	2667	2704	2593	2593
query98	245	222	210	210
query99	1421	1412	1265	1265
Total cold run time: 274076 ms
Total hot run time: 184109 ms

doris-robot · 2025-08-18T09:27:32Z

ClickBench: Total hot run time: 32.86 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e1a5256504dc4bfaa6c0a3ce18803f6900a8ef1, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.25	0.07	0.07
query4	1.63	0.11	0.11
query5	0.42	0.43	0.39
query6	1.17	0.64	0.64
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.59	0.52	0.51
query10	0.58	0.57	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.61	0.61
query14	0.78	0.84	0.83
query15	0.88	0.85	0.86
query16	0.38	0.39	0.37
query17	1.04	1.03	1.07
query18	0.22	0.19	0.20
query19	1.94	1.79	1.81
query20	0.01	0.01	0.02
query21	15.41	0.95	0.58
query22	0.75	1.18	0.77
query23	14.85	1.31	0.62
query24	6.62	1.16	1.38
query25	0.52	0.18	0.17
query26	0.51	0.18	0.12
query27	0.07	0.06	0.05
query28	10.42	0.94	0.43
query29	12.59	3.93	3.24
query30	3.10	3.04	2.92
query31	2.83	0.57	0.39
query32	3.23	0.54	0.46
query33	3.03	3.12	2.97
query34	16.11	5.47	4.91
query35	4.88	4.92	4.92
query36	0.67	0.53	0.49
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.16	0.14
query41	0.07	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.09 s
Total hot run time: 32.86 s

hello-stephen · 2025-08-18T09:39:53Z

FE UT Coverage Report

Increment line coverage 13.16% (5/38) 🎉
Increment coverage report
Complete coverage report

Jibing-Li · 2025-08-18T13:35:08Z

run buildall

doris-robot · 2025-08-18T13:51:57Z

TPC-H: Total hot run time: 33746 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fdf3a57b68c1c776d1d01ea57676006d389fe343, data reload: false
------ Round 1 ----------------------------------
q1	17587	5267	5106	5106
q2	1933	280	173	173
q3	10318	1253	695	695
q4	10213	1009	510	510
q5	7518	2427	2322	2322
q6	189	158	129	129
q7	899	741	623	623
q8	9312	1289	1087	1087
q9	6954	5043	5019	5019
q10	6886	2367	1926	1926
q11	471	293	263	263
q12	342	353	222	222
q13	17752	3720	3043	3043
q14	226	234	212	212
q15	539	476	488	476
q16	430	415	374	374
q17	582	843	366	366
q18	7240	7154	7080	7080
q19	1082	927	568	568
q20	351	347	222	222
q21	3879	2551	2349	2349
q22	1072	1016	981	981
Total cold run time: 105775 ms
Total hot run time: 33746 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5176	5154	5158	5154
q2	243	319	216	216
q3	2149	2625	2319	2319
q4	1386	1782	1333	1333
q5	4232	4350	4586	4350
q6	230	172	132	132
q7	2059	1934	1816	1816
q8	2587	2646	2640	2640
q9	7417	7247	7146	7146
q10	3092	3259	2815	2815
q11	577	513	489	489
q12	696	800	640	640
q13	3512	3969	3401	3401
q14	312	311	276	276
q15	524	501	475	475
q16	454	496	472	472
q17	1181	1574	1372	1372
q18	7934	7624	7662	7624
q19	807	815	993	815
q20	1990	2117	2010	2010
q21	4898	4286	4362	4286
q22	1086	1023	1002	1002
Total cold run time: 52542 ms
Total hot run time: 50783 ms

doris-robot · 2025-08-18T14:03:26Z

TPC-DS: Total hot run time: 183785 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fdf3a57b68c1c776d1d01ea57676006d389fe343, data reload: false
query1	975	383	417	383
query2	6541	1702	1726	1702
query3	6739	218	218	218
query4	26033	23477	22857	22857
query5	4377	608	484	484
query6	321	222	229	222
query7	4632	494	287	287
query8	280	240	228	228
query9	8650	2862	2810	2810
query10	459	335	269	269
query11	15411	14877	14610	14610
query12	165	114	110	110
query13	1657	555	421	421
query14	8547	5711	5727	5711
query15	218	196	163	163
query16	7504	676	479	479
query17	1209	717	610	610
query18	1994	424	317	317
query19	194	185	164	164
query20	127	120	114	114
query21	213	123	109	109
query22	4184	4336	4056	4056
query23	34227	33223	33281	33223
query24	8126	2350	2320	2320
query25	546	470	421	421
query26	1230	265	153	153
query27	2752	496	336	336
query28	4351	2238	2213	2213
query29	782	566	436	436
query30	284	219	195	195
query31	895	755	708	708
query32	80	75	71	71
query33	533	377	340	340
query34	778	826	509	509
query35	784	839	722	722
query36	988	1006	915	915
query37	116	109	87	87
query38	4038	4035	4043	4035
query39	1500	1411	1385	1385
query40	215	122	121	121
query41	84	54	55	54
query42	114	109	117	109
query43	501	479	462	462
query44	1313	844	837	837
query45	171	167	162	162
query46	838	998	635	635
query47	1793	1812	1754	1754
query48	397	426	306	306
query49	717	488	379	379
query50	633	662	399	399
query51	4103	4067	4020	4020
query52	132	106	105	105
query53	227	257	194	194
query54	596	581	536	536
query55	84	87	86	86
query56	310	308	315	308
query57	1190	1206	1111	1111
query58	277	262	274	262
query59	2658	2735	2545	2545
query60	338	329	321	321
query61	127	123	123	123
query62	805	737	662	662
query63	227	189	189	189
query64	4334	1044	695	695
query65	4334	4196	4170	4170
query66	1194	413	319	319
query67	15503	15380	15055	15055
query68	8284	907	565	565
query69	482	321	288	288
query70	1272	1140	1090	1090
query71	510	338	300	300
query72	5567	4787	4693	4693
query73	719	592	348	348
query74	8867	8984	8837	8837
query75	3818	3073	2637	2637
query76	3699	1137	732	732
query77	781	392	317	317
query78	9494	9602	8801	8801
query79	2526	835	594	594
query80	614	530	458	458
query81	474	254	219	219
query82	425	137	103	103
query83	281	264	239	239
query84	290	96	85	85
query85	785	367	381	367
query86	340	321	289	289
query87	4305	4293	4111	4111
query88	3005	2165	2171	2165
query89	384	310	280	280
query90	1923	221	209	209
query91	139	137	115	115
query92	88	73	67	67
query93	1226	997	652	652
query94	684	388	314	314
query95	401	309	304	304
query96	482	575	276	276
query97	2649	2684	2545	2545
query98	238	221	215	215
query99	1434	1379	1258	1258
Total cold run time: 271841 ms
Total hot run time: 183785 ms

doris-robot · 2025-08-18T14:08:54Z

ClickBench: Total hot run time: 33.1 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fdf3a57b68c1c776d1d01ea57676006d389fe343, data reload: false
query1	0.04	0.04	0.03
query2	0.09	0.05	0.04
query3	0.24	0.07	0.07
query4	1.60	0.10	0.10
query5	0.40	0.40	0.39
query6	1.16	0.64	0.64
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.61	0.52	0.51
query10	0.58	0.57	0.58
query11	0.17	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.61
query14	0.82	0.81	0.85
query15	0.88	0.86	0.86
query16	0.41	0.40	0.40
query17	1.07	1.05	1.06
query18	0.21	0.20	0.20
query19	1.93	1.79	1.87
query20	0.01	0.02	0.01
query21	15.38	0.93	0.60
query22	0.76	1.27	0.84
query23	14.78	1.40	0.64
query24	6.94	1.20	1.32
query25	0.47	0.39	0.09
query26	0.49	0.15	0.13
query27	0.07	0.06	0.05
query28	9.51	0.94	0.43
query29	12.51	3.92	3.26
query30	3.02	2.98	3.00
query31	2.81	0.60	0.38
query32	3.23	0.54	0.48
query33	3.05	3.04	3.11
query34	15.86	5.46	4.90
query35	4.90	4.90	5.01
query36	0.70	0.50	0.49
query37	0.09	0.07	0.08
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.02	0.02
Total cold run time: 106.02 s
Total hot run time: 33.1 s

hello-stephen · 2025-08-18T14:36:26Z

FE UT Coverage Report

Increment line coverage 41.30% (19/46) 🎉
Increment coverage report
Complete coverage report

Jibing-Li · 2025-08-19T07:09:04Z

run buildall

doris-robot · 2025-08-19T08:18:52Z

TPC-H: Total hot run time: 34011 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e095820f22a1c5ff8900a92cc64fc9cb64ec3a6d, data reload: false
------ Round 1 ----------------------------------
q1	17602	5255	5145	5145
q2	1967	288	193	193
q3	10238	1271	722	722
q4	10233	1012	544	544
q5	7481	2382	2372	2372
q6	182	160	126	126
q7	898	768	597	597
q8	9309	1286	1082	1082
q9	7036	5180	5102	5102
q10	6931	2374	1971	1971
q11	486	286	266	266
q12	344	352	228	228
q13	17774	3650	3025	3025
q14	223	248	217	217
q15	567	481	485	481
q16	417	427	377	377
q17	610	861	354	354
q18	7735	7121	7239	7121
q19	1110	980	567	567
q20	347	344	220	220
q21	3863	3257	2349	2349
q22	1086	1030	952	952
Total cold run time: 106439 ms
Total hot run time: 34011 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5227	5188	5145	5145
q2	240	324	218	218
q3	2140	2689	2345	2345
q4	1351	1753	1363	1363
q5	4197	4540	4515	4515
q6	222	180	130	130
q7	2090	1977	1831	1831
q8	2637	2574	2663	2574
q9	7443	7294	7250	7250
q10	3118	3298	3201	3201
q11	579	516	503	503
q12	705	785	649	649
q13	3529	4005	3306	3306
q14	301	296	277	277
q15	537	511	489	489
q16	475	656	452	452
q17	1193	1608	1358	1358
q18	7781	7717	7584	7584
q19	845	860	919	860
q20	1957	1964	1815	1815
q21	4755	4364	4380	4364
q22	1075	1038	1004	1004
Total cold run time: 52397 ms
Total hot run time: 51233 ms

hello-stephen · 2025-08-19T08:27:54Z

FE UT Coverage Report

Increment line coverage 41.30% (19/46) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2025-08-19T08:30:22Z

TPC-DS: Total hot run time: 184143 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e095820f22a1c5ff8900a92cc64fc9cb64ec3a6d, data reload: false
query1	1021	417	409	409
query2	6529	1689	1689	1689
query3	6747	222	218	218
query4	26380	23188	22868	22868
query5	4378	596	474	474
query6	310	217	217	217
query7	4631	502	279	279
query8	283	227	222	222
query9	8539	2822	2822	2822
query10	481	341	280	280
query11	15979	15103	14729	14729
query12	161	115	115	115
query13	1660	539	434	434
query14	9023	5710	5716	5710
query15	214	184	175	175
query16	7355	645	478	478
query17	1203	737	587	587
query18	1992	422	336	336
query19	212	188	168	168
query20	128	123	116	116
query21	215	125	116	116
query22	3979	4121	4073	4073
query23	34123	33133	33290	33133
query24	8160	2323	2332	2323
query25	523	458	404	404
query26	1219	268	155	155
query27	2766	516	340	340
query28	4338	2217	2212	2212
query29	770	559	454	454
query30	291	221	187	187
query31	895	793	718	718
query32	83	73	73	73
query33	549	369	354	354
query34	784	858	508	508
query35	799	823	772	772
query36	962	1017	938	938
query37	124	105	86	86
query38	4033	4041	4005	4005
query39	1489	1435	1389	1389
query40	220	126	113	113
query41	58	56	52	52
query42	125	110	109	109
query43	496	500	473	473
query44	1302	834	838	834
query45	171	174	163	163
query46	832	1007	646	646
query47	1774	1832	1689	1689
query48	381	414	316	316
query49	724	484	402	402
query50	631	691	388	388
query51	4100	4096	4132	4096
query52	121	113	101	101
query53	228	258	196	196
query54	597	585	521	521
query55	86	85	80	80
query56	309	304	302	302
query57	1163	1199	1113	1113
query58	270	280	263	263
query59	2616	2720	2711	2711
query60	341	337	320	320
query61	161	126	139	126
query62	797	700	659	659
query63	229	187	190	187
query64	4337	985	744	744
query65	4290	4211	4207	4207
query66	1180	415	319	319
query67	15314	15227	14914	14914
query68	8079	906	571	571
query69	480	320	280	280
query70	1259	1181	1107	1107
query71	466	341	309	309
query72	5628	4684	4685	4684
query73	704	580	352	352
query74	8853	8768	8636	8636
query75	3753	3051	2619	2619
query76	3655	1128	716	716
query77	795	400	339	339
query78	9604	9666	8791	8791
query79	2620	825	595	595
query80	611	536	463	463
query81	487	251	223	223
query82	484	135	111	111
query83	253	247	236	236
query84	250	100	86	86
query85	893	361	334	334
query86	393	307	308	307
query87	4267	4312	4208	4208
query88	3492	2206	2213	2206
query89	383	316	286	286
query90	1859	218	218	218
query91	138	137	110	110
query92	87	77	69	69
query93	1751	966	637	637
query94	691	417	376	376
query95	401	313	309	309
query96	486	581	284	284
query97	2656	2677	2584	2584
query98	251	222	214	214
query99	1456	1386	1273	1273
Total cold run time: 273366 ms
Total hot run time: 184143 ms

doris-robot · 2025-08-19T08:36:01Z

ClickBench: Total hot run time: 32.69 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e095820f22a1c5ff8900a92cc64fc9cb64ec3a6d, data reload: false
query1	0.04	0.04	0.04
query2	0.09	0.04	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.10
query5	0.42	0.41	0.40
query6	1.16	0.64	0.66
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.60	0.52	0.51
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.62
query14	0.79	0.89	0.85
query15	0.88	0.84	0.86
query16	0.38	0.42	0.41
query17	1.02	1.07	1.04
query18	0.21	0.20	0.19
query19	2.02	1.85	1.78
query20	0.01	0.01	0.02
query21	15.36	0.96	0.60
query22	0.75	1.09	0.69
query23	15.00	1.39	0.64
query24	6.86	1.18	0.92
query25	0.47	0.16	0.12
query26	0.62	0.19	0.12
query27	0.06	0.06	0.06
query28	9.61	0.94	0.43
query29	12.53	3.92	3.22
query30	3.10	3.06	3.04
query31	2.82	0.58	0.37
query32	3.22	0.55	0.48
query33	3.04	3.06	3.06
query34	16.07	5.49	4.84
query35	4.96	4.91	4.96
query36	0.69	0.52	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.71 s
Total hot run time: 32.69 s

Jibing-Li · 2025-08-19T11:30:53Z

run buildall

Jibing-Li · 2025-08-19T11:35:39Z

run performance

doris-robot · 2025-08-19T12:58:50Z

TPC-H: Total hot run time: 33793 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9b89c194a057bd571a1c170a8380ab49e040ad15, data reload: false
------ Round 1 ----------------------------------
q1	17617	5196	5052	5052
q2	1906	286	189	189
q3	10312	1260	707	707
q4	10216	1019	516	516
q5	7504	2389	2283	2283
q6	172	155	128	128
q7	909	712	589	589
q8	9293	1270	1030	1030
q9	6848	5106	5120	5106
q10	6963	2381	1960	1960
q11	479	273	273	273
q12	349	343	216	216
q13	17787	3645	3003	3003
q14	227	227	221	221
q15	558	473	470	470
q16	430	429	375	375
q17	592	851	359	359
q18	7395	7193	7149	7149
q19	1089	941	578	578
q20	338	319	222	222
q21	3838	3247	2374	2374
q22	1096	1018	993	993
Total cold run time: 105918 ms
Total hot run time: 33793 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5116	5144	5087	5087
q2	239	314	221	221
q3	2137	2681	2285	2285
q4	1370	1795	1373	1373
q5	4204	4389	4506	4389
q6	210	170	132	132
q7	2056	1894	1852	1852
q8	2633	2588	2553	2553
q9	7308	7350	7299	7299
q10	3081	3298	2917	2917
q11	583	523	488	488
q12	683	761	845	761
q13	3388	3793	3309	3309
q14	327	319	294	294
q15	535	466	520	466
q16	459	493	451	451
q17	1166	1534	1481	1481
q18	7958	7678	7603	7603
q19	798	852	1069	852
q20	1950	2030	1903	1903
q21	4864	4335	4319	4319
q22	1053	1043	1003	1003
Total cold run time: 52118 ms
Total hot run time: 51038 ms

doris-robot · 2025-08-19T13:10:17Z

TPC-DS: Total hot run time: 181614 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9b89c194a057bd571a1c170a8380ab49e040ad15, data reload: false
query1	994	385	422	385
query2	6532	1751	1712	1712
query3	6742	223	234	223
query4	26293	23164	22827	22827
query5	4333	590	491	491
query6	296	207	199	199
query7	4636	492	283	283
query8	269	220	222	220
query9	8580	2812	2845	2812
query10	461	330	283	283
query11	15554	14948	14746	14746
query12	165	111	114	111
query13	1660	542	418	418
query14	8512	5724	5705	5705
query15	198	189	169	169
query16	7328	677	470	470
query17	1209	713	597	597
query18	1995	429	323	323
query19	187	184	217	184
query20	124	118	111	111
query21	219	119	104	104
query22	4058	4137	4000	4000
query23	34215	33288	33435	33288
query24	8101	2320	2330	2320
query25	516	459	403	403
query26	1231	269	159	159
query27	2769	486	340	340
query28	4347	2202	2173	2173
query29	789	553	468	468
query30	285	220	193	193
query31	858	780	703	703
query32	83	81	77	77
query33	545	368	324	324
query34	789	837	511	511
query35	785	819	750	750
query36	982	996	925	925
query37	120	105	86	86
query38	4025	4010	4002	4002
query39	1468	1439	1398	1398
query40	222	123	115	115
query41	60	59	55	55
query42	117	105	110	105
query43	496	492	464	464
query44	1324	849	856	849
query45	169	172	172	172
query46	838	988	634	634
query47	1773	1814	1767	1767
query48	385	406	316	316
query49	737	481	383	383
query50	649	683	404	404
query51	4070	4124	4044	4044
query52	113	113	107	107
query53	230	274	191	191
query54	584	582	518	518
query55	88	87	91	87
query56	323	295	297	295
query57	1182	1200	1125	1125
query58	274	272	263	263
query59	2569	2629	2561	2561
query60	342	332	331	331
query61	128	121	121	121
query62	812	734	651	651
query63	228	195	212	195
query64	4351	1002	689	689
query65	4281	4211	4231	4211
query66	1148	398	322	322
query67	15563	15254	14995	14995
query68	7881	905	568	568
query69	483	315	300	300
query70	1182	1057	1093	1057
query71	402	322	314	314
query72	5782	2369	5121	2369
query73	755	744	356	356
query74	9073	9114	8597	8597
query75	3321	3071	2601	2601
query76	3303	1141	722	722
query77	788	404	317	317
query78	9570	9669	8845	8845
query79	2435	837	617	617
query80	589	533	482	482
query81	540	254	225	225
query82	338	141	114	114
query83	245	244	239	239
query84	245	103	82	82
query85	839	364	339	339
query86	378	313	326	313
query87	4237	4250	4196	4196
query88	3714	2220	2191	2191
query89	382	318	287	287
query90	1866	216	218	216
query91	143	146	107	107
query92	87	68	70	68
query93	1886	1015	643	643
query94	668	387	320	320
query95	392	313	355	313
query96	494	571	275	275
query97	2582	2702	2597	2597
query98	243	212	210	210
query99	1355	1380	1271	1271
Total cold run time: 271507 ms
Total hot run time: 181614 ms

github-actions · 2025-08-20T03:22:11Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-20T03:22:13Z

PR approved by anyone and no changes requested.

Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

…55076) backport: #54939

#55077) backport: #54939

Jibing-Li force-pushed the inf branch from a41831c to 1e1a525Compare August 18, 2025 08:42

Jibing-Li marked this pull request as ready for review August 18, 2025 08:43

Jibing-Li force-pushed the inf branch from 1e1a525 to fdf3a57Compare August 18, 2025 11:59

Jibing-Li force-pushed the inf branch from fdf3a57 to e095820Compare August 19, 2025 07:08

morrySnow reviewed Aug 19, 2025
View reviewed changes

Comment thread.../java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java

Jibing-Li force-pushed the inf branch from e095820 to c85c19fCompare August 19, 2025 07:21

morrySnow added dev/3.0.x dev/3.1.x labels Aug 19, 2025

Remove double boundary check.
9b89c19

Jibing-Li force-pushed the inf branch from c85c19f to 9b89c19Compare August 19, 2025 11:24

morrySnow approved these changes Aug 20, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 20, 2025

github-actionsBot added the reviewed label Aug 20, 2025

starocean999 approved these changes Aug 20, 2025
View reviewed changes

Jibing-Li merged commit c43b07a into apache:masterAug 20, 2025
26 of 28 checks passed

github-actionsBot added dev/3.0.x-conflict dev/3.1.x-conflict labels Aug 20, 2025

morrySnow deleted the inf branch August 20, 2025 09:40

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
d49552f
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li mentioned this pull request Aug 20, 2025
branch-3.1: [fix](constant fold)Remove double boundary check. (#54939) #55076
Merged

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
dfe3191
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
b92b1ba
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li mentioned this pull request Aug 20, 2025
branch-3.0: [fix](constant fold)Remove double boundary check. (#54939) #55077
Merged

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
388e35d
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
6631c6f
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
e44a125
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
47d1839
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 20, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
4868f86
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 21, 2025
[fix](constant fold)Remove double boundary check. (apache#54939)
7d863ba
Remove double boundary check. FE result of constant fold with double overflow should be identical with BE result.

morrySnow pushed a commit that referenced this pull request Aug 25, 2025
branch-3.1: [fix](constant fold)Remove double boundary check.#54939(#…
0fde2bb
…55076) backport: #54939

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Aug 25, 2025

dataroaring pushed a commit that referenced this pull request Aug 25, 2025
branch-3.0: [fix](constant fold)Remove double boundary check. (#54939) (
826a6e4
#55077) backport: #54939

dataroaring added dev/3.0.8-merged and removed dev/3.0.x labels Aug 25, 2025

Jibing-Li removed the dev/3.0.x-conflict label Aug 25, 2025

gavinchou mentioned this pull request Sep 1, 2025
Release Note 3.0.8 #55553
Closed

Uh oh!

Conversation

Jibing-Li commented Aug 18, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Aug 18, 2025

Uh oh!

Jibing-Li commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

hello-stephen commented Aug 18, 2025

FE UT Coverage Report

Uh oh!

Jibing-Li commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

doris-robot commented Aug 18, 2025

Uh oh!

hello-stephen commented Aug 18, 2025

FE UT Coverage Report

Uh oh!

Jibing-Li commented Aug 19, 2025

Uh oh!

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

hello-stephen commented Aug 19, 2025

FE UT Coverage Report

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

Jibing-Li commented Aug 19, 2025

Uh oh!

Jibing-Li commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

doris-robot commented Aug 19, 2025

Uh oh!

github-actionsBot commented Aug 20, 2025

Uh oh!

github-actionsBot commented Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants