branch-3.1: [fix](config) fix admin set all frontends config #55016 by cambyzju · Pull Request #55072 · apache/doris

cambyzju · 2025-08-20T10:49:26Z

pick #55016

Thearas · 2025-08-20T10:49:31Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

cambyzju · 2025-08-20T10:49:53Z

run buildall

doris-robot · 2025-08-20T11:27:50Z

TPC-H: Total hot run time: 32610 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 897186c01811aabd5a77609763b33b71775c35f6, data reload: false
------ Round 1 ----------------------------------
q1	17573	5459	5464	5459
q2	2005	411	279	279
q3	11958	1221	737	737
q4	10241	874	456	456
q5	8524	2406	2091	2091
q6	186	166	130	130
q7	895	760	619	619
q8	9324	1455	1129	1129
q9	5326	5015	4905	4905
q10	6778	2278	1828	1828
q11	477	292	260	260
q12	335	360	222	222
q13	17795	3625	3000	3000
q14	230	239	226	226
q15	524	472	453	453
q16	427	432	379	379
q17	603	874	374	374
q18	6796	6270	6396	6270
q19	1208	965	546	546
q20	328	348	204	204
q21	3026	2190	2052	2052
q22	1038	1026	991	991
Total cold run time: 105597 ms
Total hot run time: 32610 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5618	5708	5512	5512
q2	236	324	237	237
q3	2255	2631	2317	2317
q4	1371	1803	1319	1319
q5	4426	5040	4973	4973
q6	170	164	127	127
q7	2123	1980	1850	1850
q8	2623	2857	2709	2709
q9	7268	7293	7246	7246
q10	3060	3268	2756	2756
q11	571	519	500	500
q12	685	772	603	603
q13	3401	3790	3186	3186
q14	281	303	262	262
q15	537	475	465	465
q16	433	483	431	431
q17	1210	1751	1272	1272
q18	7631	7421	7364	7364
q19	803	1006	1134	1006
q20	2027	2060	1885	1885
q21	5444	5003	4509	4509
q22	1076	1072	1007	1007
Total cold run time: 53249 ms
Total hot run time: 51536 ms

doris-robot · 2025-08-20T11:40:02Z

TPC-DS: Total hot run time: 192562 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 897186c01811aabd5a77609763b33b71775c35f6, data reload: false
query1	957	415	402	402
query2	6136	1977	1879	1879
query3	8686	198	198	198
query4	33454	24155	23471	23471
query5	3709	580	454	454
query6	293	192	170	170
query7	4202	496	320	320
query8	296	234	235	234
query9	9362	2620	2623	2620
query10	458	320	266	266
query11	18105	15605	15312	15312
query12	158	107	109	107
query13	1568	536	410	410
query14	9899	6746	6785	6746
query15	236	190	181	181
query16	8129	663	498	498
query17	1526	732	558	558
query18	2139	401	317	317
query19	198	193	163	163
query20	126	116	119	116
query21	204	129	108	108
query22	4735	4645	4589	4589
query23	34967	34102	34155	34102
query24	7292	2675	2682	2675
query25	521	465	416	416
query26	796	283	169	169
query27	2102	487	372	372
query28	5680	2230	2193	2193
query29	711	560	433	433
query30	232	194	161	161
query31	1034	915	845	845
query32	98	57	65	57
query33	507	380	337	337
query34	753	861	529	529
query35	783	828	731	731
query36	1033	1069	942	942
query37	105	95	72	72
query38	4071	4039	4002	4002
query39	1537	1560	1464	1464
query40	221	125	114	114
query41	55	55	55	55
query42	132	109	113	109
query43	492	497	492	492
query44	1287	830	822	822
query45	193	188	177	177
query46	873	1072	698	698
query47	2029	2007	1936	1936
query48	412	431	359	359
query49	759	523	423	423
query50	677	694	440	440
query51	7278	7362	7270	7270
query52	109	103	93	93
query53	235	259	190	190
query54	557	548	478	478
query55	83	90	85	85
query56	295	294	268	268
query57	1284	1265	1225	1225
query58	254	231	230	230
query59	3082	3265	3096	3096
query60	312	298	281	281
query61	155	115	117	115
query62	797	746	691	691
query63	229	196	197	196
query64	3814	1017	656	656
query65	3411	3325	3327	3325
query66	819	431	325	325
query67	16239	16039	15635	15635
query68	7747	820	541	541
query69	502	305	272	272
query70	1185	1143	1152	1143
query71	386	298	264	264
query72	5782	3764	3837	3764
query73	629	749	352	352
query74	10592	9135	9300	9135
query75	3234	3124	2667	2667
query76	3150	1177	763	763
query77	499	371	279	279
query78	10287	10362	9540	9540
query79	5040	926	589	589
query80	771	522	423	423
query81	505	257	220	220
query82	612	114	89	89
query83	175	161	146	146
query84	290	102	80	80
query85	780	400	305	305
query86	400	318	301	301
query87	4343	4418	4228	4228
query88	5019	2417	2408	2408
query89	453	348	303	303
query90	1855	190	189	189
query91	148	133	110	110
query92	72	54	54	54
query93	3239	899	536	536
query94	701	411	267	267
query95	345	282	271	271
query96	489	606	282	282
query97	3270	3263	3154	3154
query98	239	216	195	195
query99	1569	1420	1289	1289
Total cold run time: 297189 ms
Total hot run time: 192562 ms

doris-robot · 2025-08-20T11:45:15Z

ClickBench: Total hot run time: 28.57 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 897186c01811aabd5a77609763b33b71775c35f6, data reload: false
query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.11	0.11
query5	0.53	0.51	0.52
query6	1.14	0.73	0.73
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.50	0.49
query10	0.55	0.55	0.55
query11	0.14	0.11	0.11
query12	0.13	0.11	0.11
query13	0.60	0.59	0.60
query14	0.77	0.79	0.82
query15	0.85	0.82	0.84
query16	0.38	0.38	0.41
query17	1.06	1.06	1.04
query18	0.25	0.24	0.25
query19	1.89	1.80	1.82
query20	0.02	0.00	0.01
query21	15.40	0.97	0.58
query22	0.74	0.79	0.56
query23	15.17	1.50	0.59
query24	3.00	0.71	0.97
query25	0.14	0.16	0.10
query26	0.37	0.15	0.13
query27	0.05	0.04	0.04
query28	12.69	1.04	0.44
query29	12.60	3.97	3.29
query30	0.25	0.10	0.06
query31	2.82	0.61	0.38
query32	3.22	0.54	0.46
query33	3.00	2.99	3.06
query34	16.72	5.15	4.48
query35	4.57	4.54	4.53
query36	0.65	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.81 s
Total hot run time: 28.57 s

related pr: apache#54409 **What's the problem:** 1. `ADMIN SET ALL FRONTENDS CONFIG` command will forward to other FEs use new commnad `ADMIN SET FRONTEND CONFIG` 2. Then other FE if found `MasterOnly` config, will forward to this request to MASTER again **How to fix:** 1. `SET ALL FRONTENDS` forward to other FEs, still use the same command: `SET ALL FRONTENDS`; 2. while Env.setConfig for `SET ALL FRONTENDS` , do not forward again while is proxy;

cambyzju · 2025-08-20T13:21:14Z

run buildall

doris-robot · 2025-08-20T13:46:09Z

TPC-H: Total hot run time: 33570 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9362af67aeeca0b72c9b4631c4287ef069f25952, data reload: false
------ Round 1 ----------------------------------
q1	17599	5835	5747	5747
q2	2034	433	284	284
q3	12408	1363	771	771
q4	10542	917	485	485
q5	9534	2505	2281	2281
q6	209	182	137	137
q7	964	778	612	612
q8	9330	1615	1291	1291
q9	5550	5183	5141	5141
q10	6845	2294	1822	1822
q11	503	291	280	280
q12	352	395	215	215
q13	17786	3729	3007	3007
q14	248	228	217	217
q15	551	477	474	474
q16	422	428	365	365
q17	638	908	376	376
q18	6890	6583	6314	6314
q19	1215	1088	585	585
q20	336	352	202	202
q21	3125	2305	1988	1988
q22	1099	1015	976	976
Total cold run time: 108180 ms
Total hot run time: 33570 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5921	5956	5933	5933
q2	242	338	237	237
q3	2279	2720	2317	2317
q4	1377	1881	1386	1386
q5	4686	5217	5169	5169
q6	191	174	129	129
q7	2161	1993	1812	1812
q8	2849	2993	2982	2982
q9	7404	7319	7261	7261
q10	3052	3344	2834	2834
q11	626	523	502	502
q12	699	814	597	597
q13	3449	3907	3219	3219
q14	302	295	267	267
q15	534	476	461	461
q16	441	507	441	441
q17	1333	1859	1314	1314
q18	7772	7506	7512	7506
q19	871	1209	1315	1209
q20	2085	2066	1887	1887
q21	5624	4875	4711	4711
q22	1129	1097	1052	1052
Total cold run time: 55027 ms
Total hot run time: 53226 ms

doris-robot · 2025-08-20T13:58:19Z

TPC-DS: Total hot run time: 191826 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9362af67aeeca0b72c9b4631c4287ef069f25952, data reload: false
query1	952	387	387	387
query2	6116	1894	1841	1841
query3	8694	208	199	199
query4	33418	23853	23383	23383
query5	3644	587	446	446
query6	293	189	173	173
query7	4204	488	325	325
query8	302	237	229	229
query9	9401	2630	2605	2605
query10	453	322	255	255
query11	18185	15506	15235	15235
query12	169	107	109	107
query13	1559	546	420	420
query14	9986	6619	7276	6619
query15	238	198	179	179
query16	8155	682	497	497
query17	1547	771	610	610
query18	2178	455	323	323
query19	213	204	175	175
query20	134	128	124	124
query21	210	142	108	108
query22	4645	4624	4403	4403
query23	35240	34272	34277	34272
query24	7381	2668	2684	2668
query25	555	524	451	451
query26	1146	299	177	177
query27	2265	480	349	349
query28	5010	2246	2212	2212
query29	796	627	467	467
query30	250	192	171	171
query31	1084	967	854	854
query32	100	65	60	60
query33	514	373	337	337
query34	767	855	531	531
query35	785	810	724	724
query36	1005	1058	969	969
query37	111	107	68	68
query38	4093	4001	4003	4001
query39	1566	1708	1480	1480
query40	210	125	117	117
query41	51	51	50	50
query42	116	104	106	104
query43	515	511	493	493
query44	1289	824	815	815
query45	187	178	179	178
query46	900	1073	682	682
query47	2011	1984	1898	1898
query48	415	437	353	353
query49	789	485	394	394
query50	679	688	428	428
query51	7429	7288	7173	7173
query52	103	102	92	92
query53	227	258	192	192
query54	540	544	471	471
query55	83	81	78	78
query56	263	264	275	264
query57	1299	1306	1205	1205
query58	255	224	222	222
query59	3086	3173	3104	3104
query60	296	294	277	277
query61	118	123	116	116
query62	790	772	698	698
query63	240	206	199	199
query64	4527	991	645	645
query65	3370	3324	3311	3311
query66	1014	411	312	312
query67	16109	15874	15627	15627
query68	7802	814	530	530
query69	486	300	266	266
query70	1146	1093	1067	1067
query71	378	297	261	261
query72	5794	3754	3843	3754
query73	629	741	343	343
query74	10173	9152	8949	8949
query75	3294	3159	2673	2673
query76	3158	1188	765	765
query77	681	360	272	272
query78	10369	10293	9497	9497
query79	3931	893	578	578
query80	721	520	450	450
query81	510	255	219	219
query82	589	123	88	88
query83	170	165	173	165
query84	286	99	80	80
query85	776	367	312	312
query86	343	321	301	301
query87	4338	4372	4188	4188
query88	4751	2412	2393	2393
query89	434	334	291	291
query90	1790	187	186	186
query91	134	141	109	109
query92	63	56	54	54
query93	2687	891	538	538
query94	678	402	323	323
query95	339	279	275	275
query96	495	609	283	283
query97	3202	3249	3193	3193
query98	226	204	206	204
query99	1551	1420	1287	1287
Total cold run time: 296199 ms
Total hot run time: 191826 ms

doris-robot · 2025-08-20T14:03:44Z

ClickBench: Total hot run time: 29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9362af67aeeca0b72c9b4631c4287ef069f25952, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.52	0.53	0.55
query6	1.12	0.72	0.74
query7	0.03	0.02	0.01
query8	0.05	0.03	0.04
query9	0.58	0.51	0.51
query10	0.55	0.56	0.59
query11	0.15	0.11	0.11
query12	0.14	0.10	0.12
query13	0.62	0.59	0.59
query14	0.78	0.79	0.78
query15	0.83	0.83	0.83
query16	0.39	0.39	0.41
query17	1.05	1.05	1.06
query18	0.25	0.24	0.23
query19	1.95	1.90	1.86
query20	0.02	0.01	0.01
query21	15.37	0.91	0.58
query22	0.74	0.93	0.72
query23	14.89	1.43	0.58
query24	3.57	0.79	1.36
query25	0.13	0.08	0.12
query26	0.38	0.15	0.14
query27	0.05	0.05	0.05
query28	13.30	1.03	0.42
query29	12.59	3.95	3.30
query30	0.25	0.10	0.06
query31	2.83	0.60	0.38
query32	3.22	0.53	0.46
query33	3.02	3.00	3.03
query34	16.57	5.18	4.55
query35	4.54	4.62	4.58
query36	0.65	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.58 s
Total hot run time: 29 s

hello-stephen · 2025-08-20T14:33:20Z

FE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉
Increment coverage report
Complete coverage report

…5016 (apache#55072) pick apache#55016

cambyzju requested a review from morrySnow as a code owner August 20, 2025 10:49

cambyzju force-pushed the fix-3.1-250820 branch from 897186c to 9362af6Compare August 20, 2025 13:20

morrySnow changed the title ~~[fix](config) fix admin set all frontends config (#55016)~~branch-3.1: [fix](config) fix admin set all frontends config #55016Aug 21, 2025

morrySnow approved these changes Aug 21, 2025
View reviewed changes

morrySnow merged commit 625f83f into apache:branch-3.1Aug 21, 2025
24 checks passed

cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Aug 21, 2025
branch-3.1: [fix](config) fix admin set all frontends configapache#5…
a63a742
…5016 (apache#55072) pick apache#55016

Navigation Menu

Uh oh!

branch-3.1: [fix](config) fix admin set all frontends config #55016 - #55072

branch-3.1: [fix](config) fix admin set all frontends config #55016#55072
morrySnow merged 1 commit into
apache:branch-3.1from
cambyzju:fix-3.1-250820

cambyzju commented Aug 20, 2025•
edited by morrySnow
Loading

Uh oh!

Thearas commented Aug 20, 2025

Uh oh!

cambyzju commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

cambyzju commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

hello-stephen commented Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

cambyzju commented Aug 20, 2025• edited by morrySnow Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Thearas commented Aug 20, 2025

Uh oh!

cambyzju commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

cambyzju commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

doris-robot commented Aug 20, 2025

Uh oh!

hello-stephen commented Aug 20, 2025

FE UT Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cambyzju commented Aug 20, 2025•
edited by morrySnow
Loading