Uh oh!
There was an error while loading. Please reload this page.
[Feature] add list partition support - #5529
Merged
Merged
Conversation
stdpain
reviewed
Mar 17, 2021
| uint32_t* dist_hashes) const { | ||
| auto it = _partitions_map->upper_bound(tuple); | ||
| const TOlapTablePartition& t_part = _t_param.partitions[0]; | ||
| decltype(_partitions_map->find(tuple)) it; |
Contributor
There was a problem hiding this comment.
we could use std::map<x,x>::iterator instead of this
| bool OlapTablePartitionParam::find_tablet(Tuple* tuple, const OlapTablePartition** partition, | ||
| uint32_t* dist_hashes) const { | ||
| auto it = _partitions_map->upper_bound(tuple); | ||
| const TOlapTablePartition& t_part = _t_param.partitions[0]; |
Contributor
There was a problem hiding this comment.
check _t_param.partitions.size() ?
ContributorAuthor
There was a problem hiding this comment.
Doris creates at least one partition (unpartitioned table) for the olap table, so here _t_param.partitions.size() is at least 1, no need to worry about.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
qidayeforce-pushed
the
branch_list_partition
branch
from
April 19, 2021 06:31
31c9172 to
449ae69CompareContributor
qidaye
commented
Apr 20, 2021
ContributorAuthor
Change-Id: Ie0b5c1b518bdd4f27e0eedc08dd71e8b1048e2ee
…conflict exception Change-Id: I42dc64541454b72389d1bc2d1f2fe455f918652e
Change-Id: Id2ef6d3aa895b4bb34e710f2e6ac99a3d74389a6
…st partition table. Change-Id: I9ff5fa4bc1bde35f4e10f3baecc14f1489eaa2f2
qidayeforce-pushed
the
branch_list_partition
branch
from
April 23, 2021 02:31
449ae69 to
eded97bCompareChange-Id: I35900b2e3ff4d7a78b5785751996e6563c919f9d
qidaye
commented
Apr 23, 2021
ContributorAuthor
10 tasks
EmmyMiao87 pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
[doris-1077] Add list partition support Change-Id: I08786b16d262638ad7192e0fd3fa6f2251ad6e65
Closed
Hastyshell pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
…e on CREATE/ALTER (apache#5529) pick apache#57671
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
add list partition support
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...