[fix](temp_table) alive session id set should be thread safe by morrySnow · Pull Request #55315 · apache/doris

morrySnow · 2025-08-26T10:08:36Z

What problem does this PR solve?

Related PR: ##40680

Problem Summary:

java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "str" is null
at org.apache.thrift.protocol.TBinaryProtocol.writeString(TBinaryProtocol.java:227) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:577) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:500) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult.write(TFrontendReportAliveSessionResult.java:429) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33897) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33859) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result.write(FrontendService.java:33810) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:58) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:250) ~[libthrift-0.16.0.jar:0.16.0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

morrySnow · 2025-08-26T10:08:44Z

run buildall

hello-stephen · 2025-08-26T10:09:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

doris-robot · 2025-08-26T10:40:33Z

TPC-H: Total hot run time: 33674 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4a6bebc9f3003535564987d3e522ff228f09d949, data reload: false
------ Round 1 ----------------------------------
q1	17614	5247	5089	5089
q2	1903	309	189	189
q3	10302	1275	693	693
q4	10222	990	515	515
q5	7535	2321	2364	2321
q6	170	158	128	128
q7	892	727	588	588
q8	9292	1277	1070	1070
q9	6743	5091	5079	5079
q10	6957	2367	1972	1972
q11	482	292	263	263
q12	339	336	210	210
q13	17795	3617	3038	3038
q14	236	233	209	209
q15	564	478	478	478
q16	425	417	367	367
q17	577	856	361	361
q18	7609	7075	7016	7016
q19	1171	944	560	560
q20	339	347	219	219
q21	3878	2536	2331	2331
q22	1057	1018	978	978
Total cold run time: 106102 ms
Total hot run time: 33674 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5173	5152	5148	5148
q2	243	320	219	219
q3	2151	2631	2292	2292
q4	1336	1784	1317	1317
q5	4194	4312	4543	4312
q6	217	181	134	134
q7	2042	2027	1818	1818
q8	2590	2593	2498	2498
q9	7373	7373	7332	7332
q10	3125	3317	2872	2872
q11	586	504	631	504
q12	708	769	619	619
q13	3432	3885	3269	3269
q14	287	305	280	280
q15	516	469	459	459
q16	470	491	476	476
q17	1172	1541	1373	1373
q18	8028	7611	7477	7477
q19	810	820	855	820
q20	2055	1935	1788	1788
q21	4723	4256	4340	4256
q22	1089	1046	986	986
Total cold run time: 52320 ms
Total hot run time: 50249 ms

doris-robot · 2025-08-26T10:52:07Z

TPC-DS: Total hot run time: 185091 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4a6bebc9f3003535564987d3e522ff228f09d949, data reload: false
query1	971	384	397	384
query2	6529	1770	1742	1742
query3	6747	220	213	213
query4	26109	23443	23202	23202
query5	4363	612	505	505
query6	299	223	201	201
query7	4626	515	284	284
query8	272	243	227	227
query9	8643	2844	2852	2844
query10	494	341	278	278
query11	15657	14999	14865	14865
query12	168	116	115	115
query13	1661	564	428	428
query14	9151	5913	5841	5841
query15	225	199	173	173
query16	7473	676	492	492
query17	1203	732	628	628
query18	2018	420	329	329
query19	193	188	170	170
query20	126	116	114	114
query21	212	121	110	110
query22	4165	4111	3988	3988
query23	34186	32954	33097	32954
query24	8166	2360	2335	2335
query25	550	463	409	409
query26	1223	260	161	161
query27	2730	501	343	343
query28	4320	2242	2200	2200
query29	797	556	439	439
query30	279	221	195	195
query31	891	807	711	711
query32	82	76	74	74
query33	550	363	337	337
query34	789	860	519	519
query35	795	817	744	744
query36	970	1011	905	905
query37	114	106	83	83
query38	4020	3980	3917	3917
query39	1481	1427	1403	1403
query40	216	123	115	115
query41	58	55	54	54
query42	115	108	112	108
query43	521	511	467	467
query44	1311	849	862	849
query45	180	168	163	163
query46	860	1023	638	638
query47	1751	1793	1748	1748
query48	396	415	320	320
query49	723	470	407	407
query50	647	659	404	404
query51	4037	4135	4093	4093
query52	118	113	104	104
query53	240	260	193	193
query54	591	572	538	538
query55	90	85	87	85
query56	319	301	299	299
query57	1170	1191	1144	1144
query58	274	273	260	260
query59	2594	2831	2595	2595
query60	353	329	328	328
query61	169	125	125	125
query62	777	723	693	693
query63	234	192	189	189
query64	4312	1006	676	676
query65	4282	4237	4178	4178
query66	1152	411	321	321
query67	15410	15251	15044	15044
query68	8173	898	579	579
query69	479	325	280	280
query70	1301	1158	1153	1153
query71	461	337	319	319
query72	5719	4704	4835	4704
query73	760	650	354	354
query74	9184	9126	8870	8870
query75	3753	3069	2655	2655
query76	3656	1140	752	752
query77	787	391	320	320
query78	9580	9641	8853	8853
query79	2991	781	590	590
query80	643	553	469	469
query81	470	255	220	220
query82	448	138	107	107
query83	286	250	232	232
query84	299	111	80	80
query85	800	375	416	375
query86	341	288	291	288
query87	4388	4344	4257	4257
query88	3017	2228	2232	2228
query89	407	312	285	285
query90	1929	224	220	220
query91	142	141	124	124
query92	85	73	72	72
query93	1854	980	638	638
query94	678	413	400	400
query95	398	311	311	311
query96	483	577	276	276
query97	2619	2700	2558	2558
query98	248	216	216	216
query99	1459	1400	1306	1306
Total cold run time: 273986 ms
Total hot run time: 185091 ms

doris-robot · 2025-08-26T10:57:35Z

ClickBench: Total hot run time: 32.17 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4a6bebc9f3003535564987d3e522ff228f09d949, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.05
query3	0.23	0.08	0.07
query4	1.62	0.11	0.11
query5	0.42	0.42	0.40
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.53	0.52
query10	0.58	0.57	0.59
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.63	0.61	0.61
query14	0.79	0.84	0.82
query15	0.88	0.85	0.87
query16	0.38	0.38	0.38
query17	1.03	1.04	1.05
query18	0.22	0.20	0.20
query19	1.90	1.88	1.83
query20	0.02	0.01	0.01
query21	15.42	0.94	0.58
query22	0.80	1.21	0.74
query23	14.80	1.36	0.67
query24	6.68	1.68	0.38
query25	0.54	0.20	0.08
query26	0.60	0.15	0.13
query27	0.06	0.05	0.05
query28	10.46	0.94	0.43
query29	12.59	3.92	3.26
query30	3.07	3.05	3.02
query31	2.82	0.56	0.38
query32	3.23	0.55	0.48
query33	2.99	3.02	3.12
query34	15.82	5.44	4.86
query35	4.92	4.86	4.99
query36	0.67	0.50	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.18	0.15	0.14
query41	0.07	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.93 s
Total hot run time: 32.17 s

dataroaring

LGTM

github-actions · 2025-08-27T01:00:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-27T01:00:50Z

PR approved by anyone and no changes requested.

Yulei-Yang

LGTM

### What problem does this PR solve? Related PR: ##40680 Problem Summary: java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "str" is null at org.apache.thrift.protocol.TBinaryProtocol.writeString(TBinaryProtocol.java:227) ~[libthrift-0.16.0.jar:0.16.0] at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:577) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:500) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.doris.thrift.TFrontendReportAliveSessionResult.write(TFrontendReportAliveSessionResult.java:429) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33897) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33859) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.doris.thrift.FrontendService$getAliveSessions_result.write(FrontendService.java:33810) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT] at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:58) ~[libthrift-0.16.0.jar:0.16.0] at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) ~[libthrift-0.16.0.jar:0.16.0] at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:250) ~[libthrift-0.16.0.jar:0.16.0] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?]

…afe #55315 (#55338) Cherry-picked from #55315 Co-authored-by: morrySnow <zhangwenxin@selectdb.com>

[fix](temp_table) alive session id set should be thread safe
4a6bebc

morrySnow requested review from CalvinKirs, dataroaring and morningman as code owners August 26, 2025 10:08

morrySnow added the dev/3.1.x label Aug 26, 2025

dataroaring approved these changes Aug 27, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2025

github-actionsBot added the reviewed label Aug 27, 2025

Yulei-Yang approved these changes Aug 27, 2025
View reviewed changes

morrySnow merged commit e969618 into apache:masterAug 27, 2025
28 of 30 checks passed

morrySnow deleted the fix_session_ids branch August 27, 2025 03:49

github-actionsBot mentioned this pull request Aug 27, 2025
branch-3.1: [fix](temp_table) alive session id set should be thread safe #55315 #55338
Merged

morrySnow added a commit that referenced this pull request Aug 28, 2025
branch-3.1: [fix](temp_table) alive session id set should be thread s…
eb22b53
…afe #55315 (#55338) Cherry-picked from #55315 Co-authored-by: morrySnow <zhangwenxin@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Aug 28, 2025

Navigation Menu

Uh oh!

[fix](temp_table) alive session id set should be thread safe - #55315

[fix](temp_table) alive session id set should be thread safe#55315
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_session_ids

morrySnow commented Aug 26, 2025

Uh oh!

morrySnow commented Aug 26, 2025

Uh oh!

hello-stephen commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

dataroaring left a comment

Uh oh!

github-actionsBot commented Aug 27, 2025

Uh oh!

github-actionsBot commented Aug 27, 2025

Uh oh!

Yulei-Yang left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

morrySnow commented Aug 26, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

morrySnow commented Aug 26, 2025

Uh oh!

hello-stephen commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

doris-robot commented Aug 26, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 27, 2025

Uh oh!

github-actionsBot commented Aug 27, 2025

Uh oh!

Yulei-Yang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants