Skip to content

[feat](txn) Add txn write amplification brpc metrics - #55544

Merged
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:wa_metrics
Sep 24, 2025
Merged

[feat](txn) Add txn write amplification brpc metrics#55544
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:wa_metrics

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

add transaction write amplification brpc metrics

max and avg

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
wyxxxcatforce-pushed the wa_metrics branch 6 times, most recently from e567b11 to 790a299CompareSeptember 2, 2025 03:38
@wyxxxcat

wyxxxcat commented Sep 2, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

liaoxin01
liaoxin01 previously approved these changes Sep 2, 2025
View reviewed changes

@liaoxin01liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@github-actions

github-actionsBot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@wyxxxcat

wyxxxcat commented Sep 2, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@doris-robot

doris-robot commented Sep 2, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.60% (1467/1734)
Line Coverage67.79% (26181/38618)
Region Coverage68.75% (13013/18928)
Branch Coverage58.73% (6965/11860)

@wyxxxcat

wyxxxcat commented Sep 2, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@hello-stephen

hello-stephen commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.60% (1467/1734)
Line Coverage67.77% (26173/38620)
Region Coverage68.77% (13017/18928)
Branch Coverage58.68% (6960/11860)

@wyxxxcat

wyxxxcat commented Sep 2, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Sep 2, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.60% (1467/1734)
Line Coverage67.81% (26192/38628)
Region Coverage68.76% (13019/18935)
Branch Coverage58.76% (6973/11866)

@wyxxxcat

wyxxxcat commented Sep 3, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (8/8) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.60% (1467/1734)
Line Coverage67.87% (26217/38628)
Region Coverage68.81% (13030/18935)
Branch Coverage58.76% (6973/11866)

dataroaring
dataroaring previously approved these changes Sep 4, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@wyxxxcat

wyxxxcat commented Sep 16, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Sep 16, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 80.71% (113/140) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.04% (1548/1842)
Line Coverage68.15% (27667/40598)
Region Coverage68.54% (13612/19861)
Branch Coverage58.82% (7269/12358)

@dataroaring

dataroaring commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Sep 19, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 86.58% (129/149) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.19% (1560/1853)
Line Coverage68.07% (27744/40759)
Region Coverage68.43% (13652/19949)
Branch Coverage58.68% (7277/12402)

gavinchou
gavinchou reviewed Sep 21, 2025
View reviewed changes
Comment threadcloud/test/bvars_test.cpp
@wyxxxcat

wyxxxcat commented Sep 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Sep 22, 2025

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 86.67% (130/150) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.96% (1560/1858)
Line Coverage67.91% (27753/40865)
Region Coverage68.20% (13643/20005)
Branch Coverage58.55% (7282/12438)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2025
@github-actions

github-actionsBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring
dataroaring merged commit a4a4c4a into apache:masterSep 24, 2025
26 checks passed
github-actionsBot pushed a commit that referenced this pull request Sep 24, 2025
@wyxxxcatYour Name
[feat](txn) Add txn write amplification brpc metrics (#55544)
ebead07
### What problem does this PR solve?
add transaction write amplification brpc metrics
@github-actionsgithub-actionsBot mentioned this pull request Sep 24, 2025
Closed
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Oct 11, 2025
@wyxxxcat
[feat](txn) Add txn write amplification brpc metrics (apache#55544)
2e723bc
add transaction write amplification brpc metrics
@wyxxxcatwyxxxcat mentioned this pull request Oct 11, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 13, 2025
@wyxxxcat
branch-3.1: [feat](txn) Add txn write amplification brpc metrics#55544…
cc9dc33
… (#56832)
picked from #55544
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
@wyxxxcat
[feat](txn) Add txn write amplification brpc metricsapache#55544(ap…
528c178
…ache#4944)
add transaction write amplification brpc metrics
pick: apache#55544
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@Yukang-LianYukang-LianYukang-Lian approved these changes
@liaoxin01liaoxin01liaoxin01 left review comments
@dataroaringdataroaringdataroaring left review comments
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.2-mergeddev/4.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@wyxxxcat@Thearas@doris-robot@hello-stephen@dataroaring@gavinchou@liaoxin01@Yukang-Lian@yiguolei@morrySnow