Skip to content

[Fix](case) Fix some cases - #55606

Merged
dataroaring merged 3 commits into
apache:masterfrom
bobhan1:fix-case-0902
Sep 4, 2025
Merged

[Fix](case) Fix some cases#55606
dataroaring merged 3 commits into
apache:masterfrom
bobhan1:fix-case-0902

Conversation

@bobhan1

@bobhan1bobhan1 commented Sep 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

fix unstable cases test_delete_publish_skip_read, test_partial_update_conflict_skip_compaction, test_partial_update_with_delete_col_in_publish, test_partial_update_merge_type

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring approved these changes Sep 3, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2025
@github-actions

github-actionsBot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring

dataroaring commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

run buildall

dataroaring
dataroaring approved these changes Sep 4, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 6c45ddd into apache:masterSep 4, 2025
32 of 34 checks passed
github-actionsBot pushed a commit that referenced this pull request Sep 4, 2025
@bobhan1Your Name
[Fix](case) Fix some cases (#55606)
e7f602b
### What problem does this PR solve?
fix unstable cases test_delete_publish_skip_read,
test_partial_update_conflict_skip_compaction,
test_partial_update_with_delete_col_in_publish,
test_partial_update_merge_type
@github-actionsgithub-actionsBot mentioned this pull request Sep 4, 2025
Merged
github-actionsBot pushed a commit that referenced this pull request Sep 4, 2025
@bobhan1Your Name
[Fix](case) Fix some cases (#55606)
49686f1
### What problem does this PR solve?
fix unstable cases test_delete_publish_skip_read,
test_partial_update_conflict_skip_compaction,
test_partial_update_with_delete_col_in_publish,
test_partial_update_merge_type
@github-actionsgithub-actionsBot mentioned this pull request Sep 4, 2025
Merged
dataroaring pushed a commit that referenced this pull request Sep 5, 2025
@github-actions@bobhan1
branch-3.0: [Fix](case) Fix some cases#55606(#55655)
636db03
Cherry-picked from #55606
Co-authored-by: bobhan1 <baohan@selectdb.com>
morrySnow pushed a commit that referenced this pull request Sep 5, 2025
@github-actions@bobhan1
branch-3.1: [Fix](case) Fix some cases#55606(#55656)
2164dd2
Cherry-picked from #55606
Co-authored-by: bobhan1 <baohan@selectdb.com>
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@bobhan1@wenzhenghu
[Fix](case) Fix some cases (apache#55606)
41ff0c6
### What problem does this PR solve?
fix unstable cases test_delete_publish_skip_read,
test_partial_update_conflict_skip_compaction,
test_partial_update_with_delete_col_in_publish,
test_partial_update_merge_type
@morrySnowmorrySnow mentioned this pull request Sep 22, 2025
Closed
@shuke987shuke987 mentioned this pull request Jul 15, 2026
Open
16 tasks
shuke987 added a commit to shuke987/doris that referenced this pull request Jul 15, 2026
@shuke987
[fix](test) Address scoped publish debug point review
c8046c4
### What problem does this PR solve?
Issue Number: N/A
Related PR: apache#55606
Problem Summary: The regression case read PartitionId from SHOW TABLETS, which does not expose that column. In addition, a nonmatching publish could consume the generic debug-point execute limit before the partition filter ran. Read and validate PartitionId from SHOW PARTITIONS, and add predicate-aware debug-point lookup so only matching publishes consume the execute limit.
### Release note
None
### Check List (For Author)
- Test: Manual test and unit test source added
- Regression framework compile
- Standalone Groovy compile
- DebugPointsTest target attempted but local CMake configuration was blocked by missing OpenBLAS, Faiss, and OpenMP prerequisites
- Behavior changed: Yes. A predicate-aware debug point consumes execute limits only after its predicate matches; existing lookup behavior is unchanged.
- Does this need documentation: No
shuke987 added a commit to shuke987/doris that referenced this pull request Jul 15, 2026
@shuke987
[fix](test) Apply review fix formatting
5bc35a5
### What problem does this PR solve?
Issue Number: N/A
Related PR: apache#55606
Problem Summary: Apply the exact clang-format 16 line wrapping reported by the current-head formatter check.
### Release note
None
### Check List (For Author)
- Test: Current-head Clang Formatter output
- Behavior changed: No
- Does this need documentation: No
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
+1 more reviewer
@koarzkoarzkoarz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.9-mergeddev/3.1.1-mergedp0_testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1@Thearas@dataroaring@koarz@morrySnow