[fix](bvar) Fix bvar leak after schema change job in be failed by xy720 · Pull Request #56207 · apache/doris

xy720 · 2025-09-18T15:02:23Z

What problem does this PR solve?

Fix bvar leak after alter tablet job failed.

How to reproduce:

1、create table

CREATE TABLE `test_tbl` (
`uid` int NOT NULL,
`vid` varchar(600) NOT NULL,
`pid` varchar(100) NOT NULL,
`create_day` date NOT NULL,
`create_time` datetime NOT NULL
) ENGINE=OLAP
UNIQUE KEY(`uid`, `vid`, `pid`, `create_day`)
PARTITION BY RANGE(`create_day`)
(PARTITION p20250908 VALUES [('2025-09-08'), ('2025-09-09')),
PARTITION p20250909 VALUES [('2025-09-09'), ('2025-09-10')),
PARTITION p20250910 VALUES [('2025-09-10'), ('2025-09-11')))
DISTRIBUTED BY HASH(`uid`) BUCKETS 32

2、insert some value

insert into test_tbl values(1, 'a', 'b', '2025-09-08', '2025-09-08 00:00:00');
...

3、open be debug point to force fail with status msg DELETE_BITMAP_LOCK_ERROR

curl -X POST "http://127.0.0.1:8040/api/debug_point/add/CloudSchemaChangeJob::_convert_historical_rowsets.fail.before.commit_job"
{
"status": "OK",
"msg": "OK"
}

4、alter table add rollup

create materialized view test_tbl_3 as select uid, vid, pid, create_day from test_tbl \G;

5、show alter table rollup

mysql> show alter table rollup\G;
*************************** 1. row ***************************
JobId: 1756715448708
TableName: test_tbl
CreateTime: 2025-09-18 22:57:14
FinishTime: 2025-09-18 22:57:50
BaseIndexName: test_tbl
RollupIndexName: test_tbl_3
RollupId: 1756715448709
TransactionId: 1528293360311296
State: CANCELLED
Msg: errCode = 2, detailMessage = rollup tasks failed on same tablet reach threshold 1, reason=task type: ALTER, status_code: DELETE_BITMAP_LOCK_ERROR, status_message: [(xxx.21.16.x)[DELETE_BITMAP_LOCK_ERROR]injected retryable error], backendId: Backend [id=1756714982495, host=xxx.21.16.x, heartbeatPort=9050, alive=true, lastStartTime=2025-09-18 22:34:45, process epoch=1758206085859, isDecommissioned=false, tags: {cloud_cluster_id=bZbcWdRS, cloud_unique_id=1:1756714581:yQsi7x17, cloud_cluster_status=NORMAL, cloud_cluster_name=tchd-dfvsacuy-plp29gys, location=default, cloud_cluster_private_endpoint=, cloud_cluster_public_endpoint=}], backendStatus: [lastSuccessReportTabletsTime='N/A', lastStreamLoadTime=1758206297222, isQueryDisabled=false, isLoadDisabled=false, currentFragmentNum=0, lastFragmentUpdateTime=1758207459008], signature: 1756715448766
Progress: NULL
Timeout: 2592000

6、Now the bvar fragment_executing_count is add but never reduce, leak happened.

curl http://xxx.21.16.x:8060/vars | grep fragment_executing_count

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-09-18T15:02:37Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

dataroaring

LGTM

xy720 · 2025-09-18T15:07:31Z

run buildall

github-actions · 2025-09-18T15:07:51Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-09-18T15:07:53Z

PR approved by anyone and no changes requested.

xy720 · 2025-09-19T06:29:53Z

run buildall

xy720 · 2025-09-19T07:02:56Z

run performance

doris-robot · 2025-09-19T07:21:58Z

TPC-H: Total hot run time: 1488 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 06031603aa076ead46713fa5d4a1d53729e3c87a, data reload: false
------ Round 1 ----------------------------------
q1	17599	31	20	20
q2	2658	28	28	28
q3	10708	17	15	15
q4	11179	18	15	15
q5	8102	15	17	15
q6	238	14	16	14
q7	942	23	22	22
q8	9454	14	12	12
q9	12627	13	12	12
q10	6968	14	11	11
q11	649	21	20	20
q12	347	12	11	11
q13	18603	13	12	12
q14	248	13	11	11
q15	602	12	10	10
q16	1025	987	953	953
q17	588	14	11	11
q18	7778	12	12	12
q19	1411	12	11	11
q20	1971	351	242	242
q21	9167	20	20	20
q22	1135	12	11	11
Total cold run time: 123999 ms
Total hot run time: 1488 ms
----- Round 2, with runtime_filter_mode=off -----
q1	11	10	11	10
q2	21	21	21	21
q3	12	11	12	11
q4	14	12	11	11
q5	11	11	11	11
q6	10	9	11	9
q7	18	20	19	19
q8	10	11	10	10
q9	10	11	10	10
q10	10	10	10	10
q11	20	20	19	19
q12	11	10	11	10
q13	10	9	9	9
q14	10	11	10	10
q15	10	10	11	10
q16	1091	1084	1029	1029
q17	12	10	10	10
q18	9	10	10	10
q19	10	10	10	10
q20	1850	2054	1840	1840
q21	20	19	18	18
q22	10	10	11	10
Total cold run time: 3190 ms
Total hot run time: 3107 ms

doris-robot · 2025-09-19T07:27:35Z

TPC-DS: Total hot run time: 2750 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 06031603aa076ead46713fa5d4a1d53729e3c87a, data reload: false
query1	1080	19	12	12
query2	7137	17	16	16
query3	7638	13	11	11
query4	26748	14	11	11
query5	4474	13	12	12
query6	399	11	11	11
query7	5420	12	11	11
query8	370	20	18	18
query9	9200	12	11	11
query10	719	12	11	11
query11	16104	11	11	11
query12	187	11	11	11
query13	1732	11	11	11
query14	10739	15	13	13
query15	388	11	9	9
query16	7183	11	10	10
query17	1531	11	11	11
query18	3064	11	12	11
query19	241	10	10	10
query20	137	11	9	9
query21	231	10	10	10
query22	4051	10	10	10
query23	33872	24	13	13
query24	9649	14	12	12
query25	753	11	9	9
query26	1073	11	10	10
query27	3493	10	10	10
query28	6231	12	12	12
query29	1222	11	10	10
query30	626	12	11	11
query31	1738	12	12	12
query32	119	12	10	10
query33	1262	11	10	10
query34	1608	840	535	535
query35	1049	11	11	11
query36	1006	10	9	9
query37	123	11	11	11
query38	3581	10	9	9
query39	1678	731	749	731
query40	276	10	9	9
query41	88	11	11	11
query42	150	9	9	9
query43	484	9	8	8
query44	1398	9	8	8
query45	394	10	10	10
query46	1318	11	9	9
query47	1827	10	10	10
query48	409	10	9	9
query49	1142	10	10	10
query50	755	10	10	10
query51	3951	10	8	8
query52	117	10	8	8
query53	247	10	10	10
query54	738	9	8	8
query55	92	10	8	8
query56	353	10	9	9
query57	1215	9	8	8
query58	387	11	10	10
query59	2641	10	9	9
query60	448	10	9	9
query61	179	9	9	9
query62	857	10	9	9
query63	270	10	10	10
query64	4443	12	9	9
query65	4042	9	9	9
query66	1480	10	9	9
query67	16972	23	11	11
query68	3672	11	9	9
query69	641	10	10	10
query70	1377	9	8	8
query71	428	413	322	322
query72	8028	11	11	11
query73	540	9	9	9
query74	9780	9	10	9
query75	3467	9	9	9
query76	2588	10	10	10
query77	925	11	9	9
query78	9892	15	10	10
query79	1236	10	8	8
query80	800	10	9	9
query81	1031	10	9	9
query82	209	9	10	9
query83	316	11	11	11
query84	368	10	9	9
query85	1760	10	9	9
query86	642	9	11	9
query87	3987	10	9	9
query88	2996	11	10	10
query89	401	8	10	8
query90	2216	10	11	10
query91	176	10	10	10
query92	78	10	9	9
query93	1433	9	8	8
query94	1646	10	10	10
query95	700	12	9	9
query96	423	10	8	8
query97	3183	10	8	8
query98	243	234	219	219
query99	1480	12	12	12
Total cold run time: 291191 ms
Total hot run time: 2750 ms

doris-robot · 2025-09-19T07:31:39Z

ClickBench: Total hot run time: 0.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 06031603aa076ead46713fa5d4a1d53729e3c87a, data reload: false
query1	0.07	0.02	0.00
query2	0.11	0.01	0.01
query3	0.27	0.01	0.01
query4	1.76	0.01	0.01
query5	0.27	0.00	0.01
query6	1.68	0.00	0.01
query7	0.06	0.01	0.01
query8	0.07	0.00	0.00
query9	0.60	0.00	0.01
query10	0.59	0.00	0.00
query11	0.18	0.01	0.01
query12	0.16	0.00	0.00
query13	0.64	0.00	0.00
query14	1.05	0.00	0.00
query15	0.88	0.00	0.01
query16	0.41	0.00	0.01
query17	1.04	0.00	0.01
query18	0.22	0.00	0.00
query19	1.93	0.00	0.00
query20	0.02	0.01	0.00
query21	15.38	0.01	0.00
query22	6.22	0.00	0.00
query23	16.32	0.00	0.00
query24	1.35	0.00	0.00
query25	0.21	0.00	0.01
query26	0.18	0.00	0.01
query27	0.11	0.00	0.00
query28	1.24	0.00	0.00
query29	13.20	0.00	0.00
query30	0.31	0.01	0.01
query31	2.22	0.01	0.01
query32	5.88	0.00	0.00
query33	4.34	0.01	0.00
query34	7.51	0.00	0.00
query35	6.05	0.00	0.00
query36	0.68	0.01	0.00
query37	0.11	0.00	0.00
query38	0.08	0.00	0.00
query39	0.05	0.00	0.00
query40	0.20	0.00	0.00
query41	0.09	0.01	0.00
query42	0.07	0.00	0.00
query43	0.05	0.01	0.00
Total cold run time: 93.86 s
Total hot run time: 0.07 s

doris-robot · 2025-09-19T07:42:46Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.35% (17597/33617)
Line Coverage	37.56% (159703/425147)
Region Coverage	32.15% (121788/378860)
Branch Coverage	33.47% (53339/159356)

xy720 · 2025-09-19T08:59:37Z

run cloud_p0

xy720 · 2025-09-19T08:59:43Z

run p0

hello-stephen · 2025-09-19T09:02:56Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.10% (23360/32856)
Line Coverage	57.45% (243735/424254)
Region Coverage	52.80% (202762/384034)
Branch Coverage	54.42% (87126/160093)

xy720 · 2025-09-19T10:33:44Z

run cloud_p0

xy720 · 2025-09-19T10:46:58Z

run p0

xy720 · 2025-09-19T10:47:03Z

run cloud_p0

hello-stephen · 2025-09-19T10:52:32Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.10% (23360/32856)
Line Coverage	57.45% (243735/424254)
Region Coverage	52.80% (202762/384034)
Branch Coverage	54.42% (87126/160093)

xy720 · 2025-09-19T10:54:33Z

run buildall

hello-stephen · 2025-09-19T12:02:35Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.34% (17596/33618)
Line Coverage	37.56% (159708/425187)
Region Coverage	32.13% (121745/378948)
Branch Coverage	33.47% (53345/159389)

xy720 · 2025-09-21T13:07:49Z

run buildall

doris-robot · 2025-09-21T14:13:42Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.34% (17595/33618)
Line Coverage	37.56% (159698/425192)
Region Coverage	32.13% (121761/378955)
Branch Coverage	33.46% (53328/159395)

hello-stephen · 2025-09-21T15:39:32Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.09% (23358/32857)
Line Coverage	57.47% (243834/424299)
Region Coverage	52.89% (203172/384129)
Branch Coverage	54.52% (87309/160132)

deardeng

LGTM

xy720 · 2025-09-27T11:15:48Z

run performance

xy720 · 2025-09-27T11:15:58Z

run nonconcurrent

doris-robot · 2025-09-27T12:04:38Z

ClickBench: Total hot run time: 30.35 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aaff74e047659d7dc16406f91dc2cdb1afcd1904, data reload: false
query1	0.06	0.05	0.04
query2	0.08	0.05	0.06
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.26	0.25
query6	1.19	0.65	0.65
query7	0.04	0.03	0.03
query8	0.05	0.05	0.05
query9	0.63	0.53	0.52
query10	0.58	0.61	0.58
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.62	0.63	0.63
query14	1.04	1.04	1.04
query15	0.86	0.86	0.85
query16	0.41	0.40	0.40
query17	1.09	1.06	1.04
query18	0.21	0.20	0.21
query19	1.97	1.84	1.87
query20	0.01	0.02	0.02
query21	15.42	0.93	0.58
query22	0.75	1.24	0.61
query23	15.00	1.38	0.65
query24	7.70	1.18	0.69
query25	0.52	0.35	0.10
query26	0.62	0.16	0.14
query27	0.06	0.05	0.05
query28	9.37	1.36	0.94
query29	12.66	3.97	3.28
query30	0.27	0.14	0.13
query31	2.83	0.59	0.39
query32	3.24	0.56	0.47
query33	3.07	3.07	3.16
query34	16.22	5.47	4.88
query35	5.00	4.87	4.95
query36	0.71	0.51	0.51
query37	0.11	0.08	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.05	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 105.28 s
Total hot run time: 30.35 s

xy720 · 2025-09-28T05:18:57Z

run nonConcurrent

…ailed #56207 (#56269) picked from #56207

…ailed (#56270) pick: #56207

Fix bvar leak after alter tablet job failed.

…ailed #56207 (#66946) Cherry-picked from #56207 Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>

save
a982204

xy720 changed the title ~~save~~[fix](bvar) Fix bvar leak after schema change job in be failedSep 18, 2025

dataroaring previously approved these changes Sep 18, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 18, 2025

github-actionsBot added the reviewed label Sep 18, 2025

save
0603160

xy720 dismissed dataroaring’s stale review via 0603160September 19, 2025 06:29

xy720 added dev/3.0.x dev/3.1.x labels Sep 19, 2025

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 19, 2025

Merge branch 'master' into fix-bvar-leak-when-alter-table-failed
ca05909

This was referenced Sep 21, 2025
branch-3.1: [fix](bvar) Fix bvar leak after schema change job in be failed #56269
Merged
branch-3.0: [fix](bvar) Fix bvar leak after schema change job in be failed #56270
Merged

Merge branch 'master' into fix-bvar-leak-when-alter-table-failed
aaff74e

deardeng approved these changes Sep 25, 2025
View reviewed changes

xy720 merged commit 371dd01 into apache:masterSep 28, 2025
25 of 27 checks passed

github-actionsBot added dev/3.0.x-conflict dev/3.1.x-conflict labels Sep 28, 2025

morrySnow pushed a commit that referenced this pull request Sep 29, 2025
branch-3.1: [fix](bvar) Fix bvar leak after schema change job in be f…
4cf7e59
…ailed #56207 (#56269) picked from #56207

morrySnow added dev/3.1.2-merged and removed dev/3.1.x dev/3.1.x-conflict labels Sep 29, 2025

liutang123 pushed a commit that referenced this pull request Oct 17, 2025
branch-3.0: [fix](bvar) Fix bvar leak after schema change job in be f…
b4a5503
…ailed (#56270) pick: #56207

xy720 added dev/3.0.9-merged and removed dev/3.0.x-conflict dev/3.0.x labels Nov 28, 2025

luwei16 added dev/4.1.x dev/4.0.x labels Aug 19, 2026

github-actionsBot pushed a commit that referenced this pull request Aug 19, 2026
[fix](bvar) Fix bvar leak after schema change job in be failed (#56207)
ee52cd8
Fix bvar leak after alter tablet job failed.

github-actionsBot mentioned this pull request Aug 19, 2026
branch-4.1: [fix](bvar) Fix bvar leak after schema change job in be failed #56207 #66946
Merged

yiguolei pushed a commit that referenced this pull request Aug 20, 2026
branch-4.1: [fix](bvar) Fix bvar leak after schema change job in be f…
beacc07
…ailed #56207 (#66946) Cherry-picked from #56207 Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>

yiguolei added dev/4.1.4-merged and removed dev/4.1.x labels Aug 20, 2026

yiguolei mentioned this pull request Sep 1, 2026
4.1.4 Release Note #67355
Open

Uh oh!

Conversation

xy720 commented Sep 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Sep 18, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

xy720 commented Sep 18, 2025

Uh oh!

github-actionsBot commented Sep 18, 2025

Uh oh!

github-actionsBot commented Sep 18, 2025

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

doris-robot commented Sep 19, 2025

Uh oh!

doris-robot commented Sep 19, 2025

Uh oh!

doris-robot commented Sep 19, 2025

Uh oh!

doris-robot commented Sep 19, 2025

BE UT Coverage Report

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

hello-stephen commented Sep 19, 2025

BE Regression && UT Coverage Report

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

hello-stephen commented Sep 19, 2025

BE Regression && UT Coverage Report

Uh oh!

xy720 commented Sep 19, 2025

Uh oh!

hello-stephen commented Sep 19, 2025

BE UT Coverage Report

Uh oh!

xy720 commented Sep 21, 2025

Uh oh!

doris-robot commented Sep 21, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Sep 21, 2025

BE Regression && UT Coverage Report

Uh oh!

deardeng left a comment

Choose a reason for hiding this comment

Uh oh!

xy720 commented Sep 27, 2025

Uh oh!

xy720 commented Sep 27, 2025

Uh oh!

doris-robot commented Sep 27, 2025

Uh oh!

xy720 commented Sep 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

xy720 commented Sep 18, 2025•
edited
Loading