Skip to content

[fix](script) Fix recycler cannot find core-site.xml and hdfs-site.xml - #56248

Merged
hello-stephen merged 1 commit into
apache:masterfrom
swjtu-zhanglei:master-fix15
Sep 19, 2025
Merged

[fix](script) Fix recycler cannot find core-site.xml and hdfs-site.xml#56248
hello-stephen merged 1 commit into
apache:masterfrom
swjtu-zhanglei:master-fix15

Conversation

@swjtu-zhanglei

@swjtu-zhangleiswjtu-zhanglei commented Sep 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei

swjtu-zhanglei commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage84.02% (1541/1834)
Line Coverage68.03% (27629/40610)
Region Coverage68.39% (13588/19868)
Branch Coverage58.70% (7257/12362)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2025
@github-actions

github-actionsBot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

shuke987
shuke987 approved these changes Sep 19, 2025
View reviewed changes

@shuke987shuke987 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Sep 19, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
hello-stephen merged commit f0f26d7 into apache:masterSep 19, 2025
36 of 37 checks passed
github-actionsBot pushed a commit that referenced this pull request Sep 22, 2025
@swjtu-zhangleiYour Name
[fix](script) Fix recycler cannot find core-site.xml and `hdfs-site…
64ffdd2
….xml` (#56248)
@github-actionsgithub-actionsBot mentioned this pull request Sep 22, 2025
Merged
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Sep 22, 2025
@swjtu-zhanglei@dwdwqfwe
[fix](script) Fix recycler cannot find core-site.xml and `hdfs-site…
1b81339
….xml` (apache#56248)
morrySnow pushed a commit that referenced this pull request Sep 25, 2025
@github-actions@swjtu-zhanglei
branch-3.1: [fix](script) Fix recycler cannot find core-site.xml an…
e4f1e1e
…d `hdfs-site.xml` #56248 (#56317)
Cherry-picked from #56248
Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Oct 23, 2025
@wyxxxcat
branch-3.1: [fix](script) Fix recycler cannot find core-site.xml and …
806383d
…hdfs-site.xml apache#56248 (apache#5016)
pick: https://github.com/apache/doris/pull/56248/files
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@wyxxxcat
branch-3.0: [fix](script) Fix recycler cannot find core-site.xml and …
6875419
…hdfs-site.xml apache#56248apache#5016 (apache#5018)
pick: https://github.com/apache/doris/pull/56248/files
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephenhello-stephenhello-stephen approved these changes
@shuke987shuke987shuke987 approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swjtu-zhanglei@Thearas@hello-stephen@shuke987@dataroaring@gavinchou@morrySnow