Skip to content

[Metrics] Add metrics to show the distribution of tablets version count - #5665

Merged
morningman merged 1 commit into
apache:masterfrom
weizuo93:rowset-num-histogram-metrics
Apr 23, 2021
Merged

[Metrics] Add metrics to show the distribution of tablets version count#5665
morningman merged 1 commit into
apache:masterfrom
weizuo93:rowset-num-histogram-metrics

Conversation

@weizuo93

@weizuo93weizuo93 commented Apr 16, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Add metrics (P50, P75, P90, P95, P99, etc.) to show the distribution of tablets version count.

# TYPE doris_be_tablet_version_num_distribution histogram
doris_be_tablet_version_num_distribution{quantile="0.50"} 9.21429
doris_be_tablet_version_num_distribution{quantile="0.75"} 11.7949
doris_be_tablet_version_num_distribution{quantile="0.90"} 13
doris_be_tablet_version_num_distribution{quantile="0.95"} 13
doris_be_tablet_version_num_distribution{quantile="0.99"} 13
doris_be_tablet_version_num_distribution_sum 950
doris_be_tablet_version_num_distribution_count 100

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Comment threadbe/src/util/doris_metrics.h Outdated
@weizuo93
weizuo93force-pushed the rowset-num-histogram-metrics branch from 2d91830 to 5523a6bCompareApril 20, 2021 10:15
morningman
morningman previously approved these changes Apr 20, 2021

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman self-assigned this Apr 20, 2021
@morningmanmorningman added approved Indicates a PR has been approved by one committer. area/metrics Issues or PRs related to the metrics labels Apr 20, 2021
Comment threadbe/src/olap/tablet_manager.cpp Outdated
acelyc111
acelyc111 previously approved these changes Apr 21, 2021

@acelyc111acelyc111 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit ad3a0fb into apache:masterApr 23, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
Add metrics (P50, P75, P90, P95, P99, etc.) to show the distribution of tablets version count.
```
# TYPE doris_be_tablet_version_num_distribution histogram
doris_be_tablet_version_num_distribution{quantile="0.50"} 9.21429
doris_be_tablet_version_num_distribution{quantile="0.75"} 11.7949
doris_be_tablet_version_num_distribution{quantile="0.90"} 13
doris_be_tablet_version_num_distribution{quantile="0.95"} 13
doris_be_tablet_version_num_distribution{quantile="0.99"} 13
doris_be_tablet_version_num_distribution_sum 950
doris_be_tablet_version_num_distribution_count 100
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/metricsIssues or PRs related to the metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@weizuo93@morningman@acelyc111