Skip to content

[fix](recycler) Avoiding Null Pointer Dereference When Calling check_meta - #56653

Merged
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:check_meta_npe
Oct 10, 2025
Merged

[fix](recycler) Avoiding Null Pointer Dereference When Calling check_meta#56653
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:check_meta_npe

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat

wyxxxcat commented Sep 30, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.35% (1632/1958)
Line Coverage67.88% (28841/42488)
Region Coverage68.11% (14218/20876)
Branch Coverage58.42% (7571/12960)

dataroaring
dataroaring approved these changes Oct 6, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 6, 2025
@github-actions

github-actionsBot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 1ddd2a7 into apache:masterOct 10, 2025
29 of 30 checks passed
github-actionsBot pushed a commit that referenced this pull request Oct 10, 2025
@wyxxxcatYour Name
[fix](recycler) Avoiding Null Pointer Dereference When Calling check_…
3db4045
…meta (#56653)
@github-actionsgithub-actionsBot mentioned this pull request Oct 10, 2025
Merged
github-actionsBot pushed a commit that referenced this pull request Oct 10, 2025
@wyxxxcatYour Name
[fix](recycler) Avoiding Null Pointer Dereference When Calling check_…
654d543
…meta (#56653)
@github-actionsgithub-actionsBot mentioned this pull request Oct 10, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 11, 2025
@github-actions@wyxxxcat
branch-3.1: [fix](recycler) Avoiding Null Pointer Dereference When Ca…
2fbdd90
…lling check_meta #56653 (#56773)
Cherry-picked from #56653
Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
yiguolei pushed a commit that referenced this pull request Oct 11, 2025
@github-actions@wyxxxcat
branch-4.0: [fix](recycler) Avoiding Null Pointer Dereference When Ca…
993ef83
…lling check_meta #56653 (#56775)
Cherry-picked from #56653
Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner
@w41terw41terAwaiting requested review from w41ter
+1 more reviewer
@koarzkoarzkoarz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.2-mergeddev/4.0.1-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat@hello-stephen@koarz@dataroaring@yiguolei@morrySnow