Skip to content

[fix](ubsan) fix ub error of uninitialized variable - #56854

Merged
morningman merged 1 commit into
apache:masterfrom
morningman:ubsan_file_writer
Oct 16, 2025
Merged

[fix](ubsan) fix ub error of uninitialized variable#56854
morningman merged 1 commit into
apache:masterfrom
morningman:ubsan_file_writer

Conversation

@morningman

@morningmanmorningman commented Oct 11, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
The bool value should be initialized, otherwise it will cause crash when enabling UBSAN

be/src/vec/sink/writer/vfile_result_writer.cpp:139:71: runtime error: load of value 190, which is not a valid value for type 'bool'

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

morningman commented Oct 11, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningmanmorningman mentioned this pull request Oct 11, 2025
Merged
morningman added a commit to morningman/doris that referenced this pull request Oct 11, 2025
@morningman
branch-4.0: [fix](ubsan) fix ub error of uninitialized variableapach…
f9946b4
…e#56854
@morningmanmorningman mentioned this pull request Oct 11, 2025
Merged
@doris-robot

doris-robot commented Oct 11, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 190946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b5414f3df7268a4f0c7b42262b256e3e96c454ba, data reload: false
query1	1034	452	414	414
query2	6563	1734	1662	1662
query3	6761	218	238	218
query4	25889	23813	23702	23702
query5	4419	674	506	506
query6	327	234	216	216
query7	4642	502	310	310
query8	313	253	242	242
query9	8712	2568	2586	2568
query10	476	347	275	275
query11	15360	15702	15679	15679
query12	203	121	131	121
query13	1758	569	442	442
query14	10781	9635	9560	9560
query15	217	205	180	180
query16	8219	712	470	470
query17	1511	813	642	642
query18	2031	416	322	322
query19	205	207	176	176
query20	142	124	119	119
query21	214	142	112	112
query22	4097	4125	4095	4095
query23	33991	33225	33108	33108
query24	8523	2447	2463	2447
query25	567	519	431	431
query26	1245	277	157	157
query27	2759	501	362	362
query28	4369	2185	2142	2142
query29	775	633	475	475
query30	299	229	207	207
query31	894	860	746	746
query32	84	69	67	67
query33	589	371	368	368
query34	790	850	519	519
query35	785	830	761	761
query36	979	1031	935	935
query37	110	108	83	83
query38	3553	3624	3572	3572
query39	1495	1442	1419	1419
query40	222	125	119	119
query41	60	59	59	59
query42	117	117	111	111
query43	486	500	469	469
query44	1330	853	823	823
query45	188	184	172	172
query46	840	1001	628	628
query47	1762	1800	1767	1767
query48	397	428	318	318
query49	769	526	450	450
query50	632	679	407	407
query51	3845	3982	4097	3982
query52	108	110	100	100
query53	239	269	193	193
query54	589	581	521	521
query55	91	83	99	83
query56	320	338	302	302
query57	1165	1211	1130	1130
query58	287	275	284	275
query59	2601	2729	2600	2600
query60	349	340	343	340
query61	177	151	152	151
query62	792	749	681	681
query63	232	189	239	189
query64	4409	1142	866	866
query65	4052	3949	3976	3949
query66	1092	438	342	342
query67	15630	15102	15109	15102
query68	7743	933	596	596
query69	503	329	289	289
query70	1367	1334	1326	1326
query71	442	351	312	312
query72	5805	5127	4967	4967
query73	657	593	361	361
query74	9022	9048	9134	9048
query75	3317	3406	2867	2867
query76	3296	1179	740	740
query77	513	402	313	313
query78	9547	9627	9028	9028
query79	2159	822	599	599
query80	674	559	514	514
query81	531	273	228	228
query82	209	166	131	131
query83	267	263	245	245
query84	260	123	92	92
query85	860	468	428	428
query86	383	315	296	296
query87	3756	3778	3681	3681
query88	3577	2239	2258	2239
query89	386	330	297	297
query90	2060	215	225	215
query91	165	168	133	133
query92	138	77	73	73
query93	2190	987	653	653
query94	702	452	322	322
query95	410	332	323	323
query96	490	580	285	285
query97	2906	2998	2876	2876
query98	247	214	219	214
query99	1349	1431	1296	1296
Total cold run time: 274393 ms
Total hot run time: 190946 ms

@doris-robot

doris-robot commented Oct 11, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b5414f3df7268a4f0c7b42262b256e3e96c454ba, data reload: false
query1	0.06	0.05	0.05
query2	0.09	0.06	0.07
query3	0.26	0.08	0.09
query4	1.61	0.12	0.12
query5	0.28	0.26	0.26
query6	1.21	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.64	0.53	0.52
query10	0.58	0.59	0.58
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.64	0.62	0.62
query14	1.06	1.04	1.02
query15	0.87	0.85	0.88
query16	0.39	0.39	0.39
query17	1.06	1.07	1.10
query18	0.20	0.20	0.20
query19	1.92	1.82	1.87
query20	0.02	0.02	0.01
query21	15.42	0.90	0.59
query22	0.77	1.21	0.67
query23	14.91	1.42	0.65
query24	6.73	1.22	0.97
query25	0.47	0.21	0.10
query26	0.68	0.17	0.14
query27	0.07	0.06	0.06
query28	9.43	1.39	0.93
query29	12.58	3.89	3.29
query30	0.27	0.13	0.11
query31	2.84	0.61	0.39
query32	3.25	0.57	0.48
query33	3.16	3.13	3.07
query34	16.13	5.49	4.90
query35	4.92	4.94	4.92
query36	0.69	0.54	0.50
query37	0.11	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.04	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.17 s
Total hot run time: 30.74 s

@hello-stephen

hello-stephen commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.50% (17729/33768)
Line Coverage37.68% (160928/427093)
Region Coverage32.18% (122953/382133)
Branch Coverage33.56% (53899/160603)

@hello-stephen

hello-stephen commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.20% (23556/33086)
Line Coverage57.62% (245836/426665)
Region Coverage52.72% (203987/386961)
Branch Coverage54.57% (88082/161414)

yiguolei pushed a commit that referenced this pull request Oct 12, 2025
@morningman
branch-4.0: [fix](ubsan) fix ub error of uninitialized variable#56854(
e1dca13
#56856)
bp #56854
yiguolei
yiguolei reviewed Oct 12, 2025
View reviewed changes
Comment threadbe/src/pipeline/exec/result_sink_operator.h
std::vector<TParquetSchema> parquet_schemas;
TParquetCompressionType::type parquet_commpression_type;
TParquetVersion::type parquet_version;
bool parquert_disable_dictionary;

@yiguoleiyiguoleiOct 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not init all the members of ResultFileOptions?

@morningmanmorningmanOct 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only primitive type like int and bool need init.
Other types have default constructor.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2025
@github-actions

github-actionsBot commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

morrySnow pushed a commit that referenced this pull request Oct 13, 2025
@morningman
branch-3.1: [fix](ubsan) fix ub error of uninitialized variable#56854(
ad5874b
#56855)
bp #56854
@morningman
morningman merged commit f0190db into apache:masterOct 16, 2025
34 of 38 checks passed
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Oct 23, 2025
@morningman
[fix](ubsan) fix ub error of uninitialized variableapache#56854(apa…
f089e8d
…che#5027)
pick apache#56854
```
start BE in cloud mode, cloud_unique_id: ddc_cloud_unique_id_be, meta_service_endpoint: 172.20.56.123:5000
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/vfile_result_writer.cpp:139:71: runtime error: load of value 190, which is not a valid value for type 'bool'
#0 0x55b5e9a1e7a0 in doris::vectorized::VFileResultWriter::_create_file_writer(std::__cxx11::basic_string, std::allocator> const&) /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/vfile_result_writer.cpp:139:71
apache#1 0x55b5e9a1ac9f in doris::vectorized::VFileResultWriter::_create_next_file_writer() /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/vfile_result_writer.cpp:116:12
apache#2 0x55b5e9a16445 in doris::vectorized::VFileResultWriter::open(doris::RuntimeState*, doris::RuntimeProfile*) /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/vfile_result_writer.cpp:100:12
apache#3 0x55b5e7677e7c in doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/async_result_writer.cpp:106:23
apache#4 0x55b5e767ca7a in doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/vec/sink/writer/async_result_writer.cpp:93:5
apache#5 0x55b5e767ca7a in void std::__invoke_impl(std::__invoke_other, doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0&) /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14
apache#6 0x55b5e767ca7a in std::enable_if, void>::type std::__invoke_r(doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0&) /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:111:2
apache#7 0x55b5e767ca7a in std::_Function_handler::_M_invoke(std::_Any_data const&) /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291:9
apache#8 0x55b5b50496a7 in doris::ThreadPool::dispatch_thread() /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/util/threadpool.cpp:602:24
apache#9 0x55b5b50206de in std::function::operator()() const /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560:9
apache#10 0x55b5b50206de in doris::Thread::supervise_thread(void*) /mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-3.1/selectdb-core/be/src/util/thread.cpp:498:5
```
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@morningman
branch-3.0: [fix](ubsan) fix ub error of uninitialized variableapach…
003677c
…e#56854 (apache#5028)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei left review comments
@CalvinKirsCalvinKirsCalvinKirs approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes
@hubgeterhubgeterhubgeter approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.2-mergeddev/4.0.1-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@morningman@Thearas@doris-robot@hello-stephen@yiguolei@CalvinKirs@zclllyybb@hubgeter