Skip to content

branch-4.0: [fix](function) Crash caused by explode function #56991 - #57000

Merged
yiguolei merged 1 commit into
branch-4.0from
auto-pick-56991-branch-4.0
Oct 16, 2025
Merged

branch-4.0: [fix](function) Crash caused by explode function #56991#57000
yiguolei merged 1 commit into
branch-4.0from
auto-pick-56991-branch-4.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #56991

@mrhhsgYour Name
[fix](function) Crash caused by explode function (#56991)
3db7937
### What problem does this PR solve?
Crashed when the `element_size` is less than `_cur_offset`.
```text
*** SIGABRT unknown detail explain (@0x3f800011a04) received by PID 72196 (TID 74961 OR 0x7bc6104c4700) from PID 72196; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420
1# 0x00007FCD3B81AD10 in /lib64/libpthread.so.0
2# __GI_raise in /lib64/libc.so.6
3# __GI_abort in /lib64/libc.so.6
4# 0x000055583DEC0C0D in /root/doris/be/output/lib/doris_be
5# google::LogMessage::SendToLog() in /root/doris/be/output/lib/doris_be
6# google::LogMessage::Flush() in /root/doris/be/output/lib/doris_be
7# google::LogMessageFatal::~LogMessageFatal() in /root/doris/be/output/lib/doris_be
8# doris::vectorized::PODArray<unsigned char, 4096ul, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator, false>, 16ul, 15ul>::operator[](long) const at /root/doris/be/src/vec/common/pod_array.h:466
9# doris::vectorized::ColumnVector<(doris::PrimitiveType)2>::insert_range_from(doris::vectorized::IColumn const&, unsigned long, unsigned long) at /root/doris/be/src/vec/columns/column_vector.cpp:278
10# doris::vectorized::VExplodeV2TableFunction::get_value(doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, int) at /root/doris/be/src/vec/exprs/table_function/vexplode_v2.cpp:233
11# doris::pipeline::TableFunctionLocalState::get_expanded_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /root/doris/be/src/pipeline/exec/table_function_operator.cpp:199
12# doris::pipeline::TableFunctionOperatorX::pull(doris::RuntimeState*, doris::vectorized::Block*, bool*) const at /root/doris/be/src/pipeline/exec/table_function_operator.h:119
13# doris::pipeline::StatefulOperatorX<doris::pipeline::TableFunctionLocalState>::get_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /root/doris/be/src/pipeline/exec/operator.cpp:707
14# doris::pipeline::OperatorXBase::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /root/doris/be/src/pipeline/exec/operator.cpp:397
15# doris::pipeline::PipelineTask::execute(bool*) at /root/doris/be/src/pipeline/pipeline_task.cpp:532
16# doris::pipeline::TaskScheduler::_do_work(int) at /root/doris/be/src/pipeline/task_scheduler.cpp:146
17# doris::pipeline::TaskScheduler::start()::$_0::operator()() const at /root/doris/be/src/pipeline/task_scheduler.cpp:67
18# void std::__invoke_impl<void, doris::pipeline::TaskScheduler::start()::$_0&>(std::__invoke_other, doris::pipeline::TaskScheduler::start()::$_0&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:63
19# std::enable_if<is_invocable_r_v<void, doris::pipeline::TaskScheduler::start()::$_0&>, void>::type std::__invoke_r<void, doris::pipeline::TaskScheduler::start()::$_0&>(doris::pipeline::TaskScheduler::start()::$_0&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:119
20# std::_Function_handler<void (), doris::pipeline::TaskScheduler::start()::$_0>::_M_invoke(std::_Any_data const&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
21# std::function<void ()>::operator()() const at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:593
22# doris::FunctionRunnable::run() at /root/doris/be/src/util/threadpool.cpp:60
23# doris::ThreadPool::dispatch_thread() at /root/doris/be/src/util/threadpool.cpp:614
24# void std::__invoke_impl<void, void (doris::ThreadPool::*&)(), doris::ThreadPool*&>(std::__invoke_memfun_deref, void (doris::ThreadPool::*&)(), doris::ThreadPool*&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:76
25# std::__invoke_result<void (doris::ThreadPool::*&)(), doris::ThreadPool*&>::type std::__invoke<void (doris::ThreadPool::*&)(), doris::ThreadPool*&>(void (doris::ThreadPool::*&)(), doris::ThreadPool*&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:98
26# void std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/functional:515
27# void std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>::operator()<, void>() at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/functional:600
28# void std::__invoke_impl<void, std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>&>(std::__invoke_other, std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:63
29# std::enable_if<is_invocable_r_v<void, std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>&>, void>::type std::__invoke_r<void, std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>&>(std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()>&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:119
30# std::_Function_handler<void (), std::_Bind<void (doris::ThreadPool::*(doris::ThreadPool*))()> >::_M_invoke(std::_Any_data const&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
31# std::function<void ()>::operator()() const at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:593
32# doris::Thread::supervise_thread(void*) at /root/doris/be/src/util/thread.cpp:460
33# asan_thread_start(void*) in /root/doris/be/output/lib/doris_be
34# start_thread in /lib64/libpthread.so.0
35# __GI___clone in /lib64/libc.so.6
```
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@hello-stephen

hello-stephen commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Oct 15, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3db7937d5dc40a724260d021b7b345325b1b93f7, data reload: true
query1	0.04	0.04	0.03
query2	0.11	0.04	0.04
query3	0.28	0.08	0.07
query4	1.73	0.10	0.11
query5	0.26	0.26	0.25
query6	1.26	0.65	0.66
query7	0.03	0.02	0.02
query8	0.06	0.03	0.04
query9	0.62	0.52	0.52
query10	0.56	0.57	0.58
query11	0.19	0.11	0.10
query12	0.16	0.11	0.12
query13	0.63	0.61	0.60
query14	0.84	0.82	0.83
query15	0.88	0.86	0.86
query16	0.40	0.40	0.39
query17	1.04	1.01	1.06
query18	0.19	0.20	0.19
query19	1.96	1.88	1.86
query20	0.02	0.01	0.01
query21	15.45	0.92	0.57
query22	0.82	0.96	1.02
query23	15.00	1.37	0.62
query24	16.29	1.49	0.61
query25	2.25	0.39	0.20
query26	0.18	0.19	0.18
query27	0.20	0.21	0.05
query28	1.78	1.04	0.94
query29	12.70	3.92	3.29
query30	0.31	0.12	0.10
query31	2.99	0.61	0.39
query32	3.33	0.57	0.49
query33	3.11	3.03	3.18
query34	16.63	5.90	4.94
query35	5.12	5.08	5.17
query36	0.76	0.54	0.52
query37	0.11	0.07	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.16	0.14
query41	0.08	0.02	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 108.72 s
Total hot run time: 30.56 s

@yiguolei
yiguolei merged commit 3032868 into branch-4.0Oct 16, 2025
22 of 23 checks passed
@github-actions
github-actionsBot deleted the auto-pick-56991-branch-4.0 branch October 16, 2025 01:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen@doris-robot@yiguolei@dataroaring@mrhhsg