Uh oh!
There was an error while loading. Please reload this page.
[fix](parquet) incorrect skip files when returning eof - #57071
Merged
Conversation
hello-stephen
commented
Oct 16, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
commented
Oct 16, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Oct 16, 2025
ClickBench: Total hot run time: 30.72 s |
doris-robot
commented
Oct 16, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Oct 16, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hubgeter
approved these changes
Oct 17, 2025
Contributor
PR approved by anyone and no changes requested. |
suxiaogang223
approved these changes
Oct 20, 2025
CalvinKirs
approved these changes
Oct 20, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 20, 2025
### What problem does this PR solve? Problem Summary: Introduced from topn optimization. When opening a parquet reader, all row group may be filtered and the open method will return EOF, we should handle this kind of return value separately and continue opening other files. Otherwise, the rest of files may be wrongly skipped and the result is incorrect.
yiguolei pushed a commit
that referenced
this pull request
Oct 22, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Introduced from topn optimization.
When opening a parquet reader, all row group may be filtered and the open method will return EOF,
we should handle this kind of return value separately and continue opening other files.
Otherwise, the rest of files may be wrongly skipped and the result is incorrect.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)