Skip to content

[fix](olap) Need to handle floating-point Infinity values in the predicate (#57100) - #57227

Merged
yiguolei merged 1 commit into
apache:branch-4.0from
mrhhsg:pick_57100
Oct 23, 2025
Merged

[fix](olap) Need to handle floating-point Infinity values in the predicate (#57100)#57227
yiguolei merged 1 commit into
apache:branch-4.0from
mrhhsg:pick_57100

Conversation

@mrhhsg

@mrhhsgmrhhsg commented Oct 22, 2025

Copy link
Copy Markdown
Member

pick #57100

Issue Number: close #xxx

Related PR: #57100

Problem Summary:

None

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
  • This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
  • Yes.

  • Confirm the release note

  • Confirm test cases

  • Confirm document

  • Add branch pick label

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…icate (apache#57100)
```text
at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/ext/string_conversions.h:90
at /root/doris_branch-4.0/doris/be/src/olap/predicate_creator.h:68
arena=...) at /root/doris_branch-4.0/doris/be/src/olap/predicate_creator.h:59
at /root/doris_branch-4.0/doris/be/src/olap/predicate_creator.h:270
at /root/doris_branch-4.0/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:95
at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:63
at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:116
__functor=...) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
```
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@mrhhsg
mrhhsg requested a review from yiguolei as a code ownerOctober 22, 2025 06:22
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03911897c8f4ddfafad466196ff0353e9464d5c6, data reload: true
query1	0.04	0.03	0.03
query2	0.11	0.04	0.04
query3	0.25	0.08	0.07
query4	1.65	0.11	0.10
query5	0.27	0.25	0.25
query6	1.23	0.65	0.65
query7	0.02	0.02	0.02
query8	0.06	0.04	0.03
query9	0.64	0.52	0.52
query10	0.58	0.57	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.62	0.61	0.61
query14	0.79	0.81	0.82
query15	0.88	0.86	0.85
query16	0.38	0.39	0.40
query17	1.03	1.03	1.06
query18	0.19	0.18	0.19
query19	1.96	1.82	1.82
query20	0.02	0.01	0.01
query21	15.41	0.89	0.57
query22	0.77	1.20	0.75
query23	15.10	1.35	0.66
query24	5.53	1.02	0.29
query25	0.34	0.14	0.09
query26	0.55	0.14	0.14
query27	0.06	0.05	0.05
query28	10.84	1.41	0.94
query29	12.62	4.03	3.42
query30	0.25	0.14	0.12
query31	3.11	0.65	0.40
query32	3.43	0.58	0.51
query33	3.30	3.40	3.43
query34	17.06	5.73	5.04
query35	5.13	5.11	4.76
query36	0.72	0.50	0.50
query37	0.10	0.07	0.06
query38	0.10	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.79 s
Total hot run time: 30.14 s

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 23, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 93e2ae5 into apache:branch-4.0Oct 23, 2025
25 of 28 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mrhhsg@hello-stephen@doris-robot@yiguolei