Skip to content

[fix] remove parse_id - #57240

Merged
zclllyybb merged 2 commits into
apache:masterfrom
wumeibanfa:remove_paser_id
Oct 26, 2025
Merged

[fix] remove parse_id#57240
zclllyybb merged 2 commits into
apache:masterfrom
wumeibanfa:remove_paser_id

Conversation

@wumeibanfa

@wumeibanfawumeibanfa commented Oct 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

remove parse_id

Issue Number: close #xxx

Related PR: #55057

Problem Summary:

Remove parse_id, as this method modifies the string. When using the same string, a second call to this method will fail.

Following testing, from_hex and parse_id demonstrate identical behaviour.

parse_id(abcd-1234) = (from_hex(abcd), from_hex(1234)) = (0xabcd, 0x1234)
parse_id(0123456789abcdef-0123456789abcdef) = (from_hex(0123456789abcdef), from_hex(0123456789abcdef)) = (0x0123456789abcdef, 0x0123456789abcdef)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa

wumeibanfa commented Oct 22, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 22, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 28.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 85b7886c197d2ffc069ed4ce49d5a6cb768884de, data reload: false
query1	0.06	0.06	0.05
query2	0.10	0.06	0.05
query3	0.25	0.09	0.09
query4	1.61	0.12	0.12
query5	0.29	0.27	0.24
query6	1.18	0.66	0.68
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.54	0.53
query10	0.59	0.60	0.59
query11	0.18	0.11	0.12
query12	0.16	0.12	0.12
query13	0.63	0.61	0.61
query14	1.03	1.01	1.04
query15	0.86	0.85	0.87
query16	0.42	0.41	0.40
query17	1.05	1.08	1.05
query18	0.22	0.20	0.21
query19	1.92	1.78	1.87
query20	0.01	0.01	0.01
query21	15.45	0.20	0.13
query22	5.09	0.07	0.05
query23	15.68	0.28	0.10
query24	2.77	0.67	1.17
query25	0.09	0.06	0.06
query26	0.15	0.14	0.15
query27	0.07	0.06	0.06
query28	5.61	1.17	0.94
query29	12.64	4.07	3.44
query30	0.29	0.14	0.13
query31	2.82	0.61	0.39
query32	3.24	0.57	0.49
query33	3.04	3.09	3.06
query34	15.91	5.23	4.55
query35	4.67	4.64	4.71
query36	0.70	0.56	0.53
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.04	0.03
query40	0.19	0.15	0.13
query41	0.10	0.04	0.04
query42	0.04	0.04	0.03
query43	0.06	0.04	0.04
Total cold run time: 100.1 s
Total hot run time: 28.3 s

@wumeibanfa

wumeibanfa commented Oct 22, 2025

Copy link
Copy Markdown
ContributorAuthor

run beut

@hello-stephen

hello-stephen commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.65% (17933/34064)
Line Coverage37.88% (162697/429462)
Region Coverage32.30% (124111/384302)
Branch Coverage33.70% (54374/161336)

@wumeibanfa

wumeibanfa commented Oct 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run p0

@wumeibanfa

wumeibanfa commented Oct 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run nonConcurrent

@hello-stephen

hello-stephen commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.34% (23859/33445)
Line Coverage57.75% (248182/429740)
Region Coverage52.91% (206129/389548)
Branch Coverage54.61% (88645/162309)

@wumeibanfa

wumeibanfa commented Oct 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run p0

@hello-stephen

hello-stephen commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.37% (23869/33445)
Line Coverage57.79% (248336/429740)
Region Coverage52.93% (206181/389548)
Branch Coverage54.64% (88692/162309)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2025
@github-actions

github-actionsBot commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zclllyybb
zclllyybb merged commit d9f3044 into apache:masterOct 26, 2025
26 of 29 checks passed
github-actionsBot pushed a commit that referenced this pull request Oct 26, 2025
@wumeibanfaYour Name
[fix] remove parse_id (#57240)
ff7c109
Related PR: #55057
Problem Summary:
Remove `parse_id`, as this method modifies the string. When using the
same string, a second call to this method will fail.
Following testing, from_hex and parse_id demonstrate identical
behaviour.
```c++
parse_id(abcd-1234) = (from_hex(abcd), from_hex(1234)) = (0xabcd, 0x1234)
parse_id(0123456789abcdef-0123456789abcdef) = (from_hex(0123456789abcdef), from_hex(0123456789abcdef)) = (0x0123456789abcdef, 0x0123456789abcdef)
```
@github-actionsgithub-actionsBot mentioned this pull request Oct 26, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 27, 2025
@github-actions@wumeibanfa
branch-4.0: [fix] remove parse_id#57240(#57330)
b74370a
Cherry-picked from #57240
Co-authored-by: admiring_xm <86338598+wumeibanfa@users.noreply.github.com>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
@wumeibanfa@dwdwqfwe
[fix] remove parse_id (apache#57240)
c6b1db9
Related PR: apache#55057
Problem Summary:
Remove `parse_id`, as this method modifies the string. When using the
same string, a second call to this method will fail.
Following testing, from_hex and parse_id demonstrate identical
behaviour.
```c++
parse_id(abcd-1234) = (from_hex(abcd), from_hex(1234)) = (0xabcd, 0x1234)
parse_id(0123456789abcdef-0123456789abcdef) = (from_hex(0123456789abcdef), from_hex(0123456789abcdef)) = (0x0123456789abcdef, 0x0123456789abcdef)
```
@morningmanmorningman mentioned this pull request Jul 15, 2026
Open
63 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.1-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wumeibanfa@hello-stephen@doris-robot@yiguolei@zclllyybb