Skip to content

branch-3.1: [fix](schema_change) fix incorrect cache usage of schema change expr leading to schema errors #56602 - #57517

Merged
morrySnow merged 2 commits into
apache:branch-3.1from
luwei16:luwei/fix-alter-expr-cache-3.1
Nov 5, 2025
Merged

branch-3.1: [fix](schema_change) fix incorrect cache usage of schema change expr leading to schema errors #56602#57517
morrySnow merged 2 commits into
apache:branch-3.1from
luwei16:luwei/fix-alter-expr-cache-3.1

Conversation

@luwei16

@luwei16luwei16 commented Oct 30, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

pick master #56602

@hello-stephen

hello-stephen commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16

luwei16 commented Oct 30, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 30, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33055 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be5f88f8916bd8c130ae02cc7c2f9038139d9b17, data reload: false
------ Round 1 ----------------------------------
q1	17592	5493	5529	5493
q2	2055	345	170	170
q3	10365	1306	731	731
q4	10209	900	503	503
q5	7713	2401	2163	2163
q6	198	169	138	138
q7	913	751	624	624
q8	9360	1492	1249	1249
q9	5243	5110	4968	4968
q10	6806	2305	1827	1827
q11	484	286	265	265
q12	346	357	221	221
q13	17785	3620	3085	3085
q14	227	245	219	219
q15	531	466	462	462
q16	426	441	381	381
q17	652	872	396	396
q18	6968	6391	6332	6332
q19	1206	977	552	552
q20	349	361	219	219
q21	3188	2308	2073	2073
q22	1037	1013	984	984
Total cold run time: 103653 ms
Total hot run time: 33055 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5614	5590	5718	5590
q2	256	348	233	233
q3	2287	2631	2376	2376
q4	1353	1851	1374	1374
q5	4471	5005	5148	5005
q6	177	170	132	132
q7	2059	1943	1832	1832
q8	2680	2844	2703	2703
q9	7244	7231	7296	7231
q10	2995	3277	2806	2806
q11	586	533	482	482
q12	673	774	623	623
q13	3395	3826	3265	3265
q14	292	315	274	274
q15	520	470	490	470
q16	454	511	445	445
q17	1246	1778	1259	1259
q18	7705	7495	7291	7291
q19	880	1207	1084	1084
q20	2046	2039	1890	1890
q21	5433	4784	4723	4723
q22	1128	1133	1050	1050
Total cold run time: 53494 ms
Total hot run time: 52138 ms

@doris-robot

doris-robot commented Oct 30, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 194594 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be5f88f8916bd8c130ae02cc7c2f9038139d9b17, data reload: false
query1	976	398	391	391
query2	6543	2062	2058	2058
query3	6703	234	236	234
query4	34258	23944	23581	23581
query5	4359	620	477	477
query6	280	197	200	197
query7	4633	531	335	335
query8	301	253	249	249
query9	9888	2856	2819	2819
query10	499	330	271	271
query11	18824	15740	15803	15740
query12	158	116	112	112
query13	1648	576	441	441
query14	11511	6748	6789	6748
query15	236	194	188	188
query16	7220	737	541	541
query17	1709	769	607	607
query18	1322	413	357	357
query19	246	205	177	177
query20	129	125	127	125
query21	212	128	111	111
query22	4552	4774	4489	4489
query23	35347	33712	33586	33586
query24	7597	2720	2672	2672
query25	542	484	429	429
query26	1224	294	179	179
query27	1987	484	369	369
query28	5245	2365	2333	2333
query29	665	642	480	480
query30	255	195	165	165
query31	984	926	807	807
query32	76	68	62	62
query33	545	385	321	321
query34	780	866	547	547
query35	816	812	757	757
query36	1061	1081	1034	1034
query37	114	99	78	78
query38	3938	3943	3937	3937
query39	1506	1492	1621	1492
query40	215	120	110	110
query41	56	54	51	51
query42	133	113	112	112
query43	559	561	498	498
query44	1378	872	873	872
query45	188	179	173	173
query46	928	1060	700	700
query47	1916	1963	1913	1913
query48	450	465	383	383
query49	826	492	416	416
query50	695	699	444	444
query51	7278	7354	7155	7155
query52	110	106	98	98
query53	247	268	194	194
query54	570	570	506	506
query55	85	85	88	85
query56	270	279	270	270
query57	1223	1247	1185	1185
query58	246	226	245	226
query59	3149	3234	3087	3087
query60	299	302	268	268
query61	122	122	118	118
query62	843	754	673	673
query63	242	205	209	205
query64	4355	1002	653	653
query65	3327	3209	3307	3209
query66	1060	414	318	318
query67	16191	15979	15700	15700
query68	7479	904	608	608
query69	487	314	279	279
query70	1304	1164	1238	1164
query71	397	304	280	280
query72	5538	3710	3888	3710
query73	697	793	395	395
query74	10170	9342	9396	9342
query75	3197	3204	2749	2749
query76	3241	1201	803	803
query77	508	382	304	304
query78	10493	10612	9663	9663
query79	2668	938	663	663
query80	650	556	461	461
query81	533	263	233	233
query82	481	125	92	92
query83	171	175	163	163
query84	248	114	86	86
query85	813	406	318	318
query86	417	326	327	326
query87	4422	4395	4308	4308
query88	5415	2651	2630	2630
query89	412	347	305	305
query90	1877	194	191	191
query91	147	149	115	115
query92	68	62	56	56
query93	1876	942	601	601
query94	697	428	309	309
query95	362	295	298	295
query96	546	644	306	306
query97	3179	3341	3164	3164
query98	238	224	205	205
query99	1343	1436	1352	1352
Total cold run time: 295924 ms
Total hot run time: 194594 ms

@doris-robot

doris-robot commented Oct 30, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be5f88f8916bd8c130ae02cc7c2f9038139d9b17, data reload: false
query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.08
query4	1.61	0.11	0.11
query5	0.50	0.52	0.51
query6	1.12	0.74	0.73
query7	0.03	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.50	0.52
query10	0.57	0.56	0.57
query11	0.16	0.12	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	0.78	0.81	0.82
query15	0.85	0.87	0.83
query16	0.41	0.38	0.39
query17	1.06	1.05	1.01
query18	0.25	0.24	0.23
query19	1.99	1.86	1.95
query20	0.02	0.02	0.01
query21	15.39	0.90	0.60
query22	0.75	0.74	0.73
query23	15.09	1.48	0.56
query24	2.94	0.89	0.84
query25	0.12	0.06	0.07
query26	0.28	0.15	0.14
query27	0.09	0.05	0.04
query28	13.75	1.07	0.45
query29	12.60	4.03	3.36
query30	0.24	0.09	0.07
query31	2.82	0.63	0.39
query32	3.23	0.55	0.48
query33	3.07	3.08	3.10
query34	16.68	5.22	4.61
query35	4.67	4.60	4.59
query36	0.65	0.53	0.49
query37	0.08	0.06	0.06
query38	0.05	0.05	0.03
query39	0.04	0.02	0.02
query40	0.16	0.15	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 103.96 s
Total hot run time: 29.34 s

@luwei16

luwei16 commented Nov 3, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@luwei16

luwei16 commented Nov 4, 2025

Copy link
Copy Markdown
ContributorAuthor

run feut

@luwei16

luwei16 commented Nov 4, 2025

Copy link
Copy Markdown
ContributorAuthor

run p0

@hello-stephen

hello-stephen commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉
Increment coverage report
Complete coverage report

@morrySnowmorrySnow changed the title [fix](schema_change) fix incorrect cache usage of schema change expr leading to schema errors (#56602)branch-3.1: [fix](schema_change) fix incorrect cache usage of schema change expr leading to schema errors #56602Nov 5, 2025
@morrySnow
morrySnow merged commit 0852d80 into apache:branch-3.1Nov 5, 2025
23 checks passed
@morrySnowmorrySnow mentioned this pull request Nov 13, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luwei16@hello-stephen@doris-robot@gavinchou@morrySnow