[Fix](funtion) Fix utc_time result when input null by linrrzqqq · Pull Request #57716 · apache/doris

linrrzqqq · 2025-11-05T04:00:09Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #57347

Problem Summary:

Before:

mysql> select utc_time(NULL);
+----------------+
| utc_time(NULL) |
+----------------+
| 00:00:00 |
+----------------+

After(throw error same with MySQL):

mysql> select utc_time(NULL);
ERROR 1105 (HY000): errCode = 2, detailMessage = UTC_TIME argument cannot be NULL.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes. [Feature](func) Support function UTC_DATE & UTC_TIME doris-website#3009

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-11-05T04:00:23Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

linrrzqqq · 2025-11-05T04:01:03Z

run buildall

zclllyybb

LGTM

doris-robot · 2025-11-05T04:30:02Z

TPC-DS: Total hot run time: 187816 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c1bb4d05006872d12bf04f4a742ec694abeba3c, data reload: false
query1	1077	409	399	399
query2	6548	1675	1744	1675
query3	6758	225	224	224
query4	26382	24153	23085	23085
query5	5897	640	453	453
query6	389	235	223	223
query7	4659	502	298	298
query8	334	257	254	254
query9	8705	2639	2625	2625
query10	570	321	288	288
query11	15650	15101	15024	15024
query12	196	121	117	117
query13	1681	550	434	434
query14	12060	9399	9375	9375
query15	253	188	173	173
query16	7756	688	539	539
query17	1422	802	726	726
query18	2107	466	361	361
query19	281	233	217	217
query20	156	141	140	140
query21	227	141	127	127
query22	4831	4723	4504	4504
query23	35065	33826	33879	33826
query24	9065	2573	2562	2562
query25	653	591	523	523
query26	1242	288	181	181
query27	2746	533	382	382
query28	4415	2261	2254	2254
query29	844	655	587	587
query30	302	247	227	227
query31	928	841	771	771
query32	82	74	70	70
query33	639	401	340	340
query34	849	885	557	557
query35	829	868	786	786
query36	1069	1041	923	923
query37	128	115	82	82
query38	3603	3631	3571	3571
query39	1495	1437	1409	1409
query40	213	123	113	113
query41	60	58	55	55
query42	124	113	110	110
query43	495	494	471	471
query44	1218	735	755	735
query45	178	182	184	182
query46	882	1013	650	650
query47	1759	1804	1777	1777
query48	395	434	324	324
query49	756	496	413	413
query50	640	681	407	407
query51	3864	3974	3870	3870
query52	105	108	100	100
query53	232	265	197	197
query54	339	285	293	285
query55	89	82	78	78
query56	326	323	291	291
query57	1170	1196	1130	1130
query58	289	274	270	270
query59	2570	2669	2493	2493
query60	344	337	319	319
query61	166	170	163	163
query62	795	729	668	668
query63	224	198	199	198
query64	4444	1177	853	853
query65	4063	3957	3942	3942
query66	1033	426	325	325
query67	15380	15375	14950	14950
query68	8558	921	593	593
query69	527	310	280	280
query70	1344	1265	1223	1223
query71	510	345	311	311
query72	5840	2684	5378	2684
query73	791	761	358	358
query74	8818	8861	8861	8861
query75	4051	3351	2785	2785
query76	3869	1158	719	719
query77	802	416	311	311
query78	9605	9721	8973	8973
query79	1480	848	579	579
query80	660	581	501	501
query81	476	254	228	228
query82	451	161	134	134
query83	281	273	250	250
query84	302	108	98	98
query85	891	498	446	446
query86	347	306	295	295
query87	3773	3673	3625	3625
query88	2784	2229	2197	2197
query89	384	337	291	291
query90	2047	210	206	206
query91	164	162	142	142
query92	83	68	63	63
query93	1129	1011	641	641
query94	699	457	335	335
query95	390	318	312	312
query96	483	559	269	269
query97	2960	2980	2889	2889
query98	233	220	220	220
query99	1421	1430	1316	1316
Total cold run time: 280199 ms
Total hot run time: 187816 ms

github-actions · 2025-11-05T04:30:40Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-11-05T04:30:42Z

PR approved by anyone and no changes requested.

doris-robot · 2025-11-05T04:35:04Z

ClickBench: Total hot run time: 27.55 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c1bb4d05006872d12bf04f4a742ec694abeba3c, data reload: false
query1	0.06	0.04	0.04
query2	0.09	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.11
query5	0.27	0.26	0.25
query6	1.19	0.64	0.64
query7	0.03	0.03	0.03
query8	0.06	0.05	0.04
query9	0.59	0.53	0.53
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.16	0.12	0.11
query13	0.62	0.61	0.61
query14	0.99	1.00	1.00
query15	0.85	0.83	0.85
query16	0.40	0.39	0.39
query17	1.04	1.06	1.05
query18	0.22	0.21	0.20
query19	1.87	1.84	1.81
query20	0.01	0.01	0.01
query21	15.47	0.19	0.13
query22	4.99	0.06	0.04
query23	15.67	0.25	0.10
query24	2.76	0.57	0.44
query25	0.08	0.07	0.06
query26	0.14	0.13	0.14
query27	0.07	0.06	0.05
query28	4.85	1.12	0.93
query29	12.56	3.86	3.28
query30	0.28	0.14	0.12
query31	2.81	0.59	0.38
query32	3.23	0.55	0.47
query33	2.99	2.99	3.09
query34	15.80	5.17	4.58
query35	4.54	4.56	4.55
query36	0.68	0.50	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.04
query40	0.17	0.15	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.5 s
Total hot run time: 27.55 s

hello-stephen · 2025-11-05T05:06:47Z

FE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉
Increment coverage report
Complete coverage report

linrrzqqq · 2025-11-05T07:25:59Z

run buildall

doris-robot · 2025-11-05T08:09:06Z

TPC-DS: Total hot run time: 189995 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0ce8fb867802bbaac003948b3ebabd7407a0c2dc, data reload: false
query1	1106	403	399	399
query2	6558	1699	1714	1699
query3	6753	231	221	221
query4	26209	23680	23370	23370
query5	5188	656	481	481
query6	343	258	233	233
query7	4656	510	303	303
query8	317	283	275	275
query9	8758	2616	2602	2602
query10	539	342	303	303
query11	15257	15159	14777	14777
query12	198	120	116	116
query13	1704	579	465	465
query14	11309	9417	9518	9417
query15	251	194	183	183
query16	7775	695	536	536
query17	1481	763	607	607
query18	2057	478	362	362
query19	229	230	186	186
query20	143	127	130	127
query21	216	132	121	121
query22	4596	4633	4504	4504
query23	34977	33643	33632	33632
query24	8916	2472	2525	2472
query25	596	519	493	493
query26	1347	302	175	175
query27	3185	561	369	369
query28	4390	2306	2230	2230
query29	786	662	487	487
query30	306	229	209	209
query31	967	885	792	792
query32	92	77	69	69
query33	610	410	340	340
query34	820	900	542	542
query35	826	920	790	790
query36	1021	1046	917	917
query37	140	115	92	92
query38	3737	3669	3532	3532
query39	1466	1396	1409	1396
query40	216	131	117	117
query41	61	57	55	55
query42	124	109	112	109
query43	481	498	478	478
query44	1269	736	738	736
query45	184	174	177	174
query46	898	1006	644	644
query47	1745	1784	1736	1736
query48	396	448	328	328
query49	770	513	425	425
query50	660	695	409	409
query51	3913	3907	3862	3862
query52	106	107	104	104
query53	242	277	201	201
query54	315	297	278	278
query55	87	87	83	83
query56	313	330	319	319
query57	1162	1203	1129	1129
query58	303	281	281	281
query59	2592	2694	2581	2581
query60	373	374	379	374
query61	191	192	186	186
query62	776	731	667	667
query63	237	198	200	198
query64	4537	1257	958	958
query65	4028	3984	4001	3984
query66	1096	459	339	339
query67	15394	15133	14963	14963
query68	8340	944	598	598
query69	516	334	308	308
query70	1335	1309	1301	1301
query71	494	346	316	316
query72	5880	4914	4859	4859
query73	672	593	357	357
query74	9242	8847	8779	8779
query75	4004	3427	2812	2812
query76	3668	1158	747	747
query77	826	429	309	309
query78	9603	9749	8919	8919
query79	2019	876	617	617
query80	652	602	498	498
query81	510	267	230	230
query82	427	169	132	132
query83	287	268	243	243
query84	258	117	91	91
query85	897	483	434	434
query86	346	312	293	293
query87	3699	3722	3702	3702
query88	3748	2264	2247	2247
query89	395	333	293	293
query90	2040	224	226	224
query91	169	168	132	132
query92	78	66	60	60
query93	1366	971	642	642
query94	696	443	349	349
query95	407	323	310	310
query96	491	589	292	292
query97	2955	2986	2871	2871
query98	242	214	208	208
query99	1661	1507	1280	1280
Total cold run time: 280217 ms
Total hot run time: 189995 ms

doris-robot · 2025-11-05T08:14:13Z

ClickBench: Total hot run time: 27.42 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0ce8fb867802bbaac003948b3ebabd7407a0c2dc, data reload: false
query1	0.05	0.05	0.05
query2	0.09	0.04	0.05
query3	0.24	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.26	0.25
query6	1.17	0.66	0.64
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.61	0.52	0.53
query10	0.57	0.58	0.56
query11	0.16	0.11	0.11
query12	0.16	0.12	0.13
query13	0.61	0.61	0.61
query14	1.01	1.00	1.00
query15	0.84	0.82	0.82
query16	0.39	0.39	0.42
query17	1.03	1.05	1.00
query18	0.21	0.20	0.20
query19	1.95	1.84	1.74
query20	0.02	0.02	0.02
query21	15.45	0.17	0.13
query22	5.19	0.06	0.05
query23	15.67	0.25	0.10
query24	2.94	1.14	0.42
query25	0.08	0.06	0.05
query26	0.15	0.14	0.14
query27	0.08	0.05	0.06
query28	4.78	1.12	0.93
query29	12.58	3.89	3.21
query30	0.28	0.13	0.12
query31	2.82	0.61	0.39
query32	3.24	0.55	0.47
query33	3.09	3.06	3.05
query34	15.87	5.15	4.54
query35	4.53	4.61	4.60
query36	0.67	0.49	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.14	0.15
query41	0.09	0.04	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.04
Total cold run time: 99.01 s
Total hot run time: 27.42 s

hello-stephen · 2025-11-05T08:40:38Z

FE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉
Increment coverage report
Complete coverage report

github-actions · 2025-11-05T10:50:46Z

PR approved by at least one committer and no changes requested.

Related PR: #57347 Before: ```text mysql> select utc_time(NULL); +----------------+ | utc_time(NULL) | +----------------+ | 00:00:00 | +----------------+ ``` After(throw error same with MySQL): ```text mysql> select utc_time(NULL); ERROR 1105 (HY000): errCode = 2, detailMessage = UTC_TIME argument cannot be NULL. ```

…#57738) Cherry-picked from #57716 Co-authored-by: linrrarity <linzhenqi@selectdb.com>

Related PR: apache#57347 Before: ```text mysql> select utc_time(NULL); +----------------+ | utc_time(NULL) | +----------------+ | 00:00:00 | +----------------+ ``` After(throw error same with MySQL): ```text mysql> select utc_time(NULL); ERROR 1105 (HY000): errCode = 2, detailMessage = UTC_TIME argument cannot be NULL. ```

[Fix](funtion) Fix utc_time result when input null
7c1bb4d

zclllyybb self-assigned this Nov 5, 2025

zclllyybb added the dev/4.0.x label Nov 5, 2025

zclllyybb previously approved these changes Nov 5, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2025

github-actionsBot added the reviewed label Nov 5, 2025

zhangstar333 previously approved these changes Nov 5, 2025
View reviewed changes

fix err_msg
0ce8fb8

linrrzqqq dismissed stale reviews from zhangstar333 and zclllyybb via 0ce8fb8November 5, 2025 07:23

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 5, 2025

zclllyybb approved these changes Nov 5, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2025

zhangstar333 approved these changes Nov 5, 2025
View reviewed changes

zclllyybb merged commit 5285135 into apache:masterNov 5, 2025
29 checks passed

github-actionsBot mentioned this pull request Nov 5, 2025
branch-4.0: [Fix](funtion) Fix utc_time result when input null #57716 #57738
Merged

yiguolei pushed a commit that referenced this pull request Nov 5, 2025
branch-4.0: [Fix](funtion) Fix utc_time result when input null#57716(…
320ed77
…#57738) Cherry-picked from #57716 Co-authored-by: linrrarity <linzhenqi@selectdb.com>

yiguolei added dev/4.0.2-merged and removed dev/4.0.x labels Nov 5, 2025

linrrzqqq deleted the period-fix branch November 6, 2025 03:40

CalvinKirs mentioned this pull request Dec 1, 2025
branch-4.0: [fix](paimon)Support user-defined S3 config prefixes and unify to HDFS S3A protocol #57116 #58544
Merged

yiguolei mentioned this pull request Dec 2, 2025
4.0.2 Release Notes #58605
Closed

Uh oh!

Conversation

linrrzqqq commented Nov 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Nov 5, 2025

Uh oh!

linrrzqqq commented Nov 5, 2025

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Nov 5, 2025

Uh oh!

github-actionsBot commented Nov 5, 2025

Uh oh!

github-actionsBot commented Nov 5, 2025

Uh oh!

doris-robot commented Nov 5, 2025

Uh oh!

hello-stephen commented Nov 5, 2025

FE UT Coverage Report

Uh oh!

linrrzqqq commented Nov 5, 2025

Uh oh!

doris-robot commented Nov 5, 2025

Uh oh!

doris-robot commented Nov 5, 2025

Uh oh!

hello-stephen commented Nov 5, 2025

FE UT Coverage Report

Uh oh!

github-actionsBot commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

linrrzqqq commented Nov 5, 2025•
edited
Loading