Uh oh!
There was an error while loading. Please reload this page.
[chore](dep)Upgrade Shade - #58071
Merged
Merged
Conversation
Thearas
commented
Nov 17, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
CalvinKirs
commented
Nov 17, 2025
MemberAuthor
run buildall |
CalvinKirs
commented
Nov 17, 2025
MemberAuthor
run buildall |
1 similar comment
CalvinKirs
commented
Nov 17, 2025
MemberAuthor
run buildall |
CalvinKirs
commented
Nov 17, 2025
MemberAuthor
run buildall |
CalvinKirs
commented
Nov 17, 2025
MemberAuthor
run buildall |
doris-robot
commented
Nov 17, 2025
TPC-H: Total hot run time: 34202 ms |
doris-robot
commented
Nov 17, 2025
TPC-DS: Total hot run time: 187822 ms |
doris-robot
commented
Nov 17, 2025
ClickBench: Total hot run time: 27.91 s |
CalvinKirs
commented
Nov 19, 2025
MemberAuthor
run buildall |
doris-robot
commented
Nov 19, 2025
TPC-H: Total hot run time: 33709 ms |
doris-robot
commented
Nov 19, 2025
TPC-DS: Total hot run time: 188119 ms |
doris-robot
commented
Nov 19, 2025
ClickBench: Total hot run time: 27.71 s |
CalvinKirs
commented
Nov 21, 2025
MemberAuthor
run buildall |
doris-robot
commented
Nov 21, 2025
TPC-H: Total hot run time: 35746 ms |
doris-robot
commented
Nov 21, 2025
TPC-DS: Total hot run time: 187053 ms |
doris-robot
commented
Nov 21, 2025
ClickBench: Total hot run time: 27.44 s |
hello-stephen
commented
Nov 21, 2025
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
CalvinKirs
commented
Nov 24, 2025
MemberAuthor
run buildall |
doris-robot
commented
Nov 24, 2025
TPC-H: Total hot run time: 34091 ms |
doris-robot
commented
Nov 24, 2025
TPC-DS: Total hot run time: 186847 ms |
morningman
approved these changes
Nov 28, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
CalvinKirs
commented
Dec 1, 2025
MemberAuthor
run buildall |
doris-robot
commented
Dec 1, 2025
TPC-H: Total hot run time: 34300 ms |
doris-robot
commented
Dec 1, 2025
TPC-DS: Total hot run time: 182052 ms |
doris-robot
commented
Dec 1, 2025
ClickBench: Total hot run time: 27.25 s |
zy-kkk
approved these changes
Dec 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Dec 1, 2025
### Upgrade Shade ### make the COS and OBS modules optional allowing us to skip them during the build with a flag such as -exclude-cos-dependencies since those modules contain unresolved supply-chain security issues upstream.
github-actionsBot
pushed a commit
that referenced
this pull request
Dec 1, 2025
### Upgrade Shade ### make the COS and OBS modules optional allowing us to skip them during the build with a flag such as -exclude-cos-dependencies since those modules contain unresolved supply-chain security issues upstream.
yiguolei pushed a commit
that referenced
this pull request
Dec 2, 2025
morrySnow pushed a commit
that referenced
this pull request
Dec 2, 2025
nagisa-kunhah pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
### Upgrade Shade ### make the COS and OBS modules optional allowing us to skip them during the build with a flag such as -exclude-cos-dependencies since those modules contain unresolved supply-chain security issues upstream.
yiguolei pushed a commit
that referenced
this pull request
Aug 12, 2026
…s}-dependencies (#66564) ## What Turn the existing `--exclude-obs-dependencies` and `--exclude-cos-dependencies` build flags into a **full exclusion** of the respective cloud provider (Huawei OBS / Tencent COS): when passed, nothing from that provider is resolved, compiled, or bundled into the FE binary. ## Why The two flags were introduced in #58071 as a `scope=provided` downgrade. That only kept the jars out of the shipped artifact — Maven **still resolved and downloaded** them at build time. In particular `com.huaweicloud:hadoop-huaweicloud:3.1.1-hw-46` is published **only** on Huawei's own Maven repo (`repo.huaweicloud.com`). Environments that cannot or must not reach it (corporate proxies blocking the host, or compliance constraints forbidding Huawei/Tencent artifacts) still could not build the FE, because resolution was unconditional. The flags now do what their names imply. ## How Active-by-default Maven profiles `obs` / `cos`, deactivated via `-Ddisable.obs=true` / `-Ddisable.cos=true`, wrap every touch point: - **fe-core**: the `fe-filesystem-obs` / `fe-filesystem-cos` test couplings. - **hadoop-deps**: the `hadoop-huaweicloud` dependency and the Huawei OBS Maven repository. - **fe-filesystem**: the `fe-filesystem-obs` / `fe-filesystem-cos` modules (which transitively pull the Huawei / Tencent SDKs). `build.sh` maps `--exclude-obs-dependencies` → `-Ddisable.obs=true` and `--exclude-cos-dependencies` → `-Ddisable.cos=true` (replacing the old `*.dependency.scope=provided` mapping), and drops the corresponding provider from **both** the `-pl` reactor list **and** the filesystem plugin packaging loop, so the reactor and the dist layout stay consistent when a provider is excluded. ## Behaviour - **Default builds are unchanged** — the profiles are active unless a flag is passed. - `sh build.sh --fe --exclude-obs-dependencies` builds the FE with no Huawei artifact resolved and no OBS code compiled or bundled; same for `--exclude-cos-dependencies` and Tencent COS. ## Testing - `mvn help:active-profiles` on `fe-core`, `fe-filesystem`, and `hadoop-deps`: `obs`/`cos` active by default, and absent with `-Ddisable.obs=true` / `-Ddisable.cos=true`. - Confirmed fe-core has no compile-time import of the OBS/COS provider classes (loaded via SPI/reflection), so `compile` and `test-compile` stay green when the profiles are off. - `xmllint` on all changed poms and `bash -n build.sh` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wyxxxcat pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 17, 2026
…s}-dependencies (apache#66564) ## What Turn the existing `--exclude-obs-dependencies` and `--exclude-cos-dependencies` build flags into a **full exclusion** of the respective cloud provider (Huawei OBS / Tencent COS): when passed, nothing from that provider is resolved, compiled, or bundled into the FE binary. ## Why The two flags were introduced in apache#58071 as a `scope=provided` downgrade. That only kept the jars out of the shipped artifact — Maven **still resolved and downloaded** them at build time. In particular `com.huaweicloud:hadoop-huaweicloud:3.1.1-hw-46` is published **only** on Huawei's own Maven repo (`repo.huaweicloud.com`). Environments that cannot or must not reach it (corporate proxies blocking the host, or compliance constraints forbidding Huawei/Tencent artifacts) still could not build the FE, because resolution was unconditional. The flags now do what their names imply. ## How Active-by-default Maven profiles `obs` / `cos`, deactivated via `-Ddisable.obs=true` / `-Ddisable.cos=true`, wrap every touch point: - **fe-core**: the `fe-filesystem-obs` / `fe-filesystem-cos` test couplings. - **hadoop-deps**: the `hadoop-huaweicloud` dependency and the Huawei OBS Maven repository. - **fe-filesystem**: the `fe-filesystem-obs` / `fe-filesystem-cos` modules (which transitively pull the Huawei / Tencent SDKs). `build.sh` maps `--exclude-obs-dependencies` → `-Ddisable.obs=true` and `--exclude-cos-dependencies` → `-Ddisable.cos=true` (replacing the old `*.dependency.scope=provided` mapping), and drops the corresponding provider from **both** the `-pl` reactor list **and** the filesystem plugin packaging loop, so the reactor and the dist layout stay consistent when a provider is excluded. ## Behaviour - **Default builds are unchanged** — the profiles are active unless a flag is passed. - `sh build.sh --fe --exclude-obs-dependencies` builds the FE with no Huawei artifact resolved and no OBS code compiled or bundled; same for `--exclude-cos-dependencies` and Tencent COS. ## Testing - `mvn help:active-profiles` on `fe-core`, `fe-filesystem`, and `hadoop-deps`: `obs`/`cos` active by default, and absent with `-Ddisable.obs=true` / `-Ddisable.cos=true`. - Confirmed fe-core has no compile-time import of the OBS/COS provider classes (loaded via SPI/reflection), so `compile` and `test-compile` stay green when the profiles are off. - `xmllint` on all changed poms and `bash -n build.sh` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Shade
make the COS and OBS modules optional
allowing us to skip them during the build with a flag such as -exclude-cos-dependencies since those modules contain unresolved supply-chain security issues upstream.