Skip to content

[branch-3.0][fix](cloud) avoid broadcast remote read in topn query [pick#58044] - #58116

Closed
freemandealer wants to merge 3 commits into
apache:branch-3.0from
freemandealer:3.0-pick-58044
Closed

[branch-3.0][fix](cloud) avoid broadcast remote read in topn query [pick#58044]#58116
freemandealer wants to merge 3 commits into
apache:branch-3.0from
freemandealer:3.0-pick-58044

Conversation

@freemandealer

@freemandealerfreemandealer commented Nov 18, 2025

Copy link
Copy Markdown
Member

Topn lazy read only read the cache in cloud mode to reduce tablet cache read.
fix#50803 failed to pass force_use_only_cached to tablet_mgr

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](cloud) reduce tablet cache read in topn query
4d38816
Topn lazy read only read the cache in cloud mode to reduce tablet cache read.
fixapache#50803 failed to pass force_use_only_cached to tablet_mgr
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer
add regression
a7f94a4
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas

Thearas commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

freemandealer commented Nov 18, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

hello-stephen commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 30.00% (3/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage42.10% (11245/26712)
Line Coverage32.62% (96271/295085)
Region Coverage30.56% (55281/180897)
Branch Coverage26.89% (27371/101786)

@hello-stephen

hello-stephen commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 70.00% (7/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage75.06% (19705/26253)
Line Coverage68.31% (201037/294306)
Region Coverage66.41% (120320/181167)
Branch Coverage59.74% (61041/102182)

@freemandealer
share dataset
56fbdda
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer

freemandealer commented Nov 18, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Nov 18, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 30.00% (3/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage42.09% (11242/26712)
Line Coverage32.61% (96240/295085)
Region Coverage30.55% (55273/180897)
Branch Coverage26.88% (27355/101786)

@hello-stephen

hello-stephen commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 70.00% (7/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage74.72% (19617/26253)
Line Coverage67.92% (199902/294306)
Region Coverage65.98% (119529/181167)
Branch Coverage59.42% (60719/102182)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2025
@github-actions

github-actionsBot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@freemandealer

freemandealer commented Nov 24, 2025

Copy link
Copy Markdown
MemberAuthor

run nonConcurrent

@hello-stephen

hello-stephen commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 70.00% (7/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage75.05% (19704/26253)
Line Coverage68.33% (201113/294306)
Region Coverage66.43% (120341/181167)
Branch Coverage59.79% (61094/102182)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@lide-reedlide-reedAwaiting requested review from lide-reedlide-reed is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@freemandealer@Thearas@hello-stephen@doris-robot@gavinchou