Skip to content

[fix](nereids)PushDownJoinOnAssertNumRows rule process project alias bug - #58174

Merged
englefly merged 2 commits into
apache:masterfrom
englefly:fix23300
Nov 24, 2025
Merged

[fix](nereids)PushDownJoinOnAssertNumRows rule process project alias bug#58174
englefly merged 2 commits into
apache:masterfrom
englefly:fix23300

Conversation

@englefly

@engleflyenglefly commented Nov 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

pr #57414 will generate error project: LogicalProject(a as b, b as c), in which 'b as c' is not correct, because 'b' is not in output of project.child()
pr #57804 fixed above issue, but made another issue, that is when the bottom project is not resued in result plan, some aliases definitions are lost.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
englefly marked this pull request as draft November 20, 2025 05:56
@englefly
englefly marked this pull request as ready for review November 20, 2025 07:05
@englefly

englefly commented Nov 20, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 72.22% (13/18) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 72.22% (13/18) 🎉
Increment coverage report
Complete coverage report

@englefly

englefly commented Nov 21, 2025

Copy link
Copy Markdown
ContributorAuthor

run performance

@doris-robot

doris-robot commented Nov 21, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 35024 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bdb3d6d2499a78e90a477f29a0374fc8727661c5, data reload: false
------ Round 1 ----------------------------------
q1	17618	5060	4903	4903
q2	2174	314	215	215
q3	10083	1257	715	715
q4	10234	928	374	374
q5	7544	2346	2354	2346
q6	182	167	134	134
q7	923	781	629	629
q8	9360	1330	1162	1162
q9	6955	5351	5404	5351
q10	6845	2205	1789	1789
q11	515	297	283	283
q12	327	365	215	215
q13	18479	3659	3060	3060
q14	229	239	216	216
q15	601	511	507	507
q16	1026	992	942	942
q17	573	850	359	359
q18	7380	7520	7573	7520
q19	1265	990	610	610
q20	374	345	230	230
q21	4016	3450	2431	2431
q22	1120	1069	1033	1033
Total cold run time: 107823 ms
Total hot run time: 35024 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5348	5193	5237	5193
q2	336	400	319	319
q3	2378	3058	2383	2383
q4	1404	1771	1437	1437
q5	4522	4470	4397	4397
q6	205	163	122	122
q7	1916	1915	1768	1768
q8	2622	2538	2495	2495
q9	7823	7462	7600	7462
q10	3028	3272	2634	2634
q11	547	496	492	492
q12	617	720	596	596
q13	3212	3641	2994	2994
q14	273	287	279	279
q15	532	488	480	480
q16	1009	1052	1005	1005
q17	1069	1418	1321	1321
q18	7314	7118	7071	7071
q19	732	803	834	803
q20	1881	1950	1862	1862
q21	4736	4330	4227	4227
q22	1065	1046	997	997
Total cold run time: 52569 ms
Total hot run time: 50337 ms

@doris-robot

doris-robot commented Nov 21, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 186824 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bdb3d6d2499a78e90a477f29a0374fc8727661c5, data reload: false
query1	1055	425	385	385
query2	6591	1679	1687	1679
query3	6749	223	220	220
query4	26033	23061	23086	23061
query5	4399	611	478	478
query6	334	241	218	218
query7	4645	495	301	301
query8	308	256	243	243
query9	8726	2561	2580	2561
query10	475	347	294	294
query11	15453	15043	14875	14875
query12	172	118	111	111
query13	1683	575	468	468
query14	10293	9183	9166	9166
query15	199	186	176	176
query16	7299	713	531	531
query17	1276	790	678	678
query18	1983	404	313	313
query19	204	203	172	172
query20	136	119	121	119
query21	217	130	111	111
query22	3948	4087	3990	3990
query23	33963	32991	32865	32865
query24	8457	2336	2400	2336
query25	580	503	455	455
query26	1253	266	157	157
query27	2765	495	360	360
query28	4366	2171	2141	2141
query29	843	606	470	470
query30	303	231	196	196
query31	883	785	739	739
query32	88	79	69	69
query33	587	386	337	337
query34	789	846	522	522
query35	806	820	748	748
query36	948	988	919	919
query37	145	103	84	84
query38	3509	3535	3413	3413
query39	1506	1424	1430	1424
query40	228	128	116	116
query41	65	60	61	60
query42	123	114	113	113
query43	479	501	462	462
query44	1220	761	757	757
query45	179	176	173	173
query46	880	979	635	635
query47	1750	1798	1686	1686
query48	405	412	334	334
query49	758	480	391	391
query50	644	677	417	417
query51	3913	3897	3964	3897
query52	114	116	103	103
query53	248	266	196	196
query54	316	294	288	288
query55	87	87	81	81
query56	332	329	317	317
query57	1155	1182	1115	1115
query58	288	264	288	264
query59	2555	2662	2523	2523
query60	348	331	336	331
query61	163	184	159	159
query62	779	716	659	659
query63	233	188	195	188
query64	4550	1131	855	855
query65	4003	3899	3921	3899
query66	1186	447	340	340
query67	15046	15084	14776	14776
query68	4626	944	631	631
query69	492	318	291	291
query70	1243	1207	1311	1207
query71	416	350	309	309
query72	5968	5040	5009	5009
query73	644	587	365	365
query74	8874	9041	8691	8691
query75	3338	3345	2854	2854
query76	3212	1162	733	733
query77	552	400	320	320
query78	9506	9617	8856	8856
query79	2039	822	590	590
query80	978	612	576	576
query81	549	260	227	227
query82	450	168	134	134
query83	280	258	259	258
query84	260	109	89	89
query85	907	473	431	431
query86	425	341	270	270
query87	3737	3671	3651	3651
query88	2886	2249	2222	2222
query89	382	319	297	297
query90	1931	216	216	216
query91	172	162	135	135
query92	89	65	65	65
query93	2261	978	673	673
query94	787	432	311	311
query95	402	321	324	321
query96	484	570	285	285
query97	2908	2935	2838	2838
query98	240	223	207	207
query99	1351	1382	1242	1242
Total cold run time: 268405 ms
Total hot run time: 186824 ms

@doris-robot

doris-robot commented Nov 21, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bdb3d6d2499a78e90a477f29a0374fc8727661c5, data reload: false
query1	0.06	0.04	0.04
query2	0.09	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.10
query5	0.27	0.25	0.25
query6	1.17	0.66	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.58	0.52	0.52
query10	0.57	0.57	0.58
query11	0.17	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.61
query14	1.00	0.99	0.99
query15	0.85	0.83	0.84
query16	0.38	0.39	0.39
query17	1.02	1.05	1.03
query18	0.21	0.21	0.20
query19	1.95	1.81	1.76
query20	0.02	0.01	0.02
query21	15.43	0.20	0.13
query22	4.82	0.07	0.05
query23	15.66	0.25	0.09
query24	2.66	0.66	0.41
query25	0.07	0.06	0.07
query26	0.15	0.14	0.14
query27	0.06	0.05	0.06
query28	4.00	1.15	0.93
query29	12.60	3.94	3.17
query30	0.28	0.14	0.11
query31	2.81	0.58	0.39
query32	3.22	0.55	0.46
query33	3.08	3.00	3.10
query34	15.99	5.14	4.60
query35	4.58	4.52	4.56
query36	0.69	0.51	0.49
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.71 s
Total hot run time: 27.31 s

@github-actions

github-actionsBot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 24, 2025
@github-actions

github-actionsBot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@englefly
englefly merged commit 7c176af into apache:masterNov 24, 2025
28 of 29 checks passed
@englefly
englefly deleted the fix23300 branch November 24, 2025 07:16
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@englefly@nagisa-kunhah
[fix](nereids)PushDownJoinOnAssertNumRows rule process project alias …
32b294b
…bug (apache#58174)
### What problem does this PR solve?
pr apache#57414 will generate error project: LogicalProject(a as b, b as c),
in which 'b as c' is not correct, because 'b' is not in output of
project.child()
pr apache#57804 fixed above issue, but made another issue, that is when the
bottom project is not resued in result plan, some aliases definitions
are lost.
@engleflyenglefly mentioned this pull request Mar 18, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Mar 19, 2026
@englefly
branch-4.1 [opt](nereids)push down assert one row join#57414(#61484)
e2e8661
### What problem does this PR solve?
pick #57414#57804#58174
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
+1 more reviewer
@feiniaofeiafeifeiniaofeiafeifeiniaofeiafei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@englefly@Thearas@hello-stephen@doris-robot@starocean999@feiniaofeiafei@yiguolei@morrySnow