Uh oh!
There was an error while loading. Please reload this page.
[refactor](predicate) Refine column predicates on OLAP table - #58582
Conversation
Thearas
commented
Dec 1, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
f89b74e to
db045adCompareGabriel39
commented
Dec 2, 2025
run buildall |
1 similar comment
Gabriel39
commented
Dec 3, 2025
run buildall |
doris-robot
commented
Dec 3, 2025
TPC-H: Total hot run time: 35134 ms |
Gabriel39
commented
Dec 3, 2025
run buildall |
| struct DeleteConditions { | ||
| int64_t filter_version = 0; // The version of this condition | ||
| std::vector<const ColumnPredicate*> column_predicate_vec; | ||
| std::vector<std::shared_ptr<ColumnPredicate>> column_predicate_vec; |
There was a problem hiding this comment.
std::vector must have a non-const, non-volatile value_type
There was a problem hiding this comment.
std::vector<std::shared_ptr> 我们应该是这个结构,感觉是可以的吧?
Gabriel39
commented
Dec 3, 2025
run buildall |
Uh oh!
There was an error while loading. Please reload this page.
doris-robot
commented
Dec 3, 2025
TPC-H: Total hot run time: 35912 ms |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Gabriel39
commented
Dec 4, 2025
run buildall |
doris-robot
commented
Dec 4, 2025
TPC-H: Total hot run time: 36922 ms |
doris-robot
commented
Dec 4, 2025
TPC-DS: Total hot run time: 171944 ms |
Gabriel39
commented
Dec 4, 2025
run buildall |
doris-robot
commented
Dec 4, 2025
TPC-DS: Total hot run time: 171095 ms |
doris-robot
commented
Dec 4, 2025
ClickBench: Total hot run time: 27.71 s |
doris-robot
commented
Dec 8, 2025
TPC-DS: Total hot run time: 0 ms |
Gabriel39
commented
Dec 8, 2025
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
doris-robot
commented
Dec 8, 2025
TPC-H: Total hot run time: 36232 ms |
doris-robot
commented
Dec 8, 2025
TPC-DS: Total hot run time: 180953 ms |
doris-robot
commented
Dec 8, 2025
ClickBench: Total hot run time: 27.21 s |
Gabriel39
commented
Dec 8, 2025
run buildall |
doris-robot
commented
Dec 8, 2025
TPC-H: Total hot run time: 36329 ms |
doris-robot
commented
Dec 8, 2025
TPC-DS: Total hot run time: 181928 ms |
doris-robot
commented
Dec 8, 2025
ClickBench: Total hot run time: 27.3 s |
hello-stephen
commented
Dec 8, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
shuke987
commented
Dec 9, 2025
skip buildall |
Uh oh!
There was an error while loading. Please reload this page.
| return BloomFilterColumnPredicate<TYPE_IPV6>::create_shared(cid, filter_olap); | ||
| } | ||
| default: | ||
| return nullptr; |
There was a problem hiding this comment.
Should also throw Exception here?
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)