Skip to content

[fix](orc-reader) Fix Orc row reader nextBatch failed. reason = unordered_map.at() - #58719

Merged
morningman merged 1 commit into
apache:masterfrom
kaka11chen:fix_orc_prune_nested_column
Dec 8, 2025
Merged

[fix](orc-reader) Fix Orc row reader nextBatch failed. reason = unordered_map.at()#58719
morningman merged 1 commit into
apache:masterfrom
kaka11chen:fix_orc_prune_nested_column

Conversation

@kaka11chen

@kaka11chenkaka11chen commented Dec 4, 2025•
edited by morningman
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Followup #57204

Release note

Fix row_index position unordered_map.at() crash becauseRowReaderOptions::filteris uninitialized.
orc third-party changed: apache/doris-thirdparty#370

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen

kaka11chen commented Dec 4, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Dec 4, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.34% (18632/34931)
Line Coverage39.00% (172061/441192)
Region Coverage33.61% (133231/396420)
Branch Coverage34.57% (57341/165883)

@hello-stephen

hello-stephen commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage72.25% (24749/34253)
Line Coverage58.95% (259879/440813)
Region Coverage53.93% (216395/401240)
Branch Coverage55.44% (92460/166782)

@kaka11chen
kaka11chenforce-pushed the fix_orc_prune_nested_column branch from fe4f1d8 to 81a432cCompareDecember 5, 2025 12:01
@kaka11chen

kaka11chen commented Dec 5, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@kaka11chen
kaka11chen marked this pull request as ready for review December 5, 2025 12:05
CopilotAI review requested due to automatic review settings December 5, 2025 12:05
CopilotAI reviewed Dec 5, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a crash in the ORC row reader caused by an uninitialized RowReaderOptions::filter leading to an unordered_map.at() exception when accessing row_index positions. The fix is implemented by updating the apache-orc submodule to a newer commit that properly initializes the filter.

  • Updates the apache-orc submodule to commit c0a2043f07115c4209abd49fba88ac1c7c084a12
  • Resolves the unordered_map.at() crash in ORC row reader's nextBatch operation
  • Aligns with corresponding changes in doris-thirdparty repository

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hello-stephen

hello-stephen commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.24% (18624/34981)
Line Coverage38.92% (171804/441398)
Region Coverage33.59% (133145/396392)
Branch Coverage34.49% (57218/165875)

@hello-stephen

hello-stephen commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.01% (25044/34303)
Line Coverage60.10% (265068/441032)
Region Coverage55.66% (223317/401206)
Branch Coverage56.89% (94873/166774)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 8, 2025
@github-actions

github-actionsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.07% (25066/34303)
Line Coverage60.18% (265402/441032)
Region Coverage55.83% (223995/401206)
Branch Coverage57.01% (95081/166774)

@morningman
morningman merged commit cec55cd into apache:masterDec 8, 2025
35 of 37 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@kaka11chen@nagisa-kunhah
[fix](orc-reader) Fix Orc row reader nextBatch failed. reason = unord…
b096fc8
…ered_map.at() (apache#58719)
Fix row_index position unordered_map.at() crash because`
RowReaderOptions::filter `is uninitialized.
orc third-party changed:
apache/doris-thirdparty#370
This was referenced Dec 22, 2025
Closed
Merged
yiguolei pushed a commit that referenced this pull request Dec 24, 2025
@kaka11chen@924060929
@mrhhsg@eldenmoon
[feature](reader) Optimize Complex Type Column Reading with Column Pu…
eea2586
…rning (#59286)
### What problem does this PR solve?
Problem Summary:
### Release note
Cherry-pick #58370#58354#59043#58851#58485#58682#58614#58373#57204#58719#58471#58573#58657
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---------
Co-authored-by: 924060929 <lanhuajian@selectdb.com>
Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
Co-authored-by: lihangyu <lihangyu@selectdb.com>
@kaka11chenkaka11chen mentioned this pull request Jan 4, 2026
Merged
16 tasks
zclllyybb pushed a commit that referenced this pull request Jan 4, 2026
@kaka11chen
[fix](orc-reader) Fix Orc row reader nextBatch failed. reason = unord…
3203add
…ered_map.at(). (#59527)
### What problem does this PR solve?
Problem Summary:
### Release note
Cherry-pick #58719
zclllyybb pushed a commit to zclllyybb/doris that referenced this pull request Feb 9, 2026
@kaka11chen@zclllyybb
[fix](orc-reader) Fix Orc row reader nextBatch failed. reason = unord…
8d896a6
…ered_map.at(). (apache#59527)
### What problem does this PR solve?
Problem Summary:
### Release note
Cherry-pick apache#58719
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@morningmanmorningmanmorningman approved these changes
@CalvinKirsCalvinKirsCalvinKirs approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaka11chen@hello-stephen@doris-robot@morningman@CalvinKirs@yiguolei