Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [fix](jdbc) Fix JNI global reference leak in JdbcConnector close #58574 - #58753
Merged
Conversation
…8574) ## Problem JNI Global References may not be deleted when `JdbcConnector::close()` fails midway due to early returns from `RETURN_IF_ERROR` macros. This prevents Java GC from collecting `BaseJdbcExecutor` and its associated `ResultSet` objects, causing old generation heap to grow to 99%+. ## Solution - C++: Always delete all three Global References regardless of Java close() failure - Java: Always clear member variable references (`resultSet`, `stmt`, `conn`) in finally block
morningman
commented
Dec 5, 2025
Contributor
run buildall |
hello-stephen
commented
Dec 5, 2025
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
doris-robot
commented
Dec 5, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Dec 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #58574