Skip to content

[refactor](predicate) Simplify ValueRange - #58832

Merged
Gabriel39 merged 2 commits into
apache:masterfrom
Gabriel39:refactor_1209
Dec 9, 2025
Merged

[refactor](predicate) Simplify ValueRange#58832
Gabriel39 merged 2 commits into
apache:masterfrom
Gabriel39:refactor_1209

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39

Gabriel39 commented Dec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Dec 9, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 36528 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86f9845a661d1fc0038241f3cbd5284f7f3c6964, data reload: false
------ Round 1 ----------------------------------
q1	17643	5093	4927	4927
q2	2030	360	236	236
q3	10187	1316	748	748
q4	10215	826	320	320
q5	7529	2149	1996	1996
q6	191	177	139	139
q7	1024	853	727	727
q8	9356	1495	1199	1199
q9	7134	5365	5341	5341
q10	6857	2401	1997	1997
q11	542	319	295	295
q12	681	735	560	560
q13	17780	3751	3010	3010
q14	289	299	291	291
q15	581	522	513	513
q16	942	895	870	870
q17	725	822	529	529
q18	7599	7110	7207	7110
q19	1084	970	631	631
q20	402	375	256	256
q21	4323	4018	3854	3854
q22	1058	1027	979	979
Total cold run time: 108172 ms
Total hot run time: 36528 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4980	4979	4927	4927
q2	344	412	313	313
q3	2159	2704	2311	2311
q4	1329	1785	1288	1288
q5	4942	4634	4529	4529
q6	238	182	137	137
q7	2015	1960	1861	1861
q8	2774	2726	2544	2544
q9	7572	7543	7474	7474
q10	3082	3411	2762	2762
q11	582	518	481	481
q12	700	812	649	649
q13	3668	3991	3415	3415
q14	289	299	281	281
q15	549	505	521	505
q16	892	908	889	889
q17	1235	1488	1485	1485
q18	7996	7574	7199	7199
q19	842	818	803	803
q20	1913	1951	1795	1795
q21	4625	4338	4110	4110
q22	1105	1043	1002	1002
Total cold run time: 53831 ms
Total hot run time: 50760 ms

@doris-robot

doris-robot commented Dec 9, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 182022 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86f9845a661d1fc0038241f3cbd5284f7f3c6964, data reload: false
query5	4832	658	491	491
query6	334	253	240	240
query7	4698	486	283	283
query8	339	255	253	253
query9	8765	2613	2603	2603
query10	600	364	326	326
query11	15355	15172	14683	14683
query12	181	117	112	112
query13	1694	521	395	395
query14	6153	3264	3063	3063
query14_1	3020	2942	2945	2942
query15	227	201	203	201
query16	7596	478	476	476
query17	1212	706	615	615
query18	2021	443	350	350
query19	250	231	216	216
query20	125	117	113	113
query21	229	143	123	123
query22	3848	4113	4051	4051
query23	16737	16215	16118	16118
query23_1	16154	16057	16112	16057
query24	7255	1638	1255	1255
query24_1	1263	1258	1269	1258
query25	650	520	446	446
query26	1265	293	182	182
query27	2890	477	315	315
query28	4385	2179	2169	2169
query29	872	628	437	437
query30	312	246	215	215
query31	819	710	624	624
query32	80	70	65	65
query33	655	338	296	296
query34	877	895	546	546
query35	806	801	723	723
query36	916	902	827	827
query37	134	93	79	79
query38	3886	3856	3844	3844
query39	756	730	704	704
query39_1	704	708	695	695
query40	231	133	120	120
query41	67	63	62	62
query42	130	106	110	106
query43	478	435	416	416
query44	1306	770	756	756
query45	202	196	185	185
query46	932	979	623	623
query47	1691	1743	1605	1605
query48	433	337	252	252
query49	809	428	346	346
query50	665	295	227	227
query51	3868	3898	3831	3831
query52	117	110	100	100
query53	333	351	296	296
query54	325	296	249	249
query55	97	76	72	72
query56	332	295	283	283
query57	1154	1121	1103	1103
query58	298	257	245	245
query59	2371	2491	2294	2294
query60	362	302	297	297
query61	160	158	155	155
query62	802	686	636	636
query63	343	302	302	302
query64	4589	1317	1008	1008
query65	4032	3980	3957	3957
query66	1198	461	334	334
query67	15216	15097	14908	14908
query68	8384	1008	748	748
query69	568	344	311	311
query70	1137	998	995	995
query71	440	325	291	291
query72	5995	5006	5109	5006
query73	754	627	309	309
query74	8914	8733	8688	8688
query75	3575	3530	3177	3177
query76	3431	1167	760	760
query77	572	392	296	296
query78	9500	9516	8881	8881
query79	1675	876	631	631
query80	757	659	550	550
query81	498	266	243	243
query82	451	135	106	106
query83	259	252	248	248
query84	256	116	105	105
query85	992	499	465	465
query86	351	287	294	287
query87	4020	4126	4066	4066
query88	4062	2270	2287	2270
query89	507	422	404	404
query90	2063	161	151	151
query91	171	175	144	144
query92	80	75	68	68
query93	1250	919	579	579
query94	794	324	257	257
query95	573	373	320	320
query96	611	477	216	216
query97	2585	2670	2634	2634
query98	247	202	193	193
query99	1350	1300	1221	1221
Total cold run time: 272266 ms
Total hot run time: 182022 ms

@doris-robot

doris-robot commented Dec 9, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86f9845a661d1fc0038241f3cbd5284f7f3c6964, data reload: false
query1	0.05	0.05	0.04
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.10	0.11
query5	0.27	0.25	0.24
query6	1.17	0.65	0.63
query7	0.04	0.02	0.03
query8	0.06	0.04	0.05
query9	0.58	0.52	0.51
query10	0.57	0.55	0.56
query11	0.15	0.11	0.11
query12	0.16	0.11	0.11
query13	0.62	0.59	0.61
query14	0.98	0.98	1.00
query15	0.82	0.80	0.80
query16	0.42	0.39	0.39
query17	1.01	1.00	1.05
query18	0.23	0.22	0.22
query19	1.98	1.79	1.75
query20	0.02	0.01	0.01
query21	15.44	0.29	0.13
query22	4.79	0.05	0.05
query23	16.01	0.30	0.10
query24	1.47	0.32	0.50
query25	0.09	0.05	0.04
query26	0.14	0.14	0.14
query27	0.06	0.08	0.04
query28	3.87	1.23	1.02
query29	12.59	4.07	3.24
query30	0.28	0.14	0.11
query31	2.81	0.60	0.38
query32	3.23	0.56	0.46
query33	3.00	3.04	3.05
query34	16.69	5.24	4.52
query35	4.52	4.54	4.55
query36	0.66	0.49	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.04
query42	0.05	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 97.33 s
Total hot run time: 27.22 s

@hello-stephen

hello-stephen commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.35% (18708/35065)
Line Coverage39.05% (172933/442829)
Region Coverage33.72% (134114/397710)
Branch Coverage34.64% (57644/166398)

@hello-stephen

hello-stephen commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage72.28% (24840/34367)
Line Coverage59.02% (261053/442349)
Region Coverage54.03% (217451/402433)
Branch Coverage55.52% (92877/167273)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2025
@github-actions

github-actionsBot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Gabriel39 merged commit 3bfd83d into apache:masterDec 9, 2025
26 of 28 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@Gabriel39@nagisa-kunhah
[refactor](predicate) Simplify ValueRange (apache#58832)
79d5381
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Jan 13, 2026
@Gabriel39
[refactor](predicate) Simplify ValueRange (apache#58832)
b796b56
@Gabriel39Gabriel39 mentioned this pull request Jan 13, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 14, 2026
@Gabriel39
[branch-4.0]Pick predicates-related PR (#59804)
0174967
### What problem does this PR solve?
pick #57397#58283#58290#58282#58832#58905#58960#59005#59088#59098#59126#59187#59581#59625#59775
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
ybtsdst pushed a commit to ybtsdst/doris that referenced this pull request Feb 27, 2026
@Gabriel39bingtao.yin
[branch-4.0]Pick predicates-related PR (apache#59804)
f702132
### What problem does this PR solve?
pick apache#57397apache#58283apache#58290apache#58282apache#58832apache#58905apache#58960apache#59005apache#59088apache#59098apache#59126apache#59187apache#59581apache#59625apache#59775
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@Gabriel39
Gabriel39 deleted the refactor_1209 branch July 30, 2026 06:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@MryangeMryangeMryange approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gabriel39@hello-stephen@doris-robot@yiguolei@Mryange