[opt](jvm) add more --add-opens by morningman · Pull Request #58936 · apache/doris

morningman · 2025-12-11T03:51:10Z

Avoid some errors like:

Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.Lang.ClassLoader.defineClassCjava.lang.String,byte[], int, int） throws java.Lang.CLassFormatError accessible: module java.base does not "opens java.Lang" to unnamed module @3952037b

hello-stephen · 2025-12-11T03:51:16Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

morningman · 2025-12-11T03:55:08Z

run buildall

doris-robot · 2025-12-11T05:40:35Z

TPC-H: Total hot run time: 36748 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 186a98d60e9569e3179573d6bbd1a6b9a1d97e62, data reload: false
------ Round 1 ----------------------------------
q1	17624	4279	4148	4148
q2	1999	345	234	234
q3	10216	1362	764	764
q4	10233	893	322	322
q5	7968	2182	1991	1991
q6	212	173	136	136
q7	1052	869	732	732
q8	9366	1509	1177	1177
q9	7116	5379	5352	5352
q10	6876	2390	1953	1953
q11	536	338	301	301
q12	695	727	592	592
q13	17787	3691	3015	3015
q14	285	297	277	277
q15	607	517	519	517
q16	941	920	889	889
q17	720	872	536	536
q18	7528	8011	7677	7677
q19	1159	1039	661	661
q20	427	373	264	264
q21	4731	4310	4196	4196
q22	1141	1103	1014	1014
Total cold run time: 109219 ms
Total hot run time: 36748 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4308	4255	4358	4255
q2	353	408	338	338
q3	2536	2849	2373	2373
q4	1461	1898	1383	1383
q5	4543	4606	4309	4309
q6	217	172	127	127
q7	2137	1959	1766	1766
q8	2760	2546	2618	2546
q9	7561	7422	7785	7422
q10	3101	3219	2895	2895
q11	581	498	477	477
q12	648	732	612	612
q13	3265	3677	3088	3088
q14	277	280	258	258
q15	533	506	497	497
q16	874	889	832	832
q17	1130	1352	1378	1352
q18	7280	7142	6952	6952
q19	860	835	858	835
q20	1897	1970	1801	1801
q21	4778	4287	4079	4079
q22	1106	1041	982	982
Total cold run time: 52206 ms
Total hot run time: 49179 ms

doris-robot · 2025-12-11T05:51:54Z

TPC-DS: Total hot run time: 180891 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 186a98d60e9569e3179573d6bbd1a6b9a1d97e62, data reload: false
query5	4851	649	478	478
query6	359	255	219	219
query7	4217	465	285	285
query8	321	258	242	242
query9	8785	2583	2591	2583
query10	538	373	326	326
query11	15212	15226	14514	14514
query12	180	120	114	114
query13	1277	506	402	402
query14	6247	3255	2973	2973
query14_1	2871	2846	2836	2836
query15	209	195	180	180
query16	850	473	497	473
query17	1129	722	597	597
query18	2627	454	355	355
query19	231	234	211	211
query20	122	115	113	113
query21	226	138	117	117
query22	3835	4104	3936	3936
query23	16620	16144	16073	16073
query23_1	16103	16068	15879	15879
query24	7487	1677	1254	1254
query24_1	1262	1247	1251	1247
query25	573	507	448	448
query26	1260	267	163	163
query27	2744	474	316	316
query28	4481	2172	2152	2152
query29	852	588	483	483
query30	321	251	217	217
query31	837	704	641	641
query32	81	73	69	69
query33	558	351	309	309
query34	903	910	541	541
query35	809	851	726	726
query36	865	905	839	839
query37	132	89	78	78
query38	3867	3834	3758	3758
query39	755	795	718	718
query39_1	697	702	709	702
query40	219	134	119	119
query41	65	61	61	61
query42	109	103	106	103
query43	425	425	394	394
query44	1358	758	757	757
query45	191	188	185	185
query46	868	993	610	610
query47	1660	1701	1615	1615
query48	326	324	247	247
query49	626	437	358	358
query50	674	296	218	218
query51	3819	3785	3835	3785
query52	103	114	98	98
query53	326	358	295	295
query54	309	255	253	253
query55	82	77	70	70
query56	291	289	298	289
query57	1170	1136	1078	1078
query58	275	259	269	259
query59	2373	2398	2407	2398
query60	326	313	305	305
query61	166	157	158	157
query62	728	679	623	623
query63	340	291	310	291
query64	4939	1342	1037	1037
query65	3991	3947	3981	3947
query66	1410	434	321	321
query67	15193	15152	14772	14772
query68	8357	1009	738	738
query69	496	355	324	324
query70	1085	995	963	963
query71	371	303	289	289
query72	6116	4944	4912	4912
query73	683	582	312	312
query74	8962	8829	8757	8757
query75	3592	3550	3153	3153
query76	3985	1140	777	777
query77	593	399	289	289
query78	9617	9564	8772	8772
query79	2142	844	609	609
query80	761	655	560	560
query81	510	268	236	236
query82	448	133	109	109
query83	258	252	238	238
query84	261	114	102	102
query85	957	510	468	468
query86	423	307	301	301
query87	4019	4066	4029	4029
query88	4622	2279	2243	2243
query89	477	428	393	393
query90	2140	163	156	156
query91	169	175	157	157
query92	79	68	68	68
query93	2345	935	568	568
query94	519	279	302	279
query95	585	383	306	306
query96	596	480	207	207
query97	2591	2691	2586	2586
query98	229	193	196	193
query99	1343	1311	1232	1232
Total cold run time: 266865 ms
Total hot run time: 180891 ms

doris-robot · 2025-12-11T05:56:55Z

ClickBench: Total hot run time: 27.27 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 186a98d60e9569e3179573d6bbd1a6b9a1d97e62, data reload: false
query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.09	0.09
query4	1.61	0.12	0.11
query5	0.27	0.27	0.27
query6	1.18	0.64	0.64
query7	0.04	0.02	0.03
query8	0.05	0.04	0.05
query9	0.59	0.52	0.52
query10	0.55	0.55	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.59	0.61
query14	0.99	0.99	0.97
query15	0.82	0.80	0.81
query16	0.39	0.40	0.42
query17	0.99	0.99	1.04
query18	0.22	0.20	0.21
query19	1.86	1.81	1.87
query20	0.02	0.02	0.01
query21	15.46	0.32	0.14
query22	4.72	0.05	0.04
query23	16.12	0.29	0.10
query24	0.93	0.63	0.28
query25	0.09	0.06	0.05
query26	0.14	0.13	0.14
query27	0.07	0.05	0.04
query28	3.05	1.26	1.03
query29	12.57	4.05	3.27
query30	0.27	0.16	0.12
query31	2.82	0.61	0.41
query32	3.24	0.55	0.47
query33	3.00	3.01	2.95
query34	16.77	5.21	4.53
query35	4.57	4.54	4.55
query36	0.68	0.50	0.48
query37	0.10	0.07	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 95.94 s
Total hot run time: 27.27 s

github-actions · 2025-12-11T18:02:43Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-12-11T18:02:46Z

PR approved by anyone and no changes requested.

Avoid some errors like: ``` Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.Lang.ClassLoader.defineClassCjava.lang.String,byte[], int, int） throws java.Lang.CLassFormatError accessible: module java.base does not "opens java.Lang" to unnamed module @3952037b ```

Cherry-picked from #58936 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>

Avoid some errors like: ``` Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.Lang.ClassLoader.defineClassCjava.lang.String,byte[], int, int） throws java.Lang.CLassFormatError accessible: module java.base does not "opens java.Lang" to unnamed module @3952037b ```

followup #58936 Also modify start scripts to add missing options if necessary

bp #58936 #59073

…#59278) ### What problem does this PR solve? Related PR: #58936 When using JNI calls, the --add-opens parameter requires an explicit = to ensure compatibility with modular boundaries and to correctly interpret the relationship between modules and packages. Omitting the = results in a JVM error (Malformed option), preventing the program from running properly. ``` [INTERNAL_ERROR]failed to init reader, err: [JNI_ERROR]ExceptionInInitializerError: null | CAUSED BY: InaccessibleObjectException: Unable to make field private volatile java.lang.String java.net.URI.string accessible: module java.base does not "opens java.net" to unnamed module @5f565482 ``` https://docs.oracle.com/en/java/javase/11/migrate/index.html#GUID-A868D0B9-026F-4D46-B979-901834343F9E In addition, to avoid conflicts with other dependencies (e.g., paimon-oss), it is necessary to prioritize the loading of paimon-oss by delegating it to the preload mechanism, ensuring consistent and stable module loading order.

[opt](jvm) add more --add-opens
186a98d

gavinchou added dev/3.1.x dev/4.0.2-merged labels Dec 11, 2025

gavinchou added dev/4.0.x and removed dev/4.0.2-merged labels Dec 11, 2025

gavinchou approved these changes Dec 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2025

github-actionsBot added the reviewed label Dec 11, 2025

CalvinKirs approved these changes Dec 12, 2025
View reviewed changes

morningman merged commit dbf2371 into apache:masterDec 12, 2025
31 of 32 checks passed

github-actionsBot added the dev/3.1.x-conflict label Dec 12, 2025

github-actionsBot mentioned this pull request Dec 12, 2025
branch-4.0: [opt](jvm) add more --add-opens #58936 #58984
Merged

yiguolei pushed a commit that referenced this pull request Dec 12, 2025
branch-4.0: [opt](jvm) add more --add-opens#58936(#58984)
aa9c189
Cherry-picked from #58936 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>

yiguolei added dev/4.0.2-merged dev/4.0.3-merged and removed dev/4.0.x dev/4.0.2-merged labels Dec 12, 2025

This was referenced Dec 15, 2025
branch-3.1: [opt](jvm) add more --add-opens #58936 #59073 #59024
Merged
[fix](test) modify conf for regression tests #59073
Merged

morningman added a commit that referenced this pull request Dec 18, 2025
[fix](test) modify conf for regression tests (#59073)
7919b4b
followup #58936 Also modify start scripts to add missing options if necessary

github-actionsBot pushed a commit that referenced this pull request Dec 18, 2025
[fix](test) modify conf for regression tests (#59073)
9ba87b5
followup #58936 Also modify start scripts to add missing options if necessary

morrySnow pushed a commit that referenced this pull request Dec 18, 2025
branch-3.1: [opt](jvm) add more --add-opens#58936#59073(#59024)
ec7c4b7
bp #58936 #59073

morrySnow added dev/3.1.4-merged and removed dev/3.1.x dev/3.1.x-conflict labels Dec 18, 2025

morningman mentioned this pull request Dec 24, 2025
[Fix](java-opts)Fix Incorrect --add-opens Usage for JNI Compatibility #59278
Merged
16 tasks

Navigation Menu

Uh oh!

[opt](jvm) add more --add-opens - #58936

[opt](jvm) add more --add-opens#58936
morningman merged 1 commit into
apache:masterfrom
morningman:add_17_jvmopt

morningman commented Dec 11, 2025

Uh oh!

hello-stephen commented Dec 11, 2025

Uh oh!

morningman commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

github-actionsBot commented Dec 11, 2025

Uh oh!

github-actionsBot commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

morningman commented Dec 11, 2025

Uh oh!

hello-stephen commented Dec 11, 2025

Uh oh!

morningman commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

doris-robot commented Dec 11, 2025

Uh oh!

github-actionsBot commented Dec 11, 2025

Uh oh!

github-actionsBot commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants