Revert "[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them (#53198)" by bobhan1 · Pull Request #59066 · apache/doris

bobhan1 · 2025-12-16T03:29:37Z

This reverts commit 9b6115d.

#53198 may result in load stuck and timeout finally, revert it temporarily and will be added back after we find the root cause.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.

Thearas · 2025-12-16T03:29:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

bobhan1 · 2025-12-16T03:32:05Z

run buildall

github-actions · 2025-12-16T03:56:22Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-12-16T03:56:25Z

PR approved by anyone and no changes requested.

doris-robot · 2025-12-16T05:36:35Z

TPC-H: Total hot run time: 36545 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e3ff13ac1381c72310acb8953118a2104f480ea, data reload: false
------ Round 1 ----------------------------------
q1	17588	4168	4028	4028
q2	2016	344	249	249
q3	10177	1372	752	752
q4	10248	874	322	322
q5	8363	2167	1989	1989
q6	233	168	140	140
q7	1055	865	733	733
q8	9397	1491	1204	1204
q9	7189	5335	5368	5335
q10	6888	2378	1958	1958
q11	526	338	292	292
q12	708	712	596	596
q13	17800	3719	3049	3049
q14	289	306	271	271
q15	587	512	518	512
q16	699	689	634	634
q17	694	746	601	601
q18	7640	7821	7712	7712
q19	1231	1033	627	627
q20	427	379	270	270
q21	4638	4262	4210	4210
q22	1130	1088	1061	1061
Total cold run time: 109523 ms
Total hot run time: 36545 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4368	4391	4303	4303
q2	330	376	355	355
q3	2610	2874	2486	2486
q4	1424	1850	1541	1541
q5	4572	4508	4526	4508
q6	209	165	123	123
q7	1987	1963	1775	1775
q8	2663	2536	2498	2498
q9	7469	7540	6942	6942
q10	2898	3123	2672	2672
q11	568	499	468	468
q12	644	722	544	544
q13	3304	3687	3007	3007
q14	259	271	261	261
q15	547	505	497	497
q16	616	656	604	604
q17	1117	1442	1358	1358
q18	7249	7164	6929	6929
q19	850	825	858	825
q20	1934	1953	1805	1805
q21	4655	4285	4247	4247
q22	1070	1043	975	975
Total cold run time: 51343 ms
Total hot run time: 48723 ms

doris-robot · 2025-12-16T05:47:38Z

TPC-DS: Total hot run time: 178183 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8e3ff13ac1381c72310acb8953118a2104f480ea, data reload: false
query5	4731	643	472	472
query6	330	229	210	210
query7	4246	464	272	272
query8	288	283	228	228
query9	8760	2546	2559	2546
query10	502	365	332	332
query11	15153	14713	14611	14611
query12	173	116	115	115
query13	1245	478	383	383
query14	5828	3326	2947	2947
query14_1	2880	2903	2968	2903
query15	223	201	181	181
query16	873	488	460	460
query17	1146	709	601	601
query18	2449	447	351	351
query19	229	234	223	223
query20	117	117	115	115
query21	218	145	120	120
query22	3842	3972	3894	3894
query23	16590	16248	15795	15795
query23_1	16004	16053	15955	15955
query24	7433	1690	1255	1255
query24_1	1274	1252	1268	1252
query25	586	506	457	457
query26	1268	278	175	175
query27	2744	461	320	320
query28	4504	2156	2134	2134
query29	812	581	466	466
query30	324	248	222	222
query31	803	707	626	626
query32	94	77	72	72
query33	551	346	293	293
query34	904	933	541	541
query35	801	833	744	744
query36	887	923	821	821
query37	135	99	91	91
query38	2859	2836	2818	2818
query39	753	742	719	719
query39_1	706	734	706	706
query40	221	133	119	119
query41	65	64	67	64
query42	104	103	103	103
query43	415	444	393	393
query44	1328	759	741	741
query45	193	188	177	177
query46	887	998	610	610
query47	1658	1696	1623	1623
query48	313	326	260	260
query49	636	442	345	345
query50	666	293	218	218
query51	3864	3885	3797	3797
query52	111	112	103	103
query53	326	354	303	303
query54	283	263	272	263
query55	79	77	74	74
query56	291	293	288	288
query57	1126	1171	1047	1047
query58	261	248	251	248
query59	2427	2464	2365	2365
query60	307	308	287	287
query61	164	159	154	154
query62	698	666	640	640
query63	333	322	305	305
query64	4957	1332	1000	1000
query65	4054	3936	3980	3936
query66	1453	444	328	328
query67	15094	14980	14763	14763
query68	5765	1009	746	746
query69	508	345	306	306
query70	1041	1035	968	968
query71	371	309	284	284
query72	6062	4944	5049	4944
query73	678	628	311	311
query74	8754	8711	8571	8571
query75	3137	3517	2790	2790
query76	3800	1149	770	770
query77	534	387	300	300
query78	9422	9648	8972	8972
query79	1244	860	634	634
query80	1289	651	562	562
query81	540	272	234	234
query82	413	134	108	108
query83	273	257	239	239
query84	255	120	104	104
query85	911	520	459	459
query86	317	311	290	290
query87	3055	2957	3032	2957
query88	3233	2285	2253	2253
query89	458	433	401	401
query90	1986	156	159	156
query91	175	163	143	143
query92	69	67	66	66
query93	1108	907	552	552
query94	537	304	280	280
query95	577	331	354	331
query96	586	467	207	207
query97	2304	2315	2249	2249
query98	208	192	192	192
query99	1272	1290	1271	1271
Total cold run time: 256681 ms
Total hot run time: 178183 ms

doris-robot · 2025-12-16T05:52:42Z

ClickBench: Total hot run time: 27.47 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8e3ff13ac1381c72310acb8953118a2104f480ea, data reload: false
query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.11	0.10
query5	0.26	0.24	0.25
query6	1.21	0.63	0.63
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.56	0.50	0.50
query10	0.55	0.54	0.56
query11	0.15	0.12	0.12
query12	0.16	0.12	0.12
query13	0.63	0.61	0.62
query14	0.99	0.98	1.00
query15	0.82	0.81	0.81
query16	0.41	0.42	0.41
query17	1.00	1.06	1.05
query18	0.23	0.21	0.22
query19	1.88	1.83	1.83
query20	0.02	0.01	0.02
query21	15.44	0.27	0.14
query22	4.93	0.05	0.05
query23	16.22	0.28	0.10
query24	2.07	0.27	0.43
query25	0.12	0.08	0.06
query26	0.15	0.14	0.13
query27	0.08	0.05	0.05
query28	5.06	1.20	1.03
query29	12.62	4.05	3.25
query30	0.28	0.14	0.11
query31	2.84	0.64	0.40
query32	3.23	0.55	0.46
query33	3.05	3.12	3.04
query34	16.83	5.19	4.56
query35	4.53	4.58	4.55
query36	0.67	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.67 s
Total hot run time: 27.47 s

hello-stephen · 2025-12-16T07:02:18Z

BE UT Coverage Report

Increment line coverage 100.00% (14/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.46% (18851/35263)
Line Coverage	39.23% (174462/444749)
Region Coverage	33.84% (134971/398862)
Branch Coverage	34.80% (58104/166967)

hello-stephen · 2025-12-16T08:15:21Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (14/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	72.29% (24981/34556)
Line Coverage	59.05% (262273/444135)
Region Coverage	53.99% (217856/403491)
Branch Coverage	55.55% (93194/167780)

bobhan1 · 2025-12-16T10:48:01Z

run p0

hello-stephen · 2025-12-16T12:36:13Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (14/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	72.31% (24988/34556)
Line Coverage	59.08% (262411/444135)
Region Coverage	54.02% (217967/403491)
Branch Coverage	55.57% (93238/167780)

liaoxin01

LGTM

Revert "[Fix](mow) seg compaction should wait for calc delete bitmap …
8e3ff13
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.

gavinchou approved these changes Dec 16, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2025

github-actionsBot added the reviewed label Dec 16, 2025

liaoxin01 approved these changes Dec 17, 2025
View reviewed changes

liaoxin01 merged commit e77de3a into apache:masterDec 17, 2025
29 of 31 checks passed

Navigation Menu

Uh oh!

Revert "[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them (#53198)" - #59066

Revert "[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them (#53198)"#59066
liaoxin01 merged 1 commit into
apache:masterfrom
bobhan1:master-revert-53198

bobhan1 commented Dec 16, 2025•
edited
Loading

Uh oh!

Thearas commented Dec 16, 2025

Uh oh!

bobhan1 commented Dec 16, 2025

Uh oh!

github-actionsBot commented Dec 16, 2025

Uh oh!

github-actionsBot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

hello-stephen commented Dec 16, 2025

Uh oh!

hello-stephen commented Dec 16, 2025

Uh oh!

bobhan1 commented Dec 16, 2025

Uh oh!

hello-stephen commented Dec 16, 2025

Uh oh!

liaoxin01 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

bobhan1 commented Dec 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Dec 16, 2025

Uh oh!

bobhan1 commented Dec 16, 2025

Uh oh!

github-actionsBot commented Dec 16, 2025

Uh oh!

github-actionsBot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

doris-robot commented Dec 16, 2025

Uh oh!

hello-stephen commented Dec 16, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Dec 16, 2025

BE Regression && UT Coverage Report

Uh oh!

bobhan1 commented Dec 16, 2025

Uh oh!

hello-stephen commented Dec 16, 2025

BE Regression && UT Coverage Report

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bobhan1 commented Dec 16, 2025•
edited
Loading