Skip to content

[BUG][Document] Fix the bug that failed to build the help module - #5917

Merged
morningman merged 2 commits into
apache:masterfrom
xy720:fix-help-topic
May 27, 2021
Merged

[BUG][Document] Fix the bug that failed to build the help module#5917
morningman merged 2 commits into
apache:masterfrom
xy720:fix-help-topic

Conversation

@xy720

@xy720xy720 commented May 26, 2021

Copy link
Copy Markdown
Member

Proposed changes

There are multiple entries with same key in help documents, which will cause build help module failed.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)

morningman
morningman reviewed May 26, 2021
View reviewed changes

@morningmanmorningman left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better change the title to
show database id, show table id and show partition id, for both Chinese and English doc.

@morningmanmorningman added the kind/docs Categorizes issue or PR as related to documentation. label May 26, 2021
EmmyMiao87
EmmyMiao87 reviewed May 27, 2021
View reviewed changes
Comment threaddocs/zh-CN/sql-reference/sql-statements/Data Manipulation/SHOW PARTITION.md Outdated
-->

# SHOW DATABASE
# SHOW PARTITION

@EmmyMiao87EmmyMiao87May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change English document

@xy720xy720May 27, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it.

@xy720xy720 changed the title [BUG][Document] Fix help module build failed[BUG][Document] Fix the bug that failed to build the moduleMay 27, 2021
@xy720xy720 changed the title [BUG][Document] Fix the bug that failed to build the module[BUG][Document] Fix the bug that failed to build the help moduleMay 27, 2021
morningman
morningman approved these changes May 27, 2021
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label May 27, 2021
@morningman
morningman merged commit a29dd42 into apache:masterMay 27, 2021
stdpain pushed a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
@xy720@morningman-cmy
[BUG][Document] Fix the bug that failed to build the help module (apa…
e1a386a
…che#5917)
There are multiple entries with same key in help documents, which will cause build help module failed.
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
@xy720wangxixu
[BUG][Document] Fix the bug that failed to build the help module (apa…
f908442
…che#5917)
There are multiple entries with same key in help documents, which will cause build help module failed.
@BloodRose162BloodRose162 mentioned this pull request Oct 27, 2023
Open
@realize096realize096 mentioned this pull request Oct 28, 2023
Open
@chncaptionchncaption mentioned this pull request Oct 29, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87EmmyMiao87EmmyMiao87 left review comments
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.kind/docsCategorizes issue or PR as related to documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xy720@morningman@EmmyMiao87