Uh oh!
There was an error while loading. Please reload this page.
[fix](cloud)Fix create dynamic table race with insert overwrite - #59489
Merged
dataroaring merged 3 commits intoJan 5, 2026
Conversation
deardeng
requested review from
CalvinKirs, dataroaring and morningman
as code ownersDecember 30, 2025 09:25
hello-stephen
commented
Dec 30, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
deardeng
commented
Dec 30, 2025
ContributorAuthor
run buildall |
deardengforce-pushed
the
fix-race-create-insertoverwrite
branch
from
December 30, 2025 09:30
af9cd0a to
65716c4Comparedeardengforce-pushed
the
fix-race-create-insertoverwrite
branch
from
December 30, 2025 09:37
65716c4 to
4e4efb1Comparedoris-robot
commented
Dec 30, 2025
TPC-H: Total hot run time: 35222 ms |
doris-robot
commented
Dec 30, 2025
TPC-DS: Total hot run time: 173947 ms |
doris-robot
commented
Dec 30, 2025
ClickBench: Total hot run time: 27.64 s |
hello-stephen
commented
Dec 30, 2025
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
PR approved by anyone and no changes requested. |
deardengforce-pushed
the
fix-race-create-insertoverwrite
branch
from
December 31, 2025 07:51
5d3e332 to
14d4d5eComparedeardeng
commented
Dec 31, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Dec 31, 2025
TPC-H: Total hot run time: 34318 ms |
doris-robot
commented
Dec 31, 2025
TPC-DS: Total hot run time: 175492 ms |
doris-robot
commented
Dec 31, 2025
ClickBench: Total hot run time: 27.38 s |
hello-stephen
commented
Dec 31, 2025
Contributor
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Dec 31, 2025
Contributor
FE Regression Coverage ReportIncrement line coverage |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
PR approved by at least one committer and no changes requested. |
deardeng
commented
Jan 5, 2026
ContributorAuthor
run cloud_p0 |
Uh oh!
There was an error while loading. Please reload this page.
zzzxl1993 pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
…pache#59489) ### What problem does this PR solve? 1. Thread 1 executed a DROP TABLE operation, followed by a CREATE TABLE operation, initializing a dynamic partition (Partition A) in memory. 2. Due to an optimization in the cloud, batch partition edit logs were attempted; however, the edit log for Partition A was not yet synchronized to the followers. 3. Thread 2 began an INSERT INTO ... OVERWRITE PARTITION (*) operation, identifying Partition A in memory and writing a replace partition edit log. 4. In follower, the replay thread attempted to replay the replace partition edit log but found a dependency on Partition A, which was absent from memory, resulting in an exception and subsequent termination. Fix ``` 2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910 java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906) at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835) at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799) at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750) at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986) at org.apache.doris.catalog.Env.replayJournal(Env.java:3100) at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862) at org.apache.doris.common.util.Daemon.run(Daemon.java:119) 2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown... 2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
deardeng added a commit
to deardeng/incubator-doris
that referenced
this pull request
Jan 14, 2026
…pache#59489) 1. Thread 1 executed a DROP TABLE operation, followed by a CREATE TABLE operation, initializing a dynamic partition (Partition A) in memory. 2. Due to an optimization in the cloud, batch partition edit logs were attempted; however, the edit log for Partition A was not yet synchronized to the followers. 3. Thread 2 began an INSERT INTO ... OVERWRITE PARTITION (*) operation, identifying Partition A in memory and writing a replace partition edit log. 4. In follower, the replay thread attempted to replay the replace partition edit log but found a dependency on Partition A, which was absent from memory, resulting in an exception and subsequent termination. Fix ``` 2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910 java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906) at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835) at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799) at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750) at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986) at org.apache.doris.catalog.Env.replayJournal(Env.java:3100) at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862) at org.apache.doris.common.util.Daemon.run(Daemon.java:119) 2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown... 2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: None - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
deardeng added a commit
to deardeng/incubator-doris
that referenced
this pull request
Jan 15, 2026
…pache#59489) 1. Thread 1 executed a DROP TABLE operation, followed by a CREATE TABLE operation, initializing a dynamic partition (Partition A) in memory. 2. Due to an optimization in the cloud, batch partition edit logs were attempted; however, the edit log for Partition A was not yet synchronized to the followers. 3. Thread 2 began an INSERT INTO ... OVERWRITE PARTITION (*) operation, identifying Partition A in memory and writing a replace partition edit log. 4. In follower, the replay thread attempted to replay the replace partition edit log but found a dependency on Partition A, which was absent from memory, resulting in an exception and subsequent termination. Fix ``` 2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910 java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906) at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835) at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799) at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750) at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986) at org.apache.doris.catalog.Env.replayJournal(Env.java:3100) at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862) at org.apache.doris.common.util.Daemon.run(Daemon.java:119) 2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown... 2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: None - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
29 tasks
yiguolei pushed a commit
to deardeng/incubator-doris
that referenced
this pull request
Jan 16, 2026
…pache#59489) 1. Thread 1 executed a DROP TABLE operation, followed by a CREATE TABLE operation, initializing a dynamic partition (Partition A) in memory. 2. Due to an optimization in the cloud, batch partition edit logs were attempted; however, the edit log for Partition A was not yet synchronized to the followers. 3. Thread 2 began an INSERT INTO ... OVERWRITE PARTITION (*) operation, identifying Partition A in memory and writing a replace partition edit log. 4. In follower, the replay thread attempted to replay the replace partition edit log but found a dependency on Partition A, which was absent from memory, resulting in an exception and subsequent termination. Fix ``` 2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910 java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906) at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835) at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799) at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750) at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986) at org.apache.doris.catalog.Env.replayJournal(Env.java:3100) at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862) at org.apache.doris.common.util.Daemon.run(Daemon.java:119) 2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown... 2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: None - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
ybtsdst pushed a commit
to ybtsdst/doris
that referenced
this pull request
Feb 27, 2026
…overwrite` apache#59489 (apache#59884) cherry pick from apache#59489
yiguolei pushed a commit
that referenced
this pull request
Apr 16, 2026
hello-stephen pushed a commit
that referenced
this pull request
May 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)