Skip to content

[fix](cloud) Fix getNormalReplicaBackendPathMapCloud function naming is confusing - #59791

Merged
gavinchou merged 1 commit into
apache:masterfrom
deardeng:fix-naming
Jan 13, 2026
Merged

[fix](cloud) Fix getNormalReplicaBackendPathMapCloud function naming is confusing#59791
gavinchou merged 1 commit into
apache:masterfrom
deardeng:fix-naming

Conversation

@deardeng

@deardengdeardeng commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng

deardeng commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@deardeng

deardeng commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jan 12, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 31910 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1dbb3e7b72c3536aea7a18c66c33a1a752632f87, data reload: false
------ Round 1 ----------------------------------
q1	17656	4304	4039	4039
q2	2030	355	250	250
q3	10163	1248	698	698
q4	10217	896	321	321
q5	7542	2091	1793	1793
q6	193	170	138	138
q7	931	783	665	665
q8	9882	1382	1241	1241
q9	5017	4584	4585	4584
q10	6815	1808	1395	1395
q11	512	288	303	288
q12	706	739	615	615
q13	17798	3831	3115	3115
q14	278	293	268	268
q15	586	510	513	510
q16	678	678	622	622
q17	672	822	481	481
q18	6632	6437	6833	6437
q19	1310	1067	642	642
q20	407	390	282	282
q21	3252	2592	2490	2490
q22	1117	1097	1036	1036
Total cold run time: 104394 ms
Total hot run time: 31910 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4311	4315	4313	4313
q2	335	411	328	328
q3	2310	2779	2411	2411
q4	1448	1899	1443	1443
q5	4646	4328	4346	4328
q6	220	167	127	127
q7	2025	1901	1883	1883
q8	2502	2382	2417	2382
q9	7011	7211	7110	7110
q10	2476	2688	2184	2184
q11	523	445	434	434
q12	644	733	584	584
q13	3348	3756	3092	3092
q14	278	273	260	260
q15	518	485	481	481
q16	608	669	604	604
q17	1099	1316	1387	1316
q18	7232	7196	7147	7147
q19	800	782	774	774
q20	1884	1991	1792	1792
q21	4516	4274	4096	4096
q22	1054	1045	961	961
Total cold run time: 49788 ms
Total hot run time: 48050 ms

@doris-robot

doris-robot commented Jan 12, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 172758 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1dbb3e7b72c3536aea7a18c66c33a1a752632f87, data reload: false
query5	4348	594	439	439
query6	340	226	199	199
query7	4205	461	257	257
query8	330	240	243	240
query9	8756	2647	2693	2647
query10	529	366	325	325
query11	15193	15256	14805	14805
query12	171	117	110	110
query13	1238	477	370	370
query14	6232	3106	2740	2740
query14_1	2665	2638	2660	2638
query15	195	188	173	173
query16	998	461	435	435
query17	1071	658	574	574
query18	2550	447	348	348
query19	231	226	198	198
query20	129	117	116	116
query21	212	142	122	122
query22	3874	4091	3940	3940
query23	15929	15622	15326	15326
query23_1	15445	15395	15351	15351
query24	7345	1551	1196	1196
query24_1	1212	1188	1207	1188
query25	564	503	428	428
query26	1246	286	179	179
query27	2725	460	294	294
query28	4543	2147	2140	2140
query29	778	557	457	457
query30	310	245	213	213
query31	805	651	571	571
query32	76	77	67	67
query33	554	348	300	300
query34	903	908	516	516
query35	756	770	685	685
query36	865	904	833	833
query37	137	97	79	79
query38	2795	2694	2601	2601
query39	774	751	723	723
query39_1	702	741	723	723
query40	226	142	124	124
query41	70	68	66	66
query42	111	106	106	106
query43	446	466	408	408
query44	1335	738	733	733
query45	195	187	178	178
query46	849	986	615	615
query47	1380	1449	1391	1391
query48	319	333	250	250
query49	623	436	343	343
query50	641	279	205	205
query51	3798	3808	3785	3785
query52	108	112	103	103
query53	298	330	283	283
query54	309	290	259	259
query55	78	76	74	74
query56	296	332	303	303
query57	1024	1002	858	858
query58	277	304	254	254
query59	2040	2141	2102	2102
query60	324	332	304	304
query61	166	166	160	160
query62	377	356	308	308
query63	304	269	270	269
query64	4852	1305	1011	1011
query65	3866	3731	3731	3731
query66	1431	413	302	302
query67	14991	14803	15473	14803
query68	6992	982	695	695
query69	512	347	328	328
query70	1023	978	956	956
query71	360	302	273	273
query72	5899	3438	3479	3438
query73	765	750	304	304
query74	8879	8804	8662	8662
query75	2827	2865	2449	2449
query76	3501	1076	673	673
query77	532	387	287	287
query78	9636	9823	9203	9203
query79	1255	893	585	585
query80	622	565	484	484
query81	514	261	236	236
query82	217	146	115	115
query83	266	258	235	235
query84	259	121	105	105
query85	939	507	467	467
query86	386	319	300	300
query87	2874	2868	2777	2777
query88	3141	2235	2204	2204
query89	390	348	335	335
query90	2199	152	147	147
query91	175	166	142	142
query92	87	69	65	65
query93	1349	895	532	532
query94	569	330	299	299
query95	578	336	319	319
query96	590	453	200	200
query97	2299	2387	2315	2315
query98	225	198	196	196
query99	574	585	507	507
Total cold run time: 252336 ms
Total hot run time: 172758 ms

@hello-stephen

hello-stephen commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (2/4) 🎉
Increment coverage report
Complete coverage report

@github-actions

github-actionsBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
@github-actions

github-actionsBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@deardeng

deardeng commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@deardeng

deardeng commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

run external

@hello-stephen

hello-stephen commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (2/4) 🎉
Increment coverage report
Complete coverage report

@gavinchou
gavinchou merged commit cf2d4de into apache:masterJan 13, 2026
29 checks passed
mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Mar 18, 2026
@deardeng@mymeiyi
[fix](cloud) Fix getNormalReplicaBackendPathMapCloud function namin…
3b2958d
…g is confusing (apache#59791)
@mymeiyimymeiyi mentioned this pull request Mar 18, 2026
Merged
yiguolei pushed a commit that referenced this pull request Mar 18, 2026
@mymeiyi@deardeng
branch-4.1: (fix)[fe] pick some fe memory improve prs (#61455)
f7a4908
pick:
#59327#59460#59648#59683#59759#59757#59776#59814#59932#59934#61080#59791
---------
Co-authored-by: deardeng <dengxin@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyimymeiyimymeiyi approved these changes
@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringAwaiting requested review from dataroaring
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deardeng@Thearas@doris-robot@hello-stephen@mymeiyi@gavinchou