Skip to content

[feature](score) support BM25 scoring in inverted index query_v2 - #59847

Merged
airborne12 merged 10 commits into
apache:masterfrom
zzzxl1993:202501132239
Mar 17, 2026
Merged

[feature](score) support BM25 scoring in inverted index query_v2#59847
airborne12 merged 10 commits into
apache:masterfrom
zzzxl1993:202501132239

Conversation

@zzzxl1993

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12

Copy link
Copy Markdown
Member

run buildall

@doris-robot

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.31% (1798/2267)
Line Coverage64.60% (32264/49944)
Region Coverage65.54% (16161/24659)
Branch Coverage55.95% (8610/15388)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@doris-robot

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.53% (32279/50023)
Region Coverage65.45% (16166/24699)
Branch Coverage55.85% (8608/15414)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.53% (32284/50026)
Region Coverage65.44% (16166/24702)
Branch Coverage55.81% (8603/15416)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@airborne12

Copy link
Copy Markdown
Member

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.50% (32267/50026)
Region Coverage65.42% (16161/24702)
Branch Coverage55.81% (8604/15416)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@airborne12

Copy link
Copy Markdown
Member

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.53% (32281/50026)
Region Coverage65.40% (16155/24702)
Branch Coverage55.83% (8606/15416)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.51% (32274/50026)
Region Coverage65.44% (16165/24702)
Branch Coverage55.84% (8608/15416)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@doris-robot

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.49% (32260/50026)
Region Coverage65.40% (16155/24702)
Branch Coverage55.81% (8603/15416)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.65% (19758/37526)
Line Coverage36.25% (184492/509010)
Region Coverage32.38% (142459/440010)
Branch Coverage33.56% (62263/185507)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.19% (26884/36730)
Line Coverage56.54% (286815/507286)
Region Coverage53.71% (238525/444057)
Branch Coverage55.47% (103176/185989)

@airborne12

Copy link
Copy Markdown
Member

run buildall

@doris-robot

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage79.24% (1798/2269)
Line Coverage64.52% (32277/50026)
Region Coverage65.42% (16161/24702)
Branch Coverage55.83% (8607/15416)

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12
airborne12 merged commit 26c1950 into apache:masterMar 17, 2026
27 of 30 checks passed
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 18, 2026
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 18, 2026
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 18, 2026
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 18, 2026
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 18, 2026
yiguolei pushed a commit that referenced this pull request Mar 19, 2026
…uery_v2 #59847 (#61470)
## Proposed changes
Cherry-pick #59847 to branch-4.0.
Original PR: #59847
## Further comments
Resolved cherry-pick conflicts caused by directory renames
(`be/src/storage/` → `be/src/olap/`, `be/src/exprs/` →
`be/src/vec/exprs/`) in branch-4.0. Key conflict resolutions:
- Updated all include paths for branch-4.0 directory structure
- Added `vectorized::` namespace qualifiers for types (`VExprSPtr`,
`VSlotRef`, etc.)
- Added `IndexExecContext` constructor parameters for segment/iter_opts
- Disabled nested group search (not available in branch-4.0)
- Excluded unrelated fields (`enable_adjust_conjunct_order_by_cost`,
`enable_paimon_cpp_reader`, `single_backend_query`,
`cteMaxRecursionDepth`) from thrift/SessionVariable
---------
Co-authored-by: zzzxl <yangsiyu@selectdb.com>
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Mar 19, 2026
yiguolei pushed a commit that referenced this pull request Mar 19, 2026
…uery_v2 #59847 (#61472)
## Proposed changes
Cherry-pick #59847 to branch-4.1.
Original PR: #59847
## Further comments
Resolved cherry-pick conflicts (minor differences from branch-4.0 pick):
- Added `IndexQueryContextPtr` member and `set/get_index_query_context`
to `IndexExecContext`
- Extended `evaluate_inverted_index_with_search_param` with
`index_query_context` parameter
- Added `enable_inverted_index_wand_query` to thrift and SessionVariable
(field 203)
- Kept existing branch-4.1 fields (`single_backend_query` field 202)
intact
---------
Co-authored-by: zzzxl <yangsiyu@selectdb.com>
@yiguoleiyiguolei mentioned this pull request Mar 27, 2026
@morningmanmorningman mentioned this pull request Jul 3, 2026
76 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.5-mergeddev/4.1.0-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@zzzxl1993@Thearas@airborne12@doris-robot@hello-stephen@eldenmoon@yiguolei