Skip to content

[Fix](partition) fix concurrent visit of partition items - #59848

Merged
zclllyybb merged 1 commit into
apache:masterfrom
zclllyybb:fix_create_partition_concurrent
Jan 14, 2026
Merged

[Fix](partition) fix concurrent visit of partition items#59848
zclllyybb merged 1 commit into
apache:masterfrom
zclllyybb:fix_create_partition_concurrent

Conversation

@zclllyybb

@zclllyybbzclllyybb commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: introduced by #56921

Problem Summary:

fix concurrency bug when dynamic partition visit partition items at the same time with modifying partitions:

2026-01-1215:31:46,108ERROR (thrift-server-pool-31|451) [ProcessFunction.process():47] InternalerrorprocessingcreatePartitionjava.lang.reflect.UndeclaredThrowableExceptionatjdk.proxy2/jdk.proxy2.$Proxy27.createPartition(UnknownSource)
atorg.apache.doris.thrift.FrontendService$Processor$createPartition.getResult(FrontendService.java:4993)
atorg.apache.doris.thrift.FrontendService$Processor$createPartition.getResult(FrontendService.java:4973)
atorg.apache.thrift.ProcessFunction.process(ProcessFunction.java:38)
atorg.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38)
atorg.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:250)
atjava.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
atjava.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
atjava.base/java.lang.Thread.run(Thread.java:833)
Causedby: java.lang.reflect.InvocationTargetExceptionatjdk.internal.reflect.GeneratedMethodAccessor27.invoke(UnknownSource)
atjava.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
atjava.base/java.lang.reflect.Method.invoke(Method.java:568)
atorg.apache.doris.service.FeServer.lambda$start$0(FeServer.java:60)
... 9moreCausedby: java.util.ConcurrentModificationExceptionatjava.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
atjava.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630)
atjava.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628)
atjava.base/java.util.AbstractCollection.toArray(AbstractCollection.java:146)
atjava.base/java.util.ArrayList.<init>(ArrayList.java:181)
atorg.apache.doris.clone.DynamicPartitionScheduler.getHistoricalPartitions(DynamicPartitionScheduler.java:209)
atorg.apache.doris.common.util.AutoBucketCalculator.calculateAutoBuckets(AutoBucketCalculator.java:142)
atorg.apache.doris.common.util.AutoBucketCalculator.calculateAutoBucketsWithBoundsCheck(AutoBucketCalculator.java:190)
atorg.apache.doris.analysis.PartitionExprUtil.getAddPartitionClauseFromPartitionValues(PartitionExprUtil.java:202)
atorg.apache.doris.service.FrontendServiceImpl.createPartition(FrontendServiceImpl.java:3622)
... 13more

all these visit operations should under table's lock.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb

zclllyybb commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jan 13, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 31300 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60500fd8b54286585108d926f72cb4f1aaa12699, data reload: false
------ Round 1 ----------------------------------
q1	17655	4279	4036	4036
q2	2036	386	239	239
q3	10138	1268	719	719
q4	10212	830	331	331
q5	7526	2082	1800	1800
q6	187	170	138	138
q7	960	780	658	658
q8	9247	1396	1114	1114
q9	4902	4536	4578	4536
q10	6745	1811	1400	1400
q11	497	296	278	278
q12	673	746	592	592
q13	17773	3802	3073	3073
q14	287	292	287	287
q15	587	521	503	503
q16	675	661	626	626
q17	634	741	550	550
q18	6661	6399	6389	6389
q19	1243	956	612	612
q20	387	368	238	238
q21	2985	2328	2230	2230
q22	1069	1020	951	951
Total cold run time: 103079 ms
Total hot run time: 31300 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4089	4051	4044	4044
q2	323	404	318	318
q3	2111	2584	2210	2210
q4	1321	1729	1353	1353
q5	4076	3965	4007	3965
q6	208	176	131	131
q7	1827	1796	1697	1697
q8	2472	2268	2287	2268
q9	6620	6678	6612	6612
q10	2331	2486	2085	2085
q11	562	464	438	438
q12	656	704	591	591
q13	3340	3814	3069	3069
q14	272	296	264	264
q15	538	519	497	497
q16	623	662	617	617
q17	1082	1243	1302	1243
q18	7439	7175	7158	7158
q19	825	812	781	781
q20	1896	2012	1796	1796
q21	4540	4311	4065	4065
q22	1099	1013	985	985
Total cold run time: 48250 ms
Total hot run time: 46187 ms

@doris-robot

doris-robot commented Jan 13, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 172710 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60500fd8b54286585108d926f72cb4f1aaa12699, data reload: false
query5	5134	631	480	480
query6	375	248	222	222
query7	4224	471	250	250
query8	350	246	241	241
query9	8750	2865	2833	2833
query10	568	390	338	338
query11	15401	15120	14780	14780
query12	203	117	117	117
query13	1269	487	375	375
query14	6735	2987	2745	2745
query14_1	2666	2634	2624	2624
query15	213	199	178	178
query16	1000	488	463	463
query17	1075	691	590	590
query18	2709	438	337	337
query19	232	223	200	200
query20	125	117	118	117
query21	213	138	117	117
query22	4192	4378	4176	4176
query23	16046	15659	15522	15522
query23_1	15359	15520	15439	15439
query24	7043	1533	1153	1153
query24_1	1237	1146	1168	1146
query25	552	479	430	430
query26	1244	264	154	154
query27	2756	445	262	262
query28	4538	2144	2153	2144
query29	792	553	444	444
query30	307	230	210	210
query31	800	609	557	557
query32	86	78	77	77
query33	534	352	308	308
query34	902	883	523	523
query35	726	804	667	667
query36	883	926	772	772
query37	124	93	84	84
query38	2750	2638	2644	2638
query39	767	768	747	747
query39_1	703	708	722	708
query40	213	133	120	120
query41	71	63	63	63
query42	105	103	102	102
query43	433	428	408	408
query44	1317	728	716	716
query45	186	185	177	177
query46	812	937	557	557
query47	1387	1491	1380	1380
query48	294	325	221	221
query49	597	414	331	331
query50	600	271	212	212
query51	3752	3797	3740	3740
query52	101	108	101	101
query53	305	320	279	279
query54	286	262	251	251
query55	78	73	77	73
query56	319	307	306	306
query57	1013	966	902	902
query58	263	261	254	254
query59	2105	2228	2158	2158
query60	336	332	306	306
query61	159	147	153	147
query62	403	358	340	340
query63	296	269	271	269
query64	4863	1288	984	984
query65	3841	3718	3711	3711
query66	1385	419	315	315
query67	15307	15179	14863	14863
query68	6744	972	689	689
query69	507	351	318	318
query70	1020	950	866	866
query71	373	301	295	295
query72	5791	3296	3234	3234
query73	770	712	306	306
query74	8794	8728	8620	8620
query75	2811	2837	2417	2417
query76	3448	1057	641	641
query77	550	376	307	307
query78	9845	9936	9199	9199
query79	1651	881	558	558
query80	669	563	495	495
query81	504	261	232	232
query82	217	145	110	110
query83	267	259	252	252
query84	260	122	99	99
query85	884	506	439	439
query86	396	329	318	318
query87	2853	2875	2733	2733
query88	2916	2098	2063	2063
query89	391	355	336	336
query90	2190	164	157	157
query91	165	161	136	136
query92	88	70	69	69
query93	1599	912	514	514
query94	599	320	313	313
query95	576	378	313	313
query96	549	486	200	200
query97	2301	2381	2286	2286
query98	239	198	199	198
query99	591	561	520	520
Total cold run time: 254035 ms
Total hot run time: 172710 ms

@hello-stephen

hello-stephen commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 77.78% (7/9) 🎉
Increment coverage report
Complete coverage report

HappenLee
HappenLee approved these changes Jan 14, 2026
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2026
@github-actions

github-actionsBot commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 77.78% (7/9) 🎉
Increment coverage report
Complete coverage report

deardeng
deardeng approved these changes Jan 14, 2026
View reviewed changes

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zclllyybb
zclllyybb merged commit d7650ab into apache:masterJan 14, 2026
33 of 34 checks passed
@zclllyybb
zclllyybb deleted the fix_create_partition_concurrent branch January 14, 2026 13:49
github-actionsBot pushed a commit that referenced this pull request Jan 14, 2026
@zclllyybbYour Name
[Fix](partition) fix concurrent visit of partition items (#59848)
e1dd29d
Related PR: introduced by #56921
Problem Summary:
fix concurrency bug when dynamic partition visit partition items at the
same time with modifying partitions:
```java
2026-01-12 15:31:46,108 ERROR (thrift-server-pool-31|451) [ProcessFunction.process():47] Internal error processing createPartition
java.lang.reflect.UndeclaredThrowableException
at jdk.proxy2/jdk.proxy2.$Proxy27.createPartition(Unknown Source)
at org.apache.doris.thrift.FrontendService$Processor$createPartition.getResult(FrontendService.java:4993)
at org.apache.doris.thrift.FrontendService$Processor$createPartition.getResult(FrontendService.java:4973)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38)
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:250)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.reflect.InvocationTargetException
at jdk.internal.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.apache.doris.service.FeServer.lambda$start$0(FeServer.java:60)
... 9 more
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630)
at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628)
at java.base/java.util.AbstractCollection.toArray(AbstractCollection.java:146)
at java.base/java.util.ArrayList.<init>(ArrayList.java:181)
at org.apache.doris.clone.DynamicPartitionScheduler.getHistoricalPartitions(DynamicPartitionScheduler.java:209)
at org.apache.doris.common.util.AutoBucketCalculator.calculateAutoBuckets(AutoBucketCalculator.java:142)
at org.apache.doris.common.util.AutoBucketCalculator.calculateAutoBucketsWithBoundsCheck(AutoBucketCalculator.java:190)
at org.apache.doris.analysis.PartitionExprUtil.getAddPartitionClauseFromPartitionValues(PartitionExprUtil.java:202)
at org.apache.doris.service.FrontendServiceImpl.createPartition(FrontendServiceImpl.java:3622)
... 13 more
```
all these visit operations should under table's lock.
@github-actionsgithub-actionsBot mentioned this pull request Jan 14, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 15, 2026
@github-actions@zclllyybb
branch-4.0: [Fix](partition) fix concurrent visit of partition items#…
13b157c
…59848 (#59891)
Cherry-picked from #59848
Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
ybtsdst pushed a commit to ybtsdst/doris that referenced this pull request Feb 27, 2026
@github-actions@zclllyybbbingtao.yin
branch-4.0: [Fix](partition) fix concurrent visit of partition itemsa…
f4a538d
…pache#59848 (apache#59891)
Cherry-picked from apache#59848
Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deardengdeardengdeardeng approved these changes
@HappenLeeHappenLeeHappenLee approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zclllyybb@Thearas@doris-robot@hello-stephen@deardeng@HappenLee@yiguolei