[bugfix](arrowflight) should call done run in on_xxx method to make work in async mode by yiguolei · Pull Request #60282 · apache/doris

yiguolei · 2026-01-27T10:57:52Z

What problem does this PR solve?

there is a logic similar to our FE fetching data from the BE: if the data is not available, it will be added to a waiting queue. Once added to the waiting queue, the guard will invoke the run method automatically.
At this point, the data received by the client is actually undefined, yet the status of this undefined value is unexpectedly ok. As a result, the program attempts to read the block value, leading to a dirty read.
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

…ork in async mode

yiguolei · 2026-01-27T10:58:04Z

run buildall

Thearas · 2026-01-27T10:58:04Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

doris-robot · 2026-01-27T11:25:55Z

TPC-H: Total hot run time: 33220 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fef41a8c6143ec8639ff0bfc32f9b512f942516d, data reload: false
------ Round 1 ----------------------------------
q1	17647	5233	5086	5086
q2	2090	312	229	229
q3	10133	1334	769	769
q4	10220	892	323	323
q5	7485	2169	1930	1930
q6	200	181	146	146
q7	878	736	602	602
q8	9263	1337	1095	1095
q9	5226	4924	4954	4924
q10	6808	1988	1578	1578
q11	535	285	270	270
q12	340	380	225	225
q13	17785	4158	3253	3253
q14	251	237	220	220
q15	906	838	806	806
q16	693	676	626	626
q17	643	766	504	504
q18	6837	6496	7539	6496
q19	1346	1059	623	623
q20	420	377	250	250
q21	3072	2258	2183	2183
q22	1131	1082	1173	1082
Total cold run time: 103909 ms
Total hot run time: 33220 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5497	5509	5667	5509
q2	274	355	259	259
q3	2392	2939	2409	2409
q4	1653	1849	1410	1410
q5	4685	4465	4440	4440
q6	225	183	148	148
q7	1986	1944	1796	1796
q8	2545	2404	2457	2404
q9	7904	7452	7577	7452
q10	2745	3023	2685	2685
q11	539	459	453	453
q12	689	759	643	643
q13	3782	4421	3525	3525
q14	305	313	301	301
q15	851	801	792	792
q16	646	684	643	643
q17	1077	1301	1269	1269
q18	7614	7311	7232	7232
q19	840	817	813	813
q20	2008	2071	1916	1916
q21	4439	4166	4066	4066
q22	1066	1027	953	953
Total cold run time: 53762 ms
Total hot run time: 51118 ms

doris-robot · 2026-01-27T11:42:42Z

ClickBench: Total hot run time: 28.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fef41a8c6143ec8639ff0bfc32f9b512f942516d, data reload: false
query1	0.05	0.05	0.04
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.26	0.24	0.24
query6	1.18	0.67	0.68
query7	0.03	0.03	0.03
query8	0.05	0.03	0.04
query9	0.57	0.49	0.50
query10	0.56	0.55	0.56
query11	0.15	0.10	0.10
query12	0.14	0.10	0.12
query13	0.64	0.61	0.63
query14	1.06	1.07	1.06
query15	0.88	0.87	0.87
query16	0.41	0.42	0.39
query17	1.11	1.11	1.14
query18	0.22	0.21	0.22
query19	2.02	1.90	2.00
query20	0.03	0.02	0.01
query21	15.40	0.24	0.14
query22	5.14	0.06	0.05
query23	15.96	0.29	0.11
query24	1.00	0.70	0.20
query25	0.11	0.05	0.06
query26	0.15	0.14	0.13
query27	0.09	0.05	0.06
query28	3.74	1.16	0.96
query29	12.60	3.93	3.19
query30	0.29	0.14	0.12
query31	2.82	0.64	0.41
query32	3.24	0.59	0.49
query33	3.29	3.28	3.29
query34	16.38	5.39	4.72
query35	4.84	4.75	4.80
query36	0.64	0.50	0.49
query37	0.11	0.07	0.08
query38	0.07	0.04	0.03
query39	0.05	0.03	0.03
query40	0.19	0.17	0.15
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.05	0.04	0.04
Total cold run time: 97.62 s
Total hot run time: 28.15 s

yiguolei · 2026-01-27T13:18:10Z

run buildall

doris-robot · 2026-01-27T13:58:34Z

TPC-H: Total hot run time: 32567 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7ba7132af1ef6ff7145260a936ba8eb35d79d275, data reload: false
------ Round 1 ----------------------------------
q1	17604	5321	5075	5075
q2	2012	310	191	191
q3	10215	1304	724	724
q4	10226	909	312	312
q5	7556	2144	1920	1920
q6	195	177	147	147
q7	876	733	594	594
q8	9242	1371	1033	1033
q9	5133	4823	4910	4823
q10	6824	1967	1555	1555
q11	546	280	285	280
q12	336	379	227	227
q13	17816	4048	3185	3185
q14	232	237	217	217
q15	907	832	811	811
q16	688	674	609	609
q17	635	754	534	534
q18	6736	6549	6566	6549
q19	1269	994	636	636
q20	405	341	230	230
q21	2655	2076	1969	1969
q22	1051	1009	946	946
Total cold run time: 103159 ms
Total hot run time: 32567 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5348	5307	5326	5307
q2	265	336	245	245
q3	2167	2666	2245	2245
q4	1356	1703	1311	1311
q5	4267	4155	4250	4155
q6	224	236	200	200
q7	2315	1974	1967	1967
q8	2586	2452	2417	2417
q9	7696	7419	7608	7419
q10	2797	3040	2564	2564
q11	539	462	464	462
q12	689	755	622	622
q13	3860	4747	3528	3528
q14	297	320	294	294
q15	854	818	849	818
q16	662	740	688	688
q17	1116	1390	1444	1390
q18	8004	7851	7726	7726
q19	936	901	930	901
q20	2114	2051	1948	1948
q21	4475	4255	4135	4135
q22	1069	991	985	985
Total cold run time: 53636 ms
Total hot run time: 51327 ms

doris-robot · 2026-01-27T14:15:22Z

ClickBench: Total hot run time: 28.42 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7ba7132af1ef6ff7145260a936ba8eb35d79d275, data reload: false
query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.11	0.11
query5	0.27	0.24	0.26
query6	1.16	0.68	0.67
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.57	0.50	0.49
query10	0.56	0.55	0.54
query11	0.15	0.09	0.10
query12	0.14	0.11	0.11
query13	0.62	0.63	0.61
query14	1.06	1.06	1.05
query15	0.88	0.87	0.87
query16	0.42	0.39	0.42
query17	1.17	1.15	1.19
query18	0.24	0.21	0.21
query19	2.12	1.87	2.04
query20	0.02	0.01	0.02
query21	15.39	0.26	0.15
query22	5.41	0.06	0.05
query23	16.01	0.30	0.10
query24	0.97	0.46	1.16
query25	0.11	0.11	0.07
query26	0.15	0.13	0.14
query27	0.08	0.05	0.08
query28	4.94	1.14	0.96
query29	12.60	3.88	3.16
query30	0.27	0.14	0.11
query31	2.81	0.63	0.40
query32	3.23	0.59	0.50
query33	3.20	3.27	3.26
query34	16.36	5.36	4.73
query35	4.84	4.83	4.77
query36	0.66	0.51	0.49
query37	0.11	0.07	0.07
query38	0.07	0.05	0.03
query39	0.05	0.03	0.03
query40	0.18	0.18	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.09 s
Total hot run time: 28.42 s

yiguolei · 2026-01-28T01:56:54Z

run beut

yiguolei · 2026-01-28T03:48:05Z

run beut

yiguolei · 2026-01-28T06:07:32Z

run beut

doris-robot · 2026-01-28T07:36:39Z

BE UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.72% (19255/36526)
Line Coverage	36.08% (178849/495664)
Region Coverage	32.53% (138687/426352)
Branch Coverage	33.47% (60026/179341)

yiguolei · 2026-01-28T08:56:10Z

run buildall

doris-robot · 2026-01-28T09:19:20Z

TPC-H: Total hot run time: 32094 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 562439a5fe430fa1bd7ef84a3e881714fbc6699a, data reload: false
------ Round 1 ----------------------------------
q1	17637	5227	5057	5057
q2	2059	306	189	189
q3	10178	1284	743	743
q4	10216	904	318	318
q5	7539	2169	1917	1917
q6	196	180	147	147
q7	876	740	604	604
q8	9274	1362	1166	1166
q9	5244	4833	4915	4833
q10	6795	1942	1570	1570
q11	517	314	271	271
q12	337	376	226	226
q13	17755	4010	3267	3267
q14	229	239	225	225
q15	875	825	810	810
q16	670	675	622	622
q17	635	759	518	518
q18	6688	6430	7518	6430
q19	1283	1032	636	636
q20	396	361	246	246
q21	2932	2279	2017	2017
q22	361	325	282	282
Total cold run time: 102692 ms
Total hot run time: 32094 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5526	5570	5537	5537
q2	271	350	259	259
q3	2363	2917	2418	2418
q4	1440	1848	1458	1458
q5	4584	4643	4765	4643
q6	227	183	141	141
q7	1987	1915	1859	1859
q8	2532	2324	2365	2324
q9	7504	7389	7613	7389
q10	2865	3089	2645	2645
q11	536	454	459	454
q12	688	778	602	602
q13	3837	4292	3523	3523
q14	263	294	268	268
q15	825	791	784	784
q16	634	698	632	632
q17	1066	1273	1326	1273
q18	7636	7494	7220	7220
q19	822	768	776	768
q20	1998	2104	1891	1891
q21	4494	4305	4157	4157
q22	553	557	500	500
Total cold run time: 52651 ms
Total hot run time: 50745 ms

doris-robot · 2026-01-28T09:36:05Z

ClickBench: Total hot run time: 28.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 562439a5fe430fa1bd7ef84a3e881714fbc6699a, data reload: false
query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.26	0.24	0.24
query6	1.16	0.67	0.67
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.56	0.50	0.49
query10	0.54	0.54	0.54
query11	0.15	0.09	0.10
query12	0.14	0.10	0.10
query13	0.62	0.60	0.62
query14	1.07	1.05	1.05
query15	0.88	0.86	0.87
query16	0.39	0.37	0.39
query17	1.17	1.11	1.05
query18	0.23	0.21	0.21
query19	2.08	2.02	2.03
query20	0.02	0.02	0.02
query21	15.43	0.27	0.14
query22	5.24	0.05	0.05
query23	16.05	0.29	0.10
query24	1.51	0.29	0.23
query25	0.11	0.06	0.06
query26	0.15	0.13	0.14
query27	0.08	0.05	0.06
query28	3.37	1.15	0.96
query29	12.58	3.94	3.14
query30	0.30	0.16	0.11
query31	2.81	0.63	0.41
query32	3.23	0.59	0.50
query33	3.15	3.28	3.24
query34	16.40	5.40	4.72
query35	4.85	4.84	4.79
query36	0.66	0.49	0.48
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.16	0.16
query41	0.10	0.03	0.02
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.91 s
Total hot run time: 28.15 s

hello-stephen · 2026-01-28T10:11:27Z

BE UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.72% (19255/36526)
Line Coverage	36.09% (178878/495664)
Region Coverage	32.53% (138705/426352)
Branch Coverage	33.48% (60038/179341)

hello-stephen · 2026-01-28T11:46:52Z

BE Regression && UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.45% (25583/35804)
Line Coverage	54.11% (267515/494431)
Region Coverage	51.86% (223362/430670)
Branch Coverage	53.18% (95760/180057)

github-actions · 2026-01-28T12:23:55Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-01-28T12:23:58Z

PR approved by anyone and no changes requested.

mrhhsg

lgtm

…ork in async mode (#60282) there is a logic similar to our FE fetching data from the BE: if the data is not available, it will be added to a waiting queue. Once added to the waiting queue, the guard will invoke the run method automatically. At this point, the data received by the client is actually undefined, yet the status of this undefined value is unexpectedly ok. As a result, the program attempts to read the block value, leading to a dirty read.

…od to make work in async mode #60282 (#60325) Cherry-picked from #60282 Co-authored-by: yiguolei <guolei@selectdb.com>

…od to make work in async mode apache#60282 (apache#60325) Cherry-picked from apache#60282 Co-authored-by: yiguolei <guolei@selectdb.com>

[bugfix](arrowflight) should call done run in on_xxx method to make w…
fef41a8
…ork in async mode

f
562439a

yiguolei force-pushed the f1 branch from e29f202 to 562439aCompare January 28, 2026 04:24

yiguolei added the dev/4.0.x label Jan 28, 2026

zclllyybb approved these changes Jan 28, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 28, 2026

github-actionsBot added the reviewed label Jan 28, 2026

mrhhsg approved these changes Jan 29, 2026
View reviewed changes

HappenLee merged commit d2922aa into apache:masterJan 29, 2026
30 of 32 checks passed

github-actionsBot mentioned this pull request Jan 29, 2026
branch-4.0: [bugfix](arrowflight) should call done run in on_xxx method to make work in async mode #60282 #60325
Merged

yiguolei added a commit that referenced this pull request Jan 29, 2026
branch-4.0: [bugfix](arrowflight) should call done run in on_xxx meth…
bd26a7c
…od to make work in async mode #60282 (#60325) Cherry-picked from #60282 Co-authored-by: yiguolei <guolei@selectdb.com>

yiguolei added dev/4.0.4-merged and removed dev/4.0.x labels Mar 31, 2026

morningman mentioned this pull request Jul 15, 2026
[Tracking] Arrow Flight SQL and ADBC Catalog: issues and improvements #65615
Open
63 tasks

Uh oh!

Conversation

yiguolei commented Jan 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

yiguolei commented Jan 27, 2026

Uh oh!

Thearas commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

yiguolei commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

yiguolei commented Jan 28, 2026

Uh oh!

yiguolei commented Jan 28, 2026

Uh oh!

yiguolei commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

BE UT Coverage Report

Uh oh!

yiguolei commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

Uh oh!

hello-stephen commented Jan 28, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 28, 2026

BE Regression && UT Coverage Report

Uh oh!

github-actionsBot commented Jan 28, 2026

Uh oh!

github-actionsBot commented Jan 28, 2026

Uh oh!

mrhhsg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yiguolei commented Jan 27, 2026•
edited
Loading