Uh oh!
There was an error while loading. Please reload this page.
[fix](filecache) avoid SIGSEGV in background LRU update when clear cache - #60533
Conversation
The background LRU update thread (BlockFileCache::run_background_block_lru_update) uses cell which is a raw pointer owned by the cache’s internal _files map and may be unset during clearing cache. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Thearas
commented
Feb 5, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
freemandealer
commented
Feb 5, 2026
run buildall |
doris-robot
commented
Feb 5, 2026
TPC-H: Total hot run time: 31410 ms |
doris-robot
commented
Feb 5, 2026
ClickBench: Total hot run time: 28.41 s |
hello-stephen
commented
Feb 5, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Feb 5, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
freemandealer
commented
Feb 10, 2026
run nonConcurrent |
hello-stephen
commented
Feb 10, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
dataroaring
commented
Mar 6, 2026
/review |
Code Review SummaryPR #60533: fix avoid SIGSEGV in background LRU update when clear cache OverviewThis PR fixes a use-after-free / dangling pointer crash in the background LRU update thread. The root cause: Review ChecklistCorrectness: PASS Thread Safety: PASS Initialization: PASS Behavioral Change: Minor, acceptable Test Coverage: PASS No issues found. The fix is well-targeted and correct. |
Uh oh!
There was an error while loading. Please reload this page.
…che (#60533) The background LRU update thread (BlockFileCache::run_background_block_lru_update) uses cell which is a raw pointer owned by the cache’s internal _files map and may be unset during clearing cache.
…che (#60533) The background LRU update thread (BlockFileCache::run_background_block_lru_update) uses cell which is a raw pointer owned by the cache’s internal _files map and may be unset during clearing cache.
…che (#60533) The background LRU update thread (BlockFileCache::run_background_block_lru_update) uses cell which is a raw pointer owned by the cache’s internal _files map and may be unset during clearing cache.
The background LRU update thread (BlockFileCache::run_background_block_lru_update) uses cell which is a raw pointer owned by the cache’s internal _files map and may be unset during clearing cache.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)