Uh oh!
There was an error while loading. Please reload this page.
[fix](cloud) checkpoint save cloud tablet stats to image - #60705
Conversation
Thearas
commented
Feb 12, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Pull request overview
This PR updates FE checkpoint/image generation for cloud mode so that the saved image includes cloud-specific runtime metadata (table/partition versions and tablet/replica stats), reducing reliance on rebuilding those values after restart.
Changes:
- Add a cloud-mode post-processing step during checkpoint generation to copy table/partition versions and replica stats from the serving env into the checkpoint env before saving the image.
- Persist additional cloud metadata by adding Gson
@SerializedNameannotations (e.g., table cached version, replica rowset/segment counts). - Make
OlapTable.setCachedTableVersion()callable from checkpoint code.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
fe/fe-core/src/main/java/org/apache/doris/master/Checkpoint.java | Adds postProcessCloudMetadata() to copy versions and tablet stats into the checkpoint catalog before saveImage(). |
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java | Persists segmentCount and rowsetCount into image via @SerializedName. |
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java | Persists cached table version via @SerializedName and exposes setter for checkpoint to populate it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mymeiyi
commented
Feb 12, 2026
run buildall |
doris-robot
commented
Feb 12, 2026
TPC-H: Total hot run time: 30543 ms |
doris-robot
commented
Feb 12, 2026
TPC-DS: Total hot run time: 189007 ms |
doris-robot
commented
Feb 12, 2026
ClickBench: Total hot run time: 28.85 s |
hello-stephen
commented
Feb 12, 2026
FE Regression Coverage ReportIncrement line coverage |
7c0af96 to
f7bf894Comparemymeiyi
commented
Feb 13, 2026
run buildall |
hello-stephen
commented
Feb 13, 2026
FE Regression Coverage ReportIncrement line coverage |
f7bf894 to
66cffc1Comparemymeiyi
commented
Feb 24, 2026
run buildall |
doris-robot
commented
Feb 24, 2026
TPC-H: Total hot run time: 28693 ms |
doris-robot
commented
Feb 24, 2026
TPC-DS: Total hot run time: 183259 ms |
hello-stephen
commented
Feb 24, 2026
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Feb 24, 2026
FE Regression Coverage ReportIncrement line coverage |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
66cffc1 to
c91c38aCompared3a9bc8 to
007ddd6Comparemymeiyi
commented
Mar 19, 2026
run buildall |
doris-robot
commented
Mar 19, 2026
TPC-H: Total hot run time: 27044 ms |
doris-robot
commented
Mar 19, 2026
TPC-DS: Total hot run time: 169627 ms |
hello-stephen
commented
Mar 19, 2026
FE UT Coverage ReportIncrement line coverage |
PR approved by at least one committer and no changes requested. |
mymeiyi
commented
Mar 20, 2026
run p0 |
Uh oh!
There was an error while loading. Please reload this page.
### What problem does this PR solve? Issue Number: None Related PR: apache#60705, apache#66154 Problem Summary: Periodically regenerating a cloud checkpoint without a newer finalized journal reused the same image sequence. That exposed checkpoint version mismatches, same-version image publication, and follower synchronization ambiguity. Stop triggering checkpoints solely because an image is stale while retaining cloud metadata persistence during normal checkpoints. Do not persist tablet-stat refresh scheduling state so an FE can use cached stats immediately after restart and then rebuild the refresh schedule. ### Release note Cloud FE no longer regenerates a checkpoint solely because the current image is stale. Tablet-stat refresh scheduling state is rebuilt after FE restart. ### Check List (For Author) - Test: No need to test (commit-history squash only; code diff is unchanged) - Behavior changed: Yes (remove periodic stale-image checkpoint generation and persisted tablet-stat scheduling state) - Does this need documentation: No
### What problem does this PR solve? Issue Number: None Related PR: apache#60705, apache#66154 Problem Summary: Periodically regenerating a cloud checkpoint without a newer finalized journal reused the same image sequence. That exposed checkpoint version mismatches, same-version image publication, and follower synchronization ambiguity. Stop triggering checkpoints solely because an image is stale while retaining cloud metadata persistence during normal checkpoints. Do not persist tablet-stat refresh scheduling state so an FE can use cached stats immediately after restart and then rebuild the refresh schedule. Also align the OlapTable test mock lambda with FE Checkstyle indentation rules. ### Release note Cloud FE no longer regenerates a checkpoint solely because the current image is stale. Tablet-stat refresh scheduling state is rebuilt after FE restart. ### Check List (For Author) - Test: No need to test (commit-history squash; functional code diff is unchanged) - Checkstyle: `mvn -pl fe-core checkstyle:check` - Behavior changed: Yes (remove periodic stale-image checkpoint generation and persisted tablet-stat scheduling state) - Does this need documentation: No
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)