Skip to content

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion - #60745

Merged
gavinchou merged 1 commit into
apache:masterfrom
mymeiyi:metrics-of-get-version
Feb 28, 2026
Merged

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion#60745
gavinchou merged 1 commit into
apache:masterfrom
mymeiyi:metrics-of-get-version

Conversation

@mymeiyi

@mymeiyimymeiyi commented Feb 13, 2026•
edited by gavinchou
Loading

Copy link
Copy Markdown
Contributor

No description provided.

CopilotAI review requested due to automatic review settings February 13, 2026 10:37
@mymeiyi
mymeiyi requested a review from w41ter as a code ownerFebruary 13, 2026 10:37
@hello-stephen

hello-stephen commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi

mymeiyi commented Feb 13, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

CopilotAI reviewed Feb 13, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves RPC metrics tracking for cloud mode by differentiating between table version and partition version queries. Previously, both types of version queries were tracked under a single "getVersion" metric, making it difficult to monitor and debug these operations separately.

Changes:

  • Modified getVisibleVersionAsync() to dynamically determine metric name based on isTableVersion field
  • Modified getVersion() to dynamically determine metric name based on isTableVersion field
  • Metrics now differentiate between "getTableVersion" and "getPartitionVersion" operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hello-stephen

hello-stephen commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 20.00% (1/5) 🎉
Increment coverage report
Complete coverage report

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 26, 2026
@github-actions

github-actionsBot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@mymeiyi

mymeiyi commented Feb 27, 2026

Copy link
Copy Markdown
ContributorAuthor

run feut

@mymeiyi

mymeiyi commented Feb 27, 2026

Copy link
Copy Markdown
ContributorAuthor

run performance

@hello-stephen

hello-stephen commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 20.00% (1/5) 🎉
Increment coverage report
Complete coverage report

@doris-robot

doris-robot commented Feb 27, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 28781 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f04da3a855c18b9b7051bc4edad5bb28a2f2668, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17654	4524	4336	4336
q2	q3	10653	790	522	522
q4	4684	350	261	261
q5	7576	1200	1009	1009
q6	178	175	142	142
q7	786	835	678	678
q8	10109	1469	1341	1341
q9	5680	4789	4716	4716
q10	6854	1902	1621	1621
q11	464	247	271	247
q12	759	574	463	463
q13	17798	4213	3434	3434
q14	238	232	209	209
q15	984	800	786	786
q16	739	719	664	664
q17	804	878	429	429
q18	6628	5489	5301	5301
q19	1419	965	633	633
q20	515	494	392	392
q21	4570	1846	1356	1356
q22	342	291	241	241
Total cold run time: 99434 ms
Total hot run time: 28781 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4525	4364	4387	4364
q2	q3	1796	2174	1731	1731
q4	860	1157	752	752
q5	4078	4329	4359	4329
q6	174	169	141	141
q7	1730	1611	1490	1490
q8	2415	2695	2518	2518
q9	7854	7478	7536	7478
q10	2743	2857	2494	2494
q11	508	433	406	406
q12	486	595	453	453
q13	3961	4413	3646	3646
q14	302	314	290	290
q15	874	833	875	833
q16	733	760	719	719
q17	1197	1585	1308	1308
q18	7100	6777	6581	6581
q19	887	878	877	877
q20	2085	2145	2162	2145
q21	3962	3493	3346	3346
q22	454	439	509	439
Total cold run time: 48724 ms
Total hot run time: 46340 ms

@doris-robot

doris-robot commented Feb 27, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 183602 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f04da3a855c18b9b7051bc4edad5bb28a2f2668, data reload: false
query5	4987	653	538	538
query6	324	219	195	195
query7	4207	473	272	272
query8	339	243	230	230
query9	8731	2731	2746	2731
query10	564	395	338	338
query11	17054	16887	16553	16553
query12	206	122	120	120
query13	1258	466	347	347
query14	6449	3310	2960	2960
query14_1	2807	2836	2801	2801
query15	206	194	184	184
query16	989	474	466	466
query17	1070	735	577	577
query18	2648	440	329	329
query19	203	194	172	172
query20	137	125	127	125
query21	220	143	118	118
query22	5117	5720	5303	5303
query23	17645	17174	16872	16872
query23_1	17095	16934	17212	16934
query24	7114	1632	1219	1219
query24_1	1213	1212	1225	1212
query25	539	472	436	436
query26	814	260	154	154
query27	2761	461	293	293
query28	4481	1840	1842	1840
query29	791	543	470	470
query30	311	247	206	206
query31	852	724	638	638
query32	80	75	70	70
query33	510	341	284	284
query34	900	909	571	571
query35	626	660	613	613
query36	1057	1095	913	913
query37	134	91	79	79
query38	2972	2920	2873	2873
query39	893	859	859	859
query39_1	834	826	826	826
query40	223	152	136	136
query41	62	59	57	57
query42	108	104	103	103
query43	392	380	353	353
query44 query45	197	195	197	195
query46	907	983	614	614
query47	2115	2127	2007	2007
query48	312	321	270	270
query49	608	472	389	389
query50	678	284	208	208
query51	4064	4093	4084	4084
query52	106	110	99	99
query53	294	337	281	281
query54	309	271	266	266
query55	88	88	80	80
query56	325	323	300	300
query57	1350	1324	1265	1265
query58	283	280	277	277
query59	2523	2696	2504	2504
query60	341	337	332	332
query61	147	154	152	152
query62	633	597	537	537
query63	313	291	271	271
query64	4174	1266	994	994
query65 query66	1350	461	344	344
query67	16520	16334	16135	16135
query68 query69	390	312	286	286
query70	992	940	884	884
query71	350	314	306	306
query72	2953	2815	2531	2531
query73	552	561	334	334
query74	10011	10017	9764	9764
query75	2866	2765	2478	2478
query76	2303	1043	689	689
query77	379	393	320	320
query78	11231	11376	10727	10727
query79	2561	822	612	612
query80	1747	684	555	555
query81	547	293	246	246
query82	983	150	114	114
query83	335	266	247	247
query84	254	126	94	94
query85	885	471	420	420
query86	413	305	296	296
query87	3085	3080	2986	2986
query88	3553	2640	2613	2613
query89	421	370	350	350
query90	1916	175	173	173
query91	160	155	132	132
query92	76	79	71	71
query93	1101	837	498	498
query94	642	311	307	307
query95	594	396	320	320
query96	635	524	229	229
query97	2474	2486	2406	2406
query98	234	218	222	218
query99	1016	991	934	934
Total cold run time: 254738 ms
Total hot run time: 183602 ms

@gavinchou
gavinchou merged commit 5434070 into apache:masterFeb 28, 2026
39 of 41 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Mar 9, 2026
@mymeiyi
[fix](cloud) change cloud FE getVersion rpc metric to getTableVersion…
a611a73
… and getPartitionVersion (apache#60745)
@mymeiyimymeiyi mentioned this pull request Mar 9, 2026
Merged
yiguolei pushed a commit that referenced this pull request Mar 9, 2026
@mymeiyi
branch-4.0: [fix](cloud) add metrics for FE to MS rpc (#60574) (#61136)
1610e6d
pick #60574 and
#60745
@yiguoleiyiguolei mentioned this pull request Mar 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@gavinchougavinchougavinchou approved these changes
@w41terw41terw41ter approved these changes
@dataroaringdataroaringAwaiting requested review from dataroaring

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.5-mergeddev/4.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mymeiyi@hello-stephen@doris-robot@gavinchou@w41ter@yiguolei